Message ID | 20230113162214.117261-2-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp363647wrt; Fri, 13 Jan 2023 08:30:00 -0800 (PST) X-Google-Smtp-Source: AMrXdXtw+N43EyMcje+JBlyK4WwAr2+DRVqW26zuFYsF1i98uBEPUNFWtsiBMwpUCEBY5+dLhK00 X-Received: by 2002:a05:6402:500a:b0:498:18e7:1667 with SMTP id p10-20020a056402500a00b0049818e71667mr24902467eda.10.1673627400199; Fri, 13 Jan 2023 08:30:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673627400; cv=none; d=google.com; s=arc-20160816; b=PFip9Z+BlA/QR35bG6pLNEAi1pA3fZbMd0vxpOxYVIANK5sq+cU0Lt/Bz8XI4lhRCR Gm/mXULySfhiT1/mD5Aomyk2/vK0/ZcpPkdEkS/O8zBE31BC4OhqbExgHPGJaPNC5ljh 1UZ57HKDjuAy0ez6W7IKbPnkAZ1uMR4vYqnR5iyDwWPMnR/g4eA2tkqPKIlbnIGRuvWl S8z867exbHPLrtPXzS/u6D7IgqmLObaw/gL8E7w6Egri2P84MU9nYR12SD1SdcmTQH37 X6v9KugfbW/uv0JzgFy/cN9XXv0ZpNMRT6auHEJqQDAbNGEUIs84DIOvb9Gl2BMBR6r4 WSeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qphHuiI3995fMsqnotERxhZjaBqWPqwflOdlSfg7u7A=; b=ht7Q2/ptri82Ax3eDP650K+pjgqdVAx69e3SieSJlTPFZ2jiAo86CBUanzMGxp1r4c OxS/aAO9OktpV6SDfQzpnjXGByzhdZcQ9P3xwLdKPtwbHWQ0o1caDMDjqXmhCO9Z6DLc lkUWApbJIkBiKhnWofI9njPheihi63GzRSqPdgJaI2K6n84jfVvzcbcKHgAzGh2LrlcG XtWWpzbMBVucUYi3r68LU3RIrVRiRo+2+/D2nJgrIievz5cGqOTElqxpcsw6Y7TB0pLZ pM54t1fjOLlzTvlXYL0ydI3+PG/B5C+iWAiL1sT9bSCAKNmHiTWwwBc+su856cecnzlZ /6SA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=M0oeeTuT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fj27-20020a0564022b9b00b00499c322a9c5si10837797edb.85.2023.01.13.08.29.33; Fri, 13 Jan 2023 08:30:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=M0oeeTuT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229996AbjAMQ2q (ORCPT <rfc822;callmefire3@gmail.com> + 99 others); Fri, 13 Jan 2023 11:28:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229655AbjAMQ2I (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 13 Jan 2023 11:28:08 -0500 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A1517EA44 for <linux-kernel@vger.kernel.org>; Fri, 13 Jan 2023 08:22:21 -0800 (PST) Received: by mail-ej1-x62a.google.com with SMTP id l22so23764092eja.12 for <linux-kernel@vger.kernel.org>; Fri, 13 Jan 2023 08:22:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qphHuiI3995fMsqnotERxhZjaBqWPqwflOdlSfg7u7A=; b=M0oeeTuTJxcCGIov8N7a9cwJEF4PjtMbQry9x4/Ou4MJXCTqdNMqWZr6QMBzxEvR3Q /o2AX3Wgl5g/LLXrR5xx1Eqqlnnnk0xz2r3wX1kagWU0kdGGXqJM5LLjToKoZ0RCg3YS p5Mx4oi8ib1cMAX2BoxdZifdW8Wtv+iAXKXUVhSMAFcbIMQ1bkBa12/uDXMOGZDtXUJs 6bgrTY3h5uXShC9oOArHaau4Ps5tLxOhrV4kDx34vuq/zuMZEhFflJmn6IkLSDPR3YK7 uoZFUrQs2ipkn6EgPcQCCJ5zTBEiCytplQS/Oi8PB/TWMKUvOo7EkFzetCxVDWC2aaba ooNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qphHuiI3995fMsqnotERxhZjaBqWPqwflOdlSfg7u7A=; b=hhyGoAW/Yf8cOcDyeXgPyUw250ZzKoGb3+Gtk57n/mfZA9PpsQu+JSbMy/qcBW0dou svibs18REAT/KOMfLUye/7YrtCuzQPM1ulGyCm/xbJqgbjIFGlRnoUbdA+L9pcKeadEW 9bTFeLHs+eKJswD5D9u+UyNyfKVeiyRMgVdvUuzxk7HHf+zYEucxGB+HWMYO/aEDT7kE EP5QfbGno1WzTADxapjzhM9fJ7gob+xlkjwQCMlFSaYceSk8GdEYYYl0qo2FJc5EvjOm xcjZj7yaHg7NcOpYcqVWUnh6AENIxcBaRabJveeJPpv3UwSweJ4b+JhfHQcDBmMTyrrD ZYkA== X-Gm-Message-State: AFqh2kpAsSZCLmx8kTJw5OzS5lyfcemXqKe0Fqe7H6CGnyryQlOPcl40 twzzsV5v3UXU2Tw4EBg+8p6mSw== X-Received: by 2002:a17:906:eda2:b0:84d:4712:9c42 with SMTP id sa2-20020a170906eda200b0084d47129c42mr19114978ejb.56.1673626940618; Fri, 13 Jan 2023 08:22:20 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id o11-20020a170906768b00b0084d242d07ffsm8376737ejm.8.2023.01.13.08.22.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 08:22:20 -0800 (PST) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Banajit Goswami <bgoswami@quicinc.com>, Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH 2/3] ASoC: dt-bindings: qcom,wcd934x: Describe slim-ifc-dev Date: Fri, 13 Jan 2023 17:22:13 +0100 Message-Id: <20230113162214.117261-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230113162214.117261-1-krzysztof.kozlowski@linaro.org> References: <20230113162214.117261-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754925524275708690?= X-GMAIL-MSGID: =?utf-8?q?1754925524275708690?= |
Series |
[1/3] ASoC: dt-bindings: qcom,wsa881x: Allow sound-name-prefix
|
|
Commit Message
Krzysztof Kozlowski
Jan. 13, 2023, 4:22 p.m. UTC
The "slim-ifc-dev" property should not be just "true", because it allows
any type.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Comments
On Fri, Jan 13, 2023 at 05:22:13PM +0100, Krzysztof Kozlowski wrote: > The "slim-ifc-dev" property should not be just "true", because it allows > any type. Yes, but it is common, so it should be in a common schema. Though there's only one other binding using it (wcd9335.txt). > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml > index 184e8ccbdd13..39b27126cfc1 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml > @@ -28,7 +28,9 @@ properties: > description: GPIO spec for reset line to use > maxItems: 1 > > - slim-ifc-dev: true > + slim-ifc-dev: > + description: IFC device interface > + $ref: /schemas/types.yaml#/definitions/phandle > > clocks: > maxItems: 1 > -- > 2.34.1 >
On 17/01/2023 20:27, Rob Herring wrote: > On Fri, Jan 13, 2023 at 05:22:13PM +0100, Krzysztof Kozlowski wrote: >> The "slim-ifc-dev" property should not be just "true", because it allows >> any type. > > Yes, but it is common, so it should be in a common schema. Though > there's only one other binding using it (wcd9335.txt). This is still wcd9335 and wcd934x specific, not really common. Maybe next Qualcomm codec would also bring it so then we can define common schema for the codecs. But so far I think it is not really a common property. Best regards, Krzysztof
On Wed, Jan 18, 2023 at 5:25 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 17/01/2023 20:27, Rob Herring wrote: > > On Fri, Jan 13, 2023 at 05:22:13PM +0100, Krzysztof Kozlowski wrote: > >> The "slim-ifc-dev" property should not be just "true", because it allows > >> any type. > > > > Yes, but it is common, so it should be in a common schema. Though > > there's only one other binding using it (wcd9335.txt). > > This is still wcd9335 and wcd934x specific, not really common. Maybe > next Qualcomm codec would also bring it so then we can define common > schema for the codecs. But so far I think it is not really a common > property. By common, I only mean used by more than 1 binding. That's already the case, there's just not a schema for the 2nd one. In any case, can address that later. Acked-by: Rob Herring <robh@kernel.org>
On 18/01/2023 14:19, Rob Herring wrote: > On Wed, Jan 18, 2023 at 5:25 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 17/01/2023 20:27, Rob Herring wrote: >>> On Fri, Jan 13, 2023 at 05:22:13PM +0100, Krzysztof Kozlowski wrote: >>>> The "slim-ifc-dev" property should not be just "true", because it allows >>>> any type. >>> >>> Yes, but it is common, so it should be in a common schema. Though >>> there's only one other binding using it (wcd9335.txt). >> >> This is still wcd9335 and wcd934x specific, not really common. Maybe >> next Qualcomm codec would also bring it so then we can define common >> schema for the codecs. But so far I think it is not really a common >> property. > > By common, I only mean used by more than 1 binding. That's already the > case, there's just not a schema for the 2nd one. In any case, can > address that later. > > Acked-by: Rob Herring <robh@kernel.org> Sure! Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml index 184e8ccbdd13..39b27126cfc1 100644 --- a/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml @@ -28,7 +28,9 @@ properties: description: GPIO spec for reset line to use maxItems: 1 - slim-ifc-dev: true + slim-ifc-dev: + description: IFC device interface + $ref: /schemas/types.yaml#/definitions/phandle clocks: maxItems: 1