diff mbox series

mm/highmem: fix spelling mistakeo

Message ID 20230118004356.4198-1-wangdeming@inspur.com
State New
Headers
Series mm/highmem: fix spelling mistakeo |

Commit Message

Deming Wang Jan. 18, 2023, 12:43 a.m. UTC 
  Substitute occurrencies of "higmem" with "highmem".

Signed-off-by: Deming Wang <wangdeming@inspur.com>
---
 Documentation/mm/highmem.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bagas Sanjaya Jan. 18, 2023, 2:21 a.m. UTC | #1 
On Tue, Jan 17, 2023 at 07:43:56PM -0500, Deming Wang wrote:
> Substitute occurrencies of "higmem" with "highmem".
> 
> Signed-off-by: Deming Wang <wangdeming@inspur.com>
> ---
>  Documentation/mm/highmem.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/mm/highmem.rst b/Documentation/mm/highmem.rst
> index 59d1078f53df..7da4a0d175f0 100644
> --- a/Documentation/mm/highmem.rst
> +++ b/Documentation/mm/highmem.rst
> @@ -83,7 +83,7 @@ list shows them in order of preference of use.
>    for pages which are known to not come from ZONE_HIGHMEM. However, it is
>    always safe to use kmap_local_page() / kunmap_local().
>  
> -  While it is significantly faster than kmap(), for the higmem case it
> +  While it is significantly faster than kmap(), for the highmem case it
>    comes with restrictions about the pointers validity. Contrary to kmap()
>    mappings, the local mappings are only valid in the context of the caller
>    and cannot be handed to other contexts. This implies that users must

Are you sure you have seen the other occurences of higmem in the same
doc? If so, do s/higmem/highmem/g.

Also, the patch subject prefix should have been Documentation: mm:
highmem, and also s/mistakeo/mistake/ in the subject.

Thanks.
Deming Wang Jan. 18, 2023, 2:55 a.m. UTC | #2 
Hi,

 I find only one typo about higmem. And I have modified the subject.

Thanks

> send: Bagas Sanjaya <bagasdotme@gmail.com>
> time: 2023年1月18日 10:21
> to: tomorrow Wang (王德明) <wangdeming@inspur.com>;
> corbet@lwn.net; fmdefrancesco@gmail.com; akpm@linux-foundation.org;
> bigeasy@linutronix.de; ira.weiny@intel.com; rppt@kernel.org
> subject: Re: [PATCH] mm/highmem: fix spelling mistakeo
> 
> On Tue, Jan 17, 2023 at 07:43:56PM -0500, Deming Wang wrote:
> > Substitute occurrencies of "higmem" with "highmem".
> >
> > Signed-off-by: Deming Wang <wangdeming@inspur.com>
> > ---
> >  Documentation/mm/highmem.rst | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/mm/highmem.rst
> > b/Documentation/mm/highmem.rst index 59d1078f53df..7da4a0d175f0
> 100644
> > --- a/Documentation/mm/highmem.rst
> > +++ b/Documentation/mm/highmem.rst
> > @@ -83,7 +83,7 @@ list shows them in order of preference of use.
> >    for pages which are known to not come from ZONE_HIGHMEM. However,
> it is
> >    always safe to use kmap_local_page() / kunmap_local().
> >
> > -  While it is significantly faster than kmap(), for the higmem case
> > it
> > +  While it is significantly faster than kmap(), for the highmem case
> > + it
> >    comes with restrictions about the pointers validity. Contrary to kmap()
> >    mappings, the local mappings are only valid in the context of the caller
> >    and cannot be handed to other contexts. This implies that users
> > must
> 
> Are you sure you have seen the other occurences of higmem in the same doc?
> If so, do s/higmem/highmem/g.
> 
> Also, the patch subject prefix should have been Documentation: mm:
> highmem, and also s/mistakeo/mistake/ in the subject.
> 
> Thanks.
> 
> --
> An old man doll... just what I always wanted! - Clara
Bagas Sanjaya Jan. 19, 2023, 2:11 a.m. UTC | #3 
On 1/18/23 09:55, tomorrow Wang (王德明) wrote:
> Hi,
> 
>  I find only one typo about higmem. And I have modified the subject.
> 

You send your patch as attachment, please send it inline instead
with git-send-email(1).

Also, please don't top-post; reply inline with appropriate context
instead.

Thanks.
Fabio M. De Francesco Jan. 19, 2023, 12:11 p.m. UTC | #4 
On mercoledì 18 gennaio 2023 01:43:56 CET Deming Wang wrote:
> Substitute occurrencies of "higmem" with "highmem".

s/occurrencies/occurrences
 
> Signed-off-by: Deming Wang <wangdeming@inspur.com>
> ---
>  Documentation/mm/highmem.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/mm/highmem.rst b/Documentation/mm/highmem.rst
> index 59d1078f53df..7da4a0d175f0 100644
> --- a/Documentation/mm/highmem.rst
> +++ b/Documentation/mm/highmem.rst
> @@ -83,7 +83,7 @@ list shows them in order of preference of use.
>    for pages which are known to not come from ZONE_HIGHMEM. However, it is
>    always safe to use kmap_local_page() / kunmap_local().
> 
> -  While it is significantly faster than kmap(), for the higmem case it
> +  While it is significantly faster than kmap(), for the highmem case it
>    comes with restrictions about the pointers validity. Contrary to kmap()
>    mappings, the local mappings are only valid in the context of the caller
>    and cannot be handed to other contexts. This implies that users must
> --
> 2.27.0

I think you missed a patch which is already in Andrew's -mm-unstable tree:

[PATCH] mm: Fix two spelling mistakes in highmem.h
https://lore.kernel.org/lkml/20230105121305.30714-1-fmdefrancesco@gmail.com/

Fabio
diff mbox series

Patch

diff --git a/Documentation/mm/highmem.rst b/Documentation/mm/highmem.rst
index 59d1078f53df..7da4a0d175f0 100644
--- a/Documentation/mm/highmem.rst
+++ b/Documentation/mm/highmem.rst
@@ -83,7 +83,7 @@  list shows them in order of preference of use.
   for pages which are known to not come from ZONE_HIGHMEM. However, it is
   always safe to use kmap_local_page() / kunmap_local().
 
-  While it is significantly faster than kmap(), for the higmem case it
+  While it is significantly faster than kmap(), for the highmem case it
   comes with restrictions about the pointers validity. Contrary to kmap()
   mappings, the local mappings are only valid in the context of the caller
   and cannot be handed to other contexts. This implies that users must