diff mbox series

[11/44] serial: atmel: Use uart_xmit_advance()

Message ID	20221019091151.6692-12-ilpo.jarvinen@linux.intel.com
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com> To: linux-serial@vger.kernel.org, Greg KH <gregkh@linuxfoundation.org>, Jiri Slaby <jirislaby@kernel.org>, Richard Genoud <richard.genoud@gmail.com>, Nicolas Ferre <nicolas.ferre@microchip.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Claudiu Beznea <claudiu.beznea@microchip.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, =?utf-8?q?Ilpo_J?= =?utf-8?q?=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com> Subject: [PATCH 11/44] serial: atmel: Use uart_xmit_advance() Date: Wed, 19 Oct 2022 12:11:18 +0300 Message-Id: <20221019091151.6692-12-ilpo.jarvinen@linux.intel.com> In-Reply-To: <20221019091151.6692-1-ilpo.jarvinen@linux.intel.com> References: <20221019091151.6692-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	serial: Convert drivers to use uart_xmit_advance() \| [00/44] serial: Convert drivers to use uart_xmit_advance() [01/44] serial: dz: Use uart_xmit_advance() [02/44] serial: men_z135_uart: Use uart_xmit_advance() [03/44] serial: msm: Use uart_xmit_advance() [04/44] serial: pch_uart: Use uart_xmit_advance() [05/44] serial: sc16is7xx: Use uart_xmit_advance() [06/44] serial: 8250_bcm7271: Use uart_xmit_advance() [07/44] serial: 8250: Use uart_xmit_advance() [08/44] serial: pl011: Use uart_xmit_advance() [09/44] serial: ar933x: Use uart_xmit_advance() [10/44] serial: arc: Use uart_xmit_advance() [11/44] serial: atmel: Use uart_xmit_advance() [12/44] serial: clps711x: Use uart_xmit_advance() [13/44] serial: cpm_uart: Use uart_xmit_advance() [14/44] serial: digicolor: Use uart_xmit_advance() [15/44] serial: linflexuart: Use uart_xmit_advance() [16/44] serial: fsl_lpuart: Use uart_xmit_advance() [17/44] serial: imx: Use uart_xmit_advance() [18/44] serial: ip22zilog: Use uart_xmit_advance() [19/44] serial: liteuart: Use uart_xmit_advance() [20/44] serial: max3100: Use uart_xmit_advance() [21/44] serial: max310x: Use uart_xmit_advance() [22/44] serial: meson: Use uart_xmit_advance() [23/44] serial: milbeaut_usio: Use uart_xmit_advance() [24/44] serial: mvebu-uart: Use uart_xmit_advance() [25/44] serial: pic32: Use uart_xmit_advance() [26/44] serial: pmac_zilog: Use uart_xmit_advance() [27/44] serial: rda: Use uart_xmit_advance() [28/44] serial: samsung_tty: Use uart_xmit_advance() [29/44] serial: sb1250-duart: Use uart_xmit_advance() [30/44] serial: sccnxp: Use uart_xmit_advance() [31/44] serial: tegra: Use uart_xmit_advance() [32/44] serial: sh-sci: Use uart_xmit_advance() [33/44] serial: sprd: Use uart_xmit_advance() [34/44] serial: stm32: Use uart_xmit_advance() [35/44] serial: sunhv: Use uart_xmit_advance() [36/44] serial: sunplus-uart: Use uart_xmit_advance() [37/44] serial: sunsab: Use uart_xmit_advance() [38/44] serial: sunsu: Use uart_xmit_advance() [39/44] serial: sunzilog: Use uart_xmit_advance() [40/44] serial: timbuart: Use uart_xmit_advance() [41/44] serial: uartlite: Use uart_xmit_advance() [42/44] serial: ucc_uart: Use uart_xmit_advance() [43/44] serial: xuartps: Use uart_xmit_advance() [44/44] serial: zs: Use uart_xmit_advance()

Commit Message

Ilpo Järvinen Oct. 19, 2022, 9:11 a.m. UTC

  Take advantage of the new uart_xmit_advance() helper.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
 drivers/tty/serial/atmel_serial.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

Comments

Claudiu Beznea Oct. 20, 2022, 9:01 a.m. UTC | #1

On 19.10.2022 12:11, Ilpo Järvinen wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Take advantage of the new uart_xmit_advance() helper.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>


> ---
>  drivers/tty/serial/atmel_serial.c | 11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index bd07f79a2df9..4485f2d26b77 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -875,10 +875,7 @@ static void atmel_complete_tx_dma(void *arg)
> 
>         if (chan)
>                 dmaengine_terminate_all(chan);
> -       xmit->tail += atmel_port->tx_len;
> -       xmit->tail &= UART_XMIT_SIZE - 1;
> -
> -       port->icount.tx += atmel_port->tx_len;
> +       uart_xmit_advance(port, atmel_port->tx_len);
> 
>         spin_lock_irq(&atmel_port->lock_tx);
>         async_tx_ack(atmel_port->desc_tx);
> @@ -1471,11 +1468,7 @@ static void atmel_tx_pdc(struct uart_port *port)
>         /* nothing left to transmit? */
>         if (atmel_uart_readl(port, ATMEL_PDC_TCR))
>                 return;
> -
> -       xmit->tail += pdc->ofs;
> -       xmit->tail &= UART_XMIT_SIZE - 1;
> -
> -       port->icount.tx += pdc->ofs;
> +       uart_xmit_advance(port, pdc->ofs);
>         pdc->ofs = 0;
> 
>         /* more to transmit - setup next transfer */
> --
> 2.30.2
>

Richard Genoud Oct. 20, 2022, 1:06 p.m. UTC | #2

Le 20/10/2022 à 11:01, Claudiu.Beznea@microchip.com a écrit :
> On 19.10.2022 12:11, Ilpo Järvinen wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> Take advantage of the new uart_xmit_advance() helper.
>>
>> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> 
> Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>

Acked-By: Richard GENOUD <richard.genoud@gmail.com>

>> ---
>>  drivers/tty/serial/atmel_serial.c | 11 ++---------
>>  1 file changed, 2 insertions(+), 9 deletions(-)
>>
>> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
>> index bd07f79a2df9..4485f2d26b77 100644
>> --- a/drivers/tty/serial/atmel_serial.c
>> +++ b/drivers/tty/serial/atmel_serial.c
>> @@ -875,10 +875,7 @@ static void atmel_complete_tx_dma(void *arg)
>>
>>         if (chan)
>>                 dmaengine_terminate_all(chan);
>> -       xmit->tail += atmel_port->tx_len;
>> -       xmit->tail &= UART_XMIT_SIZE - 1;
>> -
>> -       port->icount.tx += atmel_port->tx_len;
>> +       uart_xmit_advance(port, atmel_port->tx_len);
>>
>>         spin_lock_irq(&atmel_port->lock_tx);
>>         async_tx_ack(atmel_port->desc_tx);
>> @@ -1471,11 +1468,7 @@ static void atmel_tx_pdc(struct uart_port *port)
>>         /* nothing left to transmit? */
>>         if (atmel_uart_readl(port, ATMEL_PDC_TCR))
>>                 return;
>> -
>> -       xmit->tail += pdc->ofs;
>> -       xmit->tail &= UART_XMIT_SIZE - 1;
>> -
>> -       port->icount.tx += pdc->ofs;
>> +       uart_xmit_advance(port, pdc->ofs);
>>         pdc->ofs = 0;
>>
>>         /* more to transmit - setup next transfer */
>> --
>> 2.30.2
>>
> 

Thanks !

diff mbox series

Patch

diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index bd07f79a2df9..4485f2d26b77 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -875,10 +875,7 @@  static void atmel_complete_tx_dma(void *arg)
 
 	if (chan)
 		dmaengine_terminate_all(chan);
-	xmit->tail += atmel_port->tx_len;
-	xmit->tail &= UART_XMIT_SIZE - 1;
-
-	port->icount.tx += atmel_port->tx_len;
+	uart_xmit_advance(port, atmel_port->tx_len);
 
 	spin_lock_irq(&atmel_port->lock_tx);
 	async_tx_ack(atmel_port->desc_tx);
@@ -1471,11 +1468,7 @@  static void atmel_tx_pdc(struct uart_port *port)
 	/* nothing left to transmit? */
 	if (atmel_uart_readl(port, ATMEL_PDC_TCR))
 		return;
-
-	xmit->tail += pdc->ofs;
-	xmit->tail &= UART_XMIT_SIZE - 1;
-
-	port->icount.tx += pdc->ofs;
+	uart_xmit_advance(port, pdc->ofs);
 	pdc->ofs = 0;
 
 	/* more to transmit - setup next transfer */