diff mbox series

[3/3] PCI/portdrv: Unexport pcie_port_service_register(), pcie_port_service_unregister()

Message ID 20221019204127.44463-4-helgaas@kernel.org
State New
Headers
Series PCI/portdrv: Squash into portdrv.c |

Commit Message

Bjorn Helgaas Oct. 19, 2022, 8:41 p.m. UTC 
  From: Bjorn Helgaas <bhelgaas@google.com>

pcie_port_service_register() and pcie_port_service_unregister() are used
only by the pciehp, aer, dpc, and pme PCIe port service drivers, none of
which can be modules.  Unexport pcie_port_service_register() and
pcie_port_service_unregister().  No functional change intended.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/pci/pcie/portdrv.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Christoph Hellwig Oct. 20, 2022, 8:34 a.m. UTC | #1 
On Wed, Oct 19, 2022 at 03:41:27PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> pcie_port_service_register() and pcie_port_service_unregister() are used
> only by the pciehp, aer, dpc, and pme PCIe port service drivers, none of
> which can be modules.  Unexport pcie_port_service_register() and
> pcie_port_service_unregister().  No functional change intended.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/drivers/pci/pcie/portdrv.c b/drivers/pci/pcie/portdrv.c
index ae8da5b2e922..a6c4225505d5 100644
--- a/drivers/pci/pcie/portdrv.c
+++ b/drivers/pci/pcie/portdrv.c
@@ -584,7 +584,6 @@  int pcie_port_service_register(struct pcie_port_service_driver *new)
 
 	return driver_register(&new->driver);
 }
-EXPORT_SYMBOL(pcie_port_service_register);
 
 /**
  * pcie_port_service_unregister - unregister PCI Express port service driver
@@ -594,7 +593,6 @@  void pcie_port_service_unregister(struct pcie_port_service_driver *drv)
 {
 	driver_unregister(&drv->driver);
 }
-EXPORT_SYMBOL(pcie_port_service_unregister);
 
 /* If this switch is set, PCIe port native services should not be enabled. */
 bool pcie_ports_disabled;