diff mbox series

[-next] tty: hvc: make hvc_rtas_dev static

Message ID 20221019064412.3759874-1-ruanjinjie@huawei.com
State New
Headers
Series [-next] tty: hvc: make hvc_rtas_dev static |

Commit Message

Jinjie Ruan Oct. 19, 2022, 6:44 a.m. UTC 
  The symbol is not used outside of the file, so mark it static.

Fixes the following warning:

drivers/tty/hvc/hvc_rtas.c:29:19: warning: symbol 'hvc_rtas_dev' was
not declared. Should it be static?

Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
---
 drivers/tty/hvc/hvc_rtas.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jiri Slaby Oct. 20, 2022, 5:29 a.m. UTC | #1 
On 19. 10. 22, 8:44, ruanjinjie wrote:
> The symbol is not used outside of the file, so mark it static.
> 
> Fixes the following warning:
> 
> drivers/tty/hvc/hvc_rtas.c:29:19: warning: symbol 'hvc_rtas_dev' was
> not declared. Should it be static?

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

> Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
> ---
>   drivers/tty/hvc/hvc_rtas.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/hvc/hvc_rtas.c b/drivers/tty/hvc/hvc_rtas.c
> index e8b8c645482b..184d325abeed 100644
> --- a/drivers/tty/hvc/hvc_rtas.c
> +++ b/drivers/tty/hvc/hvc_rtas.c
> @@ -26,7 +26,7 @@
>   #include "hvc_console.h"
>   
>   #define hvc_rtas_cookie 0x67781e15
> -struct hvc_struct *hvc_rtas_dev;
> +static struct hvc_struct *hvc_rtas_dev;
>   
>   static int rtascons_put_char_token = RTAS_UNKNOWN_SERVICE;
>   static int rtascons_get_char_token = RTAS_UNKNOWN_SERVICE;
diff mbox series

Patch

diff --git a/drivers/tty/hvc/hvc_rtas.c b/drivers/tty/hvc/hvc_rtas.c
index e8b8c645482b..184d325abeed 100644
--- a/drivers/tty/hvc/hvc_rtas.c
+++ b/drivers/tty/hvc/hvc_rtas.c
@@ -26,7 +26,7 @@ 
 #include "hvc_console.h"
 
 #define hvc_rtas_cookie 0x67781e15
-struct hvc_struct *hvc_rtas_dev;
+static struct hvc_struct *hvc_rtas_dev;
 
 static int rtascons_put_char_token = RTAS_UNKNOWN_SERVICE;
 static int rtascons_get_char_token = RTAS_UNKNOWN_SERVICE;