Message ID | 20221019130200.60460-1-yuanjilin@cdjrlc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp414488wrs; Wed, 19 Oct 2022 09:19:33 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5hRlHI7q/P1D53zLLJHaQN0OEkjAITf75lOnoUmrnc3bNz6ZlpKkFAPOSMd4Fz2IOhknrG X-Received: by 2002:a17:90b:33d0:b0:20d:5edf:8b92 with SMTP id lk16-20020a17090b33d000b0020d5edf8b92mr10622354pjb.117.1666196373085; Wed, 19 Oct 2022 09:19:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666196373; cv=none; d=google.com; s=arc-20160816; b=ao39JlKyTAewnsVgfXker8wUBFxnxnuk/0p9bJnLddRPgXn0OklVoJJYcunJNbQkNe agHBYlFod3XUud1m0STfYaikxfIAb1p8tHR5so1N0i24919+qaX0OKd7m3kHozr5SJCJ NYaC42Ff2yM73MXLyzNaZnLQ/EjZSTbw/iKEKgRWTx88qDITy7lHGenGhFFwQKDfFD48 xXQhGD8/uzwvXRacYxdKWyQH49AbV6LvgTRCKv01iX6Oc3vG5ZrfuUGVJabFVGfL13bQ SpHswyzautPUAfOH65xSXu9RGm1JWPAkydn+ShzO3NbJsTMrd402945mMPe6fcOpCTLc WIQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:feedback-id:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from; bh=zmvzhznegk8YwecEnGE3nsd5UPrEcKXWN/q7RqIjQpg=; b=0RkzLqsLE8+fZ3sicQpzlucKyn8B/nreN605NyDk+hdqPi5I2U6yLHcfkyLQJARN0+ yb0JkznDnYHLbm++gRVHAsjoIgsiFdJ75reSBxJvSDvWLGNnIJb/zCtF2uhXMmI59Vg1 0Pi9iJj7yAQPgAboTJGPeXkvJyZCkZCeRvxcCNePNG+yXJbTaDD5YttJi3nKNxowin2g yWrC7LqB7MzttAx7y5Rpy/oq+LYqmAocaMVP4pR+J01Ru2z4A+zmluQ6wOCgGRBNiI9o VpIgc+cRDqaJxXzOnL7EEiXOml93GHmhul8AF7YVaxcbQhIaWrJGaDDciHf7XfF9t4wl 4e7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f10-20020a63de0a000000b0043908386679si18893744pgg.373.2022.10.19.09.19.19; Wed, 19 Oct 2022 09:19:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230083AbiJSQSj (ORCPT <rfc822;samuel.l.nystrom@gmail.com> + 99 others); Wed, 19 Oct 2022 12:18:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230153AbiJSQSY (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 19 Oct 2022 12:18:24 -0400 Received: from bg4.exmail.qq.com (bg4.exmail.qq.com [43.154.221.58]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 789AA1B6C9F for <linux-kernel@vger.kernel.org>; Wed, 19 Oct 2022 09:18:22 -0700 (PDT) X-QQ-mid: bizesmtp77t1666184527tr0g1i3e Received: from localhost.localdomain ( [182.148.15.91]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 19 Oct 2022 21:02:06 +0800 (CST) X-QQ-SSF: 01000000008000F0I000B00A0000000 X-QQ-FEAT: fs34Pe/+C2Qz/O+Hf3pkbi2c05tFOEa85g4JKwYdHD4DIEeh9/8UtoOJDQV5W uwlIh10xrr1mbVPrecjJCbagkFKCRm/doqcF7TA65gPZfgxd7eEfT8okqSjMQXiNX9y/T3A TehcB/avalAl/9BSlv8RMFexGikRr8jL+0oO4pPfh8PFhfYlYCw0jNyzMW1rtOCfjoxCC3+ F9MF6FqfV8e5pW/vwVALp1Q+UcPFnUvbPHdBf2VFI6IkEdrvNtuXbOTH7d4hexaqdXroK6J d5kd2dxArrHY6F5yQm8vuPWMmSpsMCz9OId3Xdww8fLAutWpOxkf+IMkTsI8UmWHPBGFTn6 DFgR5NhvJaIJMZAjwvbx5CaNs+W6W3XZd8rDRpaMVY+u+c9Yoq2QLex7FDXo5KsZw+ICyxC CyTE0ws6Pr0= X-QQ-GoodBg: 0 From: Jilin Yuan <yuanjilin@cdjrlc.com> To: robh+dt@kernel.org, frowand.list@gmail.com Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jilin Yuan <yuanjilin@cdjrlc.com> Subject: [PATCH] of: fix repeated words in comments Date: Wed, 19 Oct 2022 21:02:00 +0800 Message-Id: <20221019130200.60460-1-yuanjilin@cdjrlc.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:cdjrlc.com:qybglogicsvr:qybglogicsvr4 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747133528390176824?= X-GMAIL-MSGID: =?utf-8?q?1747133528390176824?= |
Series |
of: fix repeated words in comments
|
|
Commit Message
Jilin Yuan
Oct. 19, 2022, 1:02 p.m. UTC
Delete the redundant word 'of'.
Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
drivers/of/device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 10/19/22 06:02, Jilin Yuan wrote: > Delete the redundant word 'of'. > > Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com> > --- > drivers/of/device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/device.c b/drivers/of/device.c > index 8cefe5a7d04e..16c7e5a2a868 100644 > --- a/drivers/of/device.c > +++ b/drivers/of/device.c > @@ -19,7 +19,7 @@ > > /** > * of_match_device - Tell if a struct device matches an of_device_id list > - * @matches: array of of device match structures to search in > + * @matches: array of device match structures to search in Hi, Rob has already explained this at least 2 times. The second "of" is "open firmware". I would write it array of OF device match structures to search in :) > * @dev: the of device structure to match against > * > * Used by a driver to check whether an platform_device present in the
On 19/10/2022 19:53, Randy Dunlap wrote: > > > On 10/19/22 06:02, Jilin Yuan wrote: >> Delete the redundant word 'of'. >> >> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com> >> --- >> drivers/of/device.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/of/device.c b/drivers/of/device.c >> index 8cefe5a7d04e..16c7e5a2a868 100644 >> --- a/drivers/of/device.c >> +++ b/drivers/of/device.c >> @@ -19,7 +19,7 @@ >> >> /** >> * of_match_device - Tell if a struct device matches an of_device_id list >> - * @matches: array of of device match structures to search in >> + * @matches: array of device match structures to search in > > Hi, > Rob has already explained this at least 2 times. > > The second "of" is "open firmware". > I would write it > array of OF device match structures to search in > :) Good luck getting a response out of these guys, at this point you've gotta wonder if they're real people or bots. > >> * @dev: the of device structure to match against >> * >> * Used by a driver to check whether an platform_device present in the >
On Wed, Oct 19, 2022 at 11:53:54AM -0700, Randy Dunlap wrote: > > On 10/19/22 06:02, Jilin Yuan wrote: > > Delete the redundant word 'of'. > > > > Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com> > > --- > > drivers/of/device.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/of/device.c b/drivers/of/device.c > > index 8cefe5a7d04e..16c7e5a2a868 100644 > > --- a/drivers/of/device.c > > +++ b/drivers/of/device.c > > @@ -19,7 +19,7 @@ > > > > /** > > * of_match_device - Tell if a struct device matches an of_device_id list > > - * @matches: array of of device match structures to search in > > + * @matches: array of device match structures to search in > > Hi, > Rob has already explained this at least 2 times. > > The second "of" is "open firmware". > I would write it > array of OF device match structures to search in > :) Actually, I'd probably do something like array of Open Firmware (OF) device match structures... This is the first place in that file (at least in a comment) where OF gets used, and I've always been a big fan of using the fully expanded acronym before using the acronym form. Remember, PCMCIA stands for People Can't Memorize Computer Industry Acronyms. :-) (Actually, it's Personal Computer Memory Chip Industry Association, but most people don't know that, because using acronyms without defining them first makes you feel like you're an "insider". :-) - Ted
On 10/19/22 18:39, Theodore Ts'o wrote: > On Wed, Oct 19, 2022 at 11:53:54AM -0700, Randy Dunlap wrote: >> >> On 10/19/22 06:02, Jilin Yuan wrote: >>> Delete the redundant word 'of'. >>> >>> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com> >>> --- >>> drivers/of/device.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/of/device.c b/drivers/of/device.c >>> index 8cefe5a7d04e..16c7e5a2a868 100644 >>> --- a/drivers/of/device.c >>> +++ b/drivers/of/device.c >>> @@ -19,7 +19,7 @@ >>> >>> /** >>> * of_match_device - Tell if a struct device matches an of_device_id list >>> - * @matches: array of of device match structures to search in >>> + * @matches: array of device match structures to search in >> >> Hi, >> Rob has already explained this at least 2 times. >> >> The second "of" is "open firmware". >> I would write it >> array of OF device match structures to search in >> :) > > Actually, I'd probably do something like > > array of Open Firmware (OF) device match structures... Sure, that's good. > This is the first place in that file (at least in a comment) where OF > gets used, and I've always been a big fan of using the fully expanded > acronym before using the acronym form. Remember, PCMCIA stands for > People Can't Memorize Computer Industry Acronyms. :-) > > (Actually, it's Personal Computer Memory Chip Industry Association, Card International Association :) > but most people don't know that, because using acronyms without > defining them first makes you feel like you're an "insider". :-)
On Wed, Oct 19, 2022 at 8:39 PM Theodore Ts'o <tytso@mit.edu> wrote: > > On Wed, Oct 19, 2022 at 11:53:54AM -0700, Randy Dunlap wrote: > > > > On 10/19/22 06:02, Jilin Yuan wrote: > > > Delete the redundant word 'of'. > > > > > > Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com> > > > --- > > > drivers/of/device.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/of/device.c b/drivers/of/device.c > > > index 8cefe5a7d04e..16c7e5a2a868 100644 > > > --- a/drivers/of/device.c > > > +++ b/drivers/of/device.c > > > @@ -19,7 +19,7 @@ > > > > > > /** > > > * of_match_device - Tell if a struct device matches an of_device_id list > > > - * @matches: array of of device match structures to search in > > > + * @matches: array of device match structures to search in > > > > Hi, > > Rob has already explained this at least 2 times. > > > > The second "of" is "open firmware". > > I would write it > > array of OF device match structures to search in > > :) > > Actually, I'd probably do something like > > array of Open Firmware (OF) device match structures... Or just put the struct name in there: of_device_id But at this point I prefer to just leave it alone for the entertainment factor of how many times can I get this patch from send-only email accts. Rob
On Wed, Oct 19, 2022 at 07:57:44PM +0100, Conor Dooley wrote: > Good luck getting a response out of these guys, at this point > you've gotta wonder if they're real people or bots. > I think @cdjrlc.com people only have one-way communication with kernel community, since they send patches but ignoring (critical) review on these. Thanks.
On Wed, Oct 19, 2022 at 11:53:54AM -0700, Randy Dunlap wrote: > > /** > > * of_match_device - Tell if a struct device matches an of_device_id list > > - * @matches: array of of device match structures to search in > > + * @matches: array of device match structures to search in > > Hi, > Rob has already explained this at least 2 times. > On what?
On 10/20/22 06:35, Bagas Sanjaya wrote: > On Wed, Oct 19, 2022 at 11:53:54AM -0700, Randy Dunlap wrote: >>> /** >>> * of_match_device - Tell if a struct device matches an of_device_id list >>> - * @matches: array of of device match structures to search in >>> + * @matches: array of device match structures to search in >> >> Hi, >> Rob has already explained this at least 2 times. >> > > On what? > I have seen them on lkml mailing list.
diff --git a/drivers/of/device.c b/drivers/of/device.c index 8cefe5a7d04e..16c7e5a2a868 100644 --- a/drivers/of/device.c +++ b/drivers/of/device.c @@ -19,7 +19,7 @@ /** * of_match_device - Tell if a struct device matches an of_device_id list - * @matches: array of of device match structures to search in + * @matches: array of device match structures to search in * @dev: the of device structure to match against * * Used by a driver to check whether an platform_device present in the