ublk_drv: use flexible-array member instead of zero-length array

Message ID 20221018100132.355393-1-zys.zljxml@gmail.com
State New
Headers
Series ublk_drv: use flexible-array member instead of zero-length array |

Commit Message

Katrin Jo Oct. 18, 2022, 10:01 a.m. UTC
  From: Yushan Zhou <katrinzhou@tencent.com>

Eliminate the following coccicheck warning:
./drivers/block/ublk_drv.c:127:16-19: WARNING use flexible-array member instead

Signed-off-by: Yushan Zhou <katrinzhou@tencent.com>
---
 drivers/block/ublk_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Ming Lei Oct. 20, 2022, 1:26 a.m. UTC | #1
On Tue, Oct 18, 2022 at 6:02 PM <zys.zljxml@gmail.com> wrote:
>
> From: Yushan Zhou <katrinzhou@tencent.com>
>
> Eliminate the following coccicheck warning:
> ./drivers/block/ublk_drv.c:127:16-19: WARNING use flexible-array member instead
>
> Signed-off-by: Yushan Zhou <katrinzhou@tencent.com>
> ---
>  drivers/block/ublk_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
> index 2651bf41dde3..5afce6ffaadf 100644
> --- a/drivers/block/ublk_drv.c
> +++ b/drivers/block/ublk_drv.c
> @@ -124,7 +124,7 @@ struct ublk_queue {
>         bool force_abort;
>         unsigned short nr_io_ready;     /* how many ios setup */
>         struct ublk_device *dev;
> -       struct ublk_io ios[0];
> +       struct ublk_io ios[];
>  };
>
>  #define UBLK_DAEMON_MONITOR_PERIOD     (5 * HZ)

Reviewed-by: Ming Lei <ming.lei@redhat.com>

Thanks,
Ming
  
Jens Axboe Oct. 20, 2022, 1:27 a.m. UTC | #2
On Tue, 18 Oct 2022 18:01:32 +0800, zys.zljxml@gmail.com wrote:
> From: Yushan Zhou <katrinzhou@tencent.com>
> 
> Eliminate the following coccicheck warning:
> ./drivers/block/ublk_drv.c:127:16-19: WARNING use flexible-array member instead
> 
> 

Applied, thanks!

[1/1] ublk_drv: use flexible-array member instead of zero-length array
      commit: 72495b5ab456ec9f05d587238d1e2fa8e9ea63ec

Best regards,
  

Patch

diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
index 2651bf41dde3..5afce6ffaadf 100644
--- a/drivers/block/ublk_drv.c
+++ b/drivers/block/ublk_drv.c
@@ -124,7 +124,7 @@  struct ublk_queue {
 	bool force_abort;
 	unsigned short nr_io_ready;	/* how many ios setup */
 	struct ublk_device *dev;
-	struct ublk_io ios[0];
+	struct ublk_io ios[];
 };
 
 #define UBLK_DAEMON_MONITOR_PERIOD	(5 * HZ)