| Message ID | 20230111114337.24782-4-quic_sibis@quicinc.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp3271337wrt;
Wed, 11 Jan 2023 03:46:49 -0800 (PST)
X-Google-Smtp-Source:
AMrXdXuDdGYD/8Sz2M2uWs+9mZ2mTheoAPSprTSfxjzM3TD3AUHZVIQxp1uhHeeKj2q60kt1V6fH
X-Received: by 2002:a17:903:181:b0:193:3154:5c86 with SMTP id
z1-20020a170903018100b0019331545c86mr14970705plg.21.1673437609086;
Wed, 11 Jan 2023 03:46:49 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1673437609; cv=none;
d=google.com; s=arc-20160816;
b=ZE85CgNNb4cQMAY17MCi3dRdYaswoBu9+qxoC9sNPYIvJpWrZSKAF8AA+FWPOQipIW
BrBgscnWw3z4RNCUfCbz7eIWFKmU+GM4K82a7TYCYZNIKywv+o2VLbW3dbyBq3ehpxOr
fqwDBvDQKebEXiyQSSVoLrn6+uhl6dlZFBcYiQZZmY1VCvckNhWWdNrlx9NL5vgGh/FY
dqXmOQDpD1Xy3adXhv1znVOmQlZO4cPms+Y4eMhVTIZbuzP4fb3tegyDBpD2/yCgjV48
btXGvGjWile09ztapWxk5f+3Ez70X1UJVKuGlHYsC84quh2ZRRohBuoFUumtgdEXBl8q
bkAw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:mime-version:references:in-reply-to:message-id
:date:subject:cc:to:from:dkim-signature;
bh=BXPVg+Na+B5aGYrdAD3tCTK1Yc3pV1RCygVsNKebH2I=;
b=z/dfQ+Czxv5Kj2KEmosGULOc623lw1TTonNacmYZxuBQnVuADB5bDEdYtIjZdmWTRM
aqHlqQv7crYIVGyu8UPTP4PROOkW0aUOySllKTjofN6jcfPc/b20kvZlFxSn04fxhLww
rhcRIpBaMrKRwWO6+7PfhbuTMoC5zD9XiHolef0dq85m9ethpi9hdKcI2DtsNyLT76Z6
1wbaByoJtEXkpFPYnPxKpwI9JFu2G+oZD/5YhljZZzs62eoDVgsj8R9B76NOUmgGfhHx
qjTxDf34gaeDxj+FqWeDgNwQzWNdZANAS6UxbtxBsfjE0FDObiEbKJOIdiRM5rZDa3fO
P/tw==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=SNYjUPpB;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
jb10-20020a170903258a00b0019277a23421si13762752plb.53.2023.01.11.03.46.35;
Wed, 11 Jan 2023 03:46:49 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=SNYjUPpB;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S236446AbjAKLqN (ORCPT <rfc822;syz17693488234@gmail.com>
+ 99 others); Wed, 11 Jan 2023 06:46:13 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42344 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S234563AbjAKLpe (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 11 Jan 2023 06:45:34 -0500
Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com
[205.220.168.131])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79E7CBC9E;
Wed, 11 Jan 2023 03:44:25 -0800 (PST)
Received: from pps.filterd (m0279867.ppops.net [127.0.0.1])
by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id
30BAStg1018488;
Wed, 11 Jan 2023 11:44:12 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com;
h=from : to : cc :
subject : date : message-id : in-reply-to : references : mime-version :
content-type; s=qcppdkim1;
bh=BXPVg+Na+B5aGYrdAD3tCTK1Yc3pV1RCygVsNKebH2I=;
b=SNYjUPpB2c9bfsLLbMuJUc4DcFzV2CU8/NYEMKNvjzNPXTFHgSMggMhwv97/766qbtSo
n3nPbI9ED5/F5Kgo4Y2NCK8ZPDjmE7awTrFkp3ruaeJ0AozrrgZTIkG6m9asj1A23V+r
DbLYD7R6uM6E14JU4rtDgt5FAhYwDc/qnkh+Mkkin3iPtYP0XnBL5LG2M4VIQWCmz9My
HILS0W74t1XVLifwkDHumLJAttnIa5k7XA0YFigSkVjJf5cMN7+qL/Fi06rkYEdWVhon
h7FeGJ+rcwI95WQr/xz//+5JUehCx9ZDQNwaUT/4fhgfvZBsCTiJp8v1pHCB1p7pJVEa Hw==
Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com
[129.46.96.20])
by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3n1kgg165p-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Wed, 11 Jan 2023 11:44:12 +0000
Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com
[10.47.209.196])
by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id
30BBiBqd029551
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Wed, 11 Jan 2023 11:44:11 GMT
Received: from blr-ubuntu-87.ap.qualcomm.com (10.80.80.8) by
nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.2.986.36; Wed, 11 Jan 2023 03:44:07 -0800
From: Sibi Sankar <quic_sibis@quicinc.com>
To: <andersson@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<manivannan.sadhasivam@linaro.org>
CC: <agross@kernel.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<robh+dt@kernel.org>, <konrad.dybcio@somainline.org>,
<amit.pundir@linaro.org>, <regressions@leemhuis.info>,
<sumit.semwal@linaro.org>, <will@kernel.org>,
<catalin.marinas@arm.com>, <robin.murphy@arm.com>,
Sibi Sankar <quic_sibis@quicinc.com>
Subject: [PATCH V3 03/10] dt-bindings: remoteproc: qcom,sc7180-mss-pil: Update
memory-region
Date: Wed, 11 Jan 2023 17:13:30 +0530
Message-ID: <20230111114337.24782-4-quic_sibis@quicinc.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20230111114337.24782-1-quic_sibis@quicinc.com>
References: <20230111114337.24782-1-quic_sibis@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [10.80.80.8]
X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To
nalasex01a.na.qualcomm.com (10.47.209.196)
X-QCInternal: smtphost
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800
signatures=585085
X-Proofpoint-ORIG-GUID: KoNWOZy9U-Ak1WlowMElOiLNNZ7c4_LP
X-Proofpoint-GUID: KoNWOZy9U-Ak1WlowMElOiLNNZ7c4_LP
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
definitions=2023-01-11_05,2023-01-11_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
phishscore=0 spamscore=0
bulkscore=0 impostorscore=0 adultscore=0 mlxlogscore=984 mlxscore=0
lowpriorityscore=0 clxscore=1015 priorityscore=1501 malwarescore=0
suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
engine=8.12.0-2212070000 definitions=main-2301110087
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1754726514646097305?=
X-GMAIL-MSGID: =?utf-8?q?1754726514646097305?=
|
| Series |
Fix XPU violation during modem metadata authentication
|
|
Commit Message
Sibi Sankar
Jan. 11, 2023, 11:43 a.m. UTC
The dynamic memory region used for metadata authentication would still be a part of the kernel mapping and any access to this region by the application processor after assigning it to the remote Q6 will result in a XPU violation. This is fixed by using a no-map carveout instead. Update the bindings to reflect the addition of the new modem metadata carveout on SC7180 SoC. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com> --- v3: * remove double space [Krzysztof] * Pickup R-b v2: * Pad commit message to explain bindings break [Krzysztof] * Split dt/bindings per SoC [Krzysztof] .../devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On Wed, 11 Jan 2023 17:13:30 +0530, Sibi Sankar wrote: > The dynamic memory region used for metadata authentication would still > be a part of the kernel mapping and any access to this region by the > application processor after assigning it to the remote Q6 will result > in a XPU violation. This is fixed by using a no-map carveout instead. > Update the bindings to reflect the addition of the new modem metadata > carveout on SC7180 SoC. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com> > --- > > v3: > * remove double space [Krzysztof] > * Pickup R-b > > v2: > * Pad commit message to explain bindings break [Krzysztof] > * Split dt/bindings per SoC [Krzysztof] > > .../devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230111114337.24782-4-quic_sibis@quicinc.com remoteproc@4080000: memory-region: [[105], [106]] is too short arch/arm64/boot/dts/qcom/sc7180-idp.dtb remoteproc@4080000: memory-region: [[122], [123]] is too short arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick-r0-lte.dtb remoteproc@4080000: memory-region: [[123], [124]] is too short arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0-auo.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0-boe.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev1-auo.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev1-boe.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick-r0.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-boe.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-inx.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dtb remoteproc@4080000: memory-region: [[128], [129]] is too short arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-wifi.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-parade.dtb remoteproc@4080000: memory-region: [[129], [130]] is too short arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-ti.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-ti.dtb remoteproc@4080000: memory-region: [[130], [131]] is too short arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r5.dtb remoteproc@4080000: memory-region: [[131], [132]] is too short arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r2.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r4.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r1.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r9.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dtb remoteproc@4080000: memory-region: [[132], [133]] is too short arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r3.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r4.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dtb remoteproc@4080000: qcom,halt-regs:0: [110] is too short arch/arm64/boot/dts/qcom/sc7180-idp.dtb remoteproc@4080000: qcom,halt-regs:0: [127] is too short arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick-r0-lte.dtb remoteproc@4080000: qcom,halt-regs:0: [128] is too short arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0-auo.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0-boe.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev1-auo.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev1-boe.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick-r0.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-boe.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-inx.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dtb remoteproc@4080000: qcom,halt-regs:0: [133] is too short arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-wifi.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-parade.dtb remoteproc@4080000: qcom,halt-regs:0: [134] is too short arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-ti.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-ti.dtb remoteproc@4080000: qcom,halt-regs:0: [135] is too short arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r5.dtb remoteproc@4080000: qcom,halt-regs:0: [136] is too short arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r2.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r4.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r1.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r9.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dtb remoteproc@4080000: qcom,halt-regs:0: [137] is too short arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r3.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r4.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dtb arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dtb
On Wed, Jan 11, 2023 at 05:13:30PM +0530, Sibi Sankar wrote: > The dynamic memory region used for metadata authentication would still > be a part of the kernel mapping and any access to this region by the > application processor after assigning it to the remote Q6 will result > in a XPU violation. This is fixed by using a no-map carveout instead. > Update the bindings to reflect the addition of the new modem metadata > carveout on SC7180 SoC. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com> > --- > > v3: > * remove double space [Krzysztof] > * Pickup R-b > > v2: > * Pad commit message to explain bindings break [Krzysztof] > * Split dt/bindings per SoC [Krzysztof] > > .../devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml > index e4a7da8020f4..b1402bef0ebe 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml > @@ -95,6 +95,7 @@ properties: > items: > - description: MBA reserved region > - description: modem reserved region > + - description: metadata reserved region Based on dtbs_check, looks like you need 'minItems: 2'. > > firmware-name: > $ref: /schemas/types.yaml#/definitions/string-array > @@ -223,7 +224,7 @@ examples: > <&rpmhpd SC7180_MSS>; > power-domain-names = "cx", "mx", "mss"; > > - memory-region = <&mba_mem>, <&mpss_mem>; > + memory-region = <&mba_mem>, <&mpss_mem>, <&mdata_mem>; > > qcom,qmp = <&aoss_qmp>; > > -- > 2.17.1 >
On Thu, Jan 12, 2023 at 2:17 PM Rob Herring <robh@kernel.org> wrote: > > On Wed, Jan 11, 2023 at 05:13:30PM +0530, Sibi Sankar wrote: > > The dynamic memory region used for metadata authentication would still > > be a part of the kernel mapping and any access to this region by the > > application processor after assigning it to the remote Q6 will result > > in a XPU violation. This is fixed by using a no-map carveout instead. > > Update the bindings to reflect the addition of the new modem metadata > > carveout on SC7180 SoC. > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com> > > --- > > > > v3: > > * remove double space [Krzysztof] > > * Pickup R-b > > > > v2: > > * Pad commit message to explain bindings break [Krzysztof] > > * Split dt/bindings per SoC [Krzysztof] > > > > .../devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml > > index e4a7da8020f4..b1402bef0ebe 100644 > > --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml > > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml > > @@ -95,6 +95,7 @@ properties: > > items: > > - description: MBA reserved region > > - description: modem reserved region > > + - description: metadata reserved region > > Based on dtbs_check, looks like you need 'minItems: 2'. NM, I see those are all sc7180. Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml index e4a7da8020f4..b1402bef0ebe 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml @@ -95,6 +95,7 @@ properties: items: - description: MBA reserved region - description: modem reserved region + - description: metadata reserved region firmware-name: $ref: /schemas/types.yaml#/definitions/string-array @@ -223,7 +224,7 @@ examples: <&rpmhpd SC7180_MSS>; power-domain-names = "cx", "mx", "mss"; - memory-region = <&mba_mem>, <&mpss_mem>; + memory-region = <&mba_mem>, <&mpss_mem>, <&mdata_mem>; qcom,qmp = <&aoss_qmp>;