diff mbox series

f2fs: update comment about f2fs_issue_discard_timeout()

Message ID 20221220185459.55950-1-frank.li@vivo.com
State New
Headers
Series f2fs: update comment about f2fs_issue_discard_timeout() |

Commit Message

李扬韬 Dec. 20, 2022, 6:54 p.m. UTC 
  After commit 4d67490498ac ("f2fs: Don't create discard thread when
device doesn't support realtime discard"), f2fs_issue_discard_timeout()
is not only called by f2fs_put_super().

Let's update it.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 fs/f2fs/segment.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chao Yu Jan. 11, 2023, 1:30 p.m. UTC | #1 
On 2022/12/21 2:54, Yangtao Li wrote:
> After commit 4d67490498ac ("f2fs: Don't create discard thread when
> device doesn't support realtime discard"), f2fs_issue_discard_timeout()
> is not only called by f2fs_put_super().

Actually, it also comes from error path of fill_super().

We don't need to update this comments all the time, how about removing
this since it's trivial.

Thanks,

> 
> Let's update it.
diff mbox series

Patch

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index af2d522b1a89..fd3b16f68ffc 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1654,7 +1654,7 @@  void f2fs_stop_discard_thread(struct f2fs_sb_info *sbi)
 	}
 }
 
-/* This comes from f2fs_put_super */
+/* This comes from f2fs_put_super() and f2fs_remount() */
 bool f2fs_issue_discard_timeout(struct f2fs_sb_info *sbi)
 {
 	struct discard_cmd_control *dcc = SM_I(sbi)->dcc_info;