Message ID | 20230110160124.3853593-3-hugo@hugovil.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2832365wrt; Tue, 10 Jan 2023 08:06:54 -0800 (PST) X-Google-Smtp-Source: AMrXdXuj6ySb0LGkgeucSuqCOmiyxlen5Ekc1hPAlMMYCZCGj8doENLDi6HeRJvxJD1eEz5auJfb X-Received: by 2002:a05:6a20:d68f:b0:9d:efbf:48e7 with SMTP id it15-20020a056a20d68f00b0009defbf48e7mr87526290pzb.43.1673366814454; Tue, 10 Jan 2023 08:06:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673366814; cv=none; d=google.com; s=arc-20160816; b=jzEzRyNZP1fA3jUVgT4DK2W7hXftWfGFywSJfSuMFXx6FKrnJasnohmRhFLfN5Ky+J ZDi3EelgQ8jxah6phmYkhy0TU2MzjKOTEH299p/DPCNXVnvpZ9rWigFirn5kdk3EMKJg Nu30iRWd0bwdJVwNLfLa6N+IwBSL3Rm/gQS0DTPHyJhpLJX5T6oIoEGkObGn6M2Mb6Rz o5qQpxgT3beeu4UXCYYLoGqquR+Y15l6/usjw2q7fecOlXbhdBLIGvGHFxn04Tzg6mbr 2aWXb4M7zrfjsY0qGehQ9/aILmyWkl9O62lCQ/HJKTZ/LcefXJACNtJBb96pO9eNZMf5 UcOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:cc:to:from:dkim-signature; bh=oTVB50/ici0YMYyKRDs/Lka/kYpfalQ+g+Tk/bkfMeo=; b=CiwAN9yzMYj3l4AVARxzGl+gmI7s3knuysvIbMV5q8CfTs5j7Y/meZVH7jm0LaEDNa g5qmh/l0GB+qbU5nkBqSnNipOGIViObm61UsgkRX0T6wQcXgRK+ra104WhFvtsBD+KNR CQWESN7Mb51LSXwC3C7DqSmHdkcIrmBFwzSfLQCk6P7u3c5AoEBzBRWQCAuyMqBbwwlf XfoN1h6vh/fYdu91xypDknktcBWC8mu5ilqAY4n2ipEgjvxYPFS/banbT2zwNkEH1/2K BSzcIaG/U0BxJgKvFAerVOJ7p6We7ea1v1mhJnP2YYYE2NFO7FUSwty+z738wO89Y6y1 8ytA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=e2hdwprM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i6-20020a63e446000000b0047715c95650si11584594pgk.534.2023.01.10.08.06.35; Tue, 10 Jan 2023 08:06:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=e2hdwprM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234350AbjAJQCW (ORCPT <rfc822;syz17693488234@gmail.com> + 99 others); Tue, 10 Jan 2023 11:02:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233423AbjAJQBq (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 10 Jan 2023 11:01:46 -0500 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B034532EAA; Tue, 10 Jan 2023 08:01:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oTVB50/ici0YMYyKRDs/Lka/kYpfalQ+g+Tk/bkfMeo=; b=e2hdwprMphZ5yovZO8ivKPBSb0 irIkiV4DRkzH55hV0D5wp8rPfsbKdEPQjs9dUWSYe1whDrFDmnOzfLBcQigmnIG6AklQ2iZ3OB8cB JQq6507u6F0+St7VUerbcGzN+JoLVSXsa/4ESfgto5mIGmWb/+2kqcgyP+rz20gFNbKA=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:41140 helo=pettiford.lan) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from <hugo@hugovil.com>) id 1pFH4C-0007oY-Gw; Tue, 10 Jan 2023 11:01:37 -0500 From: Hugo Villeneuve <hugo@hugovil.com> To: hvilleneuve@dimonoff.com, jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, hugo@hugovil.com Date: Tue, 10 Jan 2023 11:01:24 -0500 Message-Id: <20230110160124.3853593-3-hugo@hugovil.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230110160124.3853593-1-hugo@hugovil.com> References: <20230110160124.3853593-1-hugo@hugovil.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Subject: [PATCH v2 2/2] dt-bindings: iio: adc: add Texas Instruments ADS7924 X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754652281008428295?= X-GMAIL-MSGID: =?utf-8?q?1754652281008428295?= |
Series |
iio: adc: ti-ads7924: add Texas Instruments ADS7924 driver
|
|
Commit Message
Hugo Villeneuve
Jan. 10, 2023, 4:01 p.m. UTC
From: Hugo Villeneuve <hvilleneuve@dimonoff.com> Add device tree bindings document for the Texas Instruments ADS7924 ADC. Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> --- .../bindings/iio/adc/ti,ads7924.yaml | 104 ++++++++++++++++++ 1 file changed, 104 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml
Comments
On Tue, 10 Jan 2023 11:01:24 -0500, Hugo Villeneuve wrote: > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > Add device tree bindings document for the Texas Instruments ADS7924 > ADC. > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> > --- > .../bindings/iio/adc/ti,ads7924.yaml | 104 ++++++++++++++++++ > 1 file changed, 104 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml: 'oneOf' conditional failed, one must be fixed: 'unevaluatedProperties' is a required property 'additionalProperties' is a required property hint: Either unevaluatedProperties or additionalProperties must be present from schema $id: http://devicetree.org/meta-schemas/core.yaml# Error: Documentation/devicetree/bindings/iio/adc/ti,ads7924.example.dts:29.40-41 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:434: Documentation/devicetree/bindings/iio/adc/ti,ads7924.example.dtb] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1508: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230110160124.3853593-3-hugo@hugovil.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 10/01/2023 17:01, Hugo Villeneuve wrote: > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > Add device tree bindings document for the Texas Instruments ADS7924 > ADC. > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> Please test the bindings before sending. It's better to use tools for review than humans... we are all quite busy. > --- > .../bindings/iio/adc/ti,ads7924.yaml | 104 ++++++++++++++++++ > 1 file changed, 104 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml > new file mode 100644 > index 000000000000..a9d3e8778d11 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml > @@ -0,0 +1,104 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/ti,ads7924.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: TI ADS7924 4 channels 12 bits I2C analog to digital converter > + > +maintainers: > + - Hugo Villeneuve <hvilleneuve@dimonoff.com> > + > +description: | > + Texas Instruments ADS7924 4 channels 12 bits I2C analog to digital converter > + > + Specifications: > + https://www.ti.com/lit/gpn/ads7924 > + > +properties: > + compatible: > + const: ti,ads7924 > + > + reg: > + maxItems: 1 > + > + vref-supply: > + description: > + The regulator supply for the ADC reference voltage (AVDD) > + > + reset-gpios: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + "#io-channel-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - vref-supply > + - "#address-cells" > + - "#size-cells" > + > +patternProperties: Put it before "required:" block. > + "^channel@[0-3]+$": > + $ref: "adc.yaml" Drop quotes. > + type: object > + description: | > + Represents the external channels which are connected to the ADC. > + > + properties: > + reg: > + description: | > + The channel number. It can have up to 4 channels numbered from 0 to 3. > + items: > + - minimum: 0 > + maximum: 3 Test your bindings, so you will see error here of missing label: true. > + > + required: > + - reg > + > + additionalProperties: false > + Missing additionalProperties: false. > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + adc@48 { > + compatible = "ti,ads7924"; > + reg = <0x48>; > + vref-supply = <&ads7924_reg>; > + reset-gpios = <&gpio 5 GPIO_ACTIVE_LOW>; > + interrupts = <25 IRQ_TYPE_EDGE_FALLING>; > + interrupt-parent = <&gpio>; > + #address-cells = <1>; > + #size-cells = <0>; > + channel@0 { > + reg = <0>; > + label = "CH0"; > + }; > + channel@1 { > + reg = <1>; > + label = "CH1"; > + }; > + channel@2 { > + reg = <2>; > + label = "CH2"; > + }; > + channel@3 { > + reg = <3>; > + label = "CH3"; > + }; > + }; > + }; > +... Best regards, Krzysztof
On Tue, 10 Jan 2023 19:34:56 -0600 Rob Herring <robh@kernel.org> wrote: > > On Tue, 10 Jan 2023 11:01:24 -0500, Hugo Villeneuve wrote: > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > > > Add device tree bindings document for the Texas Instruments ADS7924 > > ADC. > > > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > --- > > .../bindings/iio/adc/ti,ads7924.yaml | 104 ++++++++++++++++++ > > 1 file changed, 104 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml: 'oneOf' conditional failed, one must be fixed: > 'unevaluatedProperties' is a required property > 'additionalProperties' is a required property > hint: Either unevaluatedProperties or additionalProperties must be present > from schema $id: http://devicetree.org/meta-schemas/core.yaml# > Error: Documentation/devicetree/bindings/iio/adc/ti,ads7924.example.dts:29.40-41 syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:434: Documentation/devicetree/bindings/iio/adc/ti,ads7924.example.dtb] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:1508: dt_binding_check] Error 2 > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230110160124.3853593-3-hugo@hugovil.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. Hi Rob, I already did specify the base-commit in the first patch of the series (cover letter). Do you also want me to add an additional message in *this* commit to specify the git repos and branch that were used? Or put this comment in the cover letter? I tried to follow the documentation here: https://www.kernel.org/doc/html/v6.2-rc3/process/submitting-patches.html but it was not clear as to what base branch to use when no "T:" field is found in the MAINTAINERS file. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade I didn't run it for this series, my bad, I now have added it to my automated scripts to not forget it next time. > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. Done, thank you for your suggestions. Hugo Villeneuve <hugo@hugovil.com>
On Wed, 11 Jan 2023 10:23:20 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 10/01/2023 17:01, Hugo Villeneuve wrote: > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > > > Add device tree bindings document for the Texas Instruments ADS7924 > > ADC. > > > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > Please test the bindings before sending. It's better to use tools for > review than humans... we are all quite busy. Hi, will do from now on. > > --- > > .../bindings/iio/adc/ti,ads7924.yaml | 104 ++++++++++++++++++ > > 1 file changed, 104 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml > > new file mode 100644 > > index 000000000000..a9d3e8778d11 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml > > @@ -0,0 +1,104 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/adc/ti,ads7924.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: TI ADS7924 4 channels 12 bits I2C analog to digital converter > > + > > +maintainers: > > + - Hugo Villeneuve <hvilleneuve@dimonoff.com> > > + > > +description: | > > + Texas Instruments ADS7924 4 channels 12 bits I2C analog to digital converter > > + > > + Specifications: > > + https://www.ti.com/lit/gpn/ads7924 > > + > > +properties: > > + compatible: > > + const: ti,ads7924 > > + > > + reg: > > + maxItems: 1 > > + > > + vref-supply: > > + description: > > + The regulator supply for the ADC reference voltage (AVDD) > > + > > + reset-gpios: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + "#address-cells": > > + const: 1 > > + > > + "#size-cells": > > + const: 0 > > + > > + "#io-channel-cells": > > + const: 1 > > + > > +required: > > + - compatible > > + - reg > > + - vref-supply > > + - "#address-cells" > > + - "#size-cells" > > + > > +patternProperties: > > Put it before "required:" block. Done. > > > + "^channel@[0-3]+$": > > + $ref: "adc.yaml" > > Drop quotes. Done. > > > + type: object > > + description: | > > + Represents the external channels which are connected to the ADC. > > + > > + properties: > > + reg: > > + description: | > > + The channel number. It can have up to 4 channels numbered from 0 to 3. > > + items: > > + - minimum: 0 > > + maximum: 3 > > Test your bindings, so you will see error here of missing label: true. Added label. > > > + > > + required: > > + - reg > > + > > + additionalProperties: false > > + > > Missing additionalProperties: false. Added. > > > +examples: > > + - | > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + adc@48 { > > + compatible = "ti,ads7924"; > > + reg = <0x48>; > > + vref-supply = <&ads7924_reg>; > > + reset-gpios = <&gpio 5 GPIO_ACTIVE_LOW>; > > + interrupts = <25 IRQ_TYPE_EDGE_FALLING>; > > + interrupt-parent = <&gpio>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + channel@0 { > > + reg = <0>; > > + label = "CH0"; > > + }; > > + channel@1 { > > + reg = <1>; > > + label = "CH1"; > > + }; > > + channel@2 { > > + reg = <2>; > > + label = "CH2"; > > + }; > > + channel@3 { > > + reg = <3>; > > + label = "CH3"; > > + }; > > + }; > > + }; > > +... > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml new file mode 100644 index 000000000000..a9d3e8778d11 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml @@ -0,0 +1,104 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/adc/ti,ads7924.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TI ADS7924 4 channels 12 bits I2C analog to digital converter + +maintainers: + - Hugo Villeneuve <hvilleneuve@dimonoff.com> + +description: | + Texas Instruments ADS7924 4 channels 12 bits I2C analog to digital converter + + Specifications: + https://www.ti.com/lit/gpn/ads7924 + +properties: + compatible: + const: ti,ads7924 + + reg: + maxItems: 1 + + vref-supply: + description: + The regulator supply for the ADC reference voltage (AVDD) + + reset-gpios: + maxItems: 1 + + interrupts: + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + + "#io-channel-cells": + const: 1 + +required: + - compatible + - reg + - vref-supply + - "#address-cells" + - "#size-cells" + +patternProperties: + "^channel@[0-3]+$": + $ref: "adc.yaml" + type: object + description: | + Represents the external channels which are connected to the ADC. + + properties: + reg: + description: | + The channel number. It can have up to 4 channels numbered from 0 to 3. + items: + - minimum: 0 + maximum: 3 + + required: + - reg + + additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + adc@48 { + compatible = "ti,ads7924"; + reg = <0x48>; + vref-supply = <&ads7924_reg>; + reset-gpios = <&gpio 5 GPIO_ACTIVE_LOW>; + interrupts = <25 IRQ_TYPE_EDGE_FALLING>; + interrupt-parent = <&gpio>; + #address-cells = <1>; + #size-cells = <0>; + channel@0 { + reg = <0>; + label = "CH0"; + }; + channel@1 { + reg = <1>; + label = "CH1"; + }; + channel@2 { + reg = <2>; + label = "CH2"; + }; + channel@3 { + reg = <3>; + label = "CH3"; + }; + }; + }; +...