diff mbox series

MAINTAINERS: stop nvme matching for nvmem files

Message ID E1pCkft-004hzL-0Q@rmk-PC.armlinux.org.uk
State New
Headers
Series MAINTAINERS: stop nvme matching for nvmem files |

Commit Message

Russell King (Oracle) Jan. 3, 2023, 5:02 p.m. UTC 
  The nvme patterns detect all include files starting with nvme, which
also picks up the nvmem subsystem header files. Fix this by excluding
the nvmem subsystem header files from the nvme subsystem entry.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

Comments

Christoph Hellwig Jan. 8, 2023, 5:05 p.m. UTC | #1 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0cccd40d7801..64cc6947099e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -14711,6 +14711,7 @@ T:	git://git.infradead.org/nvme.git
>  F:	drivers/nvme/host/
>  F:	drivers/nvme/common/
>  F:	include/linux/nvme*
> +X:	include/linux/nvmem*

I think the proper thing to do would to just match the right files
from the start:

F:	include/linux/nvme.h
F:	include/linux/nvme-*.h

is it ok if I commit it with your original attributation with that
change?
Russell King (Oracle) Jan. 9, 2023, 5:21 p.m. UTC | #2 
On Sun, Jan 08, 2023 at 06:05:20PM +0100, Christoph Hellwig wrote:
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 0cccd40d7801..64cc6947099e 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -14711,6 +14711,7 @@ T:	git://git.infradead.org/nvme.git
> >  F:	drivers/nvme/host/
> >  F:	drivers/nvme/common/
> >  F:	include/linux/nvme*
> > +X:	include/linux/nvmem*
> 
> I think the proper thing to do would to just match the right files
> from the start:
> 
> F:	include/linux/nvme.h
> F:	include/linux/nvme-*.h
> 
> is it ok if I commit it with your original attributation with that
> change?

LGTM, thanks!
Christoph Hellwig Jan. 10, 2023, 7:19 a.m. UTC | #3 
On Mon, Jan 09, 2023 at 05:21:57PM +0000, Russell King (Oracle) wrote:
> > I think the proper thing to do would to just match the right files
> > from the start:
> > 
> > F:	include/linux/nvme.h
> > F:	include/linux/nvme-*.h
> > 
> > is it ok if I commit it with your original attributation with that
> > change?
> 
> LGTM, thanks!

Thanks, I've added the updated version to the nvme-6.2 branch.
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 0cccd40d7801..64cc6947099e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14711,6 +14711,7 @@  T:	git://git.infradead.org/nvme.git
 F:	drivers/nvme/host/
 F:	drivers/nvme/common/
 F:	include/linux/nvme*
+X:	include/linux/nvmem*
 F:	include/uapi/linux/nvme_ioctl.h
 
 NVM EXPRESS FABRICS AUTHENTICATION