[v2] dt-bindings: remoteproc: qcom: sc7280-adsp-pil: Add reg-names and power-domain-names
Message ID | 1672991425-898-1-git-send-email-quic_srivasam@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp701514wrt; Fri, 6 Jan 2023 00:01:09 -0800 (PST) X-Google-Smtp-Source: AMrXdXsxgvfCy1kXfxzcuuyOX1FMn2IwjZir2S68Zbd98DjuGtZFrSBlrLr872LU6ygA97vCW92n X-Received: by 2002:a17:906:308c:b0:7c0:a6a9:64e9 with SMTP id 12-20020a170906308c00b007c0a6a964e9mr62028761ejv.36.1672992069347; Fri, 06 Jan 2023 00:01:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672992069; cv=none; d=google.com; s=arc-20160816; b=T8Aa1V3BIThA2IAE9eOhkyHrqwJ/z6tB/+lWgzVSaulX+s2hN6IbsnrxHC1UjRIkIP 60WVzGbANJMJWuq0YPEvcs4jk/21MbJhnSea947hqLLbu42qdlE/bZVUH3vJbuwmPD5d SuzMvg8COEO4x0ny+zZjEh0tzc2p0CNGfSEmJ4ljBO2fOh6/Yez7nAqhzWECco33eSl0 XS75zdLZ82/tz9uzY1BHmoLZSMSg0Git8yegAmHCRXwdfBCUwUuqNYNwQHDRLxDnxNMe sRUm9hSDdKDbbVe3J4adIXs0pM2UlqZB8ujgZ0IHB2MblPNLLGn66uVNGJxW5OT5azgz EMMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=S99CK2uqgldob/xpdOz0tRfl+mlVpPSOv5ZRtV6QhcU=; b=BEC0LfAKYB5m4Q0LO6xX7e5nairuA8CqeXF3bW8G4c8MnFLk9zq8amUF5SIGvNMq8Y /lNEFS3FIq2t057UZmgbbebpC1YjIBvA6awg/2sEwMEkhluwzxttXa4xA7YIAWdCzvWI bmMXyhtxSp5MgGiodhJT34YY4QRhB6d4j16eek1r0T7d0A+atgMl9FKde0eX42zfqo1O gjwOVOLT+jTYYJal4eckD+8nax9NPVGydHtLZGFpvYqlMYzTScbJITJbpZzINDNH8bAv muvzR41ysk9ynYinxIs4qtBbzp73qKjvLzgs+m7J7AAYn+v1z6BE/dIeUntY9+pGnwA/ XdxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=GYCEmJT0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dr12-20020a170907720c00b007919c624eadsi701732ejc.522.2023.01.06.00.00.45; Fri, 06 Jan 2023 00:01:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=GYCEmJT0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231845AbjAFH45 (ORCPT <rfc822;tmhikaru@gmail.com> + 99 others); Fri, 6 Jan 2023 02:56:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229490AbjAFH4y (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 6 Jan 2023 02:56:54 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDE6C7814E; Thu, 5 Jan 2023 23:56:53 -0800 (PST) Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3067p6So015569; Fri, 6 Jan 2023 07:56:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=qcppdkim1; bh=S99CK2uqgldob/xpdOz0tRfl+mlVpPSOv5ZRtV6QhcU=; b=GYCEmJT0l2ouW2sh5R4bTypNzCrVTLlqjV4w5Jj2Mx2NrCEvlDppWf8YCMPDsxOiEmmK 6lrcRlEv6yZ2P9Q6a10b4A+y8rxX7JvvEg5udZ8sqsDxx9Mb54QWo7zvFQETn845klN+ ufD87NsGVm5Cf9ZeokMbwM2PPb3kFG02BcGSsi41Awtu9QtZAiPoKg9/KljsnbK79wOL DBsIDLnDuv1aliJAmLdqY23XzEOOMLJvLCyuzgp3eG3BaMgYEKDgS1dvyaVbF3ajXtAa hB2IedgBHWMXPtSfQmU31O/FrDq+8LApLx21KBeCrJLbADLB5aymTBphGw9yIBlV4Hvc gg== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3mx5b0h6v4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Jan 2023 07:56:01 +0000 Received: from nasanex01a.na.qualcomm.com (corens_vlan604_snip.qualcomm.com [10.53.140.1]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3067u0i8001996 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 6 Jan 2023 07:56:00 GMT Received: from hu-srivasam-hyd.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 5 Jan 2023 23:50:39 -0800 From: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> To: <linux-remoteproc@vger.kernel.org>, <agross@kernel.org>, <andersson@kernel.org>, <lgirdwood@gmail.com>, <broonie@kernel.org>, <robh+dt@kernel.org>, <quic_plai@quicinc.com>, <bgoswami@quicinc.com>, <perex@perex.cz>, <tiwai@suse.com>, <srinivas.kandagatla@linaro.org>, <quic_rohkumar@quicinc.com>, <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <swboyd@chromium.org>, <judyhsiao@chromium.org>, <devicetree@vger.kernel.org>, <krzysztof.kozlowski@linaro.org>, <mathieu.poirier@linaro.org>, <corbet@lwn.net> CC: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> Subject: [PATCH v2] dt-bindings: remoteproc: qcom: sc7280-adsp-pil: Add reg-names and power-domain-names Date: Fri, 6 Jan 2023 13:20:25 +0530 Message-ID: <1672991425-898-1-git-send-email-quic_srivasam@quicinc.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: ne0BeOfA8y4RylNLcg-2YdKJ55M-QIk7 X-Proofpoint-GUID: ne0BeOfA8y4RylNLcg-2YdKJ55M-QIk7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-06_03,2023-01-05_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 mlxlogscore=999 impostorscore=0 suspectscore=0 mlxscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301060061 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754259332169500112?= X-GMAIL-MSGID: =?utf-8?q?1754259332169500112?= |
Series |
[v2] dt-bindings: remoteproc: qcom: sc7280-adsp-pil: Add reg-names and power-domain-names
|
|
Commit Message
Srinivasa Rao Mandadapu
Jan. 6, 2023, 7:50 a.m. UTC
Add reg-names and power-domain-names for remoteproc ADSP pheripheral
loader. This is to make compatible with remoteproc ADSP PIL driver.
Also change power domain from LCX to CX.
Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
---
Changes Since v1:
-- Modify subject line to SoC specific.
.../devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
Comments
On 06/01/2023 08:50, Srinivasa Rao Mandadapu wrote: > Add reg-names and power-domain-names for remoteproc ADSP pheripheral > loader. This is to make compatible with remoteproc ADSP PIL driver. I don't understand the reasoning. Before binding was "incompatible"? > Also change power domain from LCX to CX. Why? Hardware changed? > > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> > --- > Changes Since v1: > -- Modify subject line to SoC specific. > > .../devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml > index 94ca7a0..b5bee2c 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml > @@ -23,6 +23,11 @@ properties: > - description: qdsp6ss register > - description: efuse q6ss register > > + reg-names: > + items: > + - const: qdsp6ss_base > + - const: lpass_efuse > + > iommus: > items: > - description: Phandle to apps_smmu node with sid mask > @@ -57,7 +62,11 @@ properties: > > power-domains: > items: > - - description: LCX power domain > + - description: CX power domain > + > + power-domain-names: > + items: > + - const: cx > > resets: > items: Best regards, Krzysztof
On 1/8/2023 9:06 PM, Krzysztof Kozlowski wrote: Thanks for Your Time Krzyszto!!! > On 06/01/2023 08:50, Srinivasa Rao Mandadapu wrote: >> Add reg-names and power-domain-names for remoteproc ADSP pheripheral >> loader. This is to make compatible with remoteproc ADSP PIL driver. > I don't understand the reasoning. Before binding was "incompatible"? Yes. Previous bindings needs fixes. Will add fixes tag for the same. So far corresponding device tree not mainlined and no user till now, hence these missing errors not found. > >> Also change power domain from LCX to CX. > Why? Hardware changed? No, basically it's a fix. The power domain name wrongly mentioned in previous bindings. The fixes tag mentioned above will be applicable here also. > >> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> >> --- >> Changes Since v1: >> -- Modify subject line to SoC specific. >> >> .../devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml >> index 94ca7a0..b5bee2c 100644 >> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml >> @@ -23,6 +23,11 @@ properties: >> - description: qdsp6ss register >> - description: efuse q6ss register >> >> + reg-names: >> + items: >> + - const: qdsp6ss_base >> + - const: lpass_efuse >> + >> iommus: >> items: >> - description: Phandle to apps_smmu node with sid mask >> @@ -57,7 +62,11 @@ properties: >> >> power-domains: >> items: >> - - description: LCX power domain >> + - description: CX power domain >> + >> + power-domain-names: >> + items: >> + - const: cx >> >> resets: >> items: > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml index 94ca7a0..b5bee2c 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-adsp-pil.yaml @@ -23,6 +23,11 @@ properties: - description: qdsp6ss register - description: efuse q6ss register + reg-names: + items: + - const: qdsp6ss_base + - const: lpass_efuse + iommus: items: - description: Phandle to apps_smmu node with sid mask @@ -57,7 +62,11 @@ properties: power-domains: items: - - description: LCX power domain + - description: CX power domain + + power-domain-names: + items: + - const: cx resets: items: