diff mbox series

[arm] Skip ld/pr23169 test on arm.

Message ID 20230103102251.89478-2-christophe.lyon@arm.com
State Accepted
Headers
Series [arm] Skip ld/pr23169 test on arm. |

Checks

Context Check Description
snail/binutils-gdb-check success Github commit url

Commit Message

Christophe Lyon Jan. 3, 2023, 10:22 a.m. UTC 
  The test is already skipped on several targets (including AArch64)
because it's invalid.

	* testsuite/ld-ifunc/ifunc.exp: Skip pr23169 on arm.
---
 ld/testsuite/ld-ifunc/ifunc.exp | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Christophe Lyon Jan. 9, 2023, 1:28 p.m. UTC | #1 
ping?
(this solves some of the failures reported by Matthias on the 2.40 branch)


On 1/3/23 11:22, Christophe Lyon via Binutils wrote:
> The test is already skipped on several targets (including AArch64)
> because it's invalid.
> 
> 	* testsuite/ld-ifunc/ifunc.exp: Skip pr23169 on arm.
> ---
>   ld/testsuite/ld-ifunc/ifunc.exp | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/ld/testsuite/ld-ifunc/ifunc.exp b/ld/testsuite/ld-ifunc/ifunc.exp
> index 15dcee0d967..edabcc3f744 100644
> --- a/ld/testsuite/ld-ifunc/ifunc.exp
> +++ b/ld/testsuite/ld-ifunc/ifunc.exp
> @@ -735,9 +735,10 @@ run_ld_link_exec_tests [list \
>   # in the executable (which is relocated last by ld.so).
>   if { [isnative]
>        && !([istarget "powerpc-*-*"]
> -           || [istarget "aarch64*-*-*"]
> -           || [istarget "sparc*-*-*"]
> -           || [istarget "riscv*-*-*"]) } {
> +	  || [istarget "aarch64*-*-*"]
> +	  || [istarget "arm*-*-*"]
> +	  || [istarget "sparc*-*-*"]
> +	  || [istarget "riscv*-*-*"]) } {
>   run_ld_link_exec_tests [list \
>       [list \
>   	"Run pr23169a" \
Nick Clifton Jan. 9, 2023, 3 p.m. UTC | #2 
Hi Christophe,

>>     * testsuite/ld-ifunc/ifunc.exp: Skip pr23169 on arm.

Approved - please apply, mainline and 2.40 branch.

Cheers
   Nick
diff mbox series

Patch

diff --git a/ld/testsuite/ld-ifunc/ifunc.exp b/ld/testsuite/ld-ifunc/ifunc.exp
index 15dcee0d967..edabcc3f744 100644
--- a/ld/testsuite/ld-ifunc/ifunc.exp
+++ b/ld/testsuite/ld-ifunc/ifunc.exp
@@ -735,9 +735,10 @@  run_ld_link_exec_tests [list \
 # in the executable (which is relocated last by ld.so).
 if { [isnative]
      && !([istarget "powerpc-*-*"]
-           || [istarget "aarch64*-*-*"]
-           || [istarget "sparc*-*-*"]
-           || [istarget "riscv*-*-*"]) } {
+	  || [istarget "aarch64*-*-*"]
+	  || [istarget "arm*-*-*"]
+	  || [istarget "sparc*-*-*"]
+	  || [istarget "riscv*-*-*"]) } {
 run_ld_link_exec_tests [list \
     [list \
 	"Run pr23169a" \