[v3,1/2] spi: dt-bindings: amlogic, meson-gx-spicc: Add pinctrl names for SPI signal states
Message ID | 20221004-up-aml-fix-spi-v3-1-89de126fd163@baylibre.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp355896wrs; Wed, 19 Oct 2022 07:23:25 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6FQKGNd7l2+oOBUr9GfD696aPVYZ89h6QKEjpswR/+8Ze2It3bbrg3I9YIgLVHGd5PQdFn X-Received: by 2002:a17:906:9752:b0:78d:d2e1:d745 with SMTP id o18-20020a170906975200b0078dd2e1d745mr6881228ejy.452.1666189405463; Wed, 19 Oct 2022 07:23:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666189405; cv=none; d=google.com; s=arc-20160816; b=VZw6HgjnKb/U+2t1jzG5G4kdseYo5eUHaV4oNDy3y2ccVZTL4UkvTZXD+ndBiMKfwZ gH3gEDdmVNvgDLhvdGd+JcGb9hPjq9NOanaSdxEpjYF8WihJBiikxn5vkyARbB2YKUFu 1uOzUc+MiqwPo+aR1oqT7fUTvnYVGD53RYEm89XBzqX0yVXVEYvyGTAUbEbAKNGD8K30 K/FEjyd6/WeCWEIoA0fFRDffdAXVXiO8K/DeaSh/maJcNKkk0bisFbaBPN5PoL+ycYr8 2xjWGqX7GvXTn9J0oiCEKLKmZKTJkfH7n3m8s+jBVArSzex1yljv2DQp2ntQl6FSTnOE wvww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=xtbDoRjweNPW4Ln3XA0uH8TZxjs8M3GoYCD7q6OX0gg=; b=l1JvNbdOgAHvV3QXAGpHv2DpyqltWpgC9TecSPaYeVbWH8WT62y2IpSafwNSowA60W 36zwTOALxPhK63JxETYew1YXti/mH33X3s69Tg1kUxsTMCKjNHr73kNCD8L2H+5kancI u7c+z8ax7q+67HTABFZO7AZnUDOeO6JuOjtO0FI+Hmz69g1U7wvJO2bXBq2WGNZWu5wH KNLHjJ3WGpCXQ+cZAP5yF2qwUrsqya5nJBJIT4fJ1z/XzMbimox3nUCWfpP1iU7ADdq8 tVqJbGcVJ9HZtxTEs8nnRLo+/Y4aPVycyYkxX5cECbc7PVu9xqW9M7aFGEYKTBMkLO+1 nVGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=pFzXbv7i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l18-20020a50c112000000b00459b3e9983esi13862905edf.113.2022.10.19.07.22.59; Wed, 19 Oct 2022 07:23:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=pFzXbv7i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230074AbiJSOVa (ORCPT <rfc822;samuel.l.nystrom@gmail.com> + 99 others); Wed, 19 Oct 2022 10:21:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232791AbiJSOVK (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 19 Oct 2022 10:21:10 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E348A4C61F for <linux-kernel@vger.kernel.org>; Wed, 19 Oct 2022 07:04:40 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id b4so29257079wrs.1 for <linux-kernel@vger.kernel.org>; Wed, 19 Oct 2022 07:04:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xtbDoRjweNPW4Ln3XA0uH8TZxjs8M3GoYCD7q6OX0gg=; b=pFzXbv7iB5TKy65HTPwKNi8Oya6dNVjlMeKCEG7UrRmcI/W8WpO0ouDDkOdT8BW7Fg HKwGZRZTy5zd2embkHjvTncf7YFv2OzUHfzw7wz6O92GFHaPyWhWyhRwMZ6BBGuZjHD6 1t1VV8ZvdTPHDfcObLjZauweQL/2aig1HZ/KpSUYeMjb/8ZKdJ1Wnm1mq9/umctrrj0X dDEfpAUSB6IOT6lVgCuzpHTKdaszY6zoM0LHGXPMeVLboMNGe6I2d2vaBEBSYnSO1fXq V6D3K/kq57dW1QsaXmiozYGmZWeeNi57wPKnd25DgeDG8KVBRz8+ZPzwD8XiKh2eWxxs blXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xtbDoRjweNPW4Ln3XA0uH8TZxjs8M3GoYCD7q6OX0gg=; b=FnSZdqDYeXMyQOcqj9/hqfkL2LHPtyfN3wYFSXn2aF+MeDICrmuaKOkJz5Oof2rGov +eT6tIbSRQr9g4TWN/F2Kqxi8QaCKLoeMRiF27YM9NnOEF+HAy+LSKljeAin+bJABvSk Mz8XI9oVTmH2iyYiMld/bBlciuKjPCI3ZJWzFRe4dhijgBNfeEIcA65wDdQN36/tGfMU m1P5jbojNm7o6oEOQh/cjeERa7Gz2mShQso5fhd9I5ouIv77eVM8Ihn0ozGy3vamP6w2 XKaUtgrqXoXITlkMZuuBTHfK/RzkAjo/e/LSkSzKcYSppas405Rezy0ICWqHpP2okK4l Nf+w== X-Gm-Message-State: ACrzQf09Dn1iicDnBYLwHTWVCLvTK1/oFdeiMAbqerLHbNi0/Yw+N8Wz obwNbBEpsf6B8gLvsWM5uL2ElA== X-Received: by 2002:adf:f001:0:b0:22e:4f85:3abc with SMTP id j1-20020adff001000000b0022e4f853abcmr4942257wro.107.1666188198769; Wed, 19 Oct 2022 07:03:18 -0700 (PDT) Received: from [127.0.1.1] (rtr.23.90.200.126.unyc.it. [23.90.200.126]) by smtp.googlemail.com with ESMTPSA id o5-20020a5d62c5000000b00228cbac7a25sm13998628wrv.64.2022.10.19.07.03.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 07:03:18 -0700 (PDT) From: Amjad Ouled-Ameur <aouledameur@baylibre.com> Date: Wed, 19 Oct 2022 16:01:03 +0200 Subject: [PATCH v3 1/2] spi: dt-bindings: amlogic, meson-gx-spicc: Add pinctrl names for SPI signal states MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20221004-up-aml-fix-spi-v3-1-89de126fd163@baylibre.com> References: <20221004-up-aml-fix-spi-v3-0-89de126fd163@baylibre.com> In-Reply-To: <20221004-up-aml-fix-spi-v3-0-89de126fd163@baylibre.com> To: Mark Brown <broonie@kernel.org>, Neil Armstrong <neil.armstrong@linaro.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Jerome Brunet <jbrunet@baylibre.com>, Martin Blumenstingl <martin.blumenstingl@googlemail.com>, Kevin Hilman <khilman@baylibre.com>, Rob Herring <robh+dt@kernel.org> Cc: Da Xue <da@libre.computer>, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, Neil Armstrong <neil.armstrong@linaro.org>, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Amjad Ouled-Ameur <aouledameur@baylibre.com> X-Mailer: b4 0.10.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1666188196; l=2316; i=aouledameur@baylibre.com; s=20220920; h=from:subject:message-id; bh=GT6aksNJPuRsH4QN0MrP1Ih2mkD83njM/kpnUgJ63XA=; b=ixcAkOk+adBdqxmgoxXlgXIVeDQnfg8RbvllBQ1SFspcrcB6O+ZI0+0K4uwlL2TcFbxZu3FcKeOF H7ly++vKDGHx+MCSN/UhYp09gxpJlU9dBFr2Z+0tt8yyV6TycVaP X-Developer-Key: i=aouledameur@baylibre.com; a=ed25519; pk=HgYWawSL4qLGPx+RzJ+Cuu+V8Pi/KQnDDm1wjWPMOFE= X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747126222008736647?= X-GMAIL-MSGID: =?utf-8?q?1747126222008736647?= |
Series |
spi: amlogic: meson-spicc: Use pinctrl to drive CLK line when idle
|
|
Commit Message
Amjad Ouled-Ameur
Oct. 19, 2022, 2:01 p.m. UTC
SPI pins of the SPICC Controller in Meson-GX needs to be controlled by pin biais when idle. Therefore define three pinctrl names: - default: SPI pins are controlled by spi function. - idle-high: SCLK pin is pulled-up, but MOSI/MISO are still controlled by spi function. - idle-low: SCLK pin is pulled-down, but MOSI/MISO are still controlled by spi function. Reported-by: Da Xue <da@libre.computer> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com> --- .../bindings/spi/amlogic,meson-gx-spicc.yaml | 67 ++++++++++++++-------- 1 file changed, 42 insertions(+), 25 deletions(-)
Comments
On 19/10/2022 10:01, Amjad Ouled-Ameur wrote: > SPI pins of the SPICC Controller in Meson-GX needs to be controlled by > pin biais when idle. Therefore define three pinctrl names: > - default: SPI pins are controlled by spi function. > - idle-high: SCLK pin is pulled-up, but MOSI/MISO are still controlled > by spi function. > - idle-low: SCLK pin is pulled-down, but MOSI/MISO are still controlled > by spi function. > > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - amlogic,meson-gx-spicc > + > + then: > + properties: > + pinctrl-names: > + minItems: 1 > + items: > + - const: default > + - const: idle-high > + - const: idle-low You should also define in such case pinctrl-0 and others. Best regards, Krzysztof
On 19/10/2022 16:29, Krzysztof Kozlowski wrote: > On 19/10/2022 10:01, Amjad Ouled-Ameur wrote: >> SPI pins of the SPICC Controller in Meson-GX needs to be controlled by >> pin biais when idle. Therefore define three pinctrl names: >> - default: SPI pins are controlled by spi function. >> - idle-high: SCLK pin is pulled-up, but MOSI/MISO are still controlled >> by spi function. >> - idle-low: SCLK pin is pulled-down, but MOSI/MISO are still controlled >> by spi function. >> > > >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - amlogic,meson-gx-spicc >> + >> + then: >> + properties: >> + pinctrl-names: >> + minItems: 1 >> + items: >> + - const: default >> + - const: idle-high >> + - const: idle-low > > You should also define in such case pinctrl-0 and others. Ok I thought it would be covered by the pinctrl-consumer.yaml but yeah we should allow pinctrl-1 and pinctrl-2 here aswell by adding: pinctrl-1: true pinctrl-2: true > > Best regards, > Krzysztof > Neil
On Wed, 19 Oct 2022 16:01:03 +0200, Amjad Ouled-Ameur wrote: > SPI pins of the SPICC Controller in Meson-GX needs to be controlled by > pin biais when idle. Therefore define three pinctrl names: > - default: SPI pins are controlled by spi function. > - idle-high: SCLK pin is pulled-up, but MOSI/MISO are still controlled > by spi function. > - idle-low: SCLK pin is pulled-down, but MOSI/MISO are still controlled > by spi function. > > Reported-by: Da Xue <da@libre.computer> > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com> > --- > .../bindings/spi/amlogic,meson-gx-spicc.yaml | 67 ++++++++++++++-------- > 1 file changed, 42 insertions(+), 25 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml:46:1: [error] duplication of key "allOf" in mapping (key-duplicates) dtschema/dtc warnings/errors: ./Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml:46:1: found duplicate key "allOf" with value "[]" (original value: "[]") /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml: ignoring, error parsing file make[1]: *** Deleting file 'Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.example.dts' Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml:46:1: found duplicate key "allOf" with value "[]" (original value: "[]") make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1492: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
>>> + properties: >>> + pinctrl-names: >>> + minItems: 1 >>> + items: >>> + - const: default >>> + - const: idle-high >>> + - const: idle-low >> >> You should also define in such case pinctrl-0 and others. > > Ok I thought it would be covered by the pinctrl-consumer.yaml > but yeah we should allow pinctrl-1 and pinctrl-2 here aswell by adding: > > pinctrl-1: true > pinctrl-2: true > > Yes. Best regards, Krzysztof
Hi On 10/20/22 14:49, Krzysztof Kozlowski wrote: >>>> + properties: >>>> + pinctrl-names: >>>> + minItems: 1 >>>> + items: >>>> + - const: default >>>> + - const: idle-high >>>> + - const: idle-low >>> You should also define in such case pinctrl-0 and others. >> Ok I thought it would be covered by the pinctrl-consumer.yaml >> but yeah we should allow pinctrl-1 and pinctrl-2 here aswell by adding: >> >> pinctrl-1: true >> pinctrl-2: true >> >> In such case, should I define pinctrl- as part of the if statement, as shown below, or before allOf ? [...] - if: properties: compatible: contains: enum: - amlogic,meson-gx-spicc then: properties: pinctrl-0: true pinctrl-1: true pinctrl-2: true pinctrl-names: minItems: 1 items: - const: default - const: idle-high - const: idle-low [...] Regards Amjad > Yes. > > Best regards, > Krzysztof >
On 21/10/2022 08:54, Amjad Ouled-Ameur wrote: > Hi > > On 10/20/22 14:49, Krzysztof Kozlowski wrote: >>>>> + properties: >>>>> + pinctrl-names: >>>>> + minItems: 1 >>>>> + items: >>>>> + - const: default >>>>> + - const: idle-high >>>>> + - const: idle-low >>>> You should also define in such case pinctrl-0 and others. >>> Ok I thought it would be covered by the pinctrl-consumer.yaml >>> but yeah we should allow pinctrl-1 and pinctrl-2 here aswell by adding: >>> >>> pinctrl-1: true >>> pinctrl-2: true >>> >>> > In such case, should I define pinctrl- as part of the if statement, as shown below, > > or before allOf ? The same as pinctrl-names, so part of allOf. > > [...] > > - if: > properties: > compatible: > contains: > enum: > - amlogic,meson-gx-spicc > > then: > properties: > pinctrl-0: true > pinctrl-1: true > pinctrl-2: true > > pinctrl-names: > minItems: 1 > items: > - const: default > - const: idle-high > - const: idle-low Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml b/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml index 0c10f7678178..3e47fe7760a8 100644 --- a/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml +++ b/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml @@ -43,31 +43,48 @@ properties: minItems: 1 maxItems: 2 -if: - properties: - compatible: - contains: - enum: - - amlogic,meson-g12a-spicc - -then: - properties: - clocks: - minItems: 2 - - clock-names: - items: - - const: core - - const: pclk - -else: - properties: - clocks: - maxItems: 1 - - clock-names: - items: - - const: core +allOf: + - if: + properties: + compatible: + contains: + enum: + - amlogic,meson-g12a-spicc + + then: + properties: + clocks: + minItems: 2 + + clock-names: + items: + - const: core + - const: pclk + + else: + properties: + clocks: + maxItems: 1 + + clock-names: + items: + - const: core + + - if: + properties: + compatible: + contains: + enum: + - amlogic,meson-gx-spicc + + then: + properties: + pinctrl-names: + minItems: 1 + items: + - const: default + - const: idle-high + - const: idle-low required: - compatible