diff mbox series

dmaengine: stm32-mdma: memset stm32_mdma_chan_config struct before using it

Message ID 20221017131413.202567-1-amelie.delaunay@foss.st.com
State New
Headers
Series dmaengine: stm32-mdma: memset stm32_mdma_chan_config struct before using it |

Commit Message

Amelie Delaunay Oct. 17, 2022, 1:14 p.m. UTC 
  New bool m2m_hw has been added at the end of stm32_mdma_chan_config struct
to support the STM32 DMA MDMA chaining.

m2m_hw is set true in stm32_mdma_slave_config() if peripheral_size is set,
but m2m_hw is never initialized false.

To ensure this case, and any further new update of the structure, memset it
to 0 before using it.

Fixes: 696874322771 ("dmaengine: stm32-mdma: add support to be triggered by STM32 DMA")
Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
---
 drivers/dma/stm32-mdma.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Vinod Koul Oct. 19, 2022, 1:31 p.m. UTC | #1 
On 17-10-22, 15:14, Amelie Delaunay wrote:
> New bool m2m_hw has been added at the end of stm32_mdma_chan_config struct
> to support the STM32 DMA MDMA chaining.
> 
> m2m_hw is set true in stm32_mdma_slave_config() if peripheral_size is set,
> but m2m_hw is never initialized false.
> 
> To ensure this case, and any further new update of the structure, memset it
> to 0 before using it.

Applied, thanks
diff mbox series

Patch

diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c
index e28acbcb53f4..b9d4c843635f 100644
--- a/drivers/dma/stm32-mdma.c
+++ b/drivers/dma/stm32-mdma.c
@@ -1539,6 +1539,7 @@  static struct dma_chan *stm32_mdma_of_xlate(struct of_phandle_args *dma_spec,
 		return NULL;
 	}
 
+	memset(&config, 0, sizeof(config));
 	config.request = dma_spec->args[0];
 	config.priority_level = dma_spec->args[1];
 	config.transfer_config = dma_spec->args[2];