[V4,1/3] dt-bindings: arm: ti: Add binding for AM68 SK

Message ID 20230105151740.29436-2-sinthu.raja@ti.com
State New
Headers
Series AM68 SK: Add initial support |

Commit Message

Sinthu Raja Jan. 5, 2023, 3:17 p.m. UTC
  From: Sinthu Raja <sinthu.raja@ti.com>

AM68 Starter Kit is a low cost, small form factor board designed for
TI's AM68 SoC which is optimized to provide best in class performance
for industrial applications and add binding for the same.

Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
---
 Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Krzysztof Kozlowski Jan. 6, 2023, 12:49 p.m. UTC | #1
On 05/01/2023 16:17, Sinthu Raja wrote:
> From: Sinthu Raja <sinthu.raja@ti.com>
> 
> AM68 Starter Kit is a low cost, small form factor board designed for
> TI's AM68 SoC which is optimized to provide best in class performance
> for industrial applications and add binding for the same.
> 
> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>

What happened here?

Best regards,
Krzysztof
  
Sinthu Raja Jan. 6, 2023, 12:53 p.m. UTC | #2
On Fri, Jan 6, 2023 at 6:19 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 05/01/2023 16:17, Sinthu Raja wrote:
> > From: Sinthu Raja <sinthu.raja@ti.com>
> >
> > AM68 Starter Kit is a low cost, small form factor board designed for
> > TI's AM68 SoC which is optimized to provide best in class performance
> > for industrial applications and add binding for the same.
> >
> > Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
>
> What happened here?,
Krzysztof
Missed the merge window, so rebased to 6.2rc1 and reposted again.
>
> Best regards,
> Krzysztof
>



--
With Regards
Sinthu Raja
  
Krzysztof Kozlowski Jan. 6, 2023, 12:58 p.m. UTC | #3
On 06/01/2023 13:53, Sinthu Raja M wrote:
> On Fri, Jan 6, 2023 at 6:19 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 05/01/2023 16:17, Sinthu Raja wrote:
>>> From: Sinthu Raja <sinthu.raja@ti.com>
>>>
>>> AM68 Starter Kit is a low cost, small form factor board designed for
>>> TI's AM68 SoC which is optimized to provide best in class performance
>>> for industrial applications and add binding for the same.
>>>
>>> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
>>
>> What happened here?,
> Krzysztof
> Missed the merge window, so rebased to 6.2rc1 and reposted again.

And what was here in v3?

Best regards,
Krzysztof
  
Sinthu Raja Jan. 6, 2023, 1:17 p.m. UTC | #4
On Fri, Jan 6, 2023 at 6:28 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 06/01/2023 13:53, Sinthu Raja M wrote:
> > On Fri, Jan 6, 2023 at 6:19 PM Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> On 05/01/2023 16:17, Sinthu Raja wrote:
> >>> From: Sinthu Raja <sinthu.raja@ti.com>
> >>>
> >>> AM68 Starter Kit is a low cost, small form factor board designed for
> >>> TI's AM68 SoC which is optimized to provide best in class performance
> >>> for industrial applications and add binding for the same.
> >>>
> >>> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> >>
> >> What happened here?,
> > Krzysztof
> > Missed the merge window, so rebased to 6.2rc1 and reposted again.
>
> And what was here in v3?
Krzysztof,
Are you asking about this tag?
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

As I was rebasing I thought of not adding. Do I need to respin the
patch series with V5 again with the tag?
>
> Best regards,
> Krzysztof
>
  
Nishanth Menon Jan. 6, 2023, 1:37 p.m. UTC | #5
On 13:58-20230106, Krzysztof Kozlowski wrote:
> On 06/01/2023 13:53, Sinthu Raja M wrote:
> > On Fri, Jan 6, 2023 at 6:19 PM Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> On 05/01/2023 16:17, Sinthu Raja wrote:
> >>> From: Sinthu Raja <sinthu.raja@ti.com>
> >>>
> >>> AM68 Starter Kit is a low cost, small form factor board designed for
> >>> TI's AM68 SoC which is optimized to provide best in class performance
> >>> for industrial applications and add binding for the same.
> >>>
> >>> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> >>
> >> What happened here?,
> > Krzysztof
> > Missed the merge window, so rebased to 6.2rc1 and reposted again.
> 
> And what was here in v3?

Sinthu,  If I am not mistaken (Krzysztof can correct me), what is meant here
are two things:

a) if no modification to the patch was made and just a repost is being done,
   just indicate that in $subject. Examples: [1]

b) Ensure that there is a changelog. I understand that the
  cover letter[2] has indicated this, but keep in mind that reviewers use
  filters, and cover-letter does'nt fall into their filter. I usually
  capture the change information per patch as well. If you are a b4 fan,
  see Konstantin's tips with B4 in [3][4]

[1] https://lore.kernel.org/linux-arm-kernel/?q=RESEND
[2] https://lore.kernel.org/all/20230105151740.29436-1-sinthu.raja@ti.com/
[3] https://people.kernel.org/monsieuricon/sending-a-kernel-patch-with-b4-part-1
[4] https://www.youtube.com/watch?v=-Vld9aoFPwU
  
Nishanth Menon Jan. 6, 2023, 1:41 p.m. UTC | #6
On 18:47-20230106, Sinthu Raja M wrote:
> On Fri, Jan 6, 2023 at 6:28 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> >
> > On 06/01/2023 13:53, Sinthu Raja M wrote:
> > > On Fri, Jan 6, 2023 at 6:19 PM Krzysztof Kozlowski
> > > <krzysztof.kozlowski@linaro.org> wrote:
> > >>
> > >> On 05/01/2023 16:17, Sinthu Raja wrote:
> > >>> From: Sinthu Raja <sinthu.raja@ti.com>
> > >>>
> > >>> AM68 Starter Kit is a low cost, small form factor board designed for
> > >>> TI's AM68 SoC which is optimized to provide best in class performance
> > >>> for industrial applications and add binding for the same.
> > >>>
> > >>> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> > >>
> > >> What happened here?,
> > > Krzysztof
> > > Missed the merge window, so rebased to 6.2rc1 and reposted again.
> >
> > And what was here in v3?
> Krzysztof,
> Are you asking about this tag?
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

When you are re-posting OR updating the series, it is the patch sender's
responsibility to pick up the acks. If you are explicitly not picking up
reviews and acks, you should state in the diffstat why.

Also see the b4 tricks[1]

[1] https://www.youtube.com/watch?v=-Vld9aoFPwU
  
Sinthu Raja Jan. 6, 2023, 2:03 p.m. UTC | #7
On Fri, Jan 6, 2023 at 7:11 PM Nishanth Menon <nm@ti.com> wrote:
>
> On 18:47-20230106, Sinthu Raja M wrote:
> > On Fri, Jan 6, 2023 at 6:28 PM Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> > >
> > > On 06/01/2023 13:53, Sinthu Raja M wrote:
> > > > On Fri, Jan 6, 2023 at 6:19 PM Krzysztof Kozlowski
> > > > <krzysztof.kozlowski@linaro.org> wrote:
> > > >>
> > > >> On 05/01/2023 16:17, Sinthu Raja wrote:
> > > >>> From: Sinthu Raja <sinthu.raja@ti.com>
> > > >>>
> > > >>> AM68 Starter Kit is a low cost, small form factor board designed for
> > > >>> TI's AM68 SoC which is optimized to provide best in class performance
> > > >>> for industrial applications and add binding for the same.
> > > >>>
> > > >>> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> > > >>
> > > >> What happened here?,
> > > > Krzysztof
> > > > Missed the merge window, so rebased to 6.2rc1 and reposted again.
> > >
> > > And what was here in v3?
> > Krzysztof,
> > Are you asking about this tag?
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> When you are re-posting OR updating the series, it is the patch sender's
> responsibility to pick up the acks. If you are explicitly not picking up
> reviews and acks, you should state in the diffstat why.
>
> Also see the b4 tricks[1]
>
> [1] https://www.youtube.com/watch?v=-Vld9aoFPwU
Nishanth,
Thanks for the information.

Krzysztof,
Sorry for the errors caused by my oversight. Kindly excuse me. Would
you want me to resend the V3 series with the correct subject?
>
> --
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
  
Sinthu Raja Jan. 10, 2023, 7:58 a.m. UTC | #8
On Fri, Jan 6, 2023 at 7:33 PM Sinthu Raja M
<sinthu.raja@mistralsolutions.com> wrote:
>
> On Fri, Jan 6, 2023 at 7:11 PM Nishanth Menon <nm@ti.com> wrote:
> >
> > On 18:47-20230106, Sinthu Raja M wrote:
> > > On Fri, Jan 6, 2023 at 6:28 PM Krzysztof Kozlowski
> > > <krzysztof.kozlowski@linaro.org> wrote:
> > > >
> > > > On 06/01/2023 13:53, Sinthu Raja M wrote:
> > > > > On Fri, Jan 6, 2023 at 6:19 PM Krzysztof Kozlowski
> > > > > <krzysztof.kozlowski@linaro.org> wrote:
> > > > >>
> > > > >> On 05/01/2023 16:17, Sinthu Raja wrote:
> > > > >>> From: Sinthu Raja <sinthu.raja@ti.com>
> > > > >>>
> > > > >>> AM68 Starter Kit is a low cost, small form factor board designed for
> > > > >>> TI's AM68 SoC which is optimized to provide best in class performance
> > > > >>> for industrial applications and add binding for the same.
> > > > >>>
> > > > >>> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> > > > >>
> > > > >> What happened here?,
> > > > > Krzysztof
> > > > > Missed the merge window, so rebased to 6.2rc1 and reposted again.
> > > >
> > > > And what was here in v3?
> > > Krzysztof,
> > > Are you asking about this tag?
> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >
> > When you are re-posting OR updating the series, it is the patch sender's
> > responsibility to pick up the acks. If you are explicitly not picking up
> > reviews and acks, you should state in the diffstat why.
> >
> > Also see the b4 tricks[1]
> >
> > [1] https://www.youtube.com/watch?v=-Vld9aoFPwU
> Nishanth,
> Thanks for the information.
>
> Krzysztof,
> Sorry for the errors caused by my oversight. Kindly excuse me. Would
> you want me to resend the V3 series with the correct subject?
> >
Hi Krzysztof,
Could you please let me know if further action is required from my end?
> > --
> > Regards,
> > Nishanth Menon
> > Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
>
>
>
> --
> With Regards
> Sinthu Raja
  
Krzysztof Kozlowski Jan. 10, 2023, 8:30 a.m. UTC | #9
On 10/01/2023 08:58, Sinthu Raja M wrote:
> On Fri, Jan 6, 2023 at 7:33 PM Sinthu Raja M
> <sinthu.raja@mistralsolutions.com> wrote:
>>
>> On Fri, Jan 6, 2023 at 7:11 PM Nishanth Menon <nm@ti.com> wrote:
>>>
>>> On 18:47-20230106, Sinthu Raja M wrote:
>>>> On Fri, Jan 6, 2023 at 6:28 PM Krzysztof Kozlowski
>>>> <krzysztof.kozlowski@linaro.org> wrote:
>>>>>
>>>>> On 06/01/2023 13:53, Sinthu Raja M wrote:
>>>>>> On Fri, Jan 6, 2023 at 6:19 PM Krzysztof Kozlowski
>>>>>> <krzysztof.kozlowski@linaro.org> wrote:
>>>>>>>
>>>>>>> On 05/01/2023 16:17, Sinthu Raja wrote:
>>>>>>>> From: Sinthu Raja <sinthu.raja@ti.com>
>>>>>>>>
>>>>>>>> AM68 Starter Kit is a low cost, small form factor board designed for
>>>>>>>> TI's AM68 SoC which is optimized to provide best in class performance
>>>>>>>> for industrial applications and add binding for the same.
>>>>>>>>
>>>>>>>> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
>>>>>>>
>>>>>>> What happened here?,
>>>>>> Krzysztof
>>>>>> Missed the merge window, so rebased to 6.2rc1 and reposted again.
>>>>>
>>>>> And what was here in v3?
>>>> Krzysztof,
>>>> Are you asking about this tag?
>>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>
>>> When you are re-posting OR updating the series, it is the patch sender's
>>> responsibility to pick up the acks. If you are explicitly not picking up
>>> reviews and acks, you should state in the diffstat why.
>>>
>>> Also see the b4 tricks[1]
>>>
>>> [1] https://www.youtube.com/watch?v=-Vld9aoFPwU
>> Nishanth,
>> Thanks for the information.
>>
>> Krzysztof,
>> Sorry for the errors caused by my oversight. Kindly excuse me. Would
>> you want me to resend the V3 series with the correct subject?
>>>
> Hi Krzysztof,
> Could you please let me know if further action is required from my end?

Please repost with all tags from all people and properly rebased. This
is weird that once you have in patch a tag, in next version it's gone.
it suggest you sent wrong patch, not previous but one older.

Best regards,
Krzysztof
  

Patch

diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
index 203faab80142..acbc25108533 100644
--- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
+++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
@@ -69,6 +69,7 @@  properties:
       - description: K3 J721s2 SoC
         items:
           - enum:
+              - ti,am68-sk
               - ti,j721s2-evm
           - const: ti,j721s2