| Message ID | 20230105170437.4437-1-sensor1010@163.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp413205wrt;
Thu, 5 Jan 2023 09:30:12 -0800 (PST)
X-Google-Smtp-Source:
AMrXdXulv9V9UliqGQMIrlo9MstsqBS1ISRhr1W+6dYokOwUHU1pPltpEk8tjTGXxnlGgEGNW9UD
X-Received: by 2002:a05:6402:754:b0:485:9d0f:6193 with SMTP id
p20-20020a056402075400b004859d0f6193mr31053671edy.38.1672939812315;
Thu, 05 Jan 2023 09:30:12 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1672939812; cv=none;
d=google.com; s=arc-20160816;
b=H2b1uGQr8H6RIqP5VxfhjY6khG2Gywpmf8lRYQz5Z4cRdoom6/6XuRrKPmSeJRAXhe
XCyHSi+ZmxC52x04m69TKchgURnQKaNSQT/OPU9S+6IUq9/PLr2bXT1bd0BD+5VGkier
WWTlCCo+uNKynUNZaKIVCN4+wSqM3Dd+hHU/pXooCgOMK/D/ChErCvEKm1RIm7pS0mwv
ojkNdIwx8zN+xIe71XQmS+10kCMwLnqd3s309/agC4e8a7+wKn1HocHyi6gNjsbelckh
8IJkW5jF/txHP7tYIrTjkvgbsGYvLzBpYUoYZomgEJuMpQm+Hlmh1Uxj79WeFlyLlG/5
S1rQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=dlNwiQpR74Fn2RarO3rtu77WVKud4F1n99IzYmKFdKA=;
b=iKgw269tRO1voVZ7tZXTEAddOCX9Z3XpYnJgkjoAoPIkwTBMizmR2uPCObErttQsP1
gsM33Ek3wcRNz9GC7/w5y6347uLBGnjHIOkJjDMdnV1jzn5uK61IPF5An0In1M60+YJL
ca/TO0mh8l/7AIubsbeaQFi9KHlK8VfSKAyFCLVgsAX08jLjRouAobgZhgMkKI3peLZd
c0gkHTdxYhJMlzIlP77jhU9NuGXwgZTeVC7k4J4OJQzCkWHRwZPOnfalJS2pV009axgf
Mbh38QsbSDNcNCvSjK5MLPika8BPLQzEpOrMMSGjKHNE4cQm5gw9lN26q5c+1GFV2CTp
Ve6g==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@163.com header.s=s110527 header.b=o5btCxmc;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
ev27-20020a056402541b00b00495bbc3fc95si52496edb.80.2023.01.05.09.29.48;
Thu, 05 Jan 2023 09:30:12 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@163.com header.s=s110527 header.b=o5btCxmc;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S235316AbjAER1Y (ORCPT <rfc822;tmhikaru@gmail.com> + 99 others);
Thu, 5 Jan 2023 12:27:24 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40974 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S235304AbjAER0y (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 5 Jan 2023 12:26:54 -0500
Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.216])
by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1443B59FBA;
Thu, 5 Jan 2023 09:22:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;
s=s110527; h=From:Subject:Date:Message-Id:MIME-Version:
Content-Type; bh=dlNwiQpR74Fn2RarO3rtu77WVKud4F1n99IzYmKFdKA=;
b=o5btCxmc4B/U2EIk6H+cScBBlpe5JEA1m4+Sd+DPEaJ8Ve40R51KaYcWE0XaKZ
YnXVX/ZVc6ZDzuyODMxfGfswUaEBFdXgMCNsksoPrSNfvCTnCFWg0iGvuLAA0WDA
tcjqvHOUnu8sezC1qtRPWnf/NoyoJNG7lsvKYwuTY9kSE=
Received: from localhost.localdomain (unknown [36.4.211.162])
by zwqz-smtp-mta-g4-2 (Coremail) with SMTP id
_____wD3JeYnA7djV+t6AA--.2998S4;
Fri, 06 Jan 2023 01:05:12 +0800 (CST)
From: =?utf-8?b?5p2O5ZOy?= <sensor1010@163.com>
To: gregkh@linuxfoundation.org, jirislaby@kernel.org,
ilpo.jarvinen@linux.intel.com
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
=?utf-8?b?5p2O5ZOy?= <sensor1010@163.com>
Subject: [PATCH v6] serial: linflexuart: Remove redundant uart type assignment
Date: Thu, 5 Jan 2023 09:04:37 -0800
Message-Id: <20230105170437.4437-1-sensor1010@163.com>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-CM-TRANSID: _____wD3JeYnA7djV+t6AA--.2998S4
X-Coremail-Antispam: 1Uf129KBjvdXoWrtw4rZrWxur15KFy8KryxGrg_yoWkKFg_CF
nrA343Wr1kArW3Kr1xJFyakr9agrWFvFn5tF10vF9agws8Aw4fJryfKrW3ZwnxXw48ZrWU
Wa13GrnFvrs8XjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT
9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xREzuWtUUUUU==
X-Originating-IP: [36.4.211.162]
X-CM-SenderInfo: 5vhq20jurqiii6rwjhhfrp/1tbiSA-tq1+Fgod7bAAAsJ
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,
FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1754204536196192480?=
X-GMAIL-MSGID: =?utf-8?q?1754204536196192480?=
|
| Series |
[v6] serial: linflexuart: Remove redundant uart type assignment
|
|
Commit Message
Lizhe
Jan. 5, 2023, 5:04 p.m. UTC
in linflex_config_port() the member variable type will be
assigned again. see linflex_connfig_port()
Signed-off-by: 李哲 <sensor1010@163.com>
V4 -> V5: Link: https://lore.kernel.org/all/ddcf396b-7b91-00f3-8c16-7de5dc891aef@kernel.org/
V3 -> V4: Link: https://lore.kernel.org/all/2f726128-29c-b7dd-ad8-f8b536fbe5f@linux.intel.com/
V2 -> V3: Link: https://lore.kernel.org/all/8f433e5-fb46-d3b8-431b-4bddcc938f6b@linux.intel.com/
V1 -> V2: Link: https://lore.kernel.org/all/1c33a2af-cd0d-cdde-5bc7-49b418665784@kernel.org/
---
drivers/tty/serial/fsl_linflexuart.c | 1 -
1 file changed, 1 deletion(-)
Comments
On 05. 01. 23, 18:04, 李哲 wrote: > in linflex_config_port() the member variable type will be > assigned again. see linflex_connfig_port() I wrote to v5: Please use capitals when you start a sentence. And periods at the ends of them. > Signed-off-by: 李哲 <sensor1010@163.com> > V4 -> V5: Link: https://lore.kernel.org/all/ddcf396b-7b91-00f3-8c16-7de5dc891aef@kernel.org/ > V3 -> V4: Link: https://lore.kernel.org/all/2f726128-29c-b7dd-ad8-f8b536fbe5f@linux.intel.com/ > V2 -> V3: Link: https://lore.kernel.org/all/8f433e5-fb46-d3b8-431b-4bddcc938f6b@linux.intel.com/ > V1 -> V2: Link: https://lore.kernel.org/all/1c33a2af-cd0d-cdde-5bc7-49b418665784@kernel.org/ This is not the proper way. PLease see: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format > --- > drivers/tty/serial/fsl_linflexuart.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c > index 6fc21b6684e6..34400cc6ac7f 100644 > --- a/drivers/tty/serial/fsl_linflexuart.c > +++ b/drivers/tty/serial/fsl_linflexuart.c > @@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev) > return PTR_ERR(sport->membase); > > sport->dev = &pdev->dev; > - sport->type = PORT_LINFLEXUART; > sport->iotype = UPIO_MEM; > sport->irq = platform_get_irq(pdev, 0); > sport->ops = &linflex_pops;
On Thu, Jan 05, 2023 at 09:04:37AM -0800, 李哲 wrote: > in linflex_config_port() the member variable type will be > assigned again. see linflex_connfig_port() > > Signed-off-by: 李哲 <sensor1010@163.com> > V4 -> V5: Link: https://lore.kernel.org/all/ddcf396b-7b91-00f3-8c16-7de5dc891aef@kernel.org/ > V3 -> V4: Link: https://lore.kernel.org/all/2f726128-29c-b7dd-ad8-f8b536fbe5f@linux.intel.com/ > V2 -> V3: Link: https://lore.kernel.org/all/8f433e5-fb46-d3b8-431b-4bddcc938f6b@linux.intel.com/ > V1 -> V2: Link: https://lore.kernel.org/all/1c33a2af-cd0d-cdde-5bc7-49b418665784@kernel.org/ Links are not ok for versioning, sorry, please read the documentation for how to do this properly. greg k-h
On Fri, 5 Jan 2024, lizhe wrote: > HI，all > > How should I wirte these comments ? please help me, > i am not sure how to properly write these comments, > i want to merge this patch into the mainline > > > > > > > At 2023-01-06 15:16:56, "Jiri Slaby" <jirislaby@kernel.org> wrote: > >On 05. 01. 23, 18:04, 李哲 wrote: > >> in linflex_config_port() the member variable type will be > >> assigned again. see linflex_connfig_port() > > > >I wrote to v5: > >Please use capitals when you start a sentence. And periods at the ends > >of them. > >> Signed-off-by: 李哲 <sensor1010@163.com> > > > > > >> V4 -> V5: Link: https://lore.kernel.org/all/ddcf396b-7b91-00f3-8c16-7de5d > c891aef@kernel.org/ > >> V3 -> V4: Link: https://lore.kernel.org/all/2f726128-29c-b7dd-ad8-f8b536f > be5f@linux.intel.com/ > >> V2 -> V3: Link: https://lore.kernel.org/all/8f433e5-fb46-d3b8-431b-4bddcc > 938f6b@linux.intel.com/ > >> V1 -> V2: Link: https://lore.kernel.org/all/1c33a2af-cd0d-cdde-5bc7-49b41 > 8665784@kernel.org/ > > > >This is not the proper way. PLease see: > >https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the- > canonical-patch-format For this you need to spell out the changes you made between versions. E.g., v6: - Used Chinese letters for From and Signed-off-by
diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c index 6fc21b6684e6..34400cc6ac7f 100644 --- a/drivers/tty/serial/fsl_linflexuart.c +++ b/drivers/tty/serial/fsl_linflexuart.c @@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev) return PTR_ERR(sport->membase); sport->dev = &pdev->dev; - sport->type = PORT_LINFLEXUART; sport->iotype = UPIO_MEM; sport->irq = platform_get_irq(pdev, 0); sport->ops = &linflex_pops;