diff mbox series

[V6,22/24] mmc: sdhci-uhs2: add post-mmc_attach_sd hook

Message ID 20221213090047.3805-23-victor.shih@genesyslogic.com.tw
State New
Headers
Series Add support UHS-II for GL9755 |

Commit Message

Victor Shih Dec. 13, 2022, 9 a.m. UTC 
  From: Ben Chuang <ben.chuang@genesyslogic.com.tw>

This "post" hook for mmc_attach_sd(), uhs2_post_attach_sd, will be required
to enable UHS-II support, at least, on GL9755.

Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw>
Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
---
 drivers/mmc/host/sdhci.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Adrian Hunter Jan. 5, 2023, 9:31 p.m. UTC | #1 
On 13/12/22 11:00, Victor Shih wrote:
> From: Ben Chuang <ben.chuang@genesyslogic.com.tw>
> 
> This "post" hook for mmc_attach_sd(), uhs2_post_attach_sd, will be required
> to enable UHS-II support, at least, on GL9755.
> 
> Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
>  drivers/mmc/host/sdhci.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
> index e5f64b38e339..4aac22b58d79 100644
> --- a/drivers/mmc/host/sdhci.h
> +++ b/drivers/mmc/host/sdhci.h
> @@ -728,6 +728,7 @@ struct sdhci_ops {
>  	void    (*dump_vendor_regs)(struct sdhci_host *host);
>  	void	(*dump_uhs2_regs)(struct sdhci_host *host);
>  	void    (*uhs2_pre_detect_init)(struct sdhci_host *host);
> +	void    (*uhs2_post_attach_sd)(struct sdhci_host *host);

This gets called already in "mmc: sdhci-uhs2: add uhs2_control()
to initialise the interface"

Either move that line to this patch or vice versa.

Please check compiling after each patch is applied.

>  };
>  
>  #ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS
Victor Shih Feb. 24, 2023, 10:23 a.m. UTC | #2 
Hi, Adrian

On Fri, Jan 6, 2023 at 5:31 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
>
> On 13/12/22 11:00, Victor Shih wrote:
> > From: Ben Chuang <ben.chuang@genesyslogic.com.tw>
> >
> > This "post" hook for mmc_attach_sd(), uhs2_post_attach_sd, will be required
> > to enable UHS-II support, at least, on GL9755.
> >
> > Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw>
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > ---
> >  drivers/mmc/host/sdhci.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
> > index e5f64b38e339..4aac22b58d79 100644
> > --- a/drivers/mmc/host/sdhci.h
> > +++ b/drivers/mmc/host/sdhci.h
> > @@ -728,6 +728,7 @@ struct sdhci_ops {
> >       void    (*dump_vendor_regs)(struct sdhci_host *host);
> >       void    (*dump_uhs2_regs)(struct sdhci_host *host);
> >       void    (*uhs2_pre_detect_init)(struct sdhci_host *host);
> > +     void    (*uhs2_post_attach_sd)(struct sdhci_host *host);
>
> This gets called already in "mmc: sdhci-uhs2: add uhs2_control()
> to initialise the interface"
>
> Either move that line to this patch or vice versa.
>
> Please check compiling after each patch is applied.
>

I will update it in V7 version.

> >  };
> >
> >  #ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS
>

Thanks, Victor Shih
diff mbox series

Patch

diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index e5f64b38e339..4aac22b58d79 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -728,6 +728,7 @@  struct sdhci_ops {
 	void    (*dump_vendor_regs)(struct sdhci_host *host);
 	void	(*dump_uhs2_regs)(struct sdhci_host *host);
 	void    (*uhs2_pre_detect_init)(struct sdhci_host *host);
+	void    (*uhs2_post_attach_sd)(struct sdhci_host *host);
 };
 
 #ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS