[21/27] mmc: remove tmio_mmc driver

Message ID 20230105134622.254560-22-arnd@kernel.org
State New
Headers
Series ARM: pxa: remove all unused boards&drivers |

Commit Message

Arnd Bergmann Jan. 5, 2023, 1:46 p.m. UTC
  From: Arnd Bergmann <arnd@arndb.de>

With the TMIO MFD support gone, the corresponding MMC host driver can
be removed as well. The remaining tmio_mmc_core module however is still
used by both the Renesas and Socionext host drivers.

Cc: Ian Molton <spyro@f2s.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-mmc@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/mmc/host/Kconfig    |   8 --
 drivers/mmc/host/Makefile   |   1 -
 drivers/mmc/host/tmio_mmc.c | 227 ------------------------------------
 3 files changed, 236 deletions(-)
 delete mode 100644 drivers/mmc/host/tmio_mmc.c
  

Comments

Ulf Hansson Jan. 5, 2023, 3:01 p.m. UTC | #1
On Thu, 5 Jan 2023 at 14:47, Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> With the TMIO MFD support gone, the corresponding MMC host driver can
> be removed as well. The remaining tmio_mmc_core module however is still
> used by both the Renesas and Socionext host drivers.
>
> Cc: Ian Molton <spyro@f2s.com>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Cc: linux-mmc@vger.kernel.org
> Cc: linux-renesas-soc@vger.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I intend to pick this up via my mmc tree, just awaiting an ack from Wolfram.

Kind regards
Uffe

> ---
>  drivers/mmc/host/Kconfig    |   8 --
>  drivers/mmc/host/Makefile   |   1 -
>  drivers/mmc/host/tmio_mmc.c | 227 ------------------------------------
>  3 files changed, 236 deletions(-)
>  delete mode 100644 drivers/mmc/host/tmio_mmc.c
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index f0456ad4b597..e1b88b51cc80 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -655,14 +655,6 @@ config MMC_SDHCI_SPRD
>  config MMC_TMIO_CORE
>         tristate
>
> -config MMC_TMIO
> -       tristate "Toshiba Mobile IO Controller (TMIO) MMC/SD function support"
> -       depends on MFD_TMIO || MFD_ASIC3 || COMPILE_TEST
> -       select MMC_TMIO_CORE
> -       help
> -         This provides support for the SD/MMC cell found in TC6393XB,
> -         T7L66XB and also HTC ASIC3
> -
>  config MMC_SDHI
>         tristate "Renesas SDHI SD/SDIO controller support"
>         depends on SUPERH || ARCH_RENESAS || COMPILE_TEST
> diff --git a/drivers/mmc/host/Makefile b/drivers/mmc/host/Makefile
> index 063d87764966..b498c17cd124 100644
> --- a/drivers/mmc/host/Makefile
> +++ b/drivers/mmc/host/Makefile
> @@ -35,7 +35,6 @@ obj-$(CONFIG_MMC_DAVINCI)       += davinci_mmc.o
>  obj-$(CONFIG_MMC_SPI)          += mmc_spi.o
>  obj-$(CONFIG_MMC_SPI)          += of_mmc_spi.o
>  obj-$(CONFIG_MMC_SDRICOH_CS)   += sdricoh_cs.o
> -obj-$(CONFIG_MMC_TMIO)         += tmio_mmc.o
>  obj-$(CONFIG_MMC_TMIO_CORE)    += tmio_mmc_core.o
>  obj-$(CONFIG_MMC_SDHI)         += renesas_sdhi_core.o
>  obj-$(CONFIG_MMC_SDHI_SYS_DMAC)                += renesas_sdhi_sys_dmac.o
> diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c
> deleted file mode 100644
> index 53a2ad9a24b8..000000000000
> --
> 2.39.0
>
  
Wolfram Sang Jan. 5, 2023, 3:14 p.m. UTC | #2
On Thu, Jan 05, 2023 at 02:46:16PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> With the TMIO MFD support gone, the corresponding MMC host driver can
> be removed as well. The remaining tmio_mmc_core module however is still
> used by both the Renesas and Socionext host drivers.
> 
> Cc: Ian Molton <spyro@f2s.com>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Cc: linux-mmc@vger.kernel.org
> Cc: linux-renesas-soc@vger.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I trust Arnd's research that the driver becomes unused after the PXA
removal. I can add to it that the plain TMIO driver hasn't seen any
functional update in 10 years maybe. Most modifications were tree-wide
cleanups or adjustments because the TMIO core changed. It will be
interesting to see what cleanups can be done once this driver is gone.

Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
  
Arnd Bergmann Jan. 5, 2023, 3:44 p.m. UTC | #3
On Thu, Jan 5, 2023, at 16:01, Ulf Hansson wrote:
> On Thu, 5 Jan 2023 at 14:47, Arnd Bergmann <arnd@kernel.org> wrote:
>>
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> With the TMIO MFD support gone, the corresponding MMC host driver can
>> be removed as well. The remaining tmio_mmc_core module however is still
>> used by both the Renesas and Socionext host drivers.
>>
>> Cc: Ian Molton <spyro@f2s.com>
>> Cc: Ulf Hansson <ulf.hansson@linaro.org>
>> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
>> Cc: linux-mmc@vger.kernel.org
>> Cc: linux-renesas-soc@vger.kernel.org
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> I intend to pick this up via my mmc tree, just awaiting an ack from Wolfram.

Actually I think it would be easier to just take this through
my tree along with the rest of the series, unless you expect
conflicts with other patches.

    Arnd
  
Ulf Hansson Jan. 16, 2023, 10:48 a.m. UTC | #4
On Thu, 5 Jan 2023 at 16:44, Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Thu, Jan 5, 2023, at 16:01, Ulf Hansson wrote:
> > On Thu, 5 Jan 2023 at 14:47, Arnd Bergmann <arnd@kernel.org> wrote:
> >>
> >> From: Arnd Bergmann <arnd@arndb.de>
> >>
> >> With the TMIO MFD support gone, the corresponding MMC host driver can
> >> be removed as well. The remaining tmio_mmc_core module however is still
> >> used by both the Renesas and Socionext host drivers.
> >>
> >> Cc: Ian Molton <spyro@f2s.com>
> >> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> >> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >> Cc: linux-mmc@vger.kernel.org
> >> Cc: linux-renesas-soc@vger.kernel.org
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > I intend to pick this up via my mmc tree, just awaiting an ack from Wolfram.
>
> Actually I think it would be easier to just take this through
> my tree along with the rest of the series, unless you expect
> conflicts with other patches.

If conflicts, those should probably be easy to resolve, so please go
ahead and take your own route.

Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

Kind regards
Uffe
  

Patch

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index f0456ad4b597..e1b88b51cc80 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -655,14 +655,6 @@  config MMC_SDHCI_SPRD
 config MMC_TMIO_CORE
 	tristate
 
-config MMC_TMIO
-	tristate "Toshiba Mobile IO Controller (TMIO) MMC/SD function support"
-	depends on MFD_TMIO || MFD_ASIC3 || COMPILE_TEST
-	select MMC_TMIO_CORE
-	help
-	  This provides support for the SD/MMC cell found in TC6393XB,
-	  T7L66XB and also HTC ASIC3
-
 config MMC_SDHI
 	tristate "Renesas SDHI SD/SDIO controller support"
 	depends on SUPERH || ARCH_RENESAS || COMPILE_TEST
diff --git a/drivers/mmc/host/Makefile b/drivers/mmc/host/Makefile
index 063d87764966..b498c17cd124 100644
--- a/drivers/mmc/host/Makefile
+++ b/drivers/mmc/host/Makefile
@@ -35,7 +35,6 @@  obj-$(CONFIG_MMC_DAVINCI)       += davinci_mmc.o
 obj-$(CONFIG_MMC_SPI)		+= mmc_spi.o
 obj-$(CONFIG_MMC_SPI)		+= of_mmc_spi.o
 obj-$(CONFIG_MMC_SDRICOH_CS)	+= sdricoh_cs.o
-obj-$(CONFIG_MMC_TMIO)		+= tmio_mmc.o
 obj-$(CONFIG_MMC_TMIO_CORE)	+= tmio_mmc_core.o
 obj-$(CONFIG_MMC_SDHI)		+= renesas_sdhi_core.o
 obj-$(CONFIG_MMC_SDHI_SYS_DMAC)		+= renesas_sdhi_sys_dmac.o
diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c
deleted file mode 100644
index 53a2ad9a24b8..000000000000