[1/2] dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel bindings
Message ID | 20230103-topic-sm8550-upstream-vtdr6130-panel-v1-1-9b746b858378@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4645491wrt; Tue, 3 Jan 2023 06:23:36 -0800 (PST) X-Google-Smtp-Source: AMrXdXuOPjmYuq/u9S9zf/0vueDY1jJ+Oux8+5aUMfuj70HqDc260rxMp+Qff2LAzF8sGv5NEhWA X-Received: by 2002:a17:90a:a28:b0:223:f78c:15d with SMTP id o37-20020a17090a0a2800b00223f78c015dmr48452387pjo.41.1672755816015; Tue, 03 Jan 2023 06:23:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672755815; cv=none; d=google.com; s=arc-20160816; b=JPGTvnRQ3ZGkGvGcYy//UadRvpulZX2q29qI6dghLlRaM5dE0FvAssVEOo24w5l+0f rCbwVW6ASVNn3ZfJPQ6RTL+zpeBCg2yGgEOHMMyYawA/XTwWWB/c5bz44LFpNOvtE8nI 58/9ge+YHG/+1quJKvtGc5seM8KHcWGnPYK86uK/MiwP3Oo7osIBo2xe0lzqaC4PsgMA pni0UWe+3ujMm69J4auLf3ftFYnvrzH4hzm795RPT+OuCEAVSw19eXftRbu6RFNRlc/o 6/01nOCjwL6Iq2zg9Z7ULeNjcjhF832mHe92euxrOkd5eRDzBF/ttyQZ7wAr9Pe0+dmt amtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=BrQTlFtoTu8he9ydQRdvctc8hmi7ieuddKkLwr03Ix0=; b=vla1YnQi/FsUVk0wksCbyoT83dXLdTmPxYHDbje+jz8u2l53+Hb99CoyCW4FOO45EI gfk/GYxNyjSUQ4ddK/cMJkzdB3MC3pssjGfRjJO/lGpAZuTI0U3WlY4Ppwtm+cDaRDgW zpNn7ipb8bX4TEjhHTnpdZkI7ENqtQwuILRrRYMvqYWYMAU/Qy4NaQX9eC+03Mu4aP8O DHtFBG4ElthnULvuoMdUgdIvZScwDgGO3fTrKxbYwcOVGBmiG51f4pPKdPHO52G9n16d yb4kd1dQXvx/t2z80EOBxW9wSoPk3dJGY5vlqdGKOYlV+RTpZDwAdLyE5ynpu6eTroKV OECg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xHYxZ0jD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lx1-20020a17090b4b0100b00223770a1235si35428889pjb.138.2023.01.03.06.23.23; Tue, 03 Jan 2023 06:23:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xHYxZ0jD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237894AbjACOWi (ORCPT <rfc822;tmhikaru@gmail.com> + 99 others); Tue, 3 Jan 2023 09:22:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237778AbjACOWd (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 3 Jan 2023 09:22:33 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 735512714 for <linux-kernel@vger.kernel.org>; Tue, 3 Jan 2023 06:22:32 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id d17so9850367wrs.2 for <linux-kernel@vger.kernel.org>; Tue, 03 Jan 2023 06:22:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BrQTlFtoTu8he9ydQRdvctc8hmi7ieuddKkLwr03Ix0=; b=xHYxZ0jDW2+TBmQ5IAf+o48+WdHcrpuYIJpkEKuoa8Hvb/BQHziGbWUph2B1hstbEU uOyZAreWTU3SynAXgs/KUVW609XGxXbjE8SsFSYwTSxphKlGUqg45z2jv+ip4PNysIhJ wLWNeS5qSAFdzN+2Z0T6EqzqQ9FX3YK4UKmLI76hIez8PmYQUq1WhrC8nv/0nqFQ/1LF PCUBCuC4YGW5VHu3UoRcGpJG8YR3gqXl/ieW1R1rMvOIBWb3ugsRIo02L/g6ewizQvWq wZ7p2jYJTssUMdyu0jckxKPj6/vtUUc3Wz+cmmQ/69Fy/D/7ZK2CNhweVpsmgFUl9bvD NejA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BrQTlFtoTu8he9ydQRdvctc8hmi7ieuddKkLwr03Ix0=; b=j/2fBeovJnj9NB0V7S3s3T8z5p8PRijd+cx5QsO/zfj2zk6BxG+d6dvhHg0otuBsym oJnkY/KWpnBZTkY+td6evztz4uMDkP14nLpwiAIPzAT2lnjjwuJ6VFebopqL5GHHOuva i5uwcQ5zxZ/g+OdxVqXgbHo92NccvU0Lj0hzYRZjkMA7RaH7Z0Ai5uAr7oHEWAcXbTfv d00FL/4V2IuG78CUqggB0X3UbFKt6hfknxFsbE4qy/blWPmNDP6l9+oGy07viu2stQEG h838AQLAuIfzN6uzkLMJ8DEkYDf2PS2u0vW2y8sojOYBrFkkH0ja/mT0tGzQzsVqIix3 sRJA== X-Gm-Message-State: AFqh2krEE0kIyd+04PoNQNgtZP+/9zjq95fJd/qwhgT9zANlGmFWW9QK QuVVwxUftjRpwjN+drTEZ5qq/A== X-Received: by 2002:adf:cc81:0:b0:275:ae5c:d448 with SMTP id p1-20020adfcc81000000b00275ae5cd448mr26043702wrj.13.1672755751009; Tue, 03 Jan 2023 06:22:31 -0800 (PST) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:52eb:f6ff:feb3:451a]) by smtp.gmail.com with ESMTPSA id i6-20020a5d55c6000000b00283c7b5ee3bsm20182163wrw.101.2023.01.03.06.22.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jan 2023 06:22:30 -0800 (PST) From: Neil Armstrong <neil.armstrong@linaro.org> Date: Tue, 03 Jan 2023 15:22:27 +0100 Subject: [PATCH 1/2] dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel bindings MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230103-topic-sm8550-upstream-vtdr6130-panel-v1-1-9b746b858378@linaro.org> References: <20230103-topic-sm8550-upstream-vtdr6130-panel-v1-0-9b746b858378@linaro.org> In-Reply-To: <20230103-topic-sm8550-upstream-vtdr6130-panel-v1-0-9b746b858378@linaro.org> To: Thierry Reding <thierry.reding@gmail.com>, Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong <neil.armstrong@linaro.org> X-Mailer: b4 0.11.1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754011602710952812?= X-GMAIL-MSGID: =?utf-8?q?1754011602710952812?= |
Series |
drm/panel: add support for the Visionox VTDR6130 AMOLED DSI panel
|
|
Commit Message
Neil Armstrong
Jan. 3, 2023, 2:22 p.m. UTC
Document the 1080x2400 Visionox VTDR6130 AMOLED DSI Panel bindings.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
.../bindings/display/panel/visionox,vtdr6130.yaml | 53 ++++++++++++++++++++++
1 file changed, 53 insertions(+)
Comments
Hi Neil, On Tue, Jan 03, 2023 at 03:22:27PM +0100, Neil Armstrong wrote: > Document the 1080x2400 Visionox VTDR6130 AMOLED DSI Panel bindings. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > .../bindings/display/panel/visionox,vtdr6130.yaml | 53 ++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml > new file mode 100644 > index 000000000000..49e2fd4b4e99 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/visionox,vtdr6130.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Visionox VTDR6130 AMOLED DSI Panel > + > +maintainers: > + - Neil Armstrong <neil.armstrong@linaro.org> > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: visionox,vtdr6130 > + > + vddio-supply: true > + vci-supply: true > + vdd-supply: true These 3 looks wrong to me, as the above are not documented in panel-common. But maybe I miss something and this is OK? Sam > + port: true > + reset-gpios: true > + > +additionalProperties: false > + > +required: > + - compatible > + - vddio-supply > + - vci-supply > + - vdd-supply > + - reset-gpios > + - port > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + panel { > + compatible = "visionox,vtdr6130"; > + > + vddio-supply = <&vreg_l12b_1p8>; > + vci-supply = <&vreg_l13b_3p0>; > + vdd-supply = <&vreg_l11b_1p2>; > + > + reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>; > + > + port { > + panel0_in: endpoint { > + remote-endpoint = <&dsi0_out>; > + }; > + }; > + }; > +... > > -- > 2.34.1
On 03/01/2023 18:57, Sam Ravnborg wrote: > Hi Neil, > > On Tue, Jan 03, 2023 at 03:22:27PM +0100, Neil Armstrong wrote: >> Document the 1080x2400 Visionox VTDR6130 AMOLED DSI Panel bindings. >> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> .../bindings/display/panel/visionox,vtdr6130.yaml | 53 ++++++++++++++++++++++ >> 1 file changed, 53 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml >> new file mode 100644 >> index 000000000000..49e2fd4b4e99 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml >> @@ -0,0 +1,53 @@ >> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/display/panel/visionox,vtdr6130.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Visionox VTDR6130 AMOLED DSI Panel >> + >> +maintainers: >> + - Neil Armstrong <neil.armstrong@linaro.org> >> + >> +allOf: >> + - $ref: panel-common.yaml# >> + >> +properties: >> + compatible: >> + const: visionox,vtdr6130 >> + >> + vddio-supply: true >> + vci-supply: true >> + vdd-supply: true > These 3 looks wrong to me, as the above are not documented in panel-common. > But maybe I miss something and this is OK? It should be OK, the XXXX-supply properties are standard properties Neil > > Sam > >> + port: true >> + reset-gpios: true >> + >> +additionalProperties: false >> + >> +required: >> + - compatible >> + - vddio-supply >> + - vci-supply >> + - vdd-supply >> + - reset-gpios >> + - port >> + >> +examples: >> + - | >> + #include <dt-bindings/gpio/gpio.h> >> + panel { >> + compatible = "visionox,vtdr6130"; >> + >> + vddio-supply = <&vreg_l12b_1p8>; >> + vci-supply = <&vreg_l13b_3p0>; >> + vdd-supply = <&vreg_l11b_1p2>; >> + >> + reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>; >> + >> + port { >> + panel0_in: endpoint { >> + remote-endpoint = <&dsi0_out>; >> + }; >> + }; >> + }; >> +... >> >> -- >> 2.34.1
On 03/01/2023 15:22, Neil Armstrong wrote: > Document the 1080x2400 Visionox VTDR6130 AMOLED DSI Panel bindings. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > .../bindings/display/panel/visionox,vtdr6130.yaml | 53 ++++++++++++++++++++++ > 1 file changed, 53 insertions(+) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi Neil, > > > +properties: > > > + compatible: > > > + const: visionox,vtdr6130 > > > + > > > + vddio-supply: true > > > + vci-supply: true > > > + vdd-supply: true > > These 3 looks wrong to me, as the above are not documented in panel-common. > > But maybe I miss something and this is OK? > > It should be OK, the XXXX-supply properties are standard properties Thanks for the explanation - patch is then: Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
diff --git a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml new file mode 100644 index 000000000000..49e2fd4b4e99 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml @@ -0,0 +1,53 @@ +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/visionox,vtdr6130.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Visionox VTDR6130 AMOLED DSI Panel + +maintainers: + - Neil Armstrong <neil.armstrong@linaro.org> + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: visionox,vtdr6130 + + vddio-supply: true + vci-supply: true + vdd-supply: true + port: true + reset-gpios: true + +additionalProperties: false + +required: + - compatible + - vddio-supply + - vci-supply + - vdd-supply + - reset-gpios + - port + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + panel { + compatible = "visionox,vtdr6130"; + + vddio-supply = <&vreg_l12b_1p8>; + vci-supply = <&vreg_l13b_3p0>; + vdd-supply = <&vreg_l11b_1p2>; + + reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>; + + port { + panel0_in: endpoint { + remote-endpoint = <&dsi0_out>; + }; + }; + }; +...