Message ID | 20221228100321.15949-6-linux.amoon@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1812818wrt; Wed, 28 Dec 2022 02:07:09 -0800 (PST) X-Google-Smtp-Source: AMrXdXuk6+iVWCba1VZwID9crRmxpqidyIsK+odLQAICzIcqk0livZvyf9clVqBWegZHV0ZN4pZi X-Received: by 2002:aa7:ca55:0:b0:468:38e5:f233 with SMTP id j21-20020aa7ca55000000b0046838e5f233mr21307772edt.24.1672222029526; Wed, 28 Dec 2022 02:07:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672222029; cv=none; d=google.com; s=arc-20160816; b=nkmpVdPynp1JiCTHhrhtsczX4GveJtoAORC5zOs25YEcXTazZeTAHeQUHHRBFnCiRV YtIJDGZN9YJ0U6z569WiREXP3IGFP36Zq/97vbQSSLqO/jJVV3fp9PYaF49WEwhW1ZLi sewTG/1lymOW6xk90Y0Ssyl0GfSBLnXgdu7ryMgAA60dPoR9A1uOY0FbxjvmQ9goohz2 YT8a3QpPi05lQd5AafcgAeWtx8cyJxhszjeaxZeAxGuqjmMb2OJ4LM1exmo/wZBfmk/M 4UaFdI44EZ+cu3MS4L+J0D+PdCs+MmXv8j41GTcdXksTXskbozwSyc2qKtyiO+KojHhB jH4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=GTZpZDLmOBMESWnhE00PibYliTCVq7n9n0KaHIBRUgo=; b=UBFBFYnj4dOh1ZJiC1M1ep/sALsO8kRpKPCF3Pv+ZOunzPfyfhan7p/2nFk4T955s7 lWua/dDhInYR8eaycG7GMMIuSYAE3rukyP0O3qbCPXDisetVx4nJv5kioOI4JAYJo2SO 3/WGxPhuDAd7ux/kzGpvsyXvaUbDNolLpRSua2/T9wYL/rAZ3cH993ggcaGGA2XVFOjz yYy/ERQRnqSnSnouILDqxVSEBigLRwGVpn9exZ0QvFmAEWd9ikAnVGQ8afX3iLQhWn6U Vnt0T3iitYWKQQyvngjeTflcCj5kPx4sql3RYkZIaNzbmVNk06WHfSikWpu/sSBO3nnE 26FA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ASD375cp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z16-20020a05640240d000b0046b5f810167si14746922edb.279.2022.12.28.02.06.45; Wed, 28 Dec 2022 02:07:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ASD375cp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232987AbiL1KGH (ORCPT <rfc822;eddaouddi.ayoub@gmail.com> + 99 others); Wed, 28 Dec 2022 05:06:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232887AbiL1KFd (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 28 Dec 2022 05:05:33 -0500 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17A9B1007C; Wed, 28 Dec 2022 02:05:33 -0800 (PST) Received: by mail-pj1-x1031.google.com with SMTP id j8-20020a17090a3e0800b00225fdd5007fso5996989pjc.2; Wed, 28 Dec 2022 02:05:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GTZpZDLmOBMESWnhE00PibYliTCVq7n9n0KaHIBRUgo=; b=ASD375cpLc8wE91QgoQZ79vhHoTccoa+M+X5uZ7MY27gKKGlPUZycPZp5ItavoE8Y2 mmmSRWhRwvpBCtlaexQrHpIx9cS4zCvabcVfw41PxMsOXRs2kYhz1QYaNYt71MVWasdo tE+7YN1OMa9d83NfJRqK/CjrQLVtJH4zbAXH0JwSu17WcjvQLE6r8f/XQx/hz5vlh3Up GCusR8SIRGkI8ZYOcs8kj8zS3pbNplb6OiDTMMJB42gVpOD8qFHRP5t8YxVpFf+OiC8+ 2X2qvKUD2Lsw/n3ieW7Cv9V/UoOzKY4xDJMGeTOluGsIDDL1Km3KVPUfmThSSzf6WKPL K3bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GTZpZDLmOBMESWnhE00PibYliTCVq7n9n0KaHIBRUgo=; b=b7QmiUPTZJVeWnJso/03KhggRltjExe3IjP6OfmGMfdjDGYhkYHdjDF8SXqfgL296w J1nXuSICmv0t7LqKBdiGnhitORRr1ziKU3djvfUao7UTVlSDu/amWj+LfMTXCKbqVfoe CbkBoDmncGCShe9CO0iAdrbzFH3lef3lF1BSRt3v9Msip3n3kCqmHM7+UadfPvf7Lnu2 +/22bw8m7dQ6toke81rtsoddc3B8VPJd9TrnbZ8eUGHjKuKWSG4uEwdJW5xsn9WZjsND xruiks1/2OjzxAkWEfcjD6O/ybhpZHjBOzQ2JeUBQT8Qw4IEnr2GjNxIyife/X8dnm0a Kpdw== X-Gm-Message-State: AFqh2krHTPbgp/9avWRn61rB6Zk1GRzmrZBFrz87TURaJT9EfVV8xQoB Au+QpsUuPyP6iV9OJk8cE6k= X-Received: by 2002:a05:6a21:3988:b0:ad:a09c:5734 with SMTP id ad8-20020a056a21398800b000ada09c5734mr37897250pzc.44.1672221932657; Wed, 28 Dec 2022 02:05:32 -0800 (PST) Received: from localhost.localdomain ([45.112.3.26]) by smtp.gmail.com with ESMTPSA id t6-20020a1709027fc600b0019277df45a6sm5794915plb.53.2022.12.28.02.05.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Dec 2022 02:05:32 -0800 (PST) From: Anand Moon <linux.amoon@gmail.com> To: Matthias Kaehlcke <mka@chromium.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-amlogic@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 05/11] usb: misc: onboard_usb_hub: add Genesys Logic GL852G-OHG hub support Date: Wed, 28 Dec 2022 10:03:14 +0000 Message-Id: <20221228100321.15949-6-linux.amoon@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221228100321.15949-1-linux.amoon@gmail.com> References: <20221228100321.15949-1-linux.amoon@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753451887051385253?= X-GMAIL-MSGID: =?utf-8?q?1753451887051385253?= |
Series |
[v1,01/11] dt-bindings: usb: Add device id for Genesys Logic hub controller
|
|
Commit Message
Anand Moon
Dec. 28, 2022, 10:03 a.m. UTC
Genesys Logic GL852G-OHG is a 4-port USB 2.0 STT hub that has a reset pin to
toggle and a 5.0V core supply exported though an integrated LDO is
available for powering it.
Add the support for this hub, for controlling the reset pin and the core
power supply.
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
drivers/usb/misc/onboard_usb_hub.c | 1 +
drivers/usb/misc/onboard_usb_hub.h | 1 +
2 files changed, 2 insertions(+)
Comments
On Wed, Dec 28, 2022 at 10:03:14AM +0000, Anand Moon wrote: > Genesys Logic GL852G-OHG is a 4-port USB 2.0 STT hub that has a reset pin to > toggle and a 5.0V core supply exported though an integrated LDO is > available for powering it. > > Add the support for this hub, for controlling the reset pin and the core > power supply. > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > drivers/usb/misc/onboard_usb_hub.c | 1 + > drivers/usb/misc/onboard_usb_hub.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c > index 94e7966e199d..c0e8e6f4ec0a 100644 > --- a/drivers/usb/misc/onboard_usb_hub.c > +++ b/drivers/usb/misc/onboard_usb_hub.c > @@ -409,6 +409,7 @@ static void onboard_hub_usbdev_disconnect(struct usb_device *udev) > > static const struct usb_device_id onboard_hub_id_table[] = { > { USB_DEVICE(VENDOR_ID_GENESYS, 0x0608) }, /* Genesys Logic GL850G USB 2.0 */ > + { USB_DEVICE(VENDOR_ID_GENESYS, 0x0610) }, /* Genesys Logic GL852G-OHG USB 2.0 */ > { USB_DEVICE(VENDOR_ID_MICROCHIP, 0x2514) }, /* USB2514B USB 2.0 */ > { USB_DEVICE(VENDOR_ID_REALTEK, 0x0411) }, /* RTS5411 USB 3.1 */ > { USB_DEVICE(VENDOR_ID_REALTEK, 0x5411) }, /* RTS5411 USB 2.1 */ > diff --git a/drivers/usb/misc/onboard_usb_hub.h b/drivers/usb/misc/onboard_usb_hub.h > index 62129a6a1ba5..2ee1b0032d23 100644 > --- a/drivers/usb/misc/onboard_usb_hub.h > +++ b/drivers/usb/misc/onboard_usb_hub.h > @@ -31,6 +31,7 @@ static const struct of_device_id onboard_hub_match[] = { > { .compatible = "usb451,8140", .data = &ti_tusb8041_data, }, > { .compatible = "usb451,8142", .data = &ti_tusb8041_data, }, > { .compatible = "usb5e3,608", .data = &genesys_gl850g_data, }, > + { .compatible = "genesys,usb5e3,610", .data = &genesys_gl850g_data, }, s/genesys,// > { .compatible = "usbbda,411", .data = &realtek_rts5411_data, }, > { .compatible = "usbbda,5411", .data = &realtek_rts5411_data, }, > { .compatible = "usbbda,414", .data = &realtek_rts5411_data, }, > -- > 2.38.1 >
On Wed, Jan 04, 2023 at 08:28:18PM +0000, Matthias Kaehlcke wrote: > On Wed, Dec 28, 2022 at 10:03:14AM +0000, Anand Moon wrote: > > Genesys Logic GL852G-OHG is a 4-port USB 2.0 STT hub that has a reset pin to > > toggle and a 5.0V core supply exported though an integrated LDO is > > available for powering it. > > > > Add the support for this hub, for controlling the reset pin and the core > > power supply. > > > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > > --- > > drivers/usb/misc/onboard_usb_hub.c | 1 + > > drivers/usb/misc/onboard_usb_hub.h | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c > > index 94e7966e199d..c0e8e6f4ec0a 100644 > > --- a/drivers/usb/misc/onboard_usb_hub.c > > +++ b/drivers/usb/misc/onboard_usb_hub.c > > @@ -409,6 +409,7 @@ static void onboard_hub_usbdev_disconnect(struct usb_device *udev) > > > > static const struct usb_device_id onboard_hub_id_table[] = { > > { USB_DEVICE(VENDOR_ID_GENESYS, 0x0608) }, /* Genesys Logic GL850G USB 2.0 */ > > + { USB_DEVICE(VENDOR_ID_GENESYS, 0x0610) }, /* Genesys Logic GL852G-OHG USB 2.0 */ Do you happen to know what '-OHG' stands for? The Genesys website only mentions a GL852G with different package types (none of them 'OHG'). Unless there is an 'OHG' variant with a different product id I'd say let's drop the suffix. > > { USB_DEVICE(VENDOR_ID_MICROCHIP, 0x2514) }, /* USB2514B USB 2.0 */ > > { USB_DEVICE(VENDOR_ID_REALTEK, 0x0411) }, /* RTS5411 USB 3.1 */ > > { USB_DEVICE(VENDOR_ID_REALTEK, 0x5411) }, /* RTS5411 USB 2.1 */ > > diff --git a/drivers/usb/misc/onboard_usb_hub.h b/drivers/usb/misc/onboard_usb_hub.h > > index 62129a6a1ba5..2ee1b0032d23 100644 > > --- a/drivers/usb/misc/onboard_usb_hub.h > > +++ b/drivers/usb/misc/onboard_usb_hub.h > > @@ -31,6 +31,7 @@ static const struct of_device_id onboard_hub_match[] = { > > { .compatible = "usb451,8140", .data = &ti_tusb8041_data, }, > > { .compatible = "usb451,8142", .data = &ti_tusb8041_data, }, > > { .compatible = "usb5e3,608", .data = &genesys_gl850g_data, }, > > + { .compatible = "genesys,usb5e3,610", .data = &genesys_gl850g_data, }, > > s/genesys,// > > > { .compatible = "usbbda,411", .data = &realtek_rts5411_data, }, > > { .compatible = "usbbda,5411", .data = &realtek_rts5411_data, }, > > { .compatible = "usbbda,414", .data = &realtek_rts5411_data, }, > > -- > > 2.38.1 > >
Hi Matthias On Thu, 5 Jan 2023 at 02:23, Matthias Kaehlcke <mka@chromium.org> wrote: > > On Wed, Jan 04, 2023 at 08:28:18PM +0000, Matthias Kaehlcke wrote: > > On Wed, Dec 28, 2022 at 10:03:14AM +0000, Anand Moon wrote: > > > Genesys Logic GL852G-OHG is a 4-port USB 2.0 STT hub that has a reset pin to > > > toggle and a 5.0V core supply exported through an integrated LDO is > > > available for powering it. > > > > > > Add the support for this hub, for controlling the reset pin and the core > > > power supply. > > > > > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > > > --- > > > drivers/usb/misc/onboard_usb_hub.c | 1 + > > > drivers/usb/misc/onboard_usb_hub.h | 1 + > > > 2 files changed, 2 insertions(+) > > > > > > diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c > > > index 94e7966e199d..c0e8e6f4ec0a 100644 > > > --- a/drivers/usb/misc/onboard_usb_hub.c > > > +++ b/drivers/usb/misc/onboard_usb_hub.c > > > @@ -409,6 +409,7 @@ static void onboard_hub_usbdev_disconnect(struct usb_device *udev) > > > > > > static const struct usb_device_id onboard_hub_id_table[] = { > > > { USB_DEVICE(VENDOR_ID_GENESYS, 0x0608) }, /* Genesys Logic GL850G USB 2.0 */ > > > + { USB_DEVICE(VENDOR_ID_GENESYS, 0x0610) }, /* Genesys Logic GL852G-OHG USB 2.0 */ > > Do you happen to know what '-OHG' stands for? The Genesys website only > mentions a GL852G with different package types (none of them 'OHG'). > Unless there is an 'OHG' variant with a different product id I'd say > let's drop the suffix. Ok, done. > > > > { USB_DEVICE(VENDOR_ID_MICROCHIP, 0x2514) }, /* USB2514B USB 2.0 */ > > > { USB_DEVICE(VENDOR_ID_REALTEK, 0x0411) }, /* RTS5411 USB 3.1 */ > > > { USB_DEVICE(VENDOR_ID_REALTEK, 0x5411) }, /* RTS5411 USB 2.1 */ > > > diff --git a/drivers/usb/misc/onboard_usb_hub.h b/drivers/usb/misc/onboard_usb_hub.h > > > index 62129a6a1ba5..2ee1b0032d23 100644 > > > --- a/drivers/usb/misc/onboard_usb_hub.h > > > +++ b/drivers/usb/misc/onboard_usb_hub.h > > > @@ -31,6 +31,7 @@ static const struct of_device_id onboard_hub_match[] = { > > > { .compatible = "usb451,8140", .data = &ti_tusb8041_data, }, > > > { .compatible = "usb451,8142", .data = &ti_tusb8041_data, }, > > > { .compatible = "usb5e3,608", .data = &genesys_gl850g_data, }, > > > + { .compatible = "genesys,usb5e3,610", .data = &genesys_gl850g_data, }, > > > > s/genesys,// > > > > > { .compatible = "usbbda,411", .data = &realtek_rts5411_data, }, > > > { .compatible = "usbbda,5411", .data = &realtek_rts5411_data, }, > > > { .compatible = "usbbda,414", .data = &realtek_rts5411_data, }, > > > -- > > > 2.38.1 > > >
diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c index 94e7966e199d..c0e8e6f4ec0a 100644 --- a/drivers/usb/misc/onboard_usb_hub.c +++ b/drivers/usb/misc/onboard_usb_hub.c @@ -409,6 +409,7 @@ static void onboard_hub_usbdev_disconnect(struct usb_device *udev) static const struct usb_device_id onboard_hub_id_table[] = { { USB_DEVICE(VENDOR_ID_GENESYS, 0x0608) }, /* Genesys Logic GL850G USB 2.0 */ + { USB_DEVICE(VENDOR_ID_GENESYS, 0x0610) }, /* Genesys Logic GL852G-OHG USB 2.0 */ { USB_DEVICE(VENDOR_ID_MICROCHIP, 0x2514) }, /* USB2514B USB 2.0 */ { USB_DEVICE(VENDOR_ID_REALTEK, 0x0411) }, /* RTS5411 USB 3.1 */ { USB_DEVICE(VENDOR_ID_REALTEK, 0x5411) }, /* RTS5411 USB 2.1 */ diff --git a/drivers/usb/misc/onboard_usb_hub.h b/drivers/usb/misc/onboard_usb_hub.h index 62129a6a1ba5..2ee1b0032d23 100644 --- a/drivers/usb/misc/onboard_usb_hub.h +++ b/drivers/usb/misc/onboard_usb_hub.h @@ -31,6 +31,7 @@ static const struct of_device_id onboard_hub_match[] = { { .compatible = "usb451,8140", .data = &ti_tusb8041_data, }, { .compatible = "usb451,8142", .data = &ti_tusb8041_data, }, { .compatible = "usb5e3,608", .data = &genesys_gl850g_data, }, + { .compatible = "genesys,usb5e3,610", .data = &genesys_gl850g_data, }, { .compatible = "usbbda,411", .data = &realtek_rts5411_data, }, { .compatible = "usbbda,5411", .data = &realtek_rts5411_data, }, { .compatible = "usbbda,414", .data = &realtek_rts5411_data, },