diff mbox series

Fix sim/testsuite/bpf due to linker warnings

Message ID 20230104041219.794237-1-guillermo.e.martinez@oracle.com
State Accepted
Headers
Series Fix sim/testsuite/bpf due to linker warnings |

Checks

Context Check Description
snail/binutils-gdb-check success Github commit url

Commit Message

Guillermo E. Martinez Jan. 4, 2023, 4:12 a.m. UTC 
  Hello,

This patch is meant to fix bug:
  https://sourceware.org/bugzilla/show_bug.cgi?id=29954 

Please let know your thoughts. I'll really appreciate them!,
guillermo

--

On a bpf-*-* testsuite fails:
	./ld/ld-new: warning: test has a LOAD segment with RWX permissions

Adding `--no-warn-rwx-segments' option to linker and set `--memory-size=10Mb'
to the simulator bpf testsuite passes.

Tested on bpf-*-*:

Bug 29954: https://sourceware.org/bugzilla/show_bug.cgi?id=29954

sim/testsuite:
	* bpf/allinsn.exp (SIMFLAGS_FOR_TARGET): Adjust sim flags.
	(LDFLAGS_FOR_TARGET): Adjust ld flags.
---
 sim/testsuite/bpf/allinsn.exp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Mike Frysinger Jan. 4, 2023, 7:02 a.m. UTC | #1 
On 03 Jan 2023 22:12, Guillermo E. Martinez via Binutils wrote:
> Hello,
> 
> This patch is meant to fix bug:
>   https://sourceware.org/bugzilla/show_bug.cgi?id=29954 
> 
> Please let know your thoughts. I'll really appreciate them!,
> guillermo
> 
> --
> 
> On a bpf-*-* testsuite fails:
> 	./ld/ld-new: warning: test has a LOAD segment with RWX permissions
> 
> Adding `--no-warn-rwx-segments' option to linker and set `--memory-size=10Mb'
> to the simulator bpf testsuite passes.
> 
> Tested on bpf-*-*:
> 
> Bug 29954: https://sourceware.org/bugzilla/show_bug.cgi?id=29954

i thought increasing the memory was sufficient to not need the -Ttext=0x0,
and the -Ttext=0x0 was the only reason we were triggering RWX warnings.  so
do we still need --no-warn-rwx-segments ?
-mike
Guillermo E. Martinez Jan. 4, 2023, 5:24 p.m. UTC | #2 
Hello Mike,

On Wed, Jan 04, 2023 at 02:02:26AM -0500, Mike Frysinger wrote:
> On 03 Jan 2023 22:12, Guillermo E. Martinez via Binutils wrote:
> > Hello,
> > 
> > This patch is meant to fix bug:
> >   https://sourceware.org/bugzilla/show_bug.cgi?id=29954 
> > 
> > Please let know your thoughts. I'll really appreciate them!,
> > guillermo
> > 
> > --
> > 
> > On a bpf-*-* testsuite fails:
> > 	./ld/ld-new: warning: test has a LOAD segment with RWX permissions
> > 
> > Adding `--no-warn-rwx-segments' option to linker and set `--memory-size=10Mb'
> > to the simulator bpf testsuite passes.
> > 
> > Tested on bpf-*-*:
> > 
> > Bug 29954: https://sourceware.org/bugzilla/show_bug.cgi?id=29954
> 
> i thought increasing the memory was sufficient to not need the -Ttext=0x0,
> and the -Ttext=0x0 was the only reason we were triggering RWX warnings.  so
> do we still need --no-warn-rwx-segments ?
> -mike

Oh, that's right thanks for pointing out it, I'll send patch-v2.
thanks,
guillermo
diff mbox series

Patch

diff --git a/sim/testsuite/bpf/allinsn.exp b/sim/testsuite/bpf/allinsn.exp
index 98f0346776a..758ecc1b414 100644
--- a/sim/testsuite/bpf/allinsn.exp
+++ b/sim/testsuite/bpf/allinsn.exp
@@ -6,10 +6,10 @@  sim_init
 set all_machs "bpf"
 
 global SIMFLAGS_FOR_TARGET
-set SIMFLAGS_FOR_TARGET "--memory-size=4Mb"
+set SIMFLAGS_FOR_TARGET "--memory-size=10Mb"
 
 global LDFLAGS_FOR_TARGET
-set LDFLAGS_FOR_TARGET "-Ttext=0x0"
+set LDFLAGS_FOR_TARGET "--no-warn-rwx-segments"
 
 foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.s]] {
     # If we're only testing specific files and this isn't one of them, skip it.