diff mbox series

[v4] serial: linflexuart: remove redundant uart type assignment

Message ID 20230104152444.3407-1-sensor1010@163.com
State New
Headers
Series [v4] serial: linflexuart: remove redundant uart type assignment |

Commit Message

Lizhe Jan. 4, 2023, 3:24 p.m. UTC 
  in linflex_config_port() the member variable type will be
assigned again. see linflex_connfig_port()

Signed-off-by: lizhe <sensor1010@163.com>
Link: https://lore.kernel.org/all/20230103170948.3777-1-sensor1010@163.com/
---
 drivers/tty/serial/fsl_linflexuart.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Greg KH Jan. 4, 2023, 3:39 p.m. UTC | #1 
On Wed, Jan 04, 2023 at 07:24:44AM -0800, lizhe wrote:
> in linflex_config_port() the member variable type will be
> assigned again. see linflex_connfig_port()
> 
> Signed-off-by: lizhe <sensor1010@163.com>
> Link: https://lore.kernel.org/all/20230103170948.3777-1-sensor1010@163.com/
> ---
>  drivers/tty/serial/fsl_linflexuart.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c
> index 6fc21b6684e6..34400cc6ac7f 100644
> --- a/drivers/tty/serial/fsl_linflexuart.c
> +++ b/drivers/tty/serial/fsl_linflexuart.c
> @@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev)
>  		return PTR_ERR(sport->membase);
>  
>  	sport->dev = &pdev->dev;
> -	sport->type = PORT_LINFLEXUART;
>  	sport->iotype = UPIO_MEM;
>  	sport->irq = platform_get_irq(pdev, 0);
>  	sport->ops = &linflex_pops;
> -- 
> 2.17.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file,
  Documentation/process/submitting-patches.rst for how to do this
  correctly.

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot
Greg KH Jan. 4, 2023, 3:51 p.m. UTC | #2 
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Wed, Jan 04, 2023 at 11:48:24PM +0800, lizhe wrote:
> 
> 
> 
> HI : 
>     1 .  
> I'm Chinese, lizhe is my name, and my email is sensor1010@163.com ,
> How to express real name?

Your full name that you sign documents with?  If so, great, but odds are
there is a capital letter in there, right?  Or just use your Chinese
name, that's fine too.

thanks,

greg k-h
Greg KH Jan. 5, 2023, 11:26 a.m. UTC | #3 
On Thu, Jan 05, 2023 at 12:45:02AM +0800, lizhe wrote:
> HI : 
>     thanks. Modified to LIZHE

Why?  Again, why not just use the proper Chinese characters that you use
to sign your name with in documents in your country?

And again, please do not top-post.  Nor send html-formatted emails...

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c
index 6fc21b6684e6..34400cc6ac7f 100644
--- a/drivers/tty/serial/fsl_linflexuart.c
+++ b/drivers/tty/serial/fsl_linflexuart.c
@@ -837,7 +837,6 @@  static int linflex_probe(struct platform_device *pdev)
 		return PTR_ERR(sport->membase);
 
 	sport->dev = &pdev->dev;
-	sport->type = PORT_LINFLEXUART;
 	sport->iotype = UPIO_MEM;
 	sport->irq = platform_get_irq(pdev, 0);
 	sport->ops = &linflex_pops;