Message ID | 20230104125725.271850-14-baolu.lu@linux.intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp5133996wrt; Wed, 4 Jan 2023 05:09:15 -0800 (PST) X-Google-Smtp-Source: AMrXdXuLRXpaIlWFgO/P3KJ6Sr9T+9FVIhBjQ9dfz6kzruwHfV59cADvBdvbYBGRNroZsMUfa/CU X-Received: by 2002:a05:6a00:1d03:b0:573:a0a0:c5d2 with SMTP id a3-20020a056a001d0300b00573a0a0c5d2mr55574643pfx.7.1672837755216; Wed, 04 Jan 2023 05:09:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672837755; cv=none; d=google.com; s=arc-20160816; b=cTH77Em5WB7zONKvgKM1dNlSV+9QTzw62kiDblW4/Uq8A+8s6F6higWYdocby6gbKB SahzrWOQrwVlYaXwgm2GEPMfB0WfVmbE2E6tJd3IXrMcRzvKmUWtqYGKTUIZTe8AehWF gGK+6tGmGPb70BcBtHifI6ySYXcpUXmbUEUBiNrMm6WYDPcWU7CcOSY9NoRratHnzhkR RFNA1AVHQ4a8i80nZUkyF+CjLd/us/ZKE6ErL0YoI86TlHHompoSorR5Xmixe7thkdOY UOAut95cu4D6EcQy1GiDpx0OQDk8EjNNFlJJVFhsck3q/R4SbUDpHdOTF67uKAFcJroa 4Zsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=jFrhMAqBpXI5tO8J+qzs+hyFm5JLXDdmFr6L6dhaTGI=; b=Yxo3DYMzCrvim9vxyxJCq6OOSHTE6ALE3t9XTmjgyomqqIaMVFLtWLxscA5IpHGcnx kqpBNvkcx6bopLYfoS7nqVgWBNL/Jv2omG4J60f8ROUeKtbTLfL+4TkscSfrUJfy9LtW Kzg2efP91/x1WiAHcP5Y+sLLpLymJoDa/bPUcjpxZ57mmYbu1BsEvcg/IWTXH9Q6Wd+i mnA5jEm2rywR+Inppy7KuZVTy8GX6kAafhUbCf4TYLWuWG/49chDm7gWtdcDpIdZlfrJ jvLXl3GM5bm0EaCUKGo8vjrxfhqSe7+9O0UxuOZofVpTnDRtY0RzotzQbTgWoNNqwCeF HnIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=DBmtpkqL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 7-20020a620507000000b00574c8aba4d3si32899706pff.153.2023.01.04.05.09.02; Wed, 04 Jan 2023 05:09:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=DBmtpkqL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239341AbjADNI1 (ORCPT <rfc822;tmhikaru@gmail.com> + 99 others); Wed, 4 Jan 2023 08:08:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239364AbjADNHs (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 4 Jan 2023 08:07:48 -0500 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF81C3753E for <linux-kernel@vger.kernel.org>; Wed, 4 Jan 2023 05:07:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672837626; x=1704373626; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6/1FMqG3xZJDtfDShWWRJkd9e9miluKjPk+ZSlf8fww=; b=DBmtpkqL5ZRnQXacZ2W6AkKaANIh3XXcKwq89y9fX9A3pyJaBvc8nAHd +aQlGhEKLxIHm7/Q3cELMorUNntCMI9ccVcMbAb03MEWptDf8OFeXgZvw T2Ivmb1Kd+ZO9X2Rh6/0EsYzPqE9QhuqWUT53TqmKbetfTG/oI2XYtW/T 2lcAMX22dXik7r97PE86RF6ck8Log5XcYHh/MF4o4MoshxiPrnt0J/UxW JY1uozc6kvk0uGVzko2+DF7le9mW4McVJKDOsGZhOkY02/X3wJQtf6w5Y zBnRxfFyPUY0NCpodAdRseEhw771wScDTlOKdjOsZJw2tMUqLewiMpYrP A==; X-IronPort-AV: E=McAfee;i="6500,9779,10579"; a="320640099" X-IronPort-AV: E=Sophos;i="5.96,299,1665471600"; d="scan'208";a="320640099" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 05:06:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10579"; a="797529136" X-IronPort-AV: E=Sophos;i="5.96,299,1665471600"; d="scan'208";a="797529136" Received: from allen-box.sh.intel.com ([10.239.159.48]) by fmsmga001.fm.intel.com with ESMTP; 04 Jan 2023 05:06:40 -0800 From: Lu Baolu <baolu.lu@linux.intel.com> To: Joerg Roedel <joro@8bytes.org>, Jason Gunthorpe <jgg@nvidia.com>, Christoph Hellwig <hch@infradead.org>, Kevin Tian <kevin.tian@intel.com>, Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, Jean-Philippe Brucker <jean-philippe@linaro.org> Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>, Rob Clark <robdclark@gmail.com>, Marek Szyprowski <m.szyprowski@samsung.com>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Yong Wu <yong.wu@mediatek.com>, Matthias Brugger <matthias.bgg@gmail.com>, Heiko Stuebner <heiko@sntech.de>, Matthew Rosato <mjrosato@linux.ibm.com>, Orson Zhai <orsonzhai@gmail.com>, Baolin Wang <baolin.wang@linux.alibaba.com>, Chunyan Zhang <zhang.lyra@gmail.com>, Chen-Yu Tsai <wens@csie.org>, Thierry Reding <thierry.reding@gmail.com>, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Lu Baolu <baolu.lu@linux.intel.com> Subject: [PATCH v4 13/19] iommu/mtk_v1: Add set_platform_dma_ops callback Date: Wed, 4 Jan 2023 20:57:19 +0800 Message-Id: <20230104125725.271850-14-baolu.lu@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230104125725.271850-1-baolu.lu@linux.intel.com> References: <20230104125725.271850-1-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754097521871070296?= X-GMAIL-MSGID: =?utf-8?q?1754097521871070296?= |
Series |
iommu: Retire detach_dev callback
|
|
Commit Message
Baolu Lu
Jan. 4, 2023, 12:57 p.m. UTC
This IOMMU driver doesn't support default domain. Add the implementation
of set_platform_dma_ops callback so that the IOMMU core could return the
DMA control. With the set_platform_dma_ops implemented, there's no need
for detach_dev. Remove it to avoid dead code.
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
drivers/iommu/mtk_iommu_v1.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On Wed, Jan 04, 2023 at 08:57:19PM +0800, Lu Baolu wrote: > This IOMMU driver doesn't support default domain. Add the implementation > of set_platform_dma_ops callback so that the IOMMU core could return the > DMA control. With the set_platform_dma_ops implemented, there's no need > for detach_dev. Remove it to avoid dead code. > > Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> > --- > drivers/iommu/mtk_iommu_v1.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Jason
diff --git a/drivers/iommu/mtk_iommu_v1.c b/drivers/iommu/mtk_iommu_v1.c index 69682ee068d2..78d0a84c704f 100644 --- a/drivers/iommu/mtk_iommu_v1.c +++ b/drivers/iommu/mtk_iommu_v1.c @@ -319,7 +319,7 @@ static int mtk_iommu_v1_attach_device(struct iommu_domain *domain, struct device return 0; } -static void mtk_iommu_v1_detach_device(struct iommu_domain *domain, struct device *dev) +static void mtk_iommu_v1_set_platform_dma(struct device *dev) { struct mtk_iommu_v1_data *data = dev_iommu_priv_get(dev); @@ -585,10 +585,10 @@ static const struct iommu_ops mtk_iommu_v1_ops = { .def_domain_type = mtk_iommu_v1_def_domain_type, .device_group = generic_device_group, .pgsize_bitmap = MT2701_IOMMU_PAGE_SIZE, + .set_platform_dma_ops = mtk_iommu_v1_set_platform_dma, .owner = THIS_MODULE, .default_domain_ops = &(const struct iommu_domain_ops) { .attach_dev = mtk_iommu_v1_attach_device, - .detach_dev = mtk_iommu_v1_detach_device, .map_pages = mtk_iommu_v1_map, .unmap_pages = mtk_iommu_v1_unmap, .iova_to_phys = mtk_iommu_v1_iova_to_phys,