diff mbox series

scripts/spelling: add a few more typos

Message ID 20230103175901.128262-1-sj@kernel.org
State New
Headers
Series scripts/spelling: add a few more typos |

Commit Message

SeongJae Park Jan. 3, 2023, 5:59 p.m. UTC 
  Add a few more typos that found from real patches[1,2] to 'spelling'
file.

[1] https://lore.kernel.org/linux-mm/4bc4ab74-3ccd-f892-b387-d48451463d3c@huawei.com/
[2] https://lore.kernel.org/damon/20221228174621.34868-1-sj@kernel.org/

Signed-off-by: SeongJae Park <sj@kernel.org>
---
 scripts/spelling.txt | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Randy Dunlap Jan. 3, 2023, 6:04 p.m. UTC | #1 
Hi--

On 1/3/23 09:59, SeongJae Park wrote:
> Add a few more typos that found from real patches[1,2] to 'spelling'
> file.
> 
> [1] https://lore.kernel.org/linux-mm/4bc4ab74-3ccd-f892-b387-d48451463d3c@huawei.com/
> [2] https://lore.kernel.org/damon/20221228174621.34868-1-sj@kernel.org/
> 
> Signed-off-by: SeongJae Park <sj@kernel.org>
> ---
>  scripts/spelling.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/scripts/spelling.txt b/scripts/spelling.txt
> index ded8bcfc0247..64bddbf7425b 100644
> --- a/scripts/spelling.txt
> +++ b/scripts/spelling.txt
> @@ -411,6 +411,7 @@ contruction||construction
>  contry||country
>  conuntry||country
>  convertion||conversion
> +covert||convert

"covert" is a real, valid word. Is it always incorrect when used in kernel
source or documentation?

thanks.
Joe Perches Jan. 3, 2023, 6:07 p.m. UTC | #2 
On Tue, 2023-01-03 at 17:59 +0000, SeongJae Park wrote:
> Add a few more typos that found from real patches[1,2] to 'spelling'
> file.

Most of these are fine but:

> diff --git a/scripts/spelling.txt b/scripts/spelling.txt
[]
> @@ -411,6 +411,7 @@ contruction||construction
>  contry||country
>  conuntry||country
>  convertion||conversion
> +covert||convert

Covert is a correctly spelled english word that could be used
appropriately for some security issues.

For instance:

security/keys/key.c: * security issues through covert channel problems.

Another possibility would be to fix the existing dozen or so misuses/typos.

$ git grep -i -w covert
Documentation/virt/kvm/x86/timekeeping.rst:4.8. Covert channels and leaks
arch/mips/cavium-octeon/executive/cvmx-pko.c:    * per word count. Multiply by 8 to covert to bits and divide
arch/powerpc/include/asm/vas.h:  * CP_ABORT to clear any pending COPY and prevent a covert
arch/powerpc/kernel/process.c:   * any state and prevent snooping, corruption or a covert
arch/powerpc/platforms/pseries/iommu.c: /* covert to number of tces */
arch/powerpc/platforms/pseries/iommu.c: /* covert to number of tces */
arch/sparc/kernel/chmc.c:/* Covert syndrome code into the way the bits are positioned
drivers/crypto/cavium/cpt/cptpf_main.c:         /* Covert requested cores to mask */
drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c: * directly, taking care to covert such fields to little endian. The request
drivers/net/wireless/mediatek/mt76/mt7915/mmio.c:       /* CONN_INFRA: covert to phyiscal addr and use layer 1 remap */
drivers/net/wireless/mediatek/mt76/mt7996/mmio.c:       /* CONN_INFRA: covert to phyiscal addr and use layer 1 remap */
drivers/rtc/rtc-mt6397.c:       /* rtc_tm_to_time64 covert Gregorian date to seconds since
drivers/staging/media/ipu3/include/uapi/intel-ipu3.h: * The demosaic fixed function block is responsible to covert Bayer(mosaiced)
drivers/usb/typec/rt1719.c:     /* covert mV/mA to uV/uA */
fs/iomap/buffered-io.c: * beyond EOF in this case as writeback will never write back and covert that
include/linux/spi/ad7877.h:     u8      pen_down_acc_interval;  /* 0 = covert once, 1 = every 0.5 ms,
scripts/Makefile.build:# Make $(LD) covert LLVM IR to ELF here.
security/keys/key.c: * security issues through covert channel problems.
SeongJae Park Jan. 3, 2023, 6:09 p.m. UTC | #3 
Hi Randy,

On Tue, 3 Jan 2023 10:04:43 -0800 Randy Dunlap <rdunlap@infradead.org> wrote:

> Hi--
> 
> On 1/3/23 09:59, SeongJae Park wrote:
> > Add a few more typos that found from real patches[1,2] to 'spelling'
> > file.
> > 
> > [1] https://lore.kernel.org/linux-mm/4bc4ab74-3ccd-f892-b387-d48451463d3c@huawei.com/
> > [2] https://lore.kernel.org/damon/20221228174621.34868-1-sj@kernel.org/
> > 
> > Signed-off-by: SeongJae Park <sj@kernel.org>
> > ---
> >  scripts/spelling.txt | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/scripts/spelling.txt b/scripts/spelling.txt
> > index ded8bcfc0247..64bddbf7425b 100644
> > --- a/scripts/spelling.txt
> > +++ b/scripts/spelling.txt
> > @@ -411,6 +411,7 @@ contruction||construction
> >  contry||country
> >  conuntry||country
> >  convertion||conversion
> > +covert||convert
> 
> "covert" is a real, valid word. Is it always incorrect when used in kernel
> source or documentation?

You're right.  I will drop this in the next spin.


Thanks,
SJ

> 
> thanks.
> 
> -- 
> ~Randy
SeongJae Park Jan. 3, 2023, 6:10 p.m. UTC | #4 
Hi Joe,

On Tue, 03 Jan 2023 10:07:22 -0800 Joe Perches <joe@perches.com> wrote:

> On Tue, 2023-01-03 at 17:59 +0000, SeongJae Park wrote:
> > Add a few more typos that found from real patches[1,2] to 'spelling'
> > file.
> 
> Most of these are fine but:
> 
> > diff --git a/scripts/spelling.txt b/scripts/spelling.txt
> []
> > @@ -411,6 +411,7 @@ contruction||construction
> >  contry||country
> >  conuntry||country
> >  convertion||conversion
> > +covert||convert
> 
> Covert is a correctly spelled english word that could be used
> appropriately for some security issues.

You're correct, thank you for nice comment.  Will drop this from the next spin.


Thanks,
SJ

[...]
diff mbox series

Patch

diff --git a/scripts/spelling.txt b/scripts/spelling.txt
index ded8bcfc0247..64bddbf7425b 100644
--- a/scripts/spelling.txt
+++ b/scripts/spelling.txt
@@ -411,6 +411,7 @@  contruction||construction
 contry||country
 conuntry||country
 convertion||conversion
+covert||convert
 convertor||converter
 convienient||convenient
 convinient||convenient
@@ -664,11 +665,13 @@  feauture||feature
 feautures||features
 fetaure||feature
 fetaures||features
+fetcing||fetching
 fileystem||filesystem
 fimrware||firmware
 fimware||firmware
 firmare||firmware
 firmaware||firmware
+firtly||firstly
 firware||firmware
 firwmare||firmware
 finanize||finalize
@@ -1558,6 +1561,7 @@  tunning||tuning
 ture||true
 tyep||type
 udpate||update
+updtes||updates
 uesd||used
 unknwon||unknown
 uknown||unknown