[v2,1/3] dt-bindings: mfd: qcom,spmi-pmic: document pm8550, pm8550b, pm8550ve, pm8550vs, pmk8550, pm8010 & pmr735d

Message ID 20221114-narmstrong-sm8550-upstream-spmi-v2-1-b839bf2d558a@linaro.org
State New
Headers
Series qcom: add support for SPMI PMICs found on SM8550 platforms |

Commit Message

Neil Armstrong Nov. 18, 2022, 8:24 a.m. UTC
  Document compatible for the pm8550, pm8550b, pm8550ve, pm8550vs, pmk8550.
pm8010 & pmr735d SPMI PMICs

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 7 +++++++
 1 file changed, 7 insertions(+)
  

Comments

Konrad Dybcio Nov. 18, 2022, 8:52 a.m. UTC | #1
On 18/11/2022 09:24, Neil Armstrong wrote:
> Document compatible for the pm8550, pm8550b, pm8550ve, pm8550vs, pmk8550.
> pm8010 & pmr735d SPMI PMICs
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Didn't checkpatch complain about the length of this patch's subject?
I propose:

dt-bindings: mfd: qcom,spmi-pmic: document SM8550 PMICs

or

dt-bindings: mfd: qcom,spmi-pmic: document PMICs bundled with SM8550


Konrad
>   Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> index c8362efd4345..8c9b042b4f30 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> @@ -43,6 +43,7 @@ properties:
>             - qcom,pm8004
>             - qcom,pm8005
>             - qcom,pm8009
> +          - qcom,pm8010
>             - qcom,pm8019
>             - qcom,pm8028
>             - qcom,pm8110
> @@ -54,6 +55,10 @@ properties:
>             - qcom,pm8350
>             - qcom,pm8350b
>             - qcom,pm8350c
> +          - qcom,pm8550
> +          - qcom,pm8550b
> +          - qcom,pm8550ve
> +          - qcom,pm8550vs
>             - qcom,pm8841
>             - qcom,pm8909
>             - qcom,pm8916
> @@ -70,10 +75,12 @@ properties:
>             - qcom,pmi8998
>             - qcom,pmk8002
>             - qcom,pmk8350
> +          - qcom,pmk8550
>             - qcom,pmm8155au
>             - qcom,pmp8074
>             - qcom,pmr735a
>             - qcom,pmr735b
> +          - qcom,pmr735d
>             - qcom,pms405
>             - qcom,pmx55
>             - qcom,pmx65
>
  
Neil Armstrong Nov. 18, 2022, 8:56 a.m. UTC | #2
On 18/11/2022 09:52, Konrad Dybcio wrote:
> 
> 
> On 18/11/2022 09:24, Neil Armstrong wrote:
>> Document compatible for the pm8550, pm8550b, pm8550ve, pm8550vs, pmk8550.
>> pm8010 & pmr735d SPMI PMICs
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
> Didn't checkpatch complain about the length of this patch's subject?

No, not even with --strict

> I propose:
> 
> dt-bindings: mfd: qcom,spmi-pmic: document SM8550 PMICs
> 
> or
> 
> dt-bindings: mfd: qcom,spmi-pmic: document PMICs bundled with SM8550

I'll change to of these if I need to resend,

Thanks,
Neil

> 
> 
> Konrad
>>   Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>> index c8362efd4345..8c9b042b4f30 100644
>> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>> @@ -43,6 +43,7 @@ properties:
>>             - qcom,pm8004
>>             - qcom,pm8005
>>             - qcom,pm8009
>> +          - qcom,pm8010
>>             - qcom,pm8019
>>             - qcom,pm8028
>>             - qcom,pm8110
>> @@ -54,6 +55,10 @@ properties:
>>             - qcom,pm8350
>>             - qcom,pm8350b
>>             - qcom,pm8350c
>> +          - qcom,pm8550
>> +          - qcom,pm8550b
>> +          - qcom,pm8550ve
>> +          - qcom,pm8550vs
>>             - qcom,pm8841
>>             - qcom,pm8909
>>             - qcom,pm8916
>> @@ -70,10 +75,12 @@ properties:
>>             - qcom,pmi8998
>>             - qcom,pmk8002
>>             - qcom,pmk8350
>> +          - qcom,pmk8550
>>             - qcom,pmm8155au
>>             - qcom,pmp8074
>>             - qcom,pmr735a
>>             - qcom,pmr735b
>> +          - qcom,pmr735d
>>             - qcom,pms405
>>             - qcom,pmx55
>>             - qcom,pmx65
>>
  
Lee Jones Jan. 3, 2023, 11:38 a.m. UTC | #3
I changed the subject line for you.

On Fri, 18 Nov 2022, Neil Armstrong wrote:

> Document compatible for the pm8550, pm8550b, pm8550ve, pm8550vs, pmk8550.
> pm8010 & pmr735d SPMI PMICs
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)

Applied, thanks
  

Patch

diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index c8362efd4345..8c9b042b4f30 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -43,6 +43,7 @@  properties:
           - qcom,pm8004
           - qcom,pm8005
           - qcom,pm8009
+          - qcom,pm8010
           - qcom,pm8019
           - qcom,pm8028
           - qcom,pm8110
@@ -54,6 +55,10 @@  properties:
           - qcom,pm8350
           - qcom,pm8350b
           - qcom,pm8350c
+          - qcom,pm8550
+          - qcom,pm8550b
+          - qcom,pm8550ve
+          - qcom,pm8550vs
           - qcom,pm8841
           - qcom,pm8909
           - qcom,pm8916
@@ -70,10 +75,12 @@  properties:
           - qcom,pmi8998
           - qcom,pmk8002
           - qcom,pmk8350
+          - qcom,pmk8550
           - qcom,pmm8155au
           - qcom,pmp8074
           - qcom,pmr735a
           - qcom,pmr735b
+          - qcom,pmr735d
           - qcom,pms405
           - qcom,pmx55
           - qcom,pmx65