diff mbox series

[V2,1/6] dt-bindings: usb: usbmisc-imx: convert to DT schema

Message ID 20221014095148.2063669-2-peng.fan@oss.nxp.com
State New
Headers
Series dt-bindings: usb: covert ci-hdrc-usb2/usbmisc-imx to yaml |

Commit Message

Peng Fan (OSS) Oct. 14, 2022, 9:51 a.m. UTC 
  From: Peng Fan <peng.fan@nxp.com>

Convert usbmisc-imx to DT schema format.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 .../devicetree/bindings/usb/fsl,usbmisc.yaml  | 52 +++++++++++++++++++
 .../devicetree/bindings/usb/usbmisc-imx.txt   | 18 -------
 2 files changed, 52 insertions(+), 18 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
 delete mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt

Comments

Greg KH Oct. 14, 2022, 11:56 a.m. UTC | #1 
On Fri, Oct 14, 2022 at 05:51:43PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Convert usbmisc-imx to DT schema format.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  .../devicetree/bindings/usb/fsl,usbmisc.yaml  | 52 +++++++++++++++++++
>  .../devicetree/bindings/usb/usbmisc-imx.txt   | 18 -------
>  2 files changed, 52 insertions(+), 18 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
>  delete mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> 
> diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> new file mode 100644
> index 000000000000..c83ffb6729b5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/fsl,usbmisc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale i.MX non-core registers
> +
> +maintainers:
> +  - Xu Yang <xu.yang_2@nxp.com>

Signing someone else up to be a maintainer requires them to sign off on
the patch to agree with this.  Why not list yourself instead?

thanks,

greg k-h
Krzysztof Kozlowski Oct. 15, 2022, 2:53 p.m. UTC | #2 
On 14/10/2022 05:51, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Convert usbmisc-imx to DT schema format.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  .../devicetree/bindings/usb/fsl,usbmisc.yaml  | 52 +++++++++++++++++++
>  .../devicetree/bindings/usb/usbmisc-imx.txt   | 18 -------
>  2 files changed, 52 insertions(+), 18 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
>  delete mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> 
> diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> new file mode 100644
> index 000000000000..c83ffb6729b5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/fsl,usbmisc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale i.MX non-core registers

You sent v2 before we finished this topic. Is it correct? Even if TXT
had such title, let's don't keep the wrong name.

If it is non-core registers, why it is in USB? Why it is an usb-misc device?

> +
> +maintainers:
> +  - Xu Yang <xu.yang_2@nxp.com>
> +

Best regards,
Krzysztof
Peng Fan Oct. 17, 2022, 2:53 a.m. UTC | #3 
Hi Greg,

> Subject: Re: [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: convert to DT
> schema
> 
> On Fri, Oct 14, 2022 at 05:51:43PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Convert usbmisc-imx to DT schema format.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  .../devicetree/bindings/usb/fsl,usbmisc.yaml  | 52 +++++++++++++++++++
> >  .../devicetree/bindings/usb/usbmisc-imx.txt   | 18 -------
> >  2 files changed, 52 insertions(+), 18 deletions(-)  create mode
> > 100644 Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> >  delete mode 100644
> > Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> >
> > diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> > b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> > new file mode 100644
> > index 000000000000..c83ffb6729b5
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> > @@ -0,0 +1,52 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> >
> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >
> +cetree.org%2Fschemas%2Fusb%2Ffsl%2Cusbmisc.yaml%23&amp;data=05
> %7C01%7
> >
> +Cpeng.fan%40nxp.com%7C15ebc6c1040f46f3ecef08daaddafa7a%7C686ea
> 1d3bc2b
> >
> +4c6fa92cd99c5c301635%7C0%7C0%7C638013453273330209%7CUnknown
> %7CTWFpbGZ
> >
> +sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6
> Mn0%
> >
> +3D%7C3000%7C%7C%7C&amp;sdata=NZ4SFEve9DqdFVremHTDVGgrpISKyj
> yoEJKYE4sk
> > +7tA%3D&amp;reserved=0
> > +$schema:
> >
> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> > +cetree.org%2Fmeta-
> schemas%2Fcore.yaml%23&amp;data=05%7C01%7Cpeng.fan%
> >
> +40nxp.com%7C15ebc6c1040f46f3ecef08daaddafa7a%7C686ea1d3bc2b4c6f
> a92cd9
> >
> +9c5c301635%7C0%7C0%7C638013453273330209%7CUnknown%7CTWFpb
> GZsb3d8eyJWI
> >
> +joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7
> C3000%
> >
> +7C%7C%7C&amp;sdata=SYlpPoSmOQxNYaJFAlvwPQRFq0Oaugwc%2F52w6
> tvgcrk%3D&a
> > +mp;reserved=0
> > +
> > +title: Freescale i.MX non-core registers
> > +
> > +maintainers:
> > +  - Xu Yang <xu.yang_2@nxp.com>
> 
> Signing someone else up to be a maintainer requires them to sign off on the
> patch to agree with this.  Why not list yourself instead?

I am not expert in USB area. I am just convert the file to yaml to ease the upstream
of i.MX device tree.

Is it ok for for Xu Yang to Ack the patch or I must add:
Signed-off-by: Xu Yang <xu.yang_2@nxp.com> in the patch?

Thanks,
Peng.

> 
> thanks,
> 
> greg k-h
Xu Yang Oct. 17, 2022, 3:17 a.m. UTC | #4 
Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Saturday, October 15, 2022 10:53 PM
> To: Peng Fan (OSS) <peng.fan@oss.nxp.com>; gregkh@linuxfoundation.org; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org; s.hauer@pengutronix.de; Xu Yang <xu.yang_2@nxp.com>
> Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>; linux-usb@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Jun Li <jun.li@nxp.com>;
> Peng Fan <peng.fan@nxp.com>
> Subject: [EXT] Re: [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: convert to DT schema
> 
> Caution: EXT Email
> 
> On 14/10/2022 05:51, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Convert usbmisc-imx to DT schema format.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  .../devicetree/bindings/usb/fsl,usbmisc.yaml  | 52 +++++++++++++++++++
> >  .../devicetree/bindings/usb/usbmisc-imx.txt   | 18 -------
> >  2 files changed, 52 insertions(+), 18 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> >
> > diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> > new file mode 100644
> > index 000000000000..c83ffb6729b5
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> > @@ -0,0 +1,52 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fusb%2Ffsl%2Cusbmi
> sc.yaml%23&amp;data=05%7C01%7Cxu.yang_2%40nxp.com%7C24e82b830d9f47018ff408daaebcf83d%7C686ea1d3bc2b4c6
> fa92cd99c5c301635%7C0%7C0%7C638014423898086337%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoi
> V2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=gNwMbGsiuMS1zgvbgATYAY70gv2nIhX%2F
> 16IxiSYBf3s%3D&amp;reserved=0
> > +$schema: https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-
> schemas%2Fcore.yaml%23&amp;data=05%7C01%7Cxu.yang_2%40nxp.com%7C24e82b830d9f47018ff408daaebcf83d%7C68
> 6ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638014423898242035%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA
> wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=jJUP5aKNkfkAefhNQL9almV
> Gqzn8cTNyjcRlZMOZwRk%3D&amp;reserved=0
> > +
> > +title: Freescale i.MX non-core registers
> 
> You sent v2 before we finished this topic. Is it correct? Even if TXT
> had such title, let's don't keep the wrong name.
> 
> If it is non-core registers, why it is in USB? Why it is an usb-misc device?

The chipidea's doc has a more clear explanation about core and non-core
registers as follow:

"There are two kinds of registers in the USB module: USB core registers
and USB non-core registers. USB core registers are used to control USB
core functions, and more independent of USB features. Each USB controller
core has its own core registers. USB non-core registers are additional 
to USB core registers, and more dependent on USB features. i.MX series
products vary in non-core registers."

So we have named it like this. 

Thanks,
Xu Yang

> 
> > +
> > +maintainers:
> > +  - Xu Yang <xu.yang_2@nxp.com>
> > +
> 
> Best regards,
> Krzysztof
Krzysztof Kozlowski Oct. 18, 2022, 10:51 p.m. UTC | #5 
On 16/10/2022 23:17, Xu Yang wrote:
> Hi Krzysztof,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: Saturday, October 15, 2022 10:53 PM
>> To: Peng Fan (OSS) <peng.fan@oss.nxp.com>; gregkh@linuxfoundation.org; robh+dt@kernel.org;
>> krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org; s.hauer@pengutronix.de; Xu Yang <xu.yang_2@nxp.com>
>> Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>; linux-usb@vger.kernel.org;
>> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Jun Li <jun.li@nxp.com>;
>> Peng Fan <peng.fan@nxp.com>
>> Subject: [EXT] Re: [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: convert to DT schema
>>
>> Caution: EXT Email
>>
>> On 14/10/2022 05:51, Peng Fan (OSS) wrote:
>>> From: Peng Fan <peng.fan@nxp.com>
>>>
>>> Convert usbmisc-imx to DT schema format.
>>>
>>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>>> ---
>>>  .../devicetree/bindings/usb/fsl,usbmisc.yaml  | 52 +++++++++++++++++++
>>>  .../devicetree/bindings/usb/usbmisc-imx.txt   | 18 -------
>>>  2 files changed, 52 insertions(+), 18 deletions(-)
>>>  create mode 100644 Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
>>>  delete mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
>> b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
>>> new file mode 100644
>>> index 000000000000..c83ffb6729b5
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
>>> @@ -0,0 +1,52 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id:
>> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fusb%2Ffsl%2Cusbmi
>> sc.yaml%23&amp;data=05%7C01%7Cxu.yang_2%40nxp.com%7C24e82b830d9f47018ff408daaebcf83d%7C686ea1d3bc2b4c6
>> fa92cd99c5c301635%7C0%7C0%7C638014423898086337%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoi
>> V2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=gNwMbGsiuMS1zgvbgATYAY70gv2nIhX%2F
>> 16IxiSYBf3s%3D&amp;reserved=0
>>> +$schema: https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-
>> schemas%2Fcore.yaml%23&amp;data=05%7C01%7Cxu.yang_2%40nxp.com%7C24e82b830d9f47018ff408daaebcf83d%7C68
>> 6ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638014423898242035%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA
>> wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=jJUP5aKNkfkAefhNQL9almV
>> Gqzn8cTNyjcRlZMOZwRk%3D&amp;reserved=0
>>> +
>>> +title: Freescale i.MX non-core registers
>>
>> You sent v2 before we finished this topic. Is it correct? Even if TXT
>> had such title, let's don't keep the wrong name.
>>
>> If it is non-core registers, why it is in USB? Why it is an usb-misc device?
> 
> The chipidea's doc has a more clear explanation about core and non-core
> registers as follow:
> 
> "There are two kinds of registers in the USB module: USB core registers
> and USB non-core registers. USB core registers are used to control USB
> core functions, and more independent of USB features. Each USB controller
> core has its own core registers. USB non-core registers are additional 
> to USB core registers, and more dependent on USB features. i.MX series
> products vary in non-core registers."
> 
> So we have named it like this. 

"Freescale i.MX non-core registers" implies this hardware is about i.MX
registers. i.MX like for all SoCs.

What you wrote now, about USB registers - quite different.

However if you describe here registers, not some device, usually it's
place is not USB...

And actually all devices are bunch of registers, right? So everything
should be called registers?

Name is poor choice, so please find more appropriate one matching real
purpose of this block.


Best regards,
Krzysztof
Jun Li Oct. 19, 2022, 2:10 a.m. UTC | #6 
Hi,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Wednesday, October 19, 2022 6:52 AM
> To: Xu Yang <xu.yang_2@nxp.com>; Peng Fan (OSS) <peng.fan@oss.nxp.com>;
> gregkh@linuxfoundation.org; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org;
> s.hauer@pengutronix.de
> Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> <linux-imx@nxp.com>; linux-usb@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; Jun Li <jun.li@nxp.com>; Peng Fan
> <peng.fan@nxp.com>
> Subject: Re: [EXT] Re: [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: convert
> to DT schema
> 
> On 16/10/2022 23:17, Xu Yang wrote:
> > Hi Krzysztof,
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> Sent: Saturday, October 15, 2022 10:53 PM
> >> To: Peng Fan (OSS) <peng.fan@oss.nxp.com>;
> >> gregkh@linuxfoundation.org; robh+dt@kernel.org;
> >> krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org;
> >> s.hauer@pengutronix.de; Xu Yang <xu.yang_2@nxp.com>
> >> Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> >> <linux-imx@nxp.com>; linux-usb@vger.kernel.org;
> >> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> >> linux-arm-kernel@lists.infradead.org; Jun Li <jun.li@nxp.com>; Peng
> >> Fan <peng.fan@nxp.com>
> >> Subject: [EXT] Re: [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx:
> >> convert to DT schema
> >>
> >> Caution: EXT Email
> >>
> >> On 14/10/2022 05:51, Peng Fan (OSS) wrote:
> >>> From: Peng Fan <peng.fan@nxp.com>
> >>>
> >>> Convert usbmisc-imx to DT schema format.
> >>>
> >>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> >>> ---
> >>>  .../devicetree/bindings/usb/fsl,usbmisc.yaml  | 52
> +++++++++++++++++++
> >>>  .../devicetree/bindings/usb/usbmisc-imx.txt   | 18 -------
> >>>  2 files changed, 52 insertions(+), 18 deletions(-)  create mode
> >>> 100644 Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> >>>  delete mode 100644
> >>> Documentation/devicetree/bindings/usb/usbmisc-imx.txt
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> >> b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> >>> new file mode 100644
> >>> index 000000000000..c83ffb6729b5
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
> >>> @@ -0,0 +1,52 @@
> >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> >>> +---
> >>> +$id:
> >>
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >>
> cetree.org%2Fschemas%2Fusb%2Ffsl%2Cusbmi&amp;data=05%7C01%7Cjun.li%40
> >>
> nxp.com%7C15ee8a29acf04f95ff4108dab15b5b88%7C686ea1d3bc2b4c6fa92cd99c
> >>
> 5c301635%7C0%7C0%7C638017303177794862%7CUnknown%7CTWFpbGZsb3d8eyJWIjo
> >>
> iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
> >> %7C%7C&amp;sdata=tovO%2F6fnxAMSUu9hTFv1Kgarmo%2BwxKCxS%2FeJAbt3e0k%3
> D
> >> &amp;reserved=0
> >>
> sc.yaml%23&amp;data=05%7C01%7Cxu.yang_2%40nxp.com%7C24e82b830d9f47018
> >> ff408daaebcf83d%7C686ea1d3bc2b4c6
> >>
> fa92cd99c5c301635%7C0%7C0%7C638014423898086337%7CUnknown%7CTWFpbGZsb3
> >> d8eyJWIjoiMC4wLjAwMDAiLCJQIjoi
> >>
> V2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=gNwM
> >> bGsiuMS1zgvbgATYAY70gv2nIhX%2F
> >> 16IxiSYBf3s%3D&amp;reserved=0
> >>> +$schema:
> >>>
> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fde
> >>>
> +vicetree.org%2Fmeta-&amp;data=05%7C01%7Cjun.li%40nxp.com%7C15ee8a29
> >>>
> +acf04f95ff4108dab15b5b88%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> >>>
> +%7C638017303177794862%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiL
> >>>
> +CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;s
> >>>
> +data=NxKdgHlJ9q%2F82XtXwWxHf5UFJR3v08L83jomQxg3Blo%3D&amp;reserved=
> >>> +0
> >>
> schemas%2Fcore.yaml%23&amp;data=05%7C01%7Cxu.yang_2%40nxp.com%7C24e82
> >> b830d9f47018ff408daaebcf83d%7C68
> >>
> 6ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638014423898242035%7CUnknown
> >> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjA
> >>
> wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&a
> >> mp;sdata=jJUP5aKNkfkAefhNQL9almV
> >> Gqzn8cTNyjcRlZMOZwRk%3D&amp;reserved=0
> >>> +
> >>> +title: Freescale i.MX non-core registers
> >>
> >> You sent v2 before we finished this topic. Is it correct? Even if TXT
> >> had such title, let's don't keep the wrong name.
> >>
> >> If it is non-core registers, why it is in USB? Why it is an usb-misc device?
> >
> > The chipidea's doc has a more clear explanation about core and
> > non-core registers as follow:
> >
> > "There are two kinds of registers in the USB module: USB core
> > registers and USB non-core registers. USB core registers are used to
> > control USB core functions, and more independent of USB features. Each
> > USB controller core has its own core registers. USB non-core registers
> > are additional to USB core registers, and more dependent on USB
> > features. i.MX series products vary in non-core registers."
> >
> > So we have named it like this.
> 
> "Freescale i.MX non-core registers" implies this hardware is about i.MX
> registers. i.MX like for all SoCs.
> 
> What you wrote now, about USB registers - quite different.
> 
> However if you describe here registers, not some device, usually it's place
> is not USB...
> 
> And actually all devices are bunch of registers, right? So everything should
> be called registers?
> 
> Name is poor choice, so please find more appropriate one matching real purpose
> of this block.

How about "Freescale i.MX wrapper module for Chipidea USB2 controller"

Thanks
Li Jun
> 
> 
> Best regards,
> Krzysztof
Krzysztof Kozlowski Oct. 19, 2022, 2:16 a.m. UTC | #7 
On 18/10/2022 22:10, Jun Li wrote:
>>> So we have named it like this.
>>
>> "Freescale i.MX non-core registers" implies this hardware is about i.MX
>> registers. i.MX like for all SoCs.
>>
>> What you wrote now, about USB registers - quite different.
>>
>> However if you describe here registers, not some device, usually it's place
>> is not USB...
>>
>> And actually all devices are bunch of registers, right? So everything should
>> be called registers?
>>
>> Name is poor choice, so please find more appropriate one matching real purpose
>> of this block.
> 
> How about "Freescale i.MX wrapper module for Chipidea USB2 controller"
> 

Sounds very good, thank you.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
new file mode 100644
index 000000000000..c83ffb6729b5
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml
@@ -0,0 +1,52 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/fsl,usbmisc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale i.MX non-core registers
+
+maintainers:
+  - Xu Yang <xu.yang_2@nxp.com>
+
+properties:
+  compatible:
+    oneOf:
+      - enum:
+          - fsl,imx6q-usbmisc
+          - fsl,imx7ulp-usbmisc
+          - fsl,vf610-usbmisc
+      - items:
+          - enum:
+              - fsl,imx6ul-usbmisc
+              - fsl,imx6sx-usbmisc
+              - fsl,imx7d-usbmisc
+          - const: fsl,imx6q-usbmisc
+      - items:
+          - enum:
+              - fsl,imx7ulp-usbmisc
+          - const: fsl,imx7d-usbmisc
+
+  reg:
+    maxItems: 1
+
+  '#index-cells':
+    const: 1
+    description: Cells used to describe usb controller index.
+
+required:
+  - compatible
+  - reg
+  - '#index-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+    usbmisc@2184800 {
+        #index-cells = <1>;
+        compatible = "fsl,imx6q-usbmisc";
+        reg = <0x02184800 0x200>;
+    };
+
+...
diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
deleted file mode 100644
index b796836d2ce7..000000000000
--- a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
+++ /dev/null
@@ -1,18 +0,0 @@ 
-* Freescale i.MX non-core registers
-
-Required properties:
-- #index-cells: Cells used to describe usb controller index. Should be <1>
-- compatible: Should be one of below:
-	"fsl,imx6q-usbmisc" for imx6q
-	"fsl,vf610-usbmisc" for Vybrid vf610
-	"fsl,imx6sx-usbmisc" for imx6sx
-	"fsl,imx7d-usbmisc" for imx7d
-	"fsl,imx7ulp-usbmisc" for imx7ulp
-- reg: Should contain registers location and length
-
-Examples:
-usbmisc@2184800 {
-	#index-cells = <1>;
-	compatible = "fsl,imx6q-usbmisc";
-	reg = <0x02184800 0x200>;
-};