| Message ID | 20221229181526.53766-6-samuel@sholland.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2529990wrt;
Thu, 29 Dec 2022 10:17:03 -0800 (PST)
X-Google-Smtp-Source:
AMrXdXsHPIJwdx94YHjpBhz13vL33Cn4e4B3QzpcBfbeqoLNN8tp8OopZ2Jp+dP0Dj1VMHkoSiHc
X-Received: by 2002:a62:3883:0:b0:580:b942:e85 with SMTP id
f125-20020a623883000000b00580b9420e85mr22186023pfa.16.1672337822923;
Thu, 29 Dec 2022 10:17:02 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1672337822; cv=none;
d=google.com; s=arc-20160816;
b=A6DnKGmaBullDj5JrB3jXnDjvB41wmFVyzt0MXz93INN73l9jcUn0coRW43UUYuipO
89C+fDkgmwaY6sygfDynLlQKk/FHM15vVZi5D5ZpuJlEMNm1pQpEczkrA/FCGfskegrz
aq2/92Iwz1eU+kOkWaK1FK+lUEpLRhJ5aLhU3NC78mJTvTnInYsI9vIrXhA5uxIX9ZvS
E46hpIrlWn3+yHpYCAreieHnShR/6jAekq2PAl1hvkG5zmFnsROXv/eX3A2c0/ACjAkO
hBElsK6ZZsfKmAJ1dW/AF02vmCWvWM0LG84zyWYdfFW/yv4FOVgukfhsltfksLLETsX6
PM5Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:feedback-id:dkim-signature:dkim-signature;
bh=pVPQa7Oa9NfFrWw4kM0RTohv+m63gRRiGiW2YrMQGls=;
b=kdDR8Lh0KZ/Ylb8UA8+QvORTmqp6F0gAJNXbdfhPUBOJwbWKlPSl7F4x1PJhMwF5Xf
QLDGaddqHYzRCVNs5nDuVP4QgSnv9s8BexA+lSEG3fMKHcBi6OelO8Aka9toKkDN7nFk
gUxyKa5eHRdZQz5wJGl67KG6g9AeErz2n5VGK2wdkdT8KueZDW7Ow+kSOrDzowdsq8rE
4EnVHXdzPrsFBzeqb/ittr/cjBgUrhHcLM/QaBL58elQUg3U4fpJWTMCr2cM8cJ05H6l
6v0ug+bkNgIaONv/w5WIDSOPD8s++FFfHqyHRQ76QVDnE0TM3V0AoKw2cWLEuCW04l1J
XQSg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@sholland.org header.s=fm3 header.b=T7T2dv2F;
dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=rqn5MVdn;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sholland.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
f2-20020a056a00238200b00576cd9398e7si19608605pfc.1.2022.12.29.10.16.51;
Thu, 29 Dec 2022 10:17:02 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@sholland.org header.s=fm3 header.b=T7T2dv2F;
dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=rqn5MVdn;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sholland.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S233907AbiL2SQA (ORCPT <rfc822;eddaouddi.ayoub@gmail.com>
+ 99 others); Thu, 29 Dec 2022 13:16:00 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41066 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S233940AbiL2SPp (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 29 Dec 2022 13:15:45 -0500
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
[64.147.123.25])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A0A1C27
for <linux-kernel@vger.kernel.org>;
Thu, 29 Dec 2022 10:15:44 -0800 (PST)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
by mailout.west.internal (Postfix) with ESMTP id 46E033200909;
Thu, 29 Dec 2022 13:15:43 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
by compute5.internal (MEProxy); Thu, 29 Dec 2022 13:15:44 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h=
cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to
:in-reply-to:message-id:mime-version:references:reply-to:sender
:subject:subject:to:to; s=fm3; t=1672337741; x=1672424141; bh=pV
PQa7Oa9NfFrWw4kM0RTohv+m63gRRiGiW2YrMQGls=; b=T7T2dv2FzNpv6Y1oXC
VKoZn8SgpVp7BdsTqlXkXUv5qY/hBC5D3CZl9W4ooEO2TTbdtcMVCl9h+t8DfOjl
kHGs0eX+YSAFhbiybAd1wi4dy+2EKQ3+TmJiV1m/hMB7E/mEmoNRqjkprPDuVvbV
sAOOUo22SPTyJRJGVTs4Ih1HeK6VA2ZnOlai3givXQDoeZlbimA8nMaYYPS1lBzf
LenoTfnBO2Yn0/Umez2HX4QNk6SJ3TuUBCl7WpWh8Nu9BLDr6vmQfzAgs+8B8f0D
gSbPcZBmya/vPN/TZg50jhy1XctvhHPehiK3QLpy/KbGy7Ivu6O/fiiJ79zGf4e6
Q6GQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding:date:date
:feedback-id:feedback-id:from:from:in-reply-to:in-reply-to
:message-id:mime-version:references:reply-to:sender:subject
:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; t=1672337741; x=1672424141; bh=pVPQa7Oa9NfFr
Ww4kM0RTohv+m63gRRiGiW2YrMQGls=; b=rqn5MVdneV1TUbiOZC/jhWTOKZcSB
Ru9uu0CwSsZHbzL6UabABW1+oWuwz+awkLUfbI8wG1DixZseEBmIszlAsOBNeJQt
+NypcQy+Hv3+tS8vo1X3YFwpQTQDbNegHQMEozKXa5Qcr/GFTG5ABzp0EHDevjYD
9NceDBOPUY2i5Y1VTFSuL9AsLk/J67E+DRSpgDMUdirj248v1AM5BQMRWUqb+GdJ
AjciLSO+87PYviJOz4B+djZGKSqIeekBuJToXYQztdvqWkg0GS3RVvGAxDMpgDDm
833MgTiUfDzLuoXj5CgQ/wMK2XIPE+cOed+wqM6KyH6BDgRd+eXclVpLg==
X-ME-Sender: <xms:TdmtYyE8Gw-37qTKUZgjdRjVCAMuMz3Ga69ZPmMsEK9pbm2Df65Pmw>
<xme:TdmtYzVcADvw5p7gzA0WMFKBRGEpVwvEijVdBgE4SwIceH5hiRQke_LEDVx3Voe0e
6YsiBqde61qnnLEzg>
X-ME-Received:
<xmr:TdmtY8I4O2B6lUt6y6fU7j2kpKrX6_XT5KIruhMlUN1VdGuXUfot0m9pIABAp2E4SRQbs9O6rLDI6RGGTLJUYjOpLUxWyM-hRJc-Q_3EpC0OUCNLuOCze1apzCeqSiBq0MGWLA>
X-ME-Proxy-Cause:
gggruggvucftvghtrhhoucdtuddrgedvhedrieeggdduuddtucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepufgrmhhu
vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg
ftrfgrthhtvghrnhepudekteeuudehtdelteevgfduvddvjefhfedulefgudevgeeghefg
udefiedtveetnecuvehluhhsthgvrhfuihiivgepvdenucfrrghrrghmpehmrghilhhfrh
homhepshgrmhhuvghlsehshhholhhlrghnugdrohhrgh
X-ME-Proxy: <xmx:TdmtY8Hi8AF0hrL1-fPVxmAvyr0J4Vu9AuDBsh7lixrpBAY7TVV3MA>
<xmx:TdmtY4W2eeMxUWl94MXH_LZ0xc7YdCmZO5DYpxujBC4npxJ2rrwSpQ>
<xmx:TdmtY_PQUE5RPLVFd0_wxMbfhiRo648OWvULdd95oT1R0hVUElz_Qw>
<xmx:TdmtYxP0_tkjYEFjfnvRBKSP2WJBpsxW0GMwXpaelX4YJs1mwUN5Mg>
Feedback-ID: i0ad843c9:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
29 Dec 2022 13:15:41 -0500 (EST)
From: Samuel Holland <samuel@sholland.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Boris Brezillon <bbrezillon@kernel.org>,
Samuel Holland <samuel@sholland.org>,
Brian Norris <computersforpeace@gmail.com>,
linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, linux-sunxi@lists.linux.dev
Subject: [PATCH 5/7] mtd: rawnand: sunxi: Fix the size of the last OOB region
Date: Thu, 29 Dec 2022 12:15:24 -0600
Message-Id: <20221229181526.53766-6-samuel@sholland.org>
X-Mailer: git-send-email 2.37.4
In-Reply-To: <20221229181526.53766-1-samuel@sholland.org>
References: <20221229181526.53766-1-samuel@sholland.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1753573305035076315?=
X-GMAIL-MSGID: =?utf-8?q?1753573305035076315?=
|
| Series |
mtd: rawnand: sunxi: Bug fixes and cleanup
|
|
Commit Message
Samuel Holland
Dec. 29, 2022, 6:15 p.m. UTC
The previous code assigned to the wrong structure member.
Fixes: c66811e6d350 ("mtd: nand: sunxi: switch to mtd_ooblayout_ops")
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
drivers/mtd/nand/raw/sunxi_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 12/29/2022 11:45 PM, Samuel Holland wrote: > The previous code assigned to the wrong structure member. Good catch! > > Fixes: c66811e6d350 ("mtd: nand: sunxi: switch to mtd_ooblayout_ops") > Signed-off-by: Samuel Holland <samuel@sholland.org> > --- Acked-By: Dhruva Gole <d-gole@ti.com> > > drivers/mtd/nand/raw/sunxi_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c > index 1ecf2cee343b..8e873f4fec9a 100644 > --- a/drivers/mtd/nand/raw/sunxi_nand.c > +++ b/drivers/mtd/nand/raw/sunxi_nand.c > @@ -1609,7 +1609,7 @@ static int sunxi_nand_ooblayout_free(struct mtd_info *mtd, int section, > if (section < ecc->steps) > oobregion->length = 4; > else > - oobregion->offset = mtd->oobsize - oobregion->offset; > + oobregion->length = mtd->oobsize - oobregion->offset; > > return 0; > }
On Thu, 2022-12-29 at 18:15:24 UTC, Samuel Holland wrote: > The previous code assigned to the wrong structure member. > > Fixes: c66811e6d350 ("mtd: nand: sunxi: switch to mtd_ooblayout_ops") > Signed-off-by: Samuel Holland <samuel@sholland.org> > Acked-By: Dhruva Gole <d-gole@ti.com> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel
diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c index 1ecf2cee343b..8e873f4fec9a 100644 --- a/drivers/mtd/nand/raw/sunxi_nand.c +++ b/drivers/mtd/nand/raw/sunxi_nand.c @@ -1609,7 +1609,7 @@ static int sunxi_nand_ooblayout_free(struct mtd_info *mtd, int section, if (section < ecc->steps) oobregion->length = 4; else - oobregion->offset = mtd->oobsize - oobregion->offset; + oobregion->length = mtd->oobsize - oobregion->offset; return 0; }