Message ID | 724e92e64e6d91d48d762e804b430c716679bccb.1672062380.git.ang.iglesiasg@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp940133wrt; Mon, 26 Dec 2022 06:34:12 -0800 (PST) X-Google-Smtp-Source: AMrXdXsFgSP2twak2jT2d7bNumzJDgKBEMQ7xyRUIhCWmhMNCrXTvuISRBRIqUG/WD8deQHz2o7S X-Received: by 2002:a05:6402:1cce:b0:472:1b3b:35f1 with SMTP id ds14-20020a0564021cce00b004721b3b35f1mr20317914edb.21.1672065251908; Mon, 26 Dec 2022 06:34:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672065251; cv=none; d=google.com; s=arc-20160816; b=sURU5veWLBm94PBGLpoH8N9GhDxXTvNi4t/ogATxYoHxPywVZCm7/OPkY3cZgsuiRX 3OhP5dzYuJPlWJ18grDoVf9b0IUd3XqYYoo9kgmQz0dakn4ky0PQ4xg55T6pLvOPg1U5 jBjin/7M3iITkcHwSatxAW92lpKbF+aTa4aSbOxv1ClFOENc0NbidaJe0FVzYA4ZEzoV et1tY+XGIv7+m/obdYIhkL3ueqOGKLnIRks8XcAqoBW2X2XTgpdpEn4tkXzGd6Zp80xb eHS5ACxiO3zgtQ4BGWg/flEn4PB546Qbdx9OX5KdD2lt6nXDMAqgDlPyYGFg7kVMlsEk pRmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=I+RDFj6BpHhJ2bFeylBpDtFtMyr1ovdocCHUnTCQ0GU=; b=WlM9aNr/8aiHWJWvA+ub2tODNvg2GasmGrOtcdoeL80JQOzESyYDsc2yYsQCNWeEUf +1Y89nBPNXDZltzMWJa/uOeKXPcXmsx6867P6AVbF8PC4kNY8rNKi58ET3Q0SGiPpiPI 6Hz2n7WDepEGjk2C6FG7auxuLssv2SgNjIyJtCYSCuD+Wbjgeq4LgbTQxXBETfGuMAFP JoA/j7AvOjLjbB1PfF0WTAt90u+8MsXV80UsqIQfKkepjzn8wyWPynV/jNzlluEE+Hua 3Sxcy5QnewQ1ntETjouatl+b1FEVZ33nHYLfU1FbbcLszzRZgK6xCm+qJIVutmd1NFLW HZlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=R+RbaKWc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y21-20020a50e615000000b0046adf195ec4si8296041edm.343.2022.12.26.06.33.46; Mon, 26 Dec 2022 06:34:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=R+RbaKWc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230313AbiLZOcM (ORCPT <rfc822;eddaouddi.ayoub@gmail.com> + 99 others); Mon, 26 Dec 2022 09:32:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232227AbiLZOcB (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 26 Dec 2022 09:32:01 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A693F37; Mon, 26 Dec 2022 06:32:00 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id k22-20020a05600c1c9600b003d1ee3a6289so7597556wms.2; Mon, 26 Dec 2022 06:32:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I+RDFj6BpHhJ2bFeylBpDtFtMyr1ovdocCHUnTCQ0GU=; b=R+RbaKWcEPEaEJRWYAOfU62ZnTF43IYlLUI+l7k5l0mbGpzMevRNvBGKxH6CtmU72L p0sGXZpRA1o+ESMmXCb2eWhwn//uDjyvQcukA+j9ZfJuKuFLsDWJIWwy/oq57pZmUd6j dtQw8+hQ8pgDVGUpq1U/VnJW7Rs5DSToYw1sroK64yoNOLgs+8MJ2GaKHj+7IHSOeLGd xZln/5HqQtrMbHF4+kw4qaS5QkK6ZLVDRXZ/hJP3LoIF7/Bya4u9YvNBrZRq5QygKD9v /w94QlbbYIhqSssg9Easny8lc4gC2dePdnbkVF2sugG5ypz9wu3fPQ6PDMuRjyy6nORP LVcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I+RDFj6BpHhJ2bFeylBpDtFtMyr1ovdocCHUnTCQ0GU=; b=q58PXCJhivIcnRqpC/2s3xyxW9GQ/LVLktnbaXM7Q3mfEvOZ2VrGPZ2IX575peGukv u0s/GdnQqsYS6xehispY6XgfkAtKL0y2OBZAb8wZ7DSg5obggj9pD0GJdU9jJ3oklbat Lgyxo1AsYmin0UVEzEVn+lTiTC+MEXt2SbUo0FtQC2kDXH4f9OtDO4X5BuadaHl6fF4c xgJjDJ1PIRYtGGT8W0isX1UkItzHW+CiJrC1Lq8juHzXKjJETMC/lFliNSYI8FyxrPBq 05e/FAZ01GB0Q6pMKaVIaG2Fbc2D9x2cjTr2GIa/lx5Z9Jips611zNA0L/WQ22q194z0 2k8w== X-Gm-Message-State: AFqh2kojEdvpiHICzRElxq26TEzaWf8tj07mrEBvTcqMl7VACAdarm6Z YvVx7Ex2gm+zNQsT105jTItcRT9YlmY= X-Received: by 2002:a05:600c:538a:b0:3d9:67e3:87d3 with SMTP id hg10-20020a05600c538a00b003d967e387d3mr12728605wmb.25.1672065118652; Mon, 26 Dec 2022 06:31:58 -0800 (PST) Received: from localhost.localdomain (188.red-83-35-57.dynamicip.rima-tde.net. [83.35.57.188]) by smtp.gmail.com with ESMTPSA id c4-20020a05600c0a4400b003cf75213bb9sm21511754wmq.8.2022.12.26.06.31.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Dec 2022 06:31:58 -0800 (PST) From: Angel Iglesias <ang.iglesiasg@gmail.com> To: linux-iio@vger.kernel.org Cc: Angel Iglesias <ang.iglesiasg@gmail.com>, Jonathan Cameron <jic23@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Nikita Yushchenko <nikita.yoush@cogentembedded.com>, Paul Cercueil <paul@crapouillou.net>, Ulf Hansson <ulf.hansson@linaro.org>, "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, Andreas Klinger <ak@it-klinger.de>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/5] iio: pressure: bmp280: Add preinit callback Date: Mon, 26 Dec 2022 15:29:21 +0100 Message-Id: <724e92e64e6d91d48d762e804b430c716679bccb.1672062380.git.ang.iglesiasg@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <cover.1672062380.git.ang.iglesiasg@gmail.com> References: <cover.1672062380.git.ang.iglesiasg@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753287493602654098?= X-GMAIL-MSGID: =?utf-8?q?1753287493602654098?= |
Series |
Add support for pressure sensor Bosch BMP580
|
|
Commit Message
Angel Iglesias
Dec. 26, 2022, 2:29 p.m. UTC
Adds preinit callback to execute operations on probe before applying
initial configuration.
Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>
Comments
On Mon, Dec 26, 2022 at 03:29:21PM +0100, Angel Iglesias wrote: > Adds preinit callback to execute operations on probe before applying > initial configuration. ... > @@ -935,6 +936,7 @@ static const struct bmp280_chip_info bmp280_chip_info = { > .read_temp = bmp280_read_temp, > .read_press = bmp280_read_press, > .read_calib = bmp280_read_calib, > + .preinit = NULL, > }; > > static int bme280_chip_config(struct bmp280_data *data) > @@ -979,6 +981,7 @@ static const struct bmp280_chip_info bme280_chip_info = { > .read_press = bmp280_read_press, > .read_humid = bmp280_read_humid, > .read_calib = bme280_read_calib, > + .preinit = NULL, > }; Useless changes. ... > @@ -1604,6 +1614,7 @@ static const struct bmp280_chip_info bmp180_chip_info = { > .read_temp = bmp180_read_temp, > .read_press = bmp180_read_press, > .read_calib = bmp180_read_calib, > + .preinit = NULL, > }; Ditto. ... > + /* > + * Some chips like the BMP3xx have preinit tasks to run > + * before applying the initial configuration. > + */ > + if (data->chip_info->preinit) { > + ret = data->chip_info->preinit(data); > + dev_err(dev, "error running preinit tasks"); Huh?! I guess you wanted > if (ret < 0) > return ret; if (ret < 0) return dev_err_probe(...); > }
On Mon, 26 Dec 2022 15:29:21 +0100 Angel Iglesias <ang.iglesiasg@gmail.com> wrote: > Adds preinit callback to execute operations on probe before applying > initial configuration. > > Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com> > > diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c > index 46959a91408f..c37cf2caec68 100644 > --- a/drivers/iio/pressure/bmp280-core.c > +++ b/drivers/iio/pressure/bmp280-core.c > @@ -217,6 +217,7 @@ struct bmp280_chip_info { > int (*read_press)(struct bmp280_data *, int *, int *); > int (*read_humid)(struct bmp280_data *, int *, int *); > int (*read_calib)(struct bmp280_data *); > + int (*preinit)(struct bmp280_data *); > }; > > /* > @@ -935,6 +936,7 @@ static const struct bmp280_chip_info bmp280_chip_info = { > .read_temp = bmp280_read_temp, > .read_press = bmp280_read_press, > .read_calib = bmp280_read_calib, > + .preinit = NULL, C standard guarantees those are set to NULL anyway + the default is obvious. Hence don't set them to NULL, just leave the automatic initialization of unspecified structure elements to handle it for you. > }; > > static int bme280_chip_config(struct bmp280_data *data) > @@ -979,6 +981,7 @@ static const struct bmp280_chip_info bme280_chip_info = { > .read_press = bmp280_read_press, > .read_humid = bmp280_read_humid, > .read_calib = bme280_read_calib, > + .preinit = NULL, > }; > > /* > @@ -1220,6 +1223,12 @@ static const int bmp380_odr_table[][2] = { > [BMP380_ODR_0_0015HZ] = {0, 1526}, > }; > > +static int bmp380_preinit(struct bmp280_data *data) > +{ > + /* BMP3xx requires soft-reset as part of initialization */ > + return bmp380_cmd(data, BMP380_CMD_SOFT_RESET); > +} > + > static int bmp380_chip_config(struct bmp280_data *data) > { > bool change = false, aux; > @@ -1349,6 +1358,7 @@ static const struct bmp280_chip_info bmp380_chip_info = { > .read_temp = bmp380_read_temp, > .read_press = bmp380_read_press, > .read_calib = bmp380_read_calib, > + .preinit = bmp380_preinit, > }; > > static int bmp180_measure(struct bmp280_data *data, u8 ctrl_meas) > @@ -1604,6 +1614,7 @@ static const struct bmp280_chip_info bmp180_chip_info = { > .read_temp = bmp180_read_temp, > .read_press = bmp180_read_press, > .read_calib = bmp180_read_calib, > + .preinit = NULL, > }; > > static irqreturn_t bmp085_eoc_irq(int irq, void *d) > @@ -1762,9 +1773,13 @@ int bmp280_common_probe(struct device *dev, > return -EINVAL; > } > > - /* BMP3xx requires soft-reset as part of initialization */ > - if (chip_id == BMP380_CHIP_ID) { > - ret = bmp380_cmd(data, BMP380_CMD_SOFT_RESET); > + /* > + * Some chips like the BMP3xx have preinit tasks to run > + * before applying the initial configuration. > + */ I would drop this comment. It's kind of obvious that some devices need you to call something here - otherwise why have the clearly optional callback? The specific BMP3xx requirements are well commented in your new callback above so don't want to be here as well. > + if (data->chip_info->preinit) { > + ret = data->chip_info->preinit(data); > + dev_err(dev, "error running preinit tasks"); Error message printed on success... > if (ret < 0) > return ret; return dev_err_probe(dev, ret, "error running preinit tasks"); > }
On Tue, 2022-12-27 at 23:41 +0200, Andy Shevchenko wrote: > On Mon, Dec 26, 2022 at 03:29:21PM +0100, Angel Iglesias wrote: > > Adds preinit callback to execute operations on probe before applying > > initial configuration. > > ... > > > @@ -935,6 +936,7 @@ static const struct bmp280_chip_info bmp280_chip_info = > > { > > .read_temp = bmp280_read_temp, > > .read_press = bmp280_read_press, > > .read_calib = bmp280_read_calib, > > + .preinit = NULL, > > }; > > > > static int bme280_chip_config(struct bmp280_data *data) > > @@ -979,6 +981,7 @@ static const struct bmp280_chip_info bme280_chip_info = > > { > > .read_press = bmp280_read_press, > > .read_humid = bmp280_read_humid, > > .read_calib = bme280_read_calib, > > + .preinit = NULL, > > }; > > Useless changes. > > ... > > > @@ -1604,6 +1614,7 @@ static const struct bmp280_chip_info bmp180_chip_info > > = { > > .read_temp = bmp180_read_temp, > > .read_press = bmp180_read_press, > > .read_calib = bmp180_read_calib, > > + .preinit = NULL, > > }; > > Ditto. > > ... > > > + /* > > + * Some chips like the BMP3xx have preinit tasks to run > > + * before applying the initial configuration. > > + */ > > + if (data->chip_info->preinit) { > > + ret = data->chip_info->preinit(data); > > > + dev_err(dev, "error running preinit tasks"); > > Huh?! I guess you wanted The dangers of copying paste and rushing things etc. Sorry for this brain fart! Thanks for your time, Angel > > if (ret < 0) > > return ret; > > if (ret < 0) > return dev_err_probe(...); > > > } >
On Fri, 2022-12-30 at 18:18 +0000, Jonathan Cameron wrote: > On Mon, 26 Dec 2022 15:29:21 +0100 > Angel Iglesias <ang.iglesiasg@gmail.com> wrote: > > > Adds preinit callback to execute operations on probe before applying > > initial configuration. > > > > Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com> > > > > diff --git a/drivers/iio/pressure/bmp280-core.c > > b/drivers/iio/pressure/bmp280-core.c > > index 46959a91408f..c37cf2caec68 100644 > > --- a/drivers/iio/pressure/bmp280-core.c > > +++ b/drivers/iio/pressure/bmp280-core.c > > @@ -217,6 +217,7 @@ struct bmp280_chip_info { > > int (*read_press)(struct bmp280_data *, int *, int *); > > int (*read_humid)(struct bmp280_data *, int *, int *); > > int (*read_calib)(struct bmp280_data *); > > + int (*preinit)(struct bmp280_data *); > > }; > > > > /* > > @@ -935,6 +936,7 @@ static const struct bmp280_chip_info bmp280_chip_info = > > { > > .read_temp = bmp280_read_temp, > > .read_press = bmp280_read_press, > > .read_calib = bmp280_read_calib, > > + .preinit = NULL, > C standard guarantees those are set to NULL anyway + the default is obvious. > Hence don't set them to NULL, just leave the automatic initialization of > unspecified structure elements to handle it for you. OK! Note to self: compiler knows best! > > }; > > > > static int bme280_chip_config(struct bmp280_data *data) > > @@ -979,6 +981,7 @@ static const struct bmp280_chip_info bme280_chip_info = > > { > > .read_press = bmp280_read_press, > > .read_humid = bmp280_read_humid, > > .read_calib = bme280_read_calib, > > + .preinit = NULL, > > }; > > > > /* > > @@ -1220,6 +1223,12 @@ static const int bmp380_odr_table[][2] = { > > [BMP380_ODR_0_0015HZ] = {0, 1526}, > > }; > > > > +static int bmp380_preinit(struct bmp280_data *data) > > +{ > > + /* BMP3xx requires soft-reset as part of initialization */ > > + return bmp380_cmd(data, BMP380_CMD_SOFT_RESET); > > +} > > + > > static int bmp380_chip_config(struct bmp280_data *data) > > { > > bool change = false, aux; > > @@ -1349,6 +1358,7 @@ static const struct bmp280_chip_info bmp380_chip_info > > = { > > .read_temp = bmp380_read_temp, > > .read_press = bmp380_read_press, > > .read_calib = bmp380_read_calib, > > + .preinit = bmp380_preinit, > > }; > > > > static int bmp180_measure(struct bmp280_data *data, u8 ctrl_meas) > > @@ -1604,6 +1614,7 @@ static const struct bmp280_chip_info bmp180_chip_info > > = { > > .read_temp = bmp180_read_temp, > > .read_press = bmp180_read_press, > > .read_calib = bmp180_read_calib, > > + .preinit = NULL, > > }; > > > > static irqreturn_t bmp085_eoc_irq(int irq, void *d) > > @@ -1762,9 +1773,13 @@ int bmp280_common_probe(struct device *dev, > > return -EINVAL; > > } > > > > - /* BMP3xx requires soft-reset as part of initialization */ > > - if (chip_id == BMP380_CHIP_ID) { > > - ret = bmp380_cmd(data, BMP380_CMD_SOFT_RESET); > > + /* > > + * Some chips like the BMP3xx have preinit tasks to run > > + * before applying the initial configuration. > > + */ > I would drop this comment. It's kind of obvious that some devices need you > to call something here - otherwise why have the clearly optional callback? > The specific BMP3xx requirements are well commented in your new callback above > so don't want to be here as well. > > > + if (data->chip_info->preinit) { > > + ret = data->chip_info->preinit(data); > > + dev_err(dev, "error running preinit tasks"); > > Error message printed on success... Yup, sorry about that... > > > if (ret < 0) > > return ret; > > return dev_err_probe(dev, ret, "error running preinit > tasks"); > > > } > Thanks for your time! Angel
diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c index 46959a91408f..c37cf2caec68 100644 --- a/drivers/iio/pressure/bmp280-core.c +++ b/drivers/iio/pressure/bmp280-core.c @@ -217,6 +217,7 @@ struct bmp280_chip_info { int (*read_press)(struct bmp280_data *, int *, int *); int (*read_humid)(struct bmp280_data *, int *, int *); int (*read_calib)(struct bmp280_data *); + int (*preinit)(struct bmp280_data *); }; /* @@ -935,6 +936,7 @@ static const struct bmp280_chip_info bmp280_chip_info = { .read_temp = bmp280_read_temp, .read_press = bmp280_read_press, .read_calib = bmp280_read_calib, + .preinit = NULL, }; static int bme280_chip_config(struct bmp280_data *data) @@ -979,6 +981,7 @@ static const struct bmp280_chip_info bme280_chip_info = { .read_press = bmp280_read_press, .read_humid = bmp280_read_humid, .read_calib = bme280_read_calib, + .preinit = NULL, }; /* @@ -1220,6 +1223,12 @@ static const int bmp380_odr_table[][2] = { [BMP380_ODR_0_0015HZ] = {0, 1526}, }; +static int bmp380_preinit(struct bmp280_data *data) +{ + /* BMP3xx requires soft-reset as part of initialization */ + return bmp380_cmd(data, BMP380_CMD_SOFT_RESET); +} + static int bmp380_chip_config(struct bmp280_data *data) { bool change = false, aux; @@ -1349,6 +1358,7 @@ static const struct bmp280_chip_info bmp380_chip_info = { .read_temp = bmp380_read_temp, .read_press = bmp380_read_press, .read_calib = bmp380_read_calib, + .preinit = bmp380_preinit, }; static int bmp180_measure(struct bmp280_data *data, u8 ctrl_meas) @@ -1604,6 +1614,7 @@ static const struct bmp280_chip_info bmp180_chip_info = { .read_temp = bmp180_read_temp, .read_press = bmp180_read_press, .read_calib = bmp180_read_calib, + .preinit = NULL, }; static irqreturn_t bmp085_eoc_irq(int irq, void *d) @@ -1762,9 +1773,13 @@ int bmp280_common_probe(struct device *dev, return -EINVAL; } - /* BMP3xx requires soft-reset as part of initialization */ - if (chip_id == BMP380_CHIP_ID) { - ret = bmp380_cmd(data, BMP380_CMD_SOFT_RESET); + /* + * Some chips like the BMP3xx have preinit tasks to run + * before applying the initial configuration. + */ + if (data->chip_info->preinit) { + ret = data->chip_info->preinit(data); + dev_err(dev, "error running preinit tasks"); if (ret < 0) return ret; }