Message ID | 20221222203610.2571287-2-hugo@hugovil.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp152966wrn; Thu, 22 Dec 2022 12:39:23 -0800 (PST) X-Google-Smtp-Source: AMrXdXs5Odqa2//LO8oMkj0tsaNl/mkKYEdEE7bYJb+RTgK82zyMFFe4P4/5uauDHbr84EG9gY6w X-Received: by 2002:a17:907:d50e:b0:7b1:316c:38f5 with SMTP id wb14-20020a170907d50e00b007b1316c38f5mr6321264ejc.30.1671741563370; Thu, 22 Dec 2022 12:39:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671741563; cv=none; d=google.com; s=arc-20160816; b=PwhRRKzBvNMYt/CzcFR4QMeFaF1Vw6QTh/x28zFaLHDdynGzkSoRwO//xJpfbBoHVW E5+tesumZDDa6Xm3nFs3icCGTS22uvH4fX/MMqKr6YM7Cd1y7C5nqAPveNdqT1OHIB22 wgTnK4y8UaUEgLlxFHXrZiPy//kUrvRzYONZeYJuyxQGp9NRzaZpopsguf9N/qDt90Bv pdg8ATGL0eaXzdHM1HqAS7JquyRwR/26o+bcoQhI6mY1A71HLCGab/hnfKh4HN4lqydo dVVpfpa6MGDt88CSAZf/iRY1+lvfQ5fdWD0U7fjUB380OjKhvFMnjgiCWp587sNPS4kX D/eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:cc:to:from:dkim-signature; bh=gci7HmEu/UU5CFeAVTpWpem7dZdHS+jmF3GnpB+xyIQ=; b=0TQ6antvtEJemmN69G7rgfFT0LkxW0M5svaMiszP2gnhyif5RVLyUHBnaOR80JaiXN 8S0uOljWYIVeNSX8+/zY8XSSI0ZF26gqGlXrtyUEa35a4qFwuppoUZnP3Q7LqSEFxCHd NcOoV9Xc70N1aiiunVE3A6diCQQZ8GKOeYRDlNTsY+xlP5PjH1V06KO0L70uhGuvpPAB LIMkhNVt+wvrjQFRT52JzoWb6rs43JA6ud0mXekjj+ZhdZ3iNgA+08/AL80zAw9umn/g 7HFbWeao3/SiQ13J7eUVsOctijSCN0Vs2edlCXqhVm3WPPql04jSIXymKkY95qcm05O4 FPDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=T8H+j+Q9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dt15-20020a170907728f00b007c0bf7f6845si1188811ejc.619.2022.12.22.12.38.57; Thu, 22 Dec 2022 12:39:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=T8H+j+Q9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235443AbiLVUhW (ORCPT <rfc822;pacteraone@gmail.com> + 99 others); Thu, 22 Dec 2022 15:37:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235107AbiLVUhA (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 22 Dec 2022 15:37:00 -0500 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 433EC23BFA; Thu, 22 Dec 2022 12:36:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gci7HmEu/UU5CFeAVTpWpem7dZdHS+jmF3GnpB+xyIQ=; b=T8H+j+Q9bLsoq8BEgStKsPpInj LPHTOR0+rEkCggeh3ChVWVLxsD0iu0SGKkQ94RqLEol01QxjPf4jobVush2ZCNcd1mZf+p3ryu3Nq d+5A8KvKbartIL/xbORNbVV5jSob/Sk1SHohCRSVj67lSuKkg5lOAA+XerNQuuZUN9t4=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:48920 helo=pettiford.lan) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from <hugo@hugovil.com>) id 1p8SJ8-000070-Sw; Thu, 22 Dec 2022 15:36:51 -0500 From: Hugo Villeneuve <hugo@hugovil.com> To: hvilleneuve@dimonoff.com, jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, hugo@hugovil.com Date: Thu, 22 Dec 2022 15:36:08 -0500 Message-Id: <20221222203610.2571287-2-hugo@hugovil.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221222203610.2571287-1-hugo@hugovil.com> References: <20221222203610.2571287-1-hugo@hugovil.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Subject: [PATCH v1 1/3] iio: adc: Kconfig: add SPI interface mention to AD7924 description X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752948081382810898?= X-GMAIL-MSGID: =?utf-8?q?1752948081382810898?= |
Series |
iio: adc: ti-ads7924: add ADS7924 driver
|
|
Commit Message
Hugo Villeneuve
Dec. 22, 2022, 8:36 p.m. UTC
From: Hugo Villeneuve <hvilleneuve@dimonoff.com> The Analog Devices AD7924 uses an SPI interface. There is also a Texas Instruments ADS7924 which uses an I2C interface. Adding the SPI mention to the AD7924 will help to avoid confusion between the two chips. Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> --- drivers/iio/adc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Thu, 22 Dec 2022 15:36:08 -0500 Hugo Villeneuve <hugo@hugovil.com> wrote: > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > The Analog Devices AD7924 uses an SPI interface. There is also a Texas > Instruments ADS7924 which uses an I2C interface. > > Adding the SPI mention to the AD7924 will help to avoid confusion > between the two chips. Hi Hugo, Welcome to IIO. I don't really mind this, but given they have different part numbers and the similarly named TI part could just have easily been SPI I'm not sure the clarification is really useful. Also, under all the circumstances I can think of, if you can see the help text you can also see the SPI dependence clearly listed. Hence I think is just noise, though I'm guessing it reflects a confusion you ran into! Jonathan > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> > --- > drivers/iio/adc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index 46c4fc2fc534..235319546974 100644 > --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -243,7 +243,7 @@ config AD7923 > select IIO_TRIGGERED_BUFFER > help > Say yes here to build support for Analog Devices > - AD7904, AD7914, AD7923, AD7924 4 Channel ADCs. > + AD7904, AD7914, AD7923, AD7924 4 Channel SPI ADCs. > > To compile this driver as a module, choose M here: the > module will be called ad7923.
On Fri, 23 Dec 2022 14:12:32 +0000 Jonathan Cameron <jic23@kernel.org> wrote: > On Thu, 22 Dec 2022 15:36:08 -0500 > Hugo Villeneuve <hugo@hugovil.com> wrote: > > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > > > The Analog Devices AD7924 uses an SPI interface. There is also a Texas > > Instruments ADS7924 which uses an I2C interface. > > > > Adding the SPI mention to the AD7924 will help to avoid confusion > > between the two chips. > Hi Hugo, > > Welcome to IIO. > > I don't really mind this, but given they have different part numbers > and the similarly named TI part could just have easily been SPI > I'm not sure the clarification is really useful. > > Also, under all the circumstances I can think of, if you can see the > help text you can also see the SPI dependence clearly listed. > > Hence I think is just noise, though I'm guessing it reflects a > confusion you ran into! > > Jonathan Hi Jonathan, yes, I initially tought that the TI ADS7924 was already supported because of the AD7924 entry. I wrongly assumed that the parts were similar and TI just renamed it because they bought Analog Devices. I am pretty sure that I am not the only one having made a similar error :) Of course, both chips differ not only because of their interface (SPI vs I2C), but also in their modes of operation and registers, interrupt pin presence (ADS7924), etc. But I can drop this patch if you want. Hugo V. > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > --- > > drivers/iio/adc/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > > index 46c4fc2fc534..235319546974 100644 > > --- a/drivers/iio/adc/Kconfig > > +++ b/drivers/iio/adc/Kconfig > > @@ -243,7 +243,7 @@ config AD7923 > > select IIO_TRIGGERED_BUFFER > > help > > Say yes here to build support for Analog Devices > > - AD7904, AD7914, AD7923, AD7924 4 Channel ADCs. > > + AD7904, AD7914, AD7923, AD7924 4 Channel SPI ADCs. > > > > To compile this driver as a module, choose M here: the > > module will be called ad7923. > >
On Fri, 23 Dec 2022 13:52:09 -0500 Hugo Villeneuve <hugo@hugovil.com> wrote: > On Fri, 23 Dec 2022 14:12:32 +0000 > Jonathan Cameron <jic23@kernel.org> wrote: > > > On Thu, 22 Dec 2022 15:36:08 -0500 > > Hugo Villeneuve <hugo@hugovil.com> wrote: > > > > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > > > > > The Analog Devices AD7924 uses an SPI interface. There is also a Texas > > > Instruments ADS7924 which uses an I2C interface. > > > > > > Adding the SPI mention to the AD7924 will help to avoid confusion > > > between the two chips. > > Hi Hugo, > > > > Welcome to IIO. > > > > I don't really mind this, but given they have different part numbers > > and the similarly named TI part could just have easily been SPI > > I'm not sure the clarification is really useful. > > > > Also, under all the circumstances I can think of, if you can see the > > help text you can also see the SPI dependence clearly listed. > > > > Hence I think is just noise, though I'm guessing it reflects a > > confusion you ran into! > > > > Jonathan > > Hi Jonathan, > yes, I initially tought that the TI ADS7924 was already supported because of the AD7924 entry. I wrongly assumed that the parts were similar and TI just renamed it because they bought Analog Devices. I am pretty sure that I am not the only one having made a similar error :) > Yikes. If TI bought ADI that would definitely be big news (my uninformed guess it it would never get past competition authorities :) I do vaguely wonder if long term we'll have to start naming drivers with vendor prefixes as we will eventually get significant naming clashes. Still I'm not keen to do it until we have a real problem. > Of course, both chips differ not only because of their interface (SPI vs I2C), but also in their modes of operation and registers, interrupt pin presence (ADS7924), etc. > > But I can drop this patch if you want. Will do, Thanks, Jonathan > > Hugo V. > > > > > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > > --- > > > drivers/iio/adc/Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > > > index 46c4fc2fc534..235319546974 100644 > > > --- a/drivers/iio/adc/Kconfig > > > +++ b/drivers/iio/adc/Kconfig > > > @@ -243,7 +243,7 @@ config AD7923 > > > select IIO_TRIGGERED_BUFFER > > > help > > > Say yes here to build support for Analog Devices > > > - AD7904, AD7914, AD7923, AD7924 4 Channel ADCs. > > > + AD7904, AD7914, AD7923, AD7924 4 Channel SPI ADCs. > > > > > > To compile this driver as a module, choose M here: the > > > module will be called ad7923. > > > > > >
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index 46c4fc2fc534..235319546974 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/iio/adc/Kconfig @@ -243,7 +243,7 @@ config AD7923 select IIO_TRIGGERED_BUFFER help Say yes here to build support for Analog Devices - AD7904, AD7914, AD7923, AD7924 4 Channel ADCs. + AD7904, AD7914, AD7923, AD7924 4 Channel SPI ADCs. To compile this driver as a module, choose M here: the module will be called ad7923.