Message ID | 20221228123655.15384-2-hnagalla@ti.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1870199wrt; Wed, 28 Dec 2022 04:40:36 -0800 (PST) X-Google-Smtp-Source: AMrXdXva76Jkga3dufp4fDd4+ZrpbgDSib9DSL0GCX6OXqw0ijToIRGukHTJzeiOwLVAkS0w2lZM X-Received: by 2002:aa7:96aa:0:b0:581:3b0e:803c with SMTP id g10-20020aa796aa000000b005813b0e803cmr9698911pfk.7.1672231236484; Wed, 28 Dec 2022 04:40:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672231236; cv=none; d=google.com; s=arc-20160816; b=ofKjVewDYH1sw9bGDf5/F9WrJp1m93oJAp+G92OjN6ceno9f3NLgosY4n3SD3ZY23w sZ842O/NID1+iguvfC/3Cp7hhTvU87tfr8WK8aWeWY5r5ff0O9nNeVRoy4D/YYD2fHJb cHoI+eCv37Sepw6ess2Ax+tMPRIyR43/WqOJsk+wB0FwiERBgj3UcOLEuEKqZnjQ/qbg VCg/JskHbGvD38JIcCQ/kRnnIaiiRNzu0uKjQgU546vNv0aQYU0XIVp1jgPa0yX9j6Hw W7L8uXnjxL3mAjHiT00rxclJrUuJ3fqyXag7TR8toBm8npYQSWbYFNI7n+xX8C/FILiG YOKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Ps0r76a1FWJ/OBz35wokOV4UZ8+ehUwLp37dRHRlpnE=; b=sswDM7UpRnScbaNM6WTvp/gAFE9OwhDtJk/2L5HVJRZoKZJsVKZzT8y5nfUUnsE7K0 cBAmbe3lAtCilLs06b+RXesVVX8vHPRt7OpN9Oa6gC1z8nkg855BwmCJDI+Wtn2f8Bzi KFeNwZF/VFGnxu2KgeHQg9ap8fvimunj9GwGaqxd48S6facvbffJn9uY8YNldFp67n2c z6g/ax8eyUPMgozakLGRRjL3xnkhaH/WIR5oAx96mGizH8faoXrZeKrKL67sihfFIcSq FeiG0hE8/V5u4rYXQlJu1qIFabslC5gFe9kif/8tEG39Ct25rSR+IF2gIYV3bPaM2GGk zvZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=k2jYlZDq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z2-20020aa78882000000b00580f1afe74fsi1352986pfe.38.2022.12.28.04.40.24; Wed, 28 Dec 2022 04:40:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=k2jYlZDq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232714AbiL1MhL (ORCPT <rfc822;eddaouddi.ayoub@gmail.com> + 99 others); Wed, 28 Dec 2022 07:37:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232920AbiL1MhG (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 28 Dec 2022 07:37:06 -0500 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C05DF10B4B; Wed, 28 Dec 2022 04:37:05 -0800 (PST) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2BSCauhh126426; Wed, 28 Dec 2022 06:36:56 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1672231016; bh=Ps0r76a1FWJ/OBz35wokOV4UZ8+ehUwLp37dRHRlpnE=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=k2jYlZDqcsYEkgIdzXox3LLc5EtPADNFrlrLuHBxydVv8ID5PG+VYNvbk1SEwYeZN 8HXPgSrme2ZZwyHf9GidPfMkMAH1HSRG44+JrPf7431STWTsrdYVteWQQfXyCeLvb5 mJrnYIkebljlQF1AbEb7LJ323RG/huUYQB+W0Jx8= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2BSCauku084936 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 28 Dec 2022 06:36:56 -0600 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Wed, 28 Dec 2022 06:36:55 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Wed, 28 Dec 2022 06:36:55 -0600 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 2BSCatB6129791; Wed, 28 Dec 2022 06:36:55 -0600 From: Hari Nagalla <hnagalla@ti.com> To: <andersson@kernel.org>, <devicetree@vger.kernel.org>, <mathieu.poirier@linaro.org>, <p.zabel@pengutronix.de>, <linux-remoteproc@vger.kernel.org>, <robh+dt@kernel.org>, <linux-kernel@vger.kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <s-anna@ti.com> CC: <hnagalla@ti.com>, <praneeth@ti.com>, <nm@ti.com>, <vigneshr@ti.com>, <a-bhatia1@ti.com>, <j-luthra@ti.com>, <devarsht@ti.com> Subject: [PATCH 1/2] dt-bindings: remoteproc: k3-dsp: update bindings for AM62A SoCs Date: Wed, 28 Dec 2022 06:36:54 -0600 Message-ID: <20221228123655.15384-2-hnagalla@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221228123655.15384-1-hnagalla@ti.com> References: <20221228123655.15384-1-hnagalla@ti.com> MIME-Version: 1.0 Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753461540993505436?= X-GMAIL-MSGID: =?utf-8?q?1753461540993505436?= |
Series |
Add C7xv DSP for AM62A
|
|
Commit Message
Hari Nagalla
Dec. 28, 2022, 12:36 p.m. UTC
The TI AM62A SoCs have a C7xv DSP and Analytics engine for deep
learning purposes. The DSP part is similar to the C71x DSP found on
K3 J7 SoCs, but additional hardware accelerators and IP are added to
the subsystem for deep learning.
Compatible info is updated to match AM62A SoCs.
Signed-off-by: Hari Nagalla <hnagalla@ti.com>
---
.../devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml | 3 +++
1 file changed, 3 insertions(+)
Comments
On 28/12/2022 13:36, Hari Nagalla wrote: > The TI AM62A SoCs have a C7xv DSP and Analytics engine for deep > learning purposes. The DSP part is similar to the C71x DSP found on > K3 J7 SoCs, but additional hardware accelerators and IP are added to > the subsystem for deep learning. > > Compatible info is updated to match AM62A SoCs. > > Signed-off-by: Hari Nagalla <hnagalla@ti.com> > --- > .../devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml > index cedbc5efdc56..846c9c14169a 100644 > --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml > @@ -34,10 +34,12 @@ properties: > - ti,j721e-c66-dsp > - ti,j721e-c71-dsp > - ti,j721s2-c71-dsp > + - ti,am62a-c7xv-dsp Add it in some order, e.g. alphabetical. > description: > Use "ti,j721e-c66-dsp" for C66x DSPs on K3 J721E SoCs > Use "ti,j721e-c71-dsp" for C71x DSPs on K3 J721E SoCs > Use "ti,j721s2-c71-dsp" for C71x DSPs on K3 J721S2 SoCs > + Use "ti,am62a-c7xv-dsp" for AM62A Deep learning DSPs on K3 AM62A SoCs > > resets: > description: | > @@ -111,6 +113,7 @@ else: > enum: > - ti,j721e-c71-dsp > - ti,j721s2-c71-dsp > + - ti,am62a-c7xv-dsp Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Wrong indentation. Best regards, Krzysztof
On Wed, 28 Dec 2022 06:36:54 -0600, Hari Nagalla wrote: > The TI AM62A SoCs have a C7xv DSP and Analytics engine for deep > learning purposes. The DSP part is similar to the C71x DSP found on > K3 J7 SoCs, but additional hardware accelerators and IP are added to > the subsystem for deep learning. > > Compatible info is updated to match AM62A SoCs. > > Signed-off-by: Hari Nagalla <hnagalla@ti.com> > --- > .../devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml | 3 +++ > 1 file changed, 3 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml:116:1: [error] syntax error: found character '\t' that cannot start any token (syntax) dtschema/dtc warnings/errors: make[1]: *** Deleting file 'Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.example.dts' Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml:116:1: found character '\t' that cannot start any token make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml:116:1: found character '\t' that cannot start any token /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml: ignoring, error parsing file make: *** [Makefile:1508: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221228123655.15384-2-hnagalla@ti.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 12/28/22 06:38, Krzysztof Kozlowski wrote: >> >> resets: >> description: | >> @@ -111,6 +113,7 @@ else: >> enum: >> - ti,j721e-c71-dsp >> - ti,j721s2-c71-dsp >> + - ti,am62a-c7xv-dsp > Does not look like you tested the bindings. Please run `make > dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > > Wrong indentation. Seems, i used a wrong option in our patch verify script. Used the correct options and fixed it. sending v2 with review comment updates. Thanks
diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml index cedbc5efdc56..846c9c14169a 100644 --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml @@ -34,10 +34,12 @@ properties: - ti,j721e-c66-dsp - ti,j721e-c71-dsp - ti,j721s2-c71-dsp + - ti,am62a-c7xv-dsp description: Use "ti,j721e-c66-dsp" for C66x DSPs on K3 J721E SoCs Use "ti,j721e-c71-dsp" for C71x DSPs on K3 J721E SoCs Use "ti,j721s2-c71-dsp" for C71x DSPs on K3 J721S2 SoCs + Use "ti,am62a-c7xv-dsp" for AM62A Deep learning DSPs on K3 AM62A SoCs resets: description: | @@ -111,6 +113,7 @@ else: enum: - ti,j721e-c71-dsp - ti,j721s2-c71-dsp + - ti,am62a-c7xv-dsp then: properties: reg: