Message ID | 20221227110335.2923359-2-javierm@redhat.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1336211wrt; Tue, 27 Dec 2022 03:07:33 -0800 (PST) X-Google-Smtp-Source: AMrXdXt3qrPF76Jbnh/0l/0Nie9IHOcAQmvxPXbwCeT0stIKMYH++WtB1jZ1exsAWcWHPn6QU4E2 X-Received: by 2002:a17:906:430a:b0:7c1:54b9:c688 with SMTP id j10-20020a170906430a00b007c154b9c688mr17182052ejm.60.1672139253439; Tue, 27 Dec 2022 03:07:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672139253; cv=none; d=google.com; s=arc-20160816; b=V/osN7USJeim4F3yANNzqalPoaTc+4fUsGijWq6/zaOfC/fjLqhMcXfGCm+i8xn9iX u5UEgfhJo515aS0OdYOo1/uJdUbhmfwNtTVMSPd4OegzWzkvqkFuGTqVGhcdgjBJJaHI mn6/nmQCmUpywnH4HOuFGJo5ierym8vuJw5c+W4YRcvywUaAbV9uLLaXV+iEhho85/Ls C0BEHQC91yHqJhJe6H4cu6WPb+PZoNMHWR9wpCejaw0NP2dNB6aVexP7CEpdF0Mw2+DV vsGTL+odJIBaJEFdUadPbcbBDPA5SSzHISqIYFHFA5E0InPasZSJpnrH9lq4gNUrknoM uxIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=woUir0Lts/Iv/2E8U+LoYyfYL4VWI99Q3r6CZZFNa7I=; b=kcbveodpkuXGMiMiW5Gmj4hhADhIOZr4YBT0r6Tx4D6EnWz685G0E0HzaZ7sajOvcq bboTfFeGX4j8zR/n2msE+z8bufhDsvO7VjVpN67HoISjyJRzH8AVXjtawtA7faFBgAT5 qxrRs9dGHLumFH3CmQtbN3RJj9X27WYUkhflGKZdo9RgT+pgyDgkOZJ9Q7obHeebas1Z 8j1Ju2yZy96dv5R+hpf1dzeR/kUIbLNfWvHn7muNM9wH+97Mfmuans3uyZvKiXhlAi8g DEzBQcZDU6uuydKqcLSpD098PWKZ9vFbnW5136Wq6saJJAq/C6l154fiN2720GbwPOZL tVpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iJMWltoz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g9-20020a50d0c9000000b0046844a8111dsi10143961edf.533.2022.12.27.03.07.09; Tue, 27 Dec 2022 03:07:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iJMWltoz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231304AbiL0LFA (ORCPT <rfc822;eddaouddi.ayoub@gmail.com> + 99 others); Tue, 27 Dec 2022 06:05:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231613AbiL0LE0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 27 Dec 2022 06:04:26 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1355C95A4 for <linux-kernel@vger.kernel.org>; Tue, 27 Dec 2022 03:03:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672139024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=woUir0Lts/Iv/2E8U+LoYyfYL4VWI99Q3r6CZZFNa7I=; b=iJMWltozYAWAlvI0LG0WBiOAwmpWcbgwcz7Ouu22+0Yb0D/NrjMfzk5dSbU8C4hrty9b1s 7zk2+X09fIyCUo0HLSeid3kX2kfAYTiyJcbjXAi+OMFKL7KbyV8FlfysHaLLs91QnvWsj5 2iEkzGztMP0Kn4r9Nc2SRrjm+YzCTd0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-383-1QJBs5ptO6iLaDaJpdW8Hg-1; Tue, 27 Dec 2022 06:03:43 -0500 X-MC-Unique: 1QJBs5ptO6iLaDaJpdW8Hg-1 Received: by mail-wr1-f71.google.com with SMTP id j27-20020adfa55b000000b0027f710a6ceeso364028wrb.14 for <linux-kernel@vger.kernel.org>; Tue, 27 Dec 2022 03:03:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=woUir0Lts/Iv/2E8U+LoYyfYL4VWI99Q3r6CZZFNa7I=; b=Xbw9lDKHI8NPgf5uMeKB8qKZqfEfnVVy5yYnPL+vsJ7O1HcwT5i4/ielQTHc/4somv 0g1cs4CJ6S4dJKJBeTG14C7CWT3T2lNqfr9PyJE7WAsR9qKcBjbqN8nnXUWstQo6NquF sON6MKBvvRbTJ/riXdjGkIBeYBpmpwswFh07dDC2T/aLUDSjXlMz1oyFhn1v47II5U7D 2cn4RlFLupzBR4d4iXkv9SKWyqP3oJcfsMOxljGokYs5JWRmGVt8esr4z9KOcqLQos7R Kxt/T8h3Q2izGMvDYRk7oc5V8ei09sEfFtu6ARGRGNyQnD+ebMvjebNqlnMkIXQ4i6zZ y2dA== X-Gm-Message-State: AFqh2kq+lgqqROrYkM2c6/7lBa3BbvO3IYsOSuKH2ptV9WQI6qwveFEr GoJwMqoUM4djJeKuHhUK5NUU30Fcaox8/mxCaxMD2XJNA51TKlwSS+Gq4Wm3YOFGsDcosTBgBVJ IOpWXKkwgao6sKzQhbmK3/FpEjGJ0I2oJJpsanoabEEJPwWVYxcpVAw6+h9GtadA81pfvD0lO+v g= X-Received: by 2002:adf:e283:0:b0:242:324e:b3d with SMTP id v3-20020adfe283000000b00242324e0b3dmr12664704wri.1.1672139021706; Tue, 27 Dec 2022 03:03:41 -0800 (PST) X-Received: by 2002:adf:e283:0:b0:242:324e:b3d with SMTP id v3-20020adfe283000000b00242324e0b3dmr12664672wri.1.1672139021448; Tue, 27 Dec 2022 03:03:41 -0800 (PST) Received: from minerva.home (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id p18-20020a056000019200b00279d23574c4sm7374557wrx.13.2022.12.27.03.03.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Dec 2022 03:03:41 -0800 (PST) From: Javier Martinez Canillas <javierm@redhat.com> To: linux-kernel@vger.kernel.org Cc: Peter Robinson <pbrobinson@gmail.com>, Martijn Braam <martijn@brixit.nl>, Maya Matuszczyk <maccraft123mc@gmail.com>, Sam Ravnborg <sam@ravnborg.org>, Neal Gompa <ngompa13@gmail.com>, =?utf-8?q?Kamil_Trzci=C5=84ski?= <ayufan@ayufan.eu>, Tom Fitzhenry <tom@tom-fitzhenry.me.uk>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Robert Mader <robert.mader@posteo.de>, Onuralp Sezer <thunderbirdtr@fedoraproject.org>, Ondrej Jirman <megi@xff.cz>, dri-devel@lists.freedesktop.org, Javier Martinez Canillas <javierm@redhat.com>, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Rob Herring <robh+dt@kernel.org>, Thierry Reding <thierry.reding@gmail.com>, devicetree@vger.kernel.org Subject: [PATCH v3 1/4] dt-bindings: display: Add Himax HX8394 panel controller Date: Tue, 27 Dec 2022 12:03:32 +0100 Message-Id: <20221227110335.2923359-2-javierm@redhat.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221227110335.2923359-1-javierm@redhat.com> References: <20221227110335.2923359-1-javierm@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753365090146346662?= X-GMAIL-MSGID: =?utf-8?q?1753365090146346662?= |
Series |
Add PinePhone Pro display support
|
|
Commit Message
Javier Martinez Canillas
Dec. 27, 2022, 11:03 a.m. UTC
Add device tree bindings for panels based on the Himax HX8394 controller, such as the HannStar HSD060BHW4 720x1440 TFT LCD panel that is connected through a MIPI-DSI video interface. Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Changes in v3: - Fix example snippet for `make dt_binding_check` to pass (Krzysztof Kozlowski). Changes in v2: - Drop redundant "bindings" in subject (Krzysztof Kozlowski). - Drop "device tree bindings" in title (Krzysztof Kozlowski). - Put port next to other "true" properties (Krzysztof Kozlowski). - Add Krzysztof Kozlowski's Reviewed-by tag. .../bindings/display/panel/himax,hx8394.yaml | 74 +++++++++++++++++++ 1 file changed, 74 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml
Comments
On Tue, Dec 27, 2022 at 4:33 PM Javier Martinez Canillas <javierm@redhat.com> wrote: > > Add device tree bindings for panels based on the Himax HX8394 controller, > such as the HannStar HSD060BHW4 720x1440 TFT LCD panel that is connected > through a MIPI-DSI video interface. > > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > > Changes in v3: > - Fix example snippet for `make dt_binding_check` to pass (Krzysztof Kozlowski). > > Changes in v2: > - Drop redundant "bindings" in subject (Krzysztof Kozlowski). > - Drop "device tree bindings" in title (Krzysztof Kozlowski). > - Put port next to other "true" properties (Krzysztof Kozlowski). > - Add Krzysztof Kozlowski's Reviewed-by tag. > > .../bindings/display/panel/himax,hx8394.yaml | 74 +++++++++++++++++++ > 1 file changed, 74 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml b/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml > new file mode 100644 > index 000000000000..fb1981cacfc8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/himax,hx8394.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Himax HX8394 MIPI-DSI LCD panel controller > + > +maintainers: > + - Javier Martinez Canillas <javierm@redhat.com> > + > +description: > + Device tree bindings for panels based on the Himax HX8394 controller, > + such as the HannStar HSD060BHW4 720x1440 TFT LCD panel connected with > + a MIPI-DSI video interface. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + enum: > + # HannStar HSD060BHW4 5.99" 720x1440 TFT LCD panel > + - hannstar,hsd060bhw4 Parent controller can have a compatible where the associated panels will be enum list. Jagan.
Hello Jagan, On Tue, Dec 27, 2022 at 7:16 PM Jagan Teki <jagan@amarulasolutions.com> wrote: [...] > > +allOf: > > + - $ref: panel-common.yaml# > > + > > +properties: > > + compatible: > > + enum: > > + # HannStar HSD060BHW4 5.99" 720x1440 TFT LCD panel > > + - hannstar,hsd060bhw4 > > Parent controller can have a compatible where the associated panels > will be enum list. > I'm not sure to follow what you meant. Could you please elaborate? Best regards, Javier
On Wed, Dec 28, 2022 at 12:58 AM Javier Martinez Canillas <javier@dowhile0.org> wrote: > > Hello Jagan, > > On Tue, Dec 27, 2022 at 7:16 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > [...] > > > > +allOf: > > > + - $ref: panel-common.yaml# > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + # HannStar HSD060BHW4 5.99" 720x1440 TFT LCD panel > > > + - hannstar,hsd060bhw4 > > > > Parent controller can have a compatible where the associated panels > > will be enum list. > > > > I'm not sure to follow what you meant. Could you please elaborate? compatible: items: - enum: - hannstar,hsd060bhw4 - const: himax,hx8394 himax,hx8394 is the actual controller and is denoted as fallback compatible. Jagan.
On Tue, Dec 27, 2022 at 8:37 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > On Wed, Dec 28, 2022 at 12:58 AM Javier Martinez Canillas > <javier@dowhile0.org> wrote: > > > > Hello Jagan, > > > > On Tue, Dec 27, 2022 at 7:16 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > > > [...] > > > > > > +allOf: > > > > + - $ref: panel-common.yaml# > > > > + > > > > +properties: > > > > + compatible: > > > > + enum: > > > > + # HannStar HSD060BHW4 5.99" 720x1440 TFT LCD panel > > > > + - hannstar,hsd060bhw4 > > > > > > Parent controller can have a compatible where the associated panels > > > will be enum list. > > > > > > > I'm not sure to follow what you meant. Could you please elaborate? > > compatible: > items: > - enum: > - hannstar,hsd060bhw4 > - const: himax,hx8394 > > himax,hx8394 is the actual controller and is denoted as fallback compatible. > I see. Do you have an example of a panel controller that does this? I don't see that much value in doing this since you want the DTS to describe the actual HW and so want the panel I believe. But also there isn't an of_device_id entry for this fallback controller compatible string. Feel free to propose that as a follow-up if you think it is worth doing so. Best regards, Javier
On Wed, Dec 28, 2022 at 3:46 AM Javier Martinez Canillas <javier@dowhile0.org> wrote: > > On Tue, Dec 27, 2022 at 8:37 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > > > On Wed, Dec 28, 2022 at 12:58 AM Javier Martinez Canillas > > <javier@dowhile0.org> wrote: > > > > > > Hello Jagan, > > > > > > On Tue, Dec 27, 2022 at 7:16 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > > > > > [...] > > > > > > > > +allOf: > > > > > + - $ref: panel-common.yaml# > > > > > + > > > > > +properties: > > > > > + compatible: > > > > > + enum: > > > > > + # HannStar HSD060BHW4 5.99" 720x1440 TFT LCD panel > > > > > + - hannstar,hsd060bhw4 > > > > > > > > Parent controller can have a compatible where the associated panels > > > > will be enum list. > > > > > > > > > > I'm not sure to follow what you meant. Could you please elaborate? > > > > compatible: > > items: > > - enum: > > - hannstar,hsd060bhw4 > > - const: himax,hx8394 > > > > himax,hx8394 is the actual controller and is denoted as fallback compatible. > > > > I see. Do you have an example of a panel controller that does this? I > don't see that much value in doing this since you want the DTS to > describe the actual HW and so want the panel I believe. Yes, but the Panel needs to be built on top of the display IC so the actual parent here is the display IC and the panel is sub-HW. This is what usually follows, here are some reference bindings. https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/display/panel/sitronix,st7701.yaml https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/display/panel/ilitek,ili9163.yaml https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml Jagan.
diff --git a/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml b/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml new file mode 100644 index 000000000000..fb1981cacfc8 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml @@ -0,0 +1,74 @@ +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/himax,hx8394.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Himax HX8394 MIPI-DSI LCD panel controller + +maintainers: + - Javier Martinez Canillas <javierm@redhat.com> + +description: + Device tree bindings for panels based on the Himax HX8394 controller, + such as the HannStar HSD060BHW4 720x1440 TFT LCD panel connected with + a MIPI-DSI video interface. + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + enum: + # HannStar HSD060BHW4 5.99" 720x1440 TFT LCD panel + - hannstar,hsd060bhw4 + + reg: true + + reset-gpios: true + + backlight: true + + port: true + + vcc-supply: + description: Panel power supply + + iovcc-supply: + description: I/O voltage supply + +required: + - compatible + - reg + - reset-gpios + - backlight + - port + - vcc-supply + - iovcc-supply + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + dsi { + #address-cells = <1>; + #size-cells = <0>; + panel@0 { + compatible = "hannstar,hsd060bhw4"; + reg = <0>; + vcc-supply = <®_2v8_p>; + iovcc-supply = <®_1v8_p>; + reset-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>; + backlight = <&backlight>; + + port { + mipi_in_panel: endpoint { + remote-endpoint = <&mipi_out_panel>; + }; + }; + }; + }; + +...