diff mbox series

pinctrl: at91: convert to NOIRQ_SYSTEM_SLEEP_PM_OPS

Message ID 20221215164301.934805-1-arnd@kernel.org
State New
Headers
Series pinctrl: at91: convert to NOIRQ_SYSTEM_SLEEP_PM_OPS |

Commit Message

Arnd Bergmann Dec. 15, 2022, 4:42 p.m. UTC 
  From: Arnd Bergmann <arnd@arndb.de>

With the old SET_NOIRQ_SYSTEM_SLEEP_PM_OPS, some configs result in a
build warning:

drivers/pinctrl/pinctrl-at91.c:1668:12: error: 'at91_gpio_resume' defined but not used [-Werror=unused-function]
 1668 | static int at91_gpio_resume(struct device *dev)
      |            ^~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-at91.c:1650:12: error: 'at91_gpio_suspend' defined but not used [-Werror=unused-function]
 1650 | static int at91_gpio_suspend(struct device *dev)
      |            ^~~~~~~~~~~~~~~~~

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/pinctrl/pinctrl-at91.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ryan.Wanner@microchip.com Dec. 15, 2022, 5:26 p.m. UTC | #1 
On 12/15/22 09:42, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> With the old SET_NOIRQ_SYSTEM_SLEEP_PM_OPS, some configs result in a
> build warning:
> 
> drivers/pinctrl/pinctrl-at91.c:1668:12: error: 'at91_gpio_resume' defined but not used [-Werror=unused-function]
>  1668 | static int at91_gpio_resume(struct device *dev)
>       |            ^~~~~~~~~~~~~~~~
> drivers/pinctrl/pinctrl-at91.c:1650:12: error: 'at91_gpio_suspend' defined but not used [-Werror=unused-function]
>  1650 | static int at91_gpio_suspend(struct device *dev)
>       |            ^~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Ryan Wanner <Ryan.Wanner@microchip.com>

Thanks Arnd, best,
Ryan
> ---
>  drivers/pinctrl/pinctrl-at91.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> index 1e1813d7c550..cf2423855a80 100644
> --- a/drivers/pinctrl/pinctrl-at91.c
> +++ b/drivers/pinctrl/pinctrl-at91.c
> @@ -1923,7 +1923,7 @@ static int at91_gpio_probe(struct platform_device *pdev)
>  }
> 
>  static const struct dev_pm_ops at91_gpio_pm_ops = {
> -       SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(at91_gpio_suspend, at91_gpio_resume)
> +       NOIRQ_SYSTEM_SLEEP_PM_OPS(at91_gpio_suspend, at91_gpio_resume)
>  };
> 
>  static struct platform_driver at91_gpio_driver = {
> --
> 2.35.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Linus Walleij Dec. 29, 2022, 1:11 a.m. UTC | #2 
On Thu, Dec 15, 2022 at 5:43 PM Arnd Bergmann <arnd@kernel.org> wrote:

> From: Arnd Bergmann <arnd@arndb.de>
>
> With the old SET_NOIRQ_SYSTEM_SLEEP_PM_OPS, some configs result in a
> build warning:
>
> drivers/pinctrl/pinctrl-at91.c:1668:12: error: 'at91_gpio_resume' defined but not used [-Werror=unused-function]
>  1668 | static int at91_gpio_resume(struct device *dev)
>       |            ^~~~~~~~~~~~~~~~
> drivers/pinctrl/pinctrl-at91.c:1650:12: error: 'at91_gpio_suspend' defined but not used [-Werror=unused-function]
>  1650 | static int at91_gpio_suspend(struct device *dev)
>       |            ^~~~~~~~~~~~~~~~~
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Patch applied!

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
index 1e1813d7c550..cf2423855a80 100644
--- a/drivers/pinctrl/pinctrl-at91.c
+++ b/drivers/pinctrl/pinctrl-at91.c
@@ -1923,7 +1923,7 @@  static int at91_gpio_probe(struct platform_device *pdev)
 }
 
 static const struct dev_pm_ops at91_gpio_pm_ops = {
-	SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(at91_gpio_suspend, at91_gpio_resume)
+	NOIRQ_SYSTEM_SLEEP_PM_OPS(at91_gpio_suspend, at91_gpio_resume)
 };
 
 static struct platform_driver at91_gpio_driver = {