Message ID | 20221228112456.31348-1-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1848624wrt; Wed, 28 Dec 2022 03:44:18 -0800 (PST) X-Google-Smtp-Source: AMrXdXsJYhMjbbncPPjD5UZOh4UoAUr+lHjMbuE968djeu5uaJccbsB0mbrL2NokT7bJxt0xs5Hz X-Received: by 2002:a17:906:dff5:b0:7ef:b60e:cb02 with SMTP id lc21-20020a170906dff500b007efb60ecb02mr21246114ejc.48.1672227858011; Wed, 28 Dec 2022 03:44:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672227857; cv=none; d=google.com; s=arc-20160816; b=Wv0fqC+f4/J5MqNXF0cnpZ4L3LQJTDxjkLv38WKEOoC9B9qEmbKFkO7I5tz4a/WQ5a eMielQV5ewHIh7vq5JgCpkm/hlen2+p+3KbjnBtVzBJfKBfzz84as/lFGWxf+vok0YKz D3M3b4HpgOGm6DJT0Rw5BHf6eU7X3a15IWHPqX8w6phP3REiLncEm7wcV2iJw1vRcCL8 xLHF+OQEutdi8AZM/2OYbt6+IJ1BbQfQCabEnn6IaulUtddhDcPUDNC1KL5n0Kz6XF+R KE4Fw3g3aS0dhn2SJmE0GYtEFj4G1esdKu6tYEq2Af22apqDeCcxcuyB7eTvBSPMGQpS h1AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=HBaKF3ctENLjh/5VUMrpeIPlkYdKfKPC8R4MOlRY2rs=; b=U9eLSMHdLJBSc3+gTOBWgyuZ4A/HRAHxDkU+tL+jLE2WVjr+Ux75TH8cqJdrqSIcvz 9smwu+n/I2S0AEiWY9HRYDVa0SocEP9JifpVP1T/2tPvQkhcyUJmtrvj/eaCm8qF5Kic Kv2AfCNy6BC/QUkstYiFh8GTdm9JoCyp6OBYsIue8fTfEhRSox/V99G5XjTK8ZOTwwpV Z+JC0fckVYmVR8Pr519IMHL4dYH2znMYPdliAIDe7u1lPvLQnKQM+hoKJxmeHBxeVT58 h79PJ2fTBEJQVKZm126VuetRzbD4D/ArrFCq0enHVUDuP+cMCdZaYnag3V5yH4gxYm7h 7PdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vKa9qRer; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nd27-20020a170907629b00b0084c83d43fd6si875313ejc.700.2022.12.28.03.43.53; Wed, 28 Dec 2022 03:44:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vKa9qRer; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232958AbiL1LZF (ORCPT <rfc822;eddaouddi.ayoub@gmail.com> + 99 others); Wed, 28 Dec 2022 06:25:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232525AbiL1LZC (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 28 Dec 2022 06:25:02 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F47510FCB for <linux-kernel@vger.kernel.org>; Wed, 28 Dec 2022 03:25:01 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id g13so23205077lfv.7 for <linux-kernel@vger.kernel.org>; Wed, 28 Dec 2022 03:25:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=HBaKF3ctENLjh/5VUMrpeIPlkYdKfKPC8R4MOlRY2rs=; b=vKa9qRerRMsaoPc7o449DNFCz9NLlEsTyjtFCosdYpre1arTnQ3VFH2DWkSC9PS5Ow mNjj/2q//OxSh+biDdD/C7r+QcVV1dojUbpU7I6kl+sqHVA8QQtVjVePHhPLuHH1EPl6 rwUewum+0lbaiBg3Nih0ZLgwah6bIds8V8K/WMfyWf9zrbmwc0h36HDbzh71XP1NH4cE c9hwChfABqaiAiHBvgNfqf+eLwQFXSYNlmDr/Pipq5LY9Yw2Vw5RxlXXnWGShVIWXtn1 2//OgEGLUlrn6vTXVn5f4lasf8daprInM1QOu1r1b+jwYTmVQQR9mWam2caAS5aNO+Ck B+sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HBaKF3ctENLjh/5VUMrpeIPlkYdKfKPC8R4MOlRY2rs=; b=zfqGIq5cFUuavTmMGMqsoU6F6FPya7/i/lZL68YhrTnwF6scQ+GXqHOetEV4XfD/Zm jbB9YID+DxF8Cx2jqO093W9QQjkzXvlUili5X6UTlb+f5gp6Tv/wBU51M08OGSFHIXyE 5rEKZKh1kcj61iIAwg7n3+QGMjyTkMLsNlAHRJUo56EWTDdf2PjoL9WP8uKIkTl1BGg7 Ygo630IhvLvjs+JQIt9oJ8KiYQP93hg04viZO5JuVL2pfzsr1HS1mVBgPZfCLvd6kdiu IaxwHRm8C0UpRiQEELnCKuFRrQTWAVPmAd8F4CM1qFXxxYkyBjnXRzTU4R+nVwLes8JJ iuuA== X-Gm-Message-State: AFqh2kpJhmTrS8afkxPdYzOHeGD5wCnK+cZGR4K0DuQXqdVxY8nLPI+I 9PpTpQvO09JqzY8KWj/h+OouPA== X-Received: by 2002:a05:6512:31cc:b0:4b0:1305:6ebf with SMTP id j12-20020a05651231cc00b004b013056ebfmr8032274lfe.53.1672226699641; Wed, 28 Dec 2022 03:24:59 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id y16-20020ac255b0000000b004cb0242704asm1627039lfg.255.2022.12.28.03.24.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Dec 2022 03:24:59 -0800 (PST) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH 1/2] arm64: dts: qcom: sm8350: add missing core_bi_pll_test_se GCC clock Date: Wed, 28 Dec 2022 12:24:55 +0100 Message-Id: <20221228112456.31348-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753457998367693541?= X-GMAIL-MSGID: =?utf-8?q?1753457998367693541?= |
Series |
[1/2] arm64: dts: qcom: sm8350: add missing core_bi_pll_test_se GCC clock
|
|
Commit Message
Krzysztof Kozlowski
Dec. 28, 2022, 11:24 a.m. UTC
The GCC bindings expect core_bi_pll_test_se clock input, even if it is
optional:
sm8350-mtp.dtb: clock-controller@100000: clock-names:2: 'core_bi_pll_test_se' was expected
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 ++
1 file changed, 2 insertions(+)
Comments
On 28.12.2022 12:24, Krzysztof Kozlowski wrote: > The GCC bindings expect core_bi_pll_test_se clock input, even if it is > optional: > > sm8350-mtp.dtb: clock-controller@100000: clock-names:2: 'core_bi_pll_test_se' was expected > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Is it even going to be used by anybody, or should we just drop it on the driver side as per usual? Konrad > arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi > index d473194c968d..d5747bb467e0 100644 > --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi > @@ -644,6 +644,7 @@ gcc: clock-controller@100000 { > #power-domain-cells = <1>; > clock-names = "bi_tcxo", > "sleep_clk", > + "core_bi_pll_test_se", > "pcie_0_pipe_clk", > "pcie_1_pipe_clk", > "ufs_card_rx_symbol_0_clk", > @@ -661,6 +662,7 @@ gcc: clock-controller@100000 { > <0>, > <0>, > <0>, > + <0>, > <&ufs_phy_rx_symbol_0_clk>, > <&ufs_phy_rx_symbol_1_clk>, > <&ufs_phy_tx_symbol_0_clk>,
On 28/12/2022 12:37, Konrad Dybcio wrote: > > > On 28.12.2022 12:24, Krzysztof Kozlowski wrote: >> The GCC bindings expect core_bi_pll_test_se clock input, even if it is >> optional: >> >> sm8350-mtp.dtb: clock-controller@100000: clock-names:2: 'core_bi_pll_test_se' was expected >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- > Is it even going to be used by anybody, or should we just drop > it on the driver side as per usual? It's mentioned as possible parent, so there might be users somewhere... Or you want to say that other binding and DTS users cannot use that clock? Best regards, Krzysztof
On 28.12.2022 12:55, Krzysztof Kozlowski wrote: > On 28/12/2022 12:37, Konrad Dybcio wrote: >> >> >> On 28.12.2022 12:24, Krzysztof Kozlowski wrote: >>> The GCC bindings expect core_bi_pll_test_se clock input, even if it is >>> optional: >>> >>> sm8350-mtp.dtb: clock-controller@100000: clock-names:2: 'core_bi_pll_test_se' was expected >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> --- >> Is it even going to be used by anybody, or should we just drop >> it on the driver side as per usual? > > It's mentioned as possible parent, so there might be users somewhere... > Or you want to say that other binding and DTS users cannot use that clock? There's no driver (even downstream) for a supplier of this clock and it's (probably) only used for early validation by qcom folks. What we're interested in, as far as debugging clocks goes, is handled by debugcc [1]. Konrad [1] https://github.com/andersson/debugcc/ > > Best regards, > Krzysztof >
On 28/12/2022 13:55, Krzysztof Kozlowski wrote: > On 28/12/2022 12:37, Konrad Dybcio wrote: >> >> >> On 28.12.2022 12:24, Krzysztof Kozlowski wrote: >>> The GCC bindings expect core_bi_pll_test_se clock input, even if it is >>> optional: >>> >>> sm8350-mtp.dtb: clock-controller@100000: clock-names:2: 'core_bi_pll_test_se' was expected >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> --- >> Is it even going to be used by anybody, or should we just drop >> it on the driver side as per usual? > > It's mentioned as possible parent, so there might be users somewhere... > Or you want to say that other binding and DTS users cannot use that clock? Yes. In the past few months we have been removing the core_bi_pll_test from the old clock drivers (and new clock drivers mostly lack them). Let's remove it from the rest of clock drivers. > > Best regards, > Krzysztof >
On 28/12/2022 13:50, Dmitry Baryshkov wrote: > On 28/12/2022 13:55, Krzysztof Kozlowski wrote: >> On 28/12/2022 12:37, Konrad Dybcio wrote: >>> >>> >>> On 28.12.2022 12:24, Krzysztof Kozlowski wrote: >>>> The GCC bindings expect core_bi_pll_test_se clock input, even if it is >>>> optional: >>>> >>>> sm8350-mtp.dtb: clock-controller@100000: clock-names:2: 'core_bi_pll_test_se' was expected >>>> >>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> --- >>> Is it even going to be used by anybody, or should we just drop >>> it on the driver side as per usual? >> >> It's mentioned as possible parent, so there might be users somewhere... >> Or you want to say that other binding and DTS users cannot use that clock? > > Yes. In the past few months we have been removing the core_bi_pll_test > from the old clock drivers (and new clock drivers mostly lack them). > Let's remove it from the rest of clock drivers. If you are going to start doing the same work, please at least share it upfront. Best regards, Krzysztof
On 28/12/2022 16:25, Krzysztof Kozlowski wrote: > On 28/12/2022 13:50, Dmitry Baryshkov wrote: >> On 28/12/2022 13:55, Krzysztof Kozlowski wrote: >>> On 28/12/2022 12:37, Konrad Dybcio wrote: >>>> >>>> >>>> On 28.12.2022 12:24, Krzysztof Kozlowski wrote: >>>>> The GCC bindings expect core_bi_pll_test_se clock input, even if it is >>>>> optional: >>>>> >>>>> sm8350-mtp.dtb: clock-controller@100000: clock-names:2: 'core_bi_pll_test_se' was expected >>>>> >>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>>> --- >>>> Is it even going to be used by anybody, or should we just drop >>>> it on the driver side as per usual? >>> >>> It's mentioned as possible parent, so there might be users somewhere... >>> Or you want to say that other binding and DTS users cannot use that clock? >> >> Yes. In the past few months we have been removing the core_bi_pll_test >> from the old clock drivers (and new clock drivers mostly lack them). >> Let's remove it from the rest of clock drivers. > > If you are going to start doing the same work, please at least share it > upfront. Excuse me.
On Wed, 28 Dec 2022 12:24:55 +0100, Krzysztof Kozlowski wrote: > The GCC bindings expect core_bi_pll_test_se clock input, even if it is > optional: > > sm8350-mtp.dtb: clock-controller@100000: clock-names:2: 'core_bi_pll_test_se' was expected > > Applied, thanks! [2/2] arm64: dts: qcom: sm8350-sony-xperia-sagami: specify which LDO modes are allowed commit: 8ea261588fe98d171fcecf477a9f27aea8a06fd0 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi index d473194c968d..d5747bb467e0 100644 --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi @@ -644,6 +644,7 @@ gcc: clock-controller@100000 { #power-domain-cells = <1>; clock-names = "bi_tcxo", "sleep_clk", + "core_bi_pll_test_se", "pcie_0_pipe_clk", "pcie_1_pipe_clk", "ufs_card_rx_symbol_0_clk", @@ -661,6 +662,7 @@ gcc: clock-controller@100000 { <0>, <0>, <0>, + <0>, <&ufs_phy_rx_symbol_0_clk>, <&ufs_phy_rx_symbol_1_clk>, <&ufs_phy_tx_symbol_0_clk>,