diff mbox series

[10/13] lto: drop dummy partition mapping

Message ID	orv8lxea5a.fsf@lxoliva.fsfla.org
State	Accepted
Headers	Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AC7D03858D32 To: gcc-patches@gcc.gnu.org Cc: Richard Biener <rguenther@suse.de> Subject: [10/13] lto: drop dummy partition mapping Organization: Free thinker, does not speak for AdaCore References: <or5ydxh4l4.fsf@lxoliva.fsfla.org> Date: Tue, 27 Dec 2022 01:35:45 -0300 In-Reply-To: <or5ydxh4l4.fsf@lxoliva.fsfla.org> (Alexandre Oliva's message of "Tue, 27 Dec 2022 01:07:35 -0300") Message-ID: <orv8lxea5a.fsf@lxoliva.fsfla.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: list From: Alexandre Oliva via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Alexandre Oliva <oliva@adacore.com> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
Series	[01/13] scoped tables: insert before further lookups \| [01/13] scoped tables: insert before further lookups [02/13] varpool: do not add NULL vnodes to referenced [03/13] tree-inline decl_map: skip mapping NULL to itself [04/13,C++] constraint: insert norm entry once [05/13] ssa-loop-niter: skip caching of null operands [06/13] tree-inline decl_map: skip mapping result's NULL default def [07/13] postreload-gcse: no insert on mere lookup [08/13] tm: complete tm_restart insertion [09/13,C++] constexpr: request insert iff depth is ok [10/13] lto: drop dummy partition mapping [11/13] ada: don't map NULL decl to locus [12/13] hash set: reject attempts to add empty values [13/13] hash-map: reject empty-looking insertions [14/17] parloops: don't request insert that won't be completed [15/17] prevent hash set/map insertion of deleted entries [16/17] check hash table counts at expand [17/17] check hash table insertions

Checks

Context	Check	Description
snail/gcc-patch-check	success	Github commit url

Commit Message

Alexandre Oliva Dec. 27, 2022, 4:35 a.m. UTC

  When adding a catch-all partition, we map NULL to it.  That mapping is
ineffective and unnecessary.  Drop it.

Regstrapped on x86_64-linux-gnu.  Ok to install?


for  gcc/lto/ChangeLog

	* lto-partition.cc (lto_1_to_1_map): Drop NULL partition
	mapping.
---
 gcc/lto/lto-partition.cc |    1 -
 1 file changed, 1 deletion(-)

Comments

Jeff Law Dec. 27, 2022, 3:34 p.m. UTC | #1

On 12/26/22 21:35, Alexandre Oliva via Gcc-patches wrote:
> 
> When adding a catch-all partition, we map NULL to it.  That mapping is
> ineffective and unnecessary.  Drop it.
> 
> Regstrapped on x86_64-linux-gnu.  Ok to install?
> 
> 
> for  gcc/lto/ChangeLog
> 
> 	* lto-partition.cc (lto_1_to_1_map): Drop NULL partition
> 	mapping.
OK
jeff

diff mbox series

Patch

diff --git a/gcc/lto/lto-partition.cc b/gcc/lto/lto-partition.cc
index ebb9c3abe128c..654d67f272e92 100644
--- a/gcc/lto/lto-partition.cc
+++ b/gcc/lto/lto-partition.cc
@@ -333,7 +333,6 @@  lto_1_to_1_map (void)
       else
 	{
 	  partition = new_partition ("");
-	  pmap.put (NULL, partition);
 	  npartitions++;
 	}