memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
Commit Message
The clk_disable_unprepare() should be called in the error handling
of devbus_get_timing_params() and of_platform_populate(), fix it by
replacing devm_clk_get and clk_prepare_enable by devm_clk_get_enabled.
Fixes: e81b6abebc87 ("memory: add a driver for atmel ram controllers")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
drivers/memory/mvebu-devbus.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Comments
On Sat, 26 Nov 2022 12:49:11 +0800, Gaosheng Cui wrote:
> The clk_disable_unprepare() should be called in the error handling
> of devbus_get_timing_params() and of_platform_populate(), fix it by
> replacing devm_clk_get and clk_prepare_enable by devm_clk_get_enabled.
>
>
Applied, thanks!
[1/1] memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
https://git.kernel.org/krzk/linux-mem-ctrl/c/cb8fd6f75775165390ededea8799b60d93d9fe3e
Best regards,
@@ -280,10 +280,9 @@ static int mvebu_devbus_probe(struct platform_device *pdev)
if (IS_ERR(devbus->base))
return PTR_ERR(devbus->base);
- clk = devm_clk_get(&pdev->dev, NULL);
+ clk = devm_clk_get_enabled(&pdev->dev, NULL);
if (IS_ERR(clk))
return PTR_ERR(clk);
- clk_prepare_enable(clk);
/*
* Obtain clock period in picoseconds,