arm64: dts: qcom: c630: Fix firmware paths

Message ID 20221226004727.204986-1-steev@kali.org
State New
Headers
Series arm64: dts: qcom: c630: Fix firmware paths |

Commit Message

Steev Klimaszewski Dec. 26, 2022, 12:47 a.m. UTC
  The firmware paths were pointing to qcom/manufacturer whereas other
devices have them under qcom/chipset/manufacturer, so fix this up on the
c630, so we follow the same standard setup.

Signed-off-by: Steev Klimaszewski <steev@kali.org>
---
 arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
  

Comments

Dmitry Baryshkov Dec. 26, 2022, 1:02 a.m. UTC | #1
On Mon, 26 Dec 2022 at 02:47, Steev Klimaszewski <steev@kali.org> wrote:
>
> The firmware paths were pointing to qcom/manufacturer whereas other
> devices have them under qcom/chipset/manufacturer, so fix this up on the
> c630, so we follow the same standard setup.
>
> Signed-off-by: Steev Klimaszewski <steev@kali.org>

Thanks!
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> ---
>  arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
  
Krzysztof Kozlowski Dec. 26, 2022, 12:04 p.m. UTC | #2
On 26/12/2022 01:47, Steev Klimaszewski wrote:
> The firmware paths were pointing to qcom/manufacturer whereas other
> devices have them under qcom/chipset/manufacturer, so fix this up on the
> c630, so we follow the same standard setup.
> 
> Signed-off-by: Steev Klimaszewski <steev@kali.org>

Do not attach your patches to some other threads. It messes with reading
and applying.

Best regards,
Krzysztof
  
Steev Klimaszewski Dec. 26, 2022, 7:23 p.m. UTC | #3
On Mon, Dec 26, 2022 at 6:04 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 26/12/2022 01:47, Steev Klimaszewski wrote:
> > The firmware paths were pointing to qcom/manufacturer whereas other
> > devices have them under qcom/chipset/manufacturer, so fix this up on the
> > c630, so we follow the same standard setup.
> >
> > Signed-off-by: Steev Klimaszewski <steev@kali.org>
>
> Do not attach your patches to some other threads. It messes with reading
> and applying.
>
> Best regards,
> Krzysztof
>
Sorry, I screwed up my first patch, and this was supposed to be a v2
of that one.  I'll do better on other submissions.
  
Bjorn Andersson Dec. 28, 2022, 7:13 p.m. UTC | #4
On Sun, 25 Dec 2022 18:47:27 -0600, Steev Klimaszewski wrote:
> The firmware paths were pointing to qcom/manufacturer whereas other
> devices have them under qcom/chipset/manufacturer, so fix this up on the
> c630, so we follow the same standard setup.
> 
> 

Applied, thanks!

[01/1] arm64: dts: qcom: c630: Fix firmware paths
       commit: 40103eabe3d3139a69e5235cf3a86c89214ef584
[26/26] arm64: dts: qcom: c630: set venus firmware name
        (no commit info)

Best regards,
  

Patch

diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
index 7e80e2950f8d..b04cb563496c 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
@@ -94,7 +94,7 @@  backlight: backlight {
 };
 
 &adsp_pas {
-	firmware-name = "qcom/LENOVO/81JL/qcadsp850.mbn";
+	firmware-name = "qcom/sdm850/LENOVO/81JL/qcadsp850.mbn";
 	status = "okay";
 };
 
@@ -306,7 +306,7 @@  vreg_lvs2a_1p8: lvs2 {
 };
 
 &cdsp_pas {
-	firmware-name = "qcom/LENOVO/81JL/qccdsp850.mbn";
+	firmware-name = "qcom/sdm850/LENOVO/81JL/qccdsp850.mbn";
 	status = "okay";
 };
 
@@ -345,7 +345,7 @@  &gpu {
 	status = "okay";
 	zap-shader {
 		memory-region = <&gpu_mem>;
-		firmware-name = "qcom/LENOVO/81JL/qcdxkmsuc850.mbn";
+		firmware-name = "qcom/sdm850/LENOVO/81JL/qcdxkmsuc850.mbn";
 	};
 };
 
@@ -502,7 +502,7 @@  &mdss {
 
 &mss_pil {
 	status = "okay";
-	firmware-name = "qcom/LENOVO/81JL/qcdsp1v2850.mbn", "qcom/LENOVO/81JL/qcdsp2850.mbn";
+	firmware-name = "qcom/sdm850/LENOVO/81JL/qcdsp1v2850.mbn", "qcom/sdm850/LENOVO/81JL/qcdsp2850.mbn";
 };
 
 &qup_i2c10_default {
@@ -801,6 +801,7 @@  &usb_2_qmpphy {
 };
 
 &venus {
+	firmware-name = "qcom/sdm850/LENOVO/81JL/qcvss850.mbn";
 	status = "okay";
 };