Message ID | 20221223233200.26089-15-quic_wcheng@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6000:1b02:0:0:0:0 with SMTP id f2csp32419wrz; Fri, 23 Dec 2022 15:35:09 -0800 (PST) X-Google-Smtp-Source: AMrXdXs8Csca13VeKnI1XRxMr/I6JeWjGx6A5U3Yt15DOroOYOn0s6vvrZ5obk2EowpE3O0t42UI X-Received: by 2002:a17:906:30d3:b0:838:9b81:1c98 with SMTP id b19-20020a17090630d300b008389b811c98mr8453893ejb.1.1671838509000; Fri, 23 Dec 2022 15:35:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671838508; cv=none; d=google.com; s=arc-20160816; b=NyXD6PIAS1iGMOGG3YYjEuKSgemFlZE4G9QporCc9IqKB3MVqRmqouItScs2Tug531 ReM08cGbPTr4ibMPlZYRHdb0icn0PfM9cgiSgwRs8BNRy1yHawgavi44+Ugx+YWZ3+r8 Tjm2C7VdwZ5+W98+oMlZ9g59tMlEmZBIl/QbU5QlUqVLJHEhkKy0iaSPnNA6B27En+wp BhsG/Rg+mkauX77XFkB8X+EH9ioEI6DliRfK9NG77/LYI0QAcD2EYgOeQjQYhG/j7Wl7 /ElkUDWsX2LvpU18Nz0RKMFgmVsY1ABmDmNJWkrVczN3kF/YxR3xBtQqkVFycabEHu2t EPqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=l+njOKa/UFfOWF7VK5VgFL97OAxm3R4PP9cElfezPbw=; b=LbxXJByejvTzMt70ojjlw/+I97drocF6rPcVWhnypT5ExAddTSiGlPvqOlaG6v1Rlc anKrEOfBB0mq6Z7vWTyz/2lssnQxiuE0eQeplAjh9qBxwfAKF406+BSLnvMFkRvo5v9s pDAksn/1HLtIeJ7uaB9VIhZ4VgsC+A0HSFE0kUCdK2sX2UGI81Mc/1ynPYwo0hZzL9zw IoC2vWLPXbpN7oUpyxd8EwG41WDQ8zZSLWnjBEAtoMPOX25g460aIWjA8s9AEXoPclTt eeD53NiAHxhijwhD9L3CaPdt54c7CUgvz4pWpPnWdFq5ThPUMLg6vkeSwnqDcAuKHJB1 tSaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=BDfQM1rD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y14-20020a17090668ce00b007c17665c404si2920316ejr.960.2022.12.23.15.34.45; Fri, 23 Dec 2022 15:35:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=BDfQM1rD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233631AbiLWXdv (ORCPT <rfc822;pacteraone@gmail.com> + 99 others); Fri, 23 Dec 2022 18:33:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231645AbiLWXdN (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 23 Dec 2022 18:33:13 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37CB711458; Fri, 23 Dec 2022 15:33:12 -0800 (PST) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BNNTUiv005442; Fri, 23 Dec 2022 23:32:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=l+njOKa/UFfOWF7VK5VgFL97OAxm3R4PP9cElfezPbw=; b=BDfQM1rDgFYx5Yg4OSGFVIGTDr5fFfBzYrKCehF5U1KkQJMEQuvRTTWdvVK9QkYEJyQB 4Ufn+rkTQvRVDQcq+O20mDfvPjethgoATImHVQFZmfdwcy13FWyh9X7idZ8QuPBLjvUJ d5t0rLUXcU+ab7k4gH4D8PhZ8EOUw6h32lodMMZmgZBvRCUknTdqRl5v/mmvNMWvOOG/ SfyB/QNOIkCq+m6/G6K7v37MBe34V0e5S/v/dRKJgeZxsUfkXXTHr5cPTTJfKmvYWsU1 zUDa6Xt3XW32SfeJwhs5ny9DbK4FLZ84jYtPVvlRY3uPZ8RAiGkYc5dWWqQB3Nwb+cS6 MA== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3mn2pga506-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Dec 2022 23:32:48 +0000 Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2BNNWlrM001248 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Dec 2022 23:32:47 GMT Received: from hu-wcheng-lv.qualcomm.com (10.49.16.6) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Fri, 23 Dec 2022 15:32:47 -0800 From: Wesley Cheng <quic_wcheng@quicinc.com> To: <srinivas.kandagatla@linaro.org>, <mathias.nyman@intel.com>, <perex@perex.cz>, <broonie@kernel.org>, <lgirdwood@gmail.com>, <andersson@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <gregkh@linuxfoundation.org>, <Thinh.Nguyen@synopsys.com>, <bgoswami@quicinc.com>, <tiwai@suse.com>, <robh+dt@kernel.org>, <agross@kernel.org> CC: <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>, <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>, <linux-usb@vger.kernel.org>, <quic_jackp@quicinc.com>, <quic_plai@quicinc.com>, Wesley Cheng <quic_wcheng@quicinc.com> Subject: [RFC PATCH 14/14] ASoC: dt-bindings: Update example for enabling USB offload on SM8250 Date: Fri, 23 Dec 2022 15:32:00 -0800 Message-ID: <20221223233200.26089-15-quic_wcheng@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221223233200.26089-1-quic_wcheng@quicinc.com> References: <20221223233200.26089-1-quic_wcheng@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: FeDgiKh3WUckl5Si_5rWFheXgwsrsGlF X-Proofpoint-GUID: FeDgiKh3WUckl5Si_5rWFheXgwsrsGlF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-23_08,2022-12-23_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 bulkscore=0 adultscore=0 impostorscore=0 mlxlogscore=799 lowpriorityscore=0 suspectscore=0 mlxscore=0 phishscore=0 clxscore=1015 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212230197 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753049736435823272?= X-GMAIL-MSGID: =?utf-8?q?1753049736435823272?= |
Series |
Introduce QC USB SND audio offloading support
|
|
Commit Message
Wesley Cheng
Dec. 23, 2022, 11:32 p.m. UTC
Add an example on enabling of USB offload for the Q6DSP. The routing can
be done by the mixer, which can pass the multimedia stream to the USB
backend.
Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
---
.../devicetree/bindings/sound/qcom,sm8250.yaml | 13 +++++++++++++
1 file changed, 13 insertions(+)
Comments
On 24/12/2022 00:32, Wesley Cheng wrote: > Add an example on enabling of USB offload for the Q6DSP. The routing can > be done by the mixer, which can pass the multimedia stream to the USB > backend. > > Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com> > --- > .../devicetree/bindings/sound/qcom,sm8250.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > index 70080d04ddc9..60cd84e6727a 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > @@ -216,6 +216,19 @@ examples: > sound-dai = <&vamacro 0>; > }; > }; > + > + usb-dai-link { > + link-name = "USB Playback"; > + cpu { > + sound-dai = <&q6afedai USB_RX>; Hmm, that makes me wonder if you really tested the bindings before sending? If yes, where is the USB_RX defined? Best regards, Krzysztof
On Mon, Dec 26, 2022 at 01:27:21PM +0100, Krzysztof Kozlowski wrote: > On 24/12/2022 00:32, Wesley Cheng wrote: > > + link-name = "USB Playback"; > > + cpu { > > + sound-dai = <&q6afedai USB_RX>; > Hmm, that makes me wonder if you really tested the bindings before > sending? If yes, where is the USB_RX defined? It was added in patch 2, it's in include/dt-bindings.
On Fri, 23 Dec 2022 15:32:00 -0800, Wesley Cheng wrote: > Add an example on enabling of USB offload for the Q6DSP. The routing can > be done by the mixer, which can pass the multimedia stream to the USB > backend. > > Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com> > --- > .../devicetree/bindings/sound/qcom,sm8250.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
On 03/01/2023 18:46, Mark Brown wrote: > On Mon, Dec 26, 2022 at 01:27:21PM +0100, Krzysztof Kozlowski wrote: >> On 24/12/2022 00:32, Wesley Cheng wrote: > >>> + link-name = "USB Playback"; >>> + cpu { >>> + sound-dai = <&q6afedai USB_RX>; > >> Hmm, that makes me wonder if you really tested the bindings before >> sending? If yes, where is the USB_RX defined? > > It was added in patch 2, it's in include/dt-bindings. Thanks, indeed, I was looking for another bindings patch but this was squashed with a driver. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml index 70080d04ddc9..60cd84e6727a 100644 --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml @@ -216,6 +216,19 @@ examples: sound-dai = <&vamacro 0>; }; }; + + usb-dai-link { + link-name = "USB Playback"; + cpu { + sound-dai = <&q6afedai USB_RX>; + }; + codec { + sound-dai = <&usbdai USB_RX>; + }; + platform { + sound-dai = <&q6routing>; + }; + }; }; - |