Message ID | 20221220101249.46450-1-b-kapoor@ti.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp2884515wrn; Tue, 20 Dec 2022 02:24:02 -0800 (PST) X-Google-Smtp-Source: AMrXdXv2UT4e6DmCZE2ZGGvTq3jgmklx0TT/ZGpiQ6N+txiKkyyX5jn9OURd0Icskw/1ojRAmDwh X-Received: by 2002:a17:90b:248:b0:223:495e:f7a1 with SMTP id fz8-20020a17090b024800b00223495ef7a1mr13412653pjb.21.1671531842158; Tue, 20 Dec 2022 02:24:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671531842; cv=none; d=google.com; s=arc-20160816; b=Iz5wc4cejMBzqUIHZNsAUz9z9Bm/WE3y/ElJAbFxjb+3odmvRdWWEzRh+0C1NOrsIO PndwCO8FOqzofK+vtkYiS18LAoJWNC5Wngw4azNprS9e3HJNU1pYo6QoeSCOiKunQTbA 2jhxmB2G8V21qZYxBUABFLe/JcdqoedyRQ5Cr4D0NhTeek5pzmoN7lqFjfMEXBJO+Ie2 NTI0DoGorB645WEJyeCGD7qz8qv5PLAK4pxS4QgK8BktWxbLjQyBVCDXLTO+qPadKBbc qHWD92VRXupm0JGWUrKbmA+7euHIViR/boE0OKUJaMYQpSmcvTGZluBH0K1x66pRz4G3 IuAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=CiV9OzgO0kBsrP7mVMTyx4gTrBVonvx4gVFVswlYw/U=; b=Iaxmav6tAcRWeDXUEd5OokwErSQbQomEMYOFo6ObIhWWhvkVeUawXaEkvlGHof2Bwe yf9CywCENXWvfAkp6gUbbze0pyCjMPoiWJ4iFkrZ/pZvdZC6RFlEL0BEVQOeTSeJDni4 lUo/eNkDcKSxcF8TGnSFDpXan5tPH2nT6qG8U1JC93Tz9qeyiXnq8xkffKm71firwSgT almVXkeL0K0QwoYYB1mz/KeQHEZijP62DBxuHy47tdTzPvwR0Xp4tYIgPYGlDDWVyTez j826Mrrv3DhKCKhMuHjqpTAxjffKMw9wqfgNTCdA1GE4dTQDEBamoEdKR8u1ECqIP2rg ldqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=mEkhkQjS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a63-20020a639042000000b004782769d54fsi14060122pge.36.2022.12.20.02.23.48; Tue, 20 Dec 2022 02:24:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=mEkhkQjS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233346AbiLTKNQ (ORCPT <rfc822;abdi.embedded@gmail.com> + 99 others); Tue, 20 Dec 2022 05:13:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233573AbiLTKNK (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 20 Dec 2022 05:13:10 -0500 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AC736388; Tue, 20 Dec 2022 02:13:08 -0800 (PST) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2BKACrVx084420; Tue, 20 Dec 2022 04:12:53 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1671531173; bh=CiV9OzgO0kBsrP7mVMTyx4gTrBVonvx4gVFVswlYw/U=; h=From:To:CC:Subject:Date; b=mEkhkQjShyJCKMsRDakRvKnFDA+piWuq1JfVaNY1PSDWdWgnheyZJ8qhy9fCeoRoo hWx/J8JBVTrkGcjaLJEusZvZk7X6WRUJjUZqoScNNx9t32Ze+wYsyhOFC+wxHLtIAK jTvy7v5Qk18KO0MbbqT8XhAbykFAUmPUMmsTHtuI= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2BKACr4i104635 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 20 Dec 2022 04:12:53 -0600 Received: from DLEE108.ent.ti.com (157.170.170.38) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Tue, 20 Dec 2022 04:12:52 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Tue, 20 Dec 2022 04:12:52 -0600 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 2BKACo7H075817; Tue, 20 Dec 2022 04:12:52 -0600 From: Bhavya Kapoor <b-kapoor@ti.com> To: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org> CC: <linux-arm-kernel@lists.infradead.org>, <krzysztof.kozlowski+dt@linaro.org>, <robh+dt@kernel.org>, <kristo@kernel.org>, <nm@ti.com> Subject: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes Date: Tue, 20 Dec 2022 15:42:49 +0530 Message-ID: <20221220101249.46450-1-b-kapoor@ti.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748912574425926947?= X-GMAIL-MSGID: =?utf-8?q?1752728173030060092?= |
Series |
arm64: dts: ti: k3-j721s2: Add support for ADC nodes
|
|
Commit Message
Bhavya Kapoor
Dec. 20, 2022, 10:12 a.m. UTC
J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
for 8 channel ADCs for J721s2 SoC.
Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
---
.../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
.../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++-
2 files changed, 55 insertions(+), 1 deletion(-)
Comments
On 20/12/2022 11:12, Bhavya Kapoor wrote: > J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes > for 8 channel ADCs for J721s2 SoC. > > Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com> > --- > .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++ > .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++- > 2 files changed, 55 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts > index a7aa6cf08acd..67593aa69327 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts > @@ -309,3 +309,17 @@ &mcu_mcan1 { > pinctrl-0 = <&mcu_mcan1_pins_default>; > phys = <&transceiver2>; > }; > + > +&tscadc0 { > + status = "okay"; > + adc { > + ti,adc-channels = <0 1 2 3 4 5 6 7>; > + }; > +}; > + > +&tscadc1 { > + status = "okay"; > + adc { > + ti,adc-channels = <0 1 2 3 4 5 6 7>; > + }; > +}; > \ No newline at end of file This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof
On 20/12/22 16:20, Krzysztof Kozlowski wrote: > On 20/12/2022 11:12, Bhavya Kapoor wrote: >> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes >> for 8 channel ADCs for J721s2 SoC. >> >> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com> >> --- >> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++ >> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++- >> 2 files changed, 55 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >> index a7aa6cf08acd..67593aa69327 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >> @@ -309,3 +309,17 @@ &mcu_mcan1 { >> pinctrl-0 = <&mcu_mcan1_pins_default>; >> phys = <&transceiver2>; >> }; >> + >> +&tscadc0 { >> + status = "okay"; >> + adc { >> + ti,adc-channels = <0 1 2 3 4 5 6 7>; >> + }; >> +}; >> + >> +&tscadc1 { >> + status = "okay"; >> + adc { >> + ti,adc-channels = <0 1 2 3 4 5 6 7>; >> + }; >> +}; >> \ No newline at end of file > This is a friendly reminder during the review process. > > It seems my previous comments were not fully addressed. Maybe my > feedback got lost between the quotes, maybe you just forgot to apply it. > Please go back to the previous discussion and either implement all > requested changes or keep discussing them. > > Thank you. > > Best regards, > Krzysztof Hi , I thought i did addressed the feedback since tscadc is just a wrapper node. The actual adc node is inside of tscadc node.
On 21/12/2022 06:42, Bhavya Kapoor wrote: > > On 20/12/22 16:20, Krzysztof Kozlowski wrote: >> On 20/12/2022 11:12, Bhavya Kapoor wrote: >>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes >>> for 8 channel ADCs for J721s2 SoC. >>> >>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com> >>> --- >>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++ >>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++- >>> 2 files changed, 55 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >>> index a7aa6cf08acd..67593aa69327 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >>> @@ -309,3 +309,17 @@ &mcu_mcan1 { >>> pinctrl-0 = <&mcu_mcan1_pins_default>; >>> phys = <&transceiver2>; >>> }; >>> + >>> +&tscadc0 { >>> + status = "okay"; >>> + adc { >>> + ti,adc-channels = <0 1 2 3 4 5 6 7>; >>> + }; >>> +}; >>> + >>> +&tscadc1 { >>> + status = "okay"; >>> + adc { >>> + ti,adc-channels = <0 1 2 3 4 5 6 7>; >>> + }; >>> +}; >>> \ No newline at end of file >> This is a friendly reminder during the review process. >> >> It seems my previous comments were not fully addressed. Maybe my >> feedback got lost between the quotes, maybe you just forgot to apply it. >> Please go back to the previous discussion and either implement all >> requested changes or keep discussing them. >> >> Thank you. >> >> Best regards, >> Krzysztof > > Hi , I thought i did addressed the feedback since tscadc is just a > wrapper node. > > The actual adc node is inside of tscadc node. Read the feedback, from all emails. Best regards, Krzysztof
On 21/12/22 13:24, Krzysztof Kozlowski wrote: > On 21/12/2022 06:42, Bhavya Kapoor wrote: >> On 20/12/22 16:20, Krzysztof Kozlowski wrote: >>> On 20/12/2022 11:12, Bhavya Kapoor wrote: >>>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes >>>> for 8 channel ADCs for J721s2 SoC. >>>> >>>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com> >>>> --- >>>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++ >>>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++- >>>> 2 files changed, 55 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >>>> index a7aa6cf08acd..67593aa69327 100644 >>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >>>> @@ -309,3 +309,17 @@ &mcu_mcan1 { >>>> pinctrl-0 = <&mcu_mcan1_pins_default>; >>>> phys = <&transceiver2>; >>>> }; >>>> + >>>> +&tscadc0 { >>>> + status = "okay"; >>>> + adc { >>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>; >>>> + }; >>>> +}; >>>> + >>>> +&tscadc1 { >>>> + status = "okay"; >>>> + adc { >>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>; >>>> + }; >>>> +}; >>>> \ No newline at end of file >>> This is a friendly reminder during the review process. >>> >>> It seems my previous comments were not fully addressed. Maybe my >>> feedback got lost between the quotes, maybe you just forgot to apply it. >>> Please go back to the previous discussion and either implement all >>> requested changes or keep discussing them. >>> >>> Thank you. >>> >>> Best regards, >>> Krzysztof >> Hi , I thought i did addressed the feedback since tscadc is just a >> wrapper node. >> >> The actual adc node is inside of tscadc node. > Read the feedback, from all emails. > Best regards, > Krzysztof Hi , i have gone through all earlier mails but can't find anything else. Can you point out again whats the issue. Regards
On 22/12/2022 11:39, Bhavya Kapoor wrote: > > On 21/12/22 13:24, Krzysztof Kozlowski wrote: >> On 21/12/2022 06:42, Bhavya Kapoor wrote: >>> On 20/12/22 16:20, Krzysztof Kozlowski wrote: >>>> On 20/12/2022 11:12, Bhavya Kapoor wrote: >>>>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes >>>>> for 8 channel ADCs for J721s2 SoC. >>>>> >>>>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com> >>>>> --- >>>>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++ >>>>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++- >>>>> 2 files changed, 55 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >>>>> index a7aa6cf08acd..67593aa69327 100644 >>>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >>>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >>>>> @@ -309,3 +309,17 @@ &mcu_mcan1 { >>>>> pinctrl-0 = <&mcu_mcan1_pins_default>; >>>>> phys = <&transceiver2>; >>>>> }; >>>>> + >>>>> +&tscadc0 { >>>>> + status = "okay"; >>>>> + adc { >>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>; >>>>> + }; >>>>> +}; >>>>> + >>>>> +&tscadc1 { >>>>> + status = "okay"; >>>>> + adc { >>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>; >>>>> + }; >>>>> +}; >>>>> \ No newline at end of file >>>> This is a friendly reminder during the review process. >>>> >>>> It seems my previous comments were not fully addressed. Maybe my >>>> feedback got lost between the quotes, maybe you just forgot to apply it. >>>> Please go back to the previous discussion and either implement all >>>> requested changes or keep discussing them. >>>> >>>> Thank you. >>>> >>>> Best regards, >>>> Krzysztof >>> Hi , I thought i did addressed the feedback since tscadc is just a >>> wrapper node. >>> >>> The actual adc node is inside of tscadc node. >> Read the feedback, from all emails. >> Best regards, >> Krzysztof > > > Hi , i have gone through all earlier mails but can't find anything else. > Can you point out again whats the issue. "And this is a v2? Or resend? Or something else?" You miss proper versioning and changelog. Additionally - I commented just before error in your patch. You must fix it, not ignore it, even though I did not point it out before. Best regards, Krzysztof
On 22/12/22 16:16, Krzysztof Kozlowski wrote: > On 22/12/2022 11:39, Bhavya Kapoor wrote: >> On 21/12/22 13:24, Krzysztof Kozlowski wrote: >>> On 21/12/2022 06:42, Bhavya Kapoor wrote: >>>> On 20/12/22 16:20, Krzysztof Kozlowski wrote: >>>>> On 20/12/2022 11:12, Bhavya Kapoor wrote: >>>>>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes >>>>>> for 8 channel ADCs for J721s2 SoC. >>>>>> >>>>>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com> >>>>>> --- >>>>>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++ >>>>>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++- >>>>>> 2 files changed, 55 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >>>>>> index a7aa6cf08acd..67593aa69327 100644 >>>>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >>>>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >>>>>> @@ -309,3 +309,17 @@ &mcu_mcan1 { >>>>>> pinctrl-0 = <&mcu_mcan1_pins_default>; >>>>>> phys = <&transceiver2>; >>>>>> }; >>>>>> + >>>>>> +&tscadc0 { >>>>>> + status = "okay"; >>>>>> + adc { >>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>; >>>>>> + }; >>>>>> +}; >>>>>> + >>>>>> +&tscadc1 { >>>>>> + status = "okay"; >>>>>> + adc { >>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>; >>>>>> + }; >>>>>> +}; >>>>>> \ No newline at end of file >>>>> This is a friendly reminder during the review process. >>>>> >>>>> It seems my previous comments were not fully addressed. Maybe my >>>>> feedback got lost between the quotes, maybe you just forgot to apply it. >>>>> Please go back to the previous discussion and either implement all >>>>> requested changes or keep discussing them. >>>>> >>>>> Thank you. >>>>> >>>>> Best regards, >>>>> Krzysztof >>>> Hi , I thought i did addressed the feedback since tscadc is just a >>>> wrapper node. >>>> >>>> The actual adc node is inside of tscadc node. >>> Read the feedback, from all emails. >>> Best regards, >>> Krzysztof >> >> Hi , i have gone through all earlier mails but can't find anything else. >> Can you point out again whats the issue. > "And this is a v2? Or resend? Or something else?" > > You miss proper versioning and changelog. > > Additionally - I commented just before error in your patch. You must fix > it, not ignore it, even though I did not point it out before. > > Best regards, > Krzysztof Hi, i had replied to that as well earlier. You can check that out https://lore.kernel.org/all/89ce3639-e979-e369-657a-20aea4295970@ti.com/ . Maybe you missed out on that. Regards
On 22/12/2022 12:53, Bhavya Kapoor wrote: > > On 22/12/22 16:16, Krzysztof Kozlowski wrote: >> On 22/12/2022 11:39, Bhavya Kapoor wrote: >>> On 21/12/22 13:24, Krzysztof Kozlowski wrote: >>>> On 21/12/2022 06:42, Bhavya Kapoor wrote: >>>>> On 20/12/22 16:20, Krzysztof Kozlowski wrote: >>>>>> On 20/12/2022 11:12, Bhavya Kapoor wrote: >>>>>>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes >>>>>>> for 8 channel ADCs for J721s2 SoC. >>>>>>> >>>>>>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com> >>>>>>> --- >>>>>>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++ >>>>>>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++- >>>>>>> 2 files changed, 55 insertions(+), 1 deletion(-) >>>>>>> >>>>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >>>>>>> index a7aa6cf08acd..67593aa69327 100644 >>>>>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >>>>>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >>>>>>> @@ -309,3 +309,17 @@ &mcu_mcan1 { >>>>>>> pinctrl-0 = <&mcu_mcan1_pins_default>; >>>>>>> phys = <&transceiver2>; >>>>>>> }; >>>>>>> + >>>>>>> +&tscadc0 { >>>>>>> + status = "okay"; >>>>>>> + adc { >>>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>; >>>>>>> + }; >>>>>>> +}; >>>>>>> + >>>>>>> +&tscadc1 { >>>>>>> + status = "okay"; >>>>>>> + adc { >>>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>; >>>>>>> + }; >>>>>>> +}; >>>>>>> \ No newline at end of file >>>>>> This is a friendly reminder during the review process. >>>>>> >>>>>> It seems my previous comments were not fully addressed. Maybe my >>>>>> feedback got lost between the quotes, maybe you just forgot to apply it. >>>>>> Please go back to the previous discussion and either implement all >>>>>> requested changes or keep discussing them. >>>>>> >>>>>> Thank you. >>>>>> >>>>>> Best regards, >>>>>> Krzysztof >>>>> Hi , I thought i did addressed the feedback since tscadc is just a >>>>> wrapper node. >>>>> >>>>> The actual adc node is inside of tscadc node. >>>> Read the feedback, from all emails. >>>> Best regards, >>>> Krzysztof >>> >>> Hi , i have gone through all earlier mails but can't find anything else. >>> Can you point out again whats the issue. >> "And this is a v2? Or resend? Or something else?" >> >> You miss proper versioning and changelog. >> >> Additionally - I commented just before error in your patch. You must fix >> it, not ignore it, even though I did not point it out before. >> >> Best regards, >> Krzysztof > > Hi, i had replied to that as well earlier. You can check that out > https://lore.kernel.org/all/89ce3639-e979-e369-657a-20aea4295970@ti.com/ . > > Maybe you missed out on that. So this is a duplicate? OK, then this patch can be: NAK Best regards, Krzysztof
On 22/12/2022 12:53, Bhavya Kapoor wrote: > > On 22/12/22 16:16, Krzysztof Kozlowski wrote: >> On 22/12/2022 11:39, Bhavya Kapoor wrote: >>> On 21/12/22 13:24, Krzysztof Kozlowski wrote: >>>> On 21/12/2022 06:42, Bhavya Kapoor wrote: >>>>> On 20/12/22 16:20, Krzysztof Kozlowski wrote: >>>>>> On 20/12/2022 11:12, Bhavya Kapoor wrote: >>>>>>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes >>>>>>> for 8 channel ADCs for J721s2 SoC. >>>>>>> >>>>>>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com> >>>>>>> --- >>>>>>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++ >>>>>>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++- >>>>>>> 2 files changed, 55 insertions(+), 1 deletion(-) >>>>>>> >>>>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >>>>>>> index a7aa6cf08acd..67593aa69327 100644 >>>>>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >>>>>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts >>>>>>> @@ -309,3 +309,17 @@ &mcu_mcan1 { >>>>>>> pinctrl-0 = <&mcu_mcan1_pins_default>; >>>>>>> phys = <&transceiver2>; >>>>>>> }; >>>>>>> + >>>>>>> +&tscadc0 { >>>>>>> + status = "okay"; >>>>>>> + adc { >>>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>; >>>>>>> + }; >>>>>>> +}; >>>>>>> + >>>>>>> +&tscadc1 { >>>>>>> + status = "okay"; >>>>>>> + adc { >>>>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>; >>>>>>> + }; >>>>>>> +}; >>>>>>> \ No newline at end of file >>>>>> This is a friendly reminder during the review process. >>>>>> >>>>>> It seems my previous comments were not fully addressed. Maybe my >>>>>> feedback got lost between the quotes, maybe you just forgot to apply it. >>>>>> Please go back to the previous discussion and either implement all >>>>>> requested changes or keep discussing them. >>>>>> >>>>>> Thank you. >>>>>> >>>>>> Best regards, >>>>>> Krzysztof >>>>> Hi , I thought i did addressed the feedback since tscadc is just a >>>>> wrapper node. >>>>> >>>>> The actual adc node is inside of tscadc node. >>>> Read the feedback, from all emails. >>>> Best regards, >>>> Krzysztof >>> >>> Hi , i have gone through all earlier mails but can't find anything else. >>> Can you point out again whats the issue. >> "And this is a v2? Or resend? Or something else?" >> >> You miss proper versioning and changelog. >> >> Additionally - I commented just before error in your patch. You must fix >> it, not ignore it, even though I did not point it out before. >> >> Best regards, >> Krzysztof > > Hi, i had replied to that as well earlier. You can check that out > https://lore.kernel.org/all/89ce3639-e979-e369-657a-20aea4295970@ti.com/ . BTW, there is nothing there about the patch error I wrote here. If not, please point me to the quote which addresses this patch error. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts index a7aa6cf08acd..67593aa69327 100644 --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts @@ -309,3 +309,17 @@ &mcu_mcan1 { pinctrl-0 = <&mcu_mcan1_pins_default>; phys = <&transceiver2>; }; + +&tscadc0 { + status = "okay"; + adc { + ti,adc-channels = <0 1 2 3 4 5 6 7>; + }; +}; + +&tscadc1 { + status = "okay"; + adc { + ti,adc-channels = <0 1 2 3 4 5 6 7>; + }; +}; \ No newline at end of file diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi index 0af242aa9816..ad1bc31619c4 100644 --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi @@ -306,4 +306,44 @@ cpts@3d000 { ti,cpts-periodic-outputs = <2>; }; }; -}; + + tscadc0: tscadc@40200000 { + compatible = "ti,am3359-tscadc"; + reg = <0x0 0x40200000 0x0 0x1000>; + interrupts = <GIC_SPI 892 IRQ_TYPE_LEVEL_HIGH>; + power-domains = <&k3_pds 0 TI_SCI_PD_EXCLUSIVE>; + clocks = <&k3_clks 0 0>; + assigned-clocks = <&k3_clks 0 2>; + assigned-clock-rates = <60000000>; + clock-names = "adc_tsc_fck"; + dmas = <&main_udmap 0x7400>, + <&main_udmap 0x7401>; + dma-names = "fifo0", "fifo1"; + status = "disabled"; + + adc { + #io-channel-cells = <1>; + compatible = "ti,am3359-adc"; + }; + }; + + tscadc1: tscadc@40210000 { + compatible = "ti,am3359-tscadc"; + reg = <0x0 0x40210000 0x0 0x1000>; + interrupts = <GIC_SPI 893 IRQ_TYPE_LEVEL_HIGH>; + power-domains = <&k3_pds 1 TI_SCI_PD_EXCLUSIVE>; + clocks = <&k3_clks 1 0>; + assigned-clocks = <&k3_clks 1 2>; + assigned-clock-rates = <60000000>; + clock-names = "adc_tsc_fck"; + dmas = <&main_udmap 0x7402>, + <&main_udmap 0x7403>; + dma-names = "fifo0", "fifo1"; + status = "disabled"; + + adc { + #io-channel-cells = <1>; + compatible = "ti,am3359-adc"; + }; + }; + }; \ No newline at end of file