Message ID | 20221017142007.5408-3-mengqi.zhang@mediatek.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp1482558wrs; Mon, 17 Oct 2022 07:32:53 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7xuSWeuF5cYPoQhw+I8WPzKMSDmiRKhRqbddAxgskL/ILzaf2eIM87ZqGmQX+sWtnnE9rk X-Received: by 2002:a05:6402:24a0:b0:454:d197:6238 with SMTP id q32-20020a05640224a000b00454d1976238mr10298062eda.274.1666017173790; Mon, 17 Oct 2022 07:32:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666017173; cv=none; d=google.com; s=arc-20160816; b=fQkOIcn3N7yFmF/OsRwCREeanEDot6zdTXMdYVkYBzsXcbLhpLpWQ2p00gk6L2s853 lA1bzFzXom8WxuDHXWZ18C83kGhJk9aY+UIjiQmpbyJXg0StNIHfGK44AKu6VgQY+yHA RxjF2RV80dTB5Qj5S5wLdOEobGzHuW+9yVljpLNt2SLkaV/fYDQWx9UzhafQrQFCtEXw GYrYDvhrTum9WE2LqMGn42zEI+6MGygh/asC2X5hi8hQKh7J8zcr1qWKXbWpjo180M1v L9KhQnrDh/6rin1bpqEmoxXc59Ek+8/0Lr1p5+oT7Pz4PSMAZ+/pZtPZMoz11yLuPYbz y0hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=SCTfi8EohP0/f/dHHu5qpABoBPiRJzFOeNfn7nLzrEY=; b=i0mrJ0BVBuvgMOmiTy/2LsSc47QQRff8BZf2BGqDC39l3AEied88v8gb2ryGzEgfds 7V66XRs1vVS47+XeKOHIUO+vZf3slImr8a+zzn7QJQR7fhHl/aHnyC0BwT+XKc7mbyyx Xbr6LTsY6PU2iStKEk+8le3yWgfoxYOTTDeFuOUglW+8U5JXQILZqQGoMrxWFAAqLZAH xYy5XkdEHWM9x45x5jsDNfuu4pUeW/+/T3qn1sP1dhqfZUti+wpPA2hOnq2TUPOUaxoX BtfPQwNXeEAzVHpeZ/Jc8lWdafM69UKGyk4zgUs+Mo0eOZIoz9sbJUXUcyePKOiFFQvu D70g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=ChQ48xbw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v5-20020a17090606c500b0072b1964e54esi8499721ejb.1007.2022.10.17.07.32.27; Mon, 17 Oct 2022 07:32:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=ChQ48xbw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230336AbiJQOU3 (ORCPT <rfc822;ouuuleilei@gmail.com> + 99 others); Mon, 17 Oct 2022 10:20:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230314AbiJQOUY (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 17 Oct 2022 10:20:24 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1083F5B7B9; Mon, 17 Oct 2022 07:20:21 -0700 (PDT) X-UUID: 9cac9a65c168484abf404c38ca669c74-20221017 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=SCTfi8EohP0/f/dHHu5qpABoBPiRJzFOeNfn7nLzrEY=; b=ChQ48xbwQoffs2pVw5xsHQB1p2ZiyK7ymxsB2HU7eyz88Z0n1Nq5mp2NL6SJEK3CgdsUISZBnbGEctTjBg2oCDkR6mCmrRxklFgHU9ATCibStazGWULRldx2itReRLk6to58gKtL0PmwdFA38BAH+yvhcYE7dvcqF+Ke7+HjRZk=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.11,REQID:a10657d5-d32c-45a8-bcb4-074bd6056c53,IP:0,U RL:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:39a5ff1,CLOUDID:18d80aa4-ebb2-41a8-a87c-97702aaf2e20,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: 9cac9a65c168484abf404c38ca669c74-20221017 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw01.mediatek.com (envelope-from <mengqi.zhang@mediatek.com>) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1120127280; Mon, 17 Oct 2022 22:20:15 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.186) by mtkmbs13n1.mediatek.inc (172.21.101.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Mon, 17 Oct 2022 22:20:14 +0800 Received: from localhost.localdomain (10.17.3.154) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Mon, 17 Oct 2022 22:20:13 +0800 From: Mengqi Zhang <mengqi.zhang@mediatek.com> To: <chaotian.jing@mediatek.com>, <ulf.hansson@linaro.org>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <matthias.bgg@gmail.com>, <wenbin.mei@mediatek.com> CC: <linux-mmc@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-mediatek@lists.infradead.org>, <linux-kernel@vger.kernel.org>, Mengqi Zhang <mengqi.zhang@mediatek.com> Subject: [PATCH 2/2] dt-bingdings: mmc: Mediatek: add ICE clock Date: Mon, 17 Oct 2022 22:20:07 +0800 Message-ID: <20221017142007.5408-3-mengqi.zhang@mediatek.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221017142007.5408-1-mengqi.zhang@mediatek.com> References: <20221017142007.5408-1-mengqi.zhang@mediatek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746945624212774768?= X-GMAIL-MSGID: =?utf-8?q?1746945624212774768?= |
Series |
MediaTek eMMC inline encryption support
|
|
Commit Message
Mengqi Zhang
Oct. 17, 2022, 2:20 p.m. UTC
Document the binding for crypto clock of the Inline Crypto Engine
of Mediatek SoCs.
Signed-off-by: Mengqi Zhang <mengqi.zhang@mediatek.com>
---
Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++
1 file changed, 2 insertions(+)
Comments
Il 17/10/22 16:20, Mengqi Zhang ha scritto: > Document the binding for crypto clock of the Inline Crypto Engine > of Mediatek SoCs. > > Signed-off-by: Mengqi Zhang <mengqi.zhang@mediatek.com> Looks good, but please fix the typo in the commit title. Regards, Angelo
On 17/10/2022 10:20, Mengqi Zhang wrote: > Document the binding for crypto clock of the Inline Crypto Engine > of Mediatek SoCs. This does not match the patch contents at all. > > Signed-off-by: Mengqi Zhang <mengqi.zhang@mediatek.com> > --- > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++ > 1 file changed, 2 insertions(+) Best regards, Krzysztof
On 18/10/2022 14:29, Krzysztof Kozlowski wrote: > On 17/10/2022 10:20, Mengqi Zhang wrote: >> Document the binding for crypto clock of the Inline Crypto Engine >> of Mediatek SoCs. > > This does not match the patch contents at all. Ah, my bad, I read "crypto block", not clock, so it matches. :) However you are not documenting a binding for it. You are adding optional clock. > >> >> Signed-off-by: Mengqi Zhang <mengqi.zhang@mediatek.com> >> --- >> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++ >> 1 file changed, 2 insertions(+) > > Best regards, > Krzysztof > Best regards, Krzysztof
On Mon, 17 Oct 2022 at 16:20, Mengqi Zhang <mengqi.zhang@mediatek.com> wrote: > > Document the binding for crypto clock of the Inline Crypto Engine > of Mediatek SoCs. > > Signed-off-by: Mengqi Zhang <mengqi.zhang@mediatek.com> > --- > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > index d8e1e2e9adf2..f93d686e2911 100644 > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > @@ -57,6 +57,7 @@ properties: > - description: peripheral bus clock gate (required for MT8192). > - description: AXI bus clock gate (required for MT8192). > - description: AHB bus clock gate (required for MT8192). > + - description: crypto clock used for data encrypt/decrypt (optional). > > clock-names: > minItems: 2 > @@ -69,6 +70,7 @@ properties: > - const: pclk_cg > - const: axi_cg > - const: ahb_cg > + - const: crypto Looks like minItems/maxItems for clocks needs to be updated too. > > interrupts: > description: > -- > 2.25.1 > Kind regards Uffe
On Tue, 2022-10-18 at 11:50 +0200, AngeloGioacchino Del Regno wrote: > Il 17/10/22 16:20, Mengqi Zhang ha scritto: > > Document the binding for crypto clock of the Inline Crypto Engine > > of Mediatek SoCs. > > > > Signed-off-by: Mengqi Zhang <mengqi.zhang@mediatek.com> > > Looks good, but please fix the typo in the commit title. > > Regards, > Angelo > Hi Angelo, I have re-sent my patch base on new code base. https://lore.kernel.org/linux-mmc/20221106033924.9854-3-mengqi.zhang@mediatek.com/ Please help to review. Thanks! Regards, Mengqi
On Wed, 2022-11-02 at 16:13 +0100, Ulf Hansson wrote: > On Mon, 17 Oct 2022 at 16:20, Mengqi Zhang <mengqi.zhang@mediatek.com > > wrote: > > > > Document the binding for crypto clock of the Inline Crypto Engine > > of Mediatek SoCs. > > > > Signed-off-by: Mengqi Zhang <mengqi.zhang@mediatek.com> > > --- > > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > index d8e1e2e9adf2..f93d686e2911 100644 > > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > @@ -57,6 +57,7 @@ properties: > > - description: peripheral bus clock gate (required for > > MT8192). > > - description: AXI bus clock gate (required for MT8192). > > - description: AHB bus clock gate (required for MT8192). > > + - description: crypto clock used for data encrypt/decrypt > > (optional). > > > > clock-names: > > minItems: 2 > > @@ -69,6 +70,7 @@ properties: > > - const: pclk_cg > > - const: axi_cg > > - const: ahb_cg > > + - const: crypto > > Looks like minItems/maxItems for clocks needs to be updated too. > > > > > interrupts: > > description: > > -- > > 2.25.1 > > > > Kind regards > Uffe Hi Uffe, I just add crypto clock to mt8186/mt8188/mt8195, does not exceed the minItems/maxItems. I have re-sent my patch, https://lore.kernel.org/linux-mmc/20221106033924.9854-3-mengqi.zhang@mediatek.com/ Please help to review it. Thanks! Regards, Mengqi
diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml index d8e1e2e9adf2..f93d686e2911 100644 --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml @@ -57,6 +57,7 @@ properties: - description: peripheral bus clock gate (required for MT8192). - description: AXI bus clock gate (required for MT8192). - description: AHB bus clock gate (required for MT8192). + - description: crypto clock used for data encrypt/decrypt (optional). clock-names: minItems: 2 @@ -69,6 +70,7 @@ properties: - const: pclk_cg - const: axi_cg - const: ahb_cg + - const: crypto interrupts: description: