Message ID | 20221219194241.3817250-1-hugo@hugovil.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp2585256wrn; Mon, 19 Dec 2022 11:53:17 -0800 (PST) X-Google-Smtp-Source: AA0mqf48nvlQ0Ia4tWrgH/f27pgMeGZ0ImT7CGGkhZmh7MOZEix64vM8Cf3BDew36qygOh+mYXvD X-Received: by 2002:aa7:d5ce:0:b0:46b:aedf:f32b with SMTP id d14-20020aa7d5ce000000b0046baedff32bmr56013629eds.4.1671479597170; Mon, 19 Dec 2022 11:53:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671479597; cv=none; d=google.com; s=arc-20160816; b=NFddbmiVBjLQJExF74BVLyu4hdIWrbiyETYSdlbqzXiWDrrIPwQSVO4uyrMW6YDAtv AqJFdpejOVPfdiB+mqJDSgmz4R1PZUE4PzPSk7oH76PA4tCOEqRd/Zky/jichIQV1XCC 08EPCm8dMUZU0IDuiEOE/7E7iOIuSW+NyLIA9edX6ljBvqkF5A/ExvTICj43uaq+hyAC rjLujnf4X/PDza8SxLYqz0u9hE8C7ZnE9SDYWqwLTOgs/a9jxEO+U/z8mJQWXxV9FJZj hQeGRPsrMDYfqgJUorazhbKr5wE6+jVEfHcQ28intbKUj5eFZBbF2WgCeKADWrjN7DNg AbmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :message-id:date:cc:to:from:dkim-signature; bh=dXTe+uDPBMx9nlPLhWwbmvq6EC47ovYlZ6ePwcNeyig=; b=BJL7vaYf5h/DjDgxsWsYBbGOevpSkWoqQhvhlvvoc1Siz9hGEU6lmqLqbvMOaRuH9d aoWbGBvdUa6xOGoM98xozkRGSHIp0R/5wKttakBJdfSgpZyigxaSijGms50w3fR+g+D/ FCOsOB9mU5qS72JNN3jzbL0nabHkSqOfCghFzcYVJ1cOI5ikz6msXPWAlhRW6IMbVkLC v5vUHNO5iJglkCG2GYZDNIL5fvwoSBWulej8KDkgLIAfSWHgJEqRb7ZLy1lyVvJ0SoBX iPuiENS0ItKhZuylT6jblAKSFPFvpEQlZkbR3aERxMynU72i58Eul1LAijAiXzpt8vJA iLYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=gpt2WMmf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y1-20020a056402358100b0046aee4c4ebdsi10817042edc.103.2022.12.19.11.52.53; Mon, 19 Dec 2022 11:53:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=gpt2WMmf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232073AbiLSTnD (ORCPT <rfc822;abdi.embedded@gmail.com> + 99 others); Mon, 19 Dec 2022 14:43:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229712AbiLSTnB (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 19 Dec 2022 14:43:01 -0500 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C603113E8D; Mon, 19 Dec 2022 11:42:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Cc:To :From:Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=dXTe+uDPBMx9nlPLhWwbmvq6EC47ovYlZ6ePwcNeyig=; b=g pt2WMmfT3TP0f3iHOnyQoLhoKfqHCU/izCQrasa3JTOcER+JDLoqiaVwPctPVfPqjVIipGHO4gaT+ 4+dvsaxCHPt7eNQlWiUSqHU7Iy/ecSgRsXFMfR5Q3RPIyHWjbtB6XD8vBUrK7dd0CwFkIIt0J5mzC wGX+YmzfZ0jbF6+0=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:48616 helo=pettiford.lan) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from <hugo@hugovil.com>) id 1p7M2H-0004Bt-Jd; Mon, 19 Dec 2022 14:42:54 -0500 From: Hugo Villeneuve <hugo@hugovil.com> To: Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: hugo@hugovil.com, bruno.thomsen@gmail.com, Hugo Villeneuve <hvilleneuve@dimonoff.com>, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 19 Dec 2022 14:42:40 -0500 Message-Id: <20221219194241.3817250-1-hugo@hugovil.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Subject: [PATCH] dt-bindings: rtc: pcf2127: add missing pcf/pca2129 entries X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752673390268321552?= X-GMAIL-MSGID: =?utf-8?q?1752673390268321552?= |
Series |
dt-bindings: rtc: pcf2127: add missing pcf/pca2129 entries
|
|
Commit Message
Hugo Villeneuve
Dec. 19, 2022, 7:42 p.m. UTC
From: Hugo Villeneuve <hvilleneuve@dimonoff.com> The pcf2127_of_match structure in drivers/rtc/rtc-pcf2127.c also contains: nxp,pcf2129 ncp,pca2129 Add these missing entries. Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> --- Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) base-commit: e88f319a2546fd7772c726bf3a82a23b0859ddeb
Comments
On Mon, Dec 19, 2022 at 02:42:40PM -0500, Hugo Villeneuve wrote: > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > The pcf2127_of_match structure in drivers/rtc/rtc-pcf2127.c also > contains: > nxp,pcf2129 > ncp,pca2129 > > Add these missing entries. > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> > --- > Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > index cde7b1675ead..00dbae7e23c2 100644 > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > @@ -14,7 +14,10 @@ maintainers: > > properties: > compatible: > - const: nxp,pcf2127 > + enum: > + - nxp,pcf2127 > + - nxp,pcf2129 > + - ncp,pca2129 Check Documentation/devicetree/bindings/rtc/trivial-rtc.yaml. Maybe they aren't trivial after all and should be removed? Or nxp,pcf2127 is also trivial? Rob P.S. 'make dt_compatible_check' will check in the kernel for undocumented (by a schema) compatibles.
On Mon, 19 Dec 2022 16:03:35 -0600 Rob Herring <robh@kernel.org> wrote: > On Mon, Dec 19, 2022 at 02:42:40PM -0500, Hugo Villeneuve wrote: > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > > > The pcf2127_of_match structure in drivers/rtc/rtc-pcf2127.c also > > contains: > > nxp,pcf2129 > > ncp,pca2129 > > > > Add these missing entries. > > > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > --- > > Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > > index cde7b1675ead..00dbae7e23c2 100644 > > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > > @@ -14,7 +14,10 @@ maintainers: > > > > properties: > > compatible: > > - const: nxp,pcf2127 > > + enum: > > + - nxp,pcf2127 > > + - nxp,pcf2129 > > + - ncp,pca2129 > > Check Documentation/devicetree/bindings/rtc/trivial-rtc.yaml. > > Maybe they aren't trivial after all and should be removed? Or > nxp,pcf2127 is also trivial? Hi Rob, the pcf2127, and also the pca/pcf2129, can use the "reset-source" property. Are they still considered "trivial" devices then? Hugo. > P.S. 'make dt_compatible_check' will check in the kernel for > undocumented (by a schema) compatibles. >
On 19/12/2022 20:42, Hugo Villeneuve wrote: > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > The pcf2127_of_match structure in drivers/rtc/rtc-pcf2127.c also > contains: > nxp,pcf2129 > ncp,pca2129 > > Add these missing entries. > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> > --- > Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > index cde7b1675ead..00dbae7e23c2 100644 > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > @@ -14,7 +14,10 @@ maintainers: > > properties: > compatible: > - const: nxp,pcf2127 > + enum: > + - nxp,pcf2127 > + - nxp,pcf2129 > + - ncp,pca2129 Keep the entries sorted, e.g. alphabetically. Best regards, Krzysztof
On 19/12/2022 23:52, Hugo Villeneuve wrote: > On Mon, 19 Dec 2022 16:03:35 -0600 > Rob Herring <robh@kernel.org> wrote: > >> On Mon, Dec 19, 2022 at 02:42:40PM -0500, Hugo Villeneuve wrote: >>> From: Hugo Villeneuve <hvilleneuve@dimonoff.com> >>> >>> The pcf2127_of_match structure in drivers/rtc/rtc-pcf2127.c also >>> contains: >>> nxp,pcf2129 >>> ncp,pca2129 >>> >>> Add these missing entries. >>> >>> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> >>> --- >>> Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml >>> index cde7b1675ead..00dbae7e23c2 100644 >>> --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml >>> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml >>> @@ -14,7 +14,10 @@ maintainers: >>> >>> properties: >>> compatible: >>> - const: nxp,pcf2127 >>> + enum: >>> + - nxp,pcf2127 >>> + - nxp,pcf2129 >>> + - ncp,pca2129 >> >> Check Documentation/devicetree/bindings/rtc/trivial-rtc.yaml. >> >> Maybe they aren't trivial after all and should be removed? Or >> nxp,pcf2127 is also trivial? > > Hi Rob, > the pcf2127, and also the pca/pcf2129, can use the "reset-source" property. Are they still considered "trivial" devices then? Then they do not look trivial, so please remove them from trivial-rtc.yaml. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml index cde7b1675ead..00dbae7e23c2 100644 --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml @@ -14,7 +14,10 @@ maintainers: properties: compatible: - const: nxp,pcf2127 + enum: + - nxp,pcf2127 + - nxp,pcf2129 + - ncp,pca2129 reg: maxItems: 1