| Message ID | 20221206132624.1051104-1-jason@redhat.com |
|---|---|
| State | Accepted |
| Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2819717wrr;
Tue, 6 Dec 2022 05:27:20 -0800 (PST)
X-Google-Smtp-Source:
AA0mqf4NBa+sN+zxGPXcIATML5nChL5ke+NNIwbhS30rXvSQ/H+Wq3J3KvRSsY3OfH2AgY5KFdyM
X-Received: by 2002:a05:6402:396:b0:46b:9c63:fa87 with SMTP id
o22-20020a056402039600b0046b9c63fa87mr27046034edv.100.1670333240322;
Tue, 06 Dec 2022 05:27:20 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1670333240; cv=none;
d=google.com; s=arc-20160816;
b=WB9ZMOEgvDNdba6Hq6dSQuQ9ZAy2vbo91qrzBsPsFZHwMbfBGngZZBJpOuF+18wlnZ
U7Zem3iVdgFS/elQbQ/GupdSiGXN/tuXXpWDoPCNLA9zvupKfbC7hm0Cjjvbtl+E1L7A
xZQ2aSYCoaUfA0ahSRwHRTp2Eyw8zyD18yzqu+Om15R8vBYyiyeKd18tDdX0+DW3gqa4
yEREyUdrqCHTPEGEFMFvik3hK9Y/2hKwEHBi1m1WbCvJR6ZN54jyrAk8m4i+49ixIlUo
eWbxVUOqS6/ZmeeGNjDGBshmIy9LJRBiBNe90IuA54Au9MYf48MqGCLWad6X85/meDwT
kzxw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post
:list-archive:list-unsubscribe:list-id:precedence
:content-transfer-encoding:mime-version:message-id:date:subject:to
:dmarc-filter:delivered-to:dkim-signature:dkim-filter;
bh=gbhrLVJEWk6KBf/3e3Prg7x2C5JP6GgYdawAirx1whE=;
b=SqKOuXKQRVQPo7iwo0ou473AoosblBHqGWd+cqeA6ie4yVSYNJh4qYWejRT1CElayv
CYRGcL+TbssZgpgxrhRhdqCX4K5qrFJMeVnGq010riZQrf51qbSjrzugAv+9jZaLSI+g
BDXDyBFtM/f7l6hSqkEtFbBQvtVXAXU0dOIWmw2yygLDIDB1m7GVcp4FE7hygz7BjSxX
7yDEieBX8LBFMt6WbFzoiPIwBgjPA6hW34ARp18N84jc0NhCvE7Quxv1maTBjZQoPRow
Gk7vGhFFlcXJbLzk7+Ybv3Q7xAVI+QEupjUmYrr9mF6/7mIfbPZpr4TJQ7vtNJDQSEyS
L3pQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@gcc.gnu.org header.s=default header.b=hmKJiwgG;
spf=pass (google.com: domain of
gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as
permitted sender)
smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org";
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org
Received: from sourceware.org (server2.sourceware.org. [8.43.85.97])
by mx.google.com with ESMTPS id
dm8-20020a170907948800b007c08578ed86si13875613ejc.960.2022.12.06.05.27.20
for <ouuuleilei@gmail.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 06 Dec 2022 05:27:20 -0800 (PST)
Received-SPF: pass (google.com: domain of
gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as
permitted sender) client-ip=8.43.85.97;
Authentication-Results: mx.google.com;
dkim=pass header.i=@gcc.gnu.org header.s=default header.b=hmKJiwgG;
spf=pass (google.com: domain of
gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as
permitted sender)
smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org";
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org
Received: from server2.sourceware.org (localhost [IPv6:::1])
by sourceware.org (Postfix) with ESMTP id 3964D3864A2C
for <ouuuleilei@gmail.com>; Tue, 6 Dec 2022 13:27:19 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3964D3864A2C
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
s=default; t=1670333239;
bh=gbhrLVJEWk6KBf/3e3Prg7x2C5JP6GgYdawAirx1whE=;
h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post:
List-Help:List-Subscribe:From:Reply-To:From;
b=hmKJiwgGlhWlgxhiRGyY4AFkXGr+RJZGk+FZbr4kgVPuKDk/m7+Mp5JYGC/iOCBa5
74f712HDb8rGnaCKUzUlQO2BePLxqGwgnBSf5amixSCqk8gp8OGcborefm/ovPzxKv
8ieXaRIXVqemhH+hs9atMlK27jaSScgw9wNM0dxY=
X-Original-To: gcc-patches@gcc.gnu.org
Delivered-To: gcc-patches@gcc.gnu.org
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.133.124])
by sourceware.org (Postfix) with ESMTPS id DA0773864A0B
for <gcc-patches@gcc.gnu.org>; Tue, 6 Dec 2022 13:26:31 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DA0773864A0B
Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com
[209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
us-mta-198-J0ESrla-NlqMDRJMj6yRTQ-1; Tue, 06 Dec 2022 08:26:29 -0500
X-MC-Unique: J0ESrla-NlqMDRJMj6yRTQ-1
Received: by mail-qv1-f71.google.com with SMTP id
ng1-20020a0562143bc100b004bb706b3a27so34332796qvb.20
for <gcc-patches@gcc.gnu.org>; Tue, 06 Dec 2022 05:26:29 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-transfer-encoding:mime-version:message-id:date:subject:to
:from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=gbhrLVJEWk6KBf/3e3Prg7x2C5JP6GgYdawAirx1whE=;
b=zJLdC5FK+C8vPjXKDddcTVx6JHasWXmVfzJPkY5LiId2g+Q+QkZFeQ9lILY0sNQTO8
Lk/+QJP3brdVR6GBO1ZPJ27JhGLjjNKrbc+OEWHvtdTomEVSUtiTCOqgeDT9EMiMWWce
E5iuwJvRXnZEA1PlwnHAciYXlrbvOOiU3f/npYNK7WarQzkg0x4/+VL5D96N5+7PUi1x
oPBWcXZfEm8kOtNzjyFZDsbnzeG8Q656eyL61LZFipVMXdljlctWmf7kqMs36m3su6kn
zebkK/k1ce0nOy4fexV/Kx5FYbNJ0KUcrRhT3hpaUOENe7Riwdd5PJrL43bFYS/Zbu9J
pRPQ==
X-Gm-Message-State: ANoB5pkfj2dZmDh7mMla4cjTiBFMTKhR18Q9RBkCNg85l7TIFw04jaIZ
B/E4FlumLcmeYh2Xx6b8MKt5jR0nhgLA0s6/8MwBpwNG22TZ2uHqGwwew31fUH+Eq0m479xiUpU
bt2kjrevXEPwb/JYPXTSeZv0jznsnZVMSn1EkwJUDC2IMAfoaoLAzsEzhWYY+pBEHkA==
X-Received: by 2002:a37:cce:0:b0:6fe:b359:4896 with SMTP id
197-20020a370cce000000b006feb3594896mr8130337qkm.579.1670333188736;
Tue, 06 Dec 2022 05:26:28 -0800 (PST)
X-Received: by 2002:a37:cce:0:b0:6fe:b359:4896 with SMTP id
197-20020a370cce000000b006feb3594896mr8130303qkm.579.1670333188310;
Tue, 06 Dec 2022 05:26:28 -0800 (PST)
Received: from jason.com
(130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com.
[130.44.159.43]) by smtp.gmail.com with ESMTPSA id
n14-20020a05620a294e00b006fbae4a5f59sm15346404qkp.41.2022.12.06.05.26.27
for <gcc-patches@gcc.gnu.org>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 06 Dec 2022 05:26:27 -0800 (PST)
To: gcc-patches@gcc.gnu.org
Subject: [PATCH RFA] build: add -Wconditionally-supported to strict_warn
[PR64867]
Date: Tue, 6 Dec 2022 08:26:24 -0500
Message-Id: <20221206132624.1051104-1-jason@redhat.com>
X-Mailer: git-send-email 2.31.1
MIME-Version: 1.0
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"; x-default=true
X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0,
RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE,
TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
<mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
<mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
From: Jason Merrill via Gcc-patches <gcc-patches@gcc.gnu.org>
Reply-To: Jason Merrill <jason@redhat.com>
Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org
Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org>
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1751471347543799564?=
X-GMAIL-MSGID: =?utf-8?q?1751471347543799564?=
|
| Series |
[RFA] build: add -Wconditionally-supported to strict_warn [PR64867]
|
|
Checks
| Context | Check | Description |
|---|---|---|
| snail/gcc-patch-check | success | Github commit url |
Commit Message
Jason Merrill
Dec. 6, 2022, 1:26 p.m. UTC
Tested x86_64-pc-linux-gnu, OK for trunk? -- 8< -- The PR (which isn't resolved by this commit) pointed out to me that GCC should build with -Wconditionally-supported to support bootstrapping with a C++11 compiler that makes different choices. PR c++/64867 gcc/ChangeLog: * configure.ac (strict_warn): Add -Wconditionally-supported. * configure: Regenerate. --- gcc/configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: d19aa6af6634b1e97f38431ad091f3b3f12baf2f
Comments
On 12/6/22 08:26, Jason Merrill wrote: > Tested x86_64-pc-linux-gnu, OK for trunk? Ping. > -- 8< -- > > The PR (which isn't resolved by this commit) pointed out to me that GCC > should build with -Wconditionally-supported to support bootstrapping with a > C++11 compiler that makes different choices. > > PR c++/64867 > > gcc/ChangeLog: > > * configure.ac (strict_warn): Add -Wconditionally-supported. > * configure: Regenerate. > --- > gcc/configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/configure.ac b/gcc/configure.ac > index 7ca08726efa..12771fc292c 100644 > --- a/gcc/configure.ac > +++ b/gcc/configure.ac > @@ -580,7 +580,7 @@ ACX_PROG_CC_WARNING_OPTS( > m4_quote(m4_do([-Wstrict-prototypes -Wmissing-prototypes ], > [])), [c_loose_warn]) > ACX_PROG_CXX_WARNING_OPTS( > - m4_quote(m4_do([-Wmissing-format-attribute ], > + m4_quote(m4_do([-Wmissing-format-attribute ], [-Wconditionally-supported ], > [-Woverloaded-virtual])), [strict_warn]) > ACX_PROG_CC_WARNING_OPTS( > m4_quote(m4_do([-Wold-style-definition -Wc++-compat])), [c_strict_warn]) > > base-commit: d19aa6af6634b1e97f38431ad091f3b3f12baf2f
On 12/6/22 06:26, Jason Merrill via Gcc-patches wrote: > Tested x86_64-pc-linux-gnu, OK for trunk? > > -- 8< -- > > The PR (which isn't resolved by this commit) pointed out to me that GCC > should build with -Wconditionally-supported to support bootstrapping with a > C++11 compiler that makes different choices. > > PR c++/64867 > > gcc/ChangeLog: > > * configure.ac (strict_warn): Add -Wconditionally-supported. > * configure: Regenerate. OK. I wonder if it'll trip anything, particularly in the target files. Jeff
On 12/16/22 19:52, Jeff Law wrote: > > > On 12/6/22 06:26, Jason Merrill via Gcc-patches wrote: >> Tested x86_64-pc-linux-gnu, OK for trunk? >> >> -- 8< -- >> >> The PR (which isn't resolved by this commit) pointed out to me that GCC >> should build with -Wconditionally-supported to support bootstrapping >> with a >> C++11 compiler that makes different choices. >> >> PR c++/64867 >> >> gcc/ChangeLog: >> >> * configure.ac (strict_warn): Add -Wconditionally-supported. >> * configure: Regenerate. > OK. I wonder if it'll trip anything, particularly in the target files. Also applying this to fix a breakage reported on IRC:
diff --git a/gcc/configure.ac b/gcc/configure.ac index 7ca08726efa..12771fc292c 100644 --- a/gcc/configure.ac +++ b/gcc/configure.ac @@ -580,7 +580,7 @@ ACX_PROG_CC_WARNING_OPTS( m4_quote(m4_do([-Wstrict-prototypes -Wmissing-prototypes ], [])), [c_loose_warn]) ACX_PROG_CXX_WARNING_OPTS( - m4_quote(m4_do([-Wmissing-format-attribute ], + m4_quote(m4_do([-Wmissing-format-attribute ], [-Wconditionally-supported ], [-Woverloaded-virtual])), [strict_warn]) ACX_PROG_CC_WARNING_OPTS( m4_quote(m4_do([-Wold-style-definition -Wc++-compat])), [c_strict_warn])