Message ID | 20221219191855.2010466-2-allenwebb@google.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp2572177wrn; Mon, 19 Dec 2022 11:19:53 -0800 (PST) X-Google-Smtp-Source: AA0mqf6ubsUhju5JnBPUob6V+rDvxHti7VzxUqixWhOrVCY74aLCxEpKhSSdndEhCktA7rqm12ai X-Received: by 2002:a17:907:2179:b0:7c0:f90f:163d with SMTP id rl25-20020a170907217900b007c0f90f163dmr32712781ejb.11.1671477592970; Mon, 19 Dec 2022 11:19:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671477592; cv=none; d=google.com; s=arc-20160816; b=sT1ukMe5gg/nPHdLp4j8clT2/nV+dnD0c1VAflfqXdKzuh2DKY9bTzjRx/FFd54bTH lmdSvaooIG8E0bjHQpF8+CcGOkLSxyY2zu0yynY7RuKfeLnaVxekg0B2PqAPokLfDIVo SwgeZlKIEFIDe/Pb3LnViG+8kFM1noT9ZrHLK/1xBHURkqDVaGp2Qe/obJ3wWIeCa0zY zrLZn+BufvYOZ5fHCkT6epkwzdUgzclgxzgDeaZqvLZz/eBAur6BJgKlbT1rNgRxZoX1 DG2O3QxSxxdLpu6G6XK7kP8C0JDVGtNoHsjrcuditOZNfdOk4ImfykMdnqXDc+g0yzHQ 8FGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=JPHDmjOz4kw82vudyh2gpNSeY/P1g0Ll1cHkuMKd04M=; b=Sw8H//niDEdDTou/moUvPxlRgTvk8XGYkZ3GItaUpbBR2oZytKgjSzQAQbQ1WXXORs 7AFv76ZnuA1WDpnVx2sRg+f0gQkMMMKSkOxjFByKaqwyqwZ34Y04WYU/SujyVmoBz0WF qtKQN3874Z4kZumah5zteL8OPZTompDgJVD0+q3VfQTCnioPOoY7+th3pN2Q2Q5gVxib HtS6yEsDslLfZT1QW5MwwvsbbCCiROa0x6X0q9cjrwwlLX4q/7IwC0JqEdieFZyqFuEI Eae+jITPISSuAjd81Su66FXFdVHQjJ+33sO/xQx3MIP7E0Hsl53ArqvwenoB52gU6sjU 5FaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=Hl9NxWeW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ne5-20020a1709077b8500b008327270a7ffsi1008718ejc.663.2022.12.19.11.19.29; Mon, 19 Dec 2022 11:19:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=Hl9NxWeW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232586AbiLSTTN (ORCPT <rfc822;abdi.embedded@gmail.com> + 99 others); Mon, 19 Dec 2022 14:19:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232381AbiLSTTB (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 19 Dec 2022 14:19:01 -0500 Received: from mail-il1-x14a.google.com (mail-il1-x14a.google.com [IPv6:2607:f8b0:4864:20::14a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6D7011C0D for <linux-kernel@vger.kernel.org>; Mon, 19 Dec 2022 11:19:00 -0800 (PST) Received: by mail-il1-x14a.google.com with SMTP id x10-20020a056e021bca00b00302b6c0a683so7193204ilv.23 for <linux-kernel@vger.kernel.org>; Mon, 19 Dec 2022 11:19:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=JPHDmjOz4kw82vudyh2gpNSeY/P1g0Ll1cHkuMKd04M=; b=Hl9NxWeWRbBMNIcYbJvo9h4lOhGhAZEsdPi5MbDF9oJxtlLgXY3/mwkDZQWTaIwfkQ uRsDLcZ4I/U1gY4gCmXSISAxWk/Q+4bC9AjBLvXBDAGpdcTe6ZvPzE244kYMz+eA42M7 wUWTlTn5N9Ycs5PdWjiOwiuS4D24OyLvoF1F0RZuvYaBBxdnihvlB8yySBabO1K/gMER IlHNuvhH7i1NM5Zkqc62EZrJphOMVnPQVdcgqbAIpZbhRekeIOeieN7xMd/0cZm4sCYW wHN2yrmAvyiCOSq4m09u35HFC2IdBGxzUUkasE0xaZ33SnBQTRz5fBVfqCSpGlQ3qR0I 8geg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JPHDmjOz4kw82vudyh2gpNSeY/P1g0Ll1cHkuMKd04M=; b=jhPAlyBNoWjGI/lYQmvSmSxA3qCODwv5mv3etLInu1b20lHqet+hSqgAqAGke9OA3G lkKonBdu/qUiPqpaikCtuXGxT1t7yKLt0WtHQ3H7ky+KxEp//mpUSoJ/rCoBiOs6OPx7 sJKJDYfHcJwcGdQzinu5yIZW0Tde+gnvGJ/9qfEFUonuDHH4MGfMYgQVCivpQsTjOhfo 4HBj7TrCkHeYxpgrCA3b3cHGruFgY70XLSFKu4Ki84CtlY37xoSzNIMbjyegd/Qu/Plv gDbGdSDk9khXCuv9Y5TNbc5G83/76DKWIHFwZbcKT2MOr0UdhUT0aYv9K737bDTym2Ny wEyw== X-Gm-Message-State: ANoB5pmF7BM4bvvrbMmKOesZxlymPGNE1Mfg7TtIbFCr+3XdrpUOjf00 Xx7zCCrKYR8D271OSDDjsENjtnvURBYqFEU= X-Received: from allenwebb.c.googlers.com ([fda3:e722:ac3:cc00:2b:ff92:c0a8:12e8]) (user=allenwebb job=sendgmr) by 2002:a02:a117:0:b0:38a:7675:fd26 with SMTP id f23-20020a02a117000000b0038a7675fd26mr5696278jag.300.1671477540032; Mon, 19 Dec 2022 11:19:00 -0800 (PST) Date: Mon, 19 Dec 2022 13:18:47 -0600 In-Reply-To: <20221219191855.2010466-1-allenwebb@google.com> Mime-Version: 1.0 References: <20221216221703.294683-1-allenwebb@google.com> <20221219191855.2010466-1-allenwebb@google.com> X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog Message-ID: <20221219191855.2010466-2-allenwebb@google.com> Subject: [PATCH v8 1/9] imx: Fix typo From: Allen Webb <allenwebb@google.com> To: "linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Cc: Luis Chamberlain <mcgrof@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J. Wysocki" <rafael@kernel.org>, Allen Webb <allenwebb@google.com>, kernel test robot <lkp@intel.com> Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752671288541274539?= X-GMAIL-MSGID: =?utf-8?q?1752671288541274539?= |
Series |
Generate modules.builtin.alias from match ids
|
|
Commit Message
Allen Webb
Dec. 19, 2022, 7:18 p.m. UTC
A one character difference in the name supplied to MODULE_DEVICE_TABLE
breaks a future patch set, so fix the typo.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Allen Webb <allenwebb@google.com>
---
drivers/soc/imx/imx8mp-blk-ctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Mon, Dec 19, 2022 at 01:18:47PM -0600, Allen Webb wrote: > A one character difference in the name supplied to MODULE_DEVICE_TABLE > breaks a future patch set, so fix the typo. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Allen Webb <allenwebb@google.com> > --- > drivers/soc/imx/imx8mp-blk-ctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp-blk-ctrl.c > index 0e3b6ba22f943..344a0a71df14a 100644 > --- a/drivers/soc/imx/imx8mp-blk-ctrl.c > +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c > @@ -743,7 +743,7 @@ static const struct of_device_id imx8mp_blk_ctrl_of_match[] = { > /* Sentinel */ > } > }; > -MODULE_DEVICE_TABLE(of, imx8m_blk_ctrl_of_match); > +MODULE_DEVICE_TABLE(of, imx8mp_blk_ctrl_of_match); What commit id does this fix? Shouldn't this be also cc: stable to resolve this issue for older kernels as obviousl the module device table for auto-loading is not correct? thanks, greg k-h
On Mon, Dec 19, 2022 at 1:22 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Mon, Dec 19, 2022 at 01:18:47PM -0600, Allen Webb wrote: > > A one character difference in the name supplied to MODULE_DEVICE_TABLE > > breaks a future patch set, so fix the typo. > > > > Reported-by: kernel test robot <lkp@intel.com> > > Signed-off-by: Allen Webb <allenwebb@google.com> > > --- > > drivers/soc/imx/imx8mp-blk-ctrl.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp-blk-ctrl.c > > index 0e3b6ba22f943..344a0a71df14a 100644 > > --- a/drivers/soc/imx/imx8mp-blk-ctrl.c > > +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c > > @@ -743,7 +743,7 @@ static const struct of_device_id imx8mp_blk_ctrl_of_match[] = { > > /* Sentinel */ > > } > > }; > > -MODULE_DEVICE_TABLE(of, imx8m_blk_ctrl_of_match); > > +MODULE_DEVICE_TABLE(of, imx8mp_blk_ctrl_of_match); > > What commit id does this fix? Shouldn't this be also cc: stable to > resolve this issue for older kernels as obviousl the module device table > for auto-loading is not correct? I have included Cc stable and Fixes: for the three patches that were obvious typos and will upload a follow-up series shortly. It is unlikely these drivers were being built as modules because the build would have been broken for that configuration. This seems to be the most recent case so it is the most likely to make a difference, but I would imagine SOC drivers might not be loadable in practice if they are needed to bootstrap the system to a point that loadable modules can be accessed. > > thanks, > > greg k-h
diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp-blk-ctrl.c index 0e3b6ba22f943..344a0a71df14a 100644 --- a/drivers/soc/imx/imx8mp-blk-ctrl.c +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c @@ -743,7 +743,7 @@ static const struct of_device_id imx8mp_blk_ctrl_of_match[] = { /* Sentinel */ } }; -MODULE_DEVICE_TABLE(of, imx8m_blk_ctrl_of_match); +MODULE_DEVICE_TABLE(of, imx8mp_blk_ctrl_of_match); static struct platform_driver imx8mp_blk_ctrl_driver = { .probe = imx8mp_blk_ctrl_probe,