diff mbox series

myri10ge: Fix an error handling path in myri10ge_probe()

Message ID f03711f1d0919017c081e273e16afd9009874fd4.1671386898.git.christophe.jaillet@wanadoo.fr
State New
Headers
Series myri10ge: Fix an error handling path in myri10ge_probe() |

Commit Message

Christophe JAILLET Dec. 18, 2022, 6:08 p.m. UTC 
  Some memory allocated in myri10ge_probe_slices() is not released in the
error handling path of myri10ge_probe().

Add the corresponding kfree(), as already done in the remove function.

Fixes: 0dcffac1a329 ("myri10ge: add multislices support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 1 +
 1 file changed, 1 insertion(+)

Comments

patchwork-bot+netdevbpf@kernel.org Dec. 19, 2022, 12:40 p.m. UTC | #1 
Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Sun, 18 Dec 2022 19:08:40 +0100 you wrote:
> Some memory allocated in myri10ge_probe_slices() is not released in the
> error handling path of myri10ge_probe().
> 
> Add the corresponding kfree(), as already done in the remove function.
> 
> Fixes: 0dcffac1a329 ("myri10ge: add multislices support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> 
> [...]

Here is the summary with links:
  - myri10ge: Fix an error handling path in myri10ge_probe()
    https://git.kernel.org/netdev/net/c/d83b950d44d2

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
index 8073d7a90a26..c5687d94ea88 100644
--- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
+++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
@@ -3912,6 +3912,7 @@  static int myri10ge_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	myri10ge_free_slices(mgp);
 
 abort_with_firmware:
+	kfree(mgp->msix_vectors);
 	myri10ge_dummy_rdma(mgp, 0);
 
 abort_with_ioremap: