Message ID | 20221111082912.14557-1-matthias.bgg@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp619744wru; Fri, 11 Nov 2022 00:39:37 -0800 (PST) X-Google-Smtp-Source: AA0mqf5L09qjIYvXqsGMPjsgtTsNIuvCMZC06NktRbt74qWs2iO6EOpGEKBLUgH2XyTliVwMM4Cu X-Received: by 2002:aa7:d3c6:0:b0:463:c64e:bc75 with SMTP id o6-20020aa7d3c6000000b00463c64ebc75mr584111edr.205.1668155976885; Fri, 11 Nov 2022 00:39:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668155976; cv=none; d=google.com; s=arc-20160816; b=eXU2ybF3D2zINXFyuugGHMhTAwsDKEuuOmoPio01SgtKFAukOnrhnHHfSP6awpSmuc oU56MnR/dl7OoWyTirs5VwlfmxJae/f/iLX93KT99MMySQAhYqcVjZO51MoVu/EvjdG8 LW140arenJz32iS8GfCUENRlOVY2dwkgjhZTUwvfFHY41t2MRgbPEUPSVVq+wh/WeIX2 uHAkFcb0ugfIa4BECNabRvspMfZ4D6UQY3jd2+WYXhNrHMAN6VPZVmERKjAs91Q/f6A/ Qn1vpHWo0wrWILoOBUPr1VOTZyOWMO8a/DbzwIqyiHDE8WOU3jidAy+pLrN4m4oGTQbB HvKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=O7XFRD57Ip4dGqDJ0XOR7pxNjCqTahxYqdQzy3E8aVM=; b=CF1m96SNfIX7r+kJAfIZn088WR2vBo+d4c1J3YI67Slv+gDI3JT3elmH2mte44oY5m /vLYkVhFfCNEOPRr8aDXoP068sqyeU2ujIPKGpEsHPr6BOIVKPicfXnZQi6pZzYQV65d KQtbLRC1y3+L8GsscAH4FvnKPpuxFBP7xe2FBsgyZko+SR5jXOwEXj47rSJhkpgtmGQL /VvtHL4AURf5DqXAMYkM5rRo09xmyAoz6F8nle4fefd3GWrEyICF49cvstTsL4SnUb1R E+lyWNscSDsXpeslduckJn5s/bv6biT3ugGmYkVXx989PLzic5kcBN7ZPx2W0yqEAC8u AdhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="STTRE6H/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x4-20020a05640226c400b0046199bc9130si304067edd.467.2022.11.11.00.39.13; Fri, 11 Nov 2022 00:39:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="STTRE6H/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233009AbiKKI3c (ORCPT <rfc822;winker.wchi@gmail.com> + 99 others); Fri, 11 Nov 2022 03:29:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232935AbiKKI33 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 11 Nov 2022 03:29:29 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B1A8E79 for <linux-kernel@vger.kernel.org>; Fri, 11 Nov 2022 00:29:29 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ACF1761EBB for <linux-kernel@vger.kernel.org>; Fri, 11 Nov 2022 08:29:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C739BC433D6; Fri, 11 Nov 2022 08:29:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668155368; bh=IbKTOSMRuvpV8+oOxfdFXA1JqBMgz65cI7OeqnvELIk=; h=From:To:Cc:Subject:Date:From; b=STTRE6H/1T/mrvwgv3N6PQyijKtXpeAPGlTOng+Osur9C0CwbVaiO9InFBF7R7Q3H cisSqYm8zwxZjrgPdkHu/3VSAnLRnHNrwshrfC0Q4gA/tQ/ED9ht4sVr1+1GPB2nIS p7g8CUfJzAZgCJ4ZRZNK0KWSsg/DmZKHkLHX7Ug9hJNqNVXhVoIvz4VEf3ap6KxysS 2F74FPN/SQg5I3IFmSms3bHZfD5+O0oTJ7jyfv0cjYngcD08dZxM09+trxaTGX5atV hPWd/ByQacSUXyxWZPM6NnJtQ53VW96zs2AIWEHqCM1UZ5Bu6cKVo25053IyiM+vNQ N40vxDESs3Law== From: matthias.bgg@kernel.org To: matthias.bgg@gmail.com, nancy.lin@mediatek.com Cc: linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] soc: mediatek: Add deprecated compatible to mmsys Date: Fri, 11 Nov 2022 09:29:12 +0100 Message-Id: <20221111082912.14557-1-matthias.bgg@kernel.org> X-Mailer: git-send-email 2.38.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749110987222214691?= X-GMAIL-MSGID: =?utf-8?q?1749188321717786216?= |
Series |
[v2] soc: mediatek: Add deprecated compatible to mmsys
|
|
Commit Message
Matthias Brugger
Nov. 11, 2022, 8:29 a.m. UTC
From: Matthias Brugger <matthias.bgg@gmail.com> For backward compatibility we add the deprecated compatible. Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com> --- Changes since v1: - fix drive data pointer drivers/soc/mediatek/mtk-mmsys.c | 4 ++++ 1 file changed, 4 insertions(+)
Comments
Il 11/11/22 09:29, matthias.bgg@kernel.org ha scritto: > From: Matthias Brugger <matthias.bgg@gmail.com> > > For backward compatibility we add the deprecated compatible. > > Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> ...And tested on MT8195 Cherry Chromebook. Cheers, Angelo
On 14/11/2022 12:58, AngeloGioacchino Del Regno wrote: > Il 11/11/22 09:29, matthias.bgg@kernel.org ha scritto: >> From: Matthias Brugger <matthias.bgg@gmail.com> >> >> For backward compatibility we add the deprecated compatible. >> >> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com> > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > ...And tested on MT8195 Cherry Chromebook. > Applied, thanks for testing!
On Mon, Nov 14, 2022 at 7:59 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > Il 11/11/22 09:29, matthias.bgg@kernel.org ha scritto: > > From: Matthias Brugger <matthias.bgg@gmail.com> > > > > For backward compatibility we add the deprecated compatible. > > > > Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com> > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > ...And tested on MT8195 Cherry Chromebook. This now seems like a bad idea. In the dtsi we have two nodes (vdosys0 and vdosys1) that both currently use the -mmsys compatible, which in the driver maps to vdosys0. So not only do we have vdosys1 incorrectly probing as vdosys0, we also have duplicate clks being registered and duplicate DRM pipelines. On my device vdosys1 ends up winning the duplicate clock race. I suggest just reverting this. The display stuff won't be useful unless the drivers are able to distinguish themselves from one another. Regards ChenYu
On Thu, Dec 1, 2022 at 7:20 PM Chen-Yu Tsai <wenst@chromium.org> wrote: > > On Mon, Nov 14, 2022 at 7:59 PM AngeloGioacchino Del Regno > <angelogioacchino.delregno@collabora.com> wrote: > > > > Il 11/11/22 09:29, matthias.bgg@kernel.org ha scritto: > > > From: Matthias Brugger <matthias.bgg@gmail.com> > > > > > > For backward compatibility we add the deprecated compatible. > > > > > > Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com> > > > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > > > ...And tested on MT8195 Cherry Chromebook. > > This now seems like a bad idea. In the dtsi we have two nodes (vdosys0 and > vdosys1) that both currently use the -mmsys compatible, which in the driver > maps to vdosys0. So not only do we have vdosys1 incorrectly probing as > vdosys0, we also have duplicate clks being registered and duplicate DRM > pipelines. On my device vdosys1 ends up winning the duplicate clock race. > > I suggest just reverting this. The display stuff won't be useful unless > the drivers are able to distinguish themselves from one another. That and try to fix the vdosys0 node ASAP. > Regards > ChenYu
On 01/12/2022 12:20, Chen-Yu Tsai wrote: > On Mon, Nov 14, 2022 at 7:59 PM AngeloGioacchino Del Regno > <angelogioacchino.delregno@collabora.com> wrote: >> >> Il 11/11/22 09:29, matthias.bgg@kernel.org ha scritto: >>> From: Matthias Brugger <matthias.bgg@gmail.com> >>> >>> For backward compatibility we add the deprecated compatible. >>> >>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com> >> >> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> >> ...And tested on MT8195 Cherry Chromebook. > > This now seems like a bad idea. In the dtsi we have two nodes (vdosys0 and > vdosys1) that both currently use the -mmsys compatible, which in the driver > maps to vdosys0. So not only do we have vdosys1 incorrectly probing as > vdosys0, we also have duplicate clks being registered and duplicate DRM > pipelines. On my device vdosys1 ends up winning the duplicate clock race. > That's true, we should fix the DTS deleting vdosys1 node as it's not implemented. While at it we should also fix the compatible for vdosys0 as "mediatek,mt8195-mmsys" is now deprecated. Would you mind to send a patch? Regards, Matthias > I suggest just reverting this. The display stuff won't be useful unless > the drivers are able to distinguish themselves from one another. >
On 01/12/2022 12:25, Chen-Yu Tsai wrote: > On Thu, Dec 1, 2022 at 7:20 PM Chen-Yu Tsai <wenst@chromium.org> wrote: >> >> On Mon, Nov 14, 2022 at 7:59 PM AngeloGioacchino Del Regno >> <angelogioacchino.delregno@collabora.com> wrote: >>> >>> Il 11/11/22 09:29, matthias.bgg@kernel.org ha scritto: >>>> From: Matthias Brugger <matthias.bgg@gmail.com> >>>> >>>> For backward compatibility we add the deprecated compatible. >>>> >>>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com> >>> >>> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >>> >>> ...And tested on MT8195 Cherry Chromebook. >> >> This now seems like a bad idea. In the dtsi we have two nodes (vdosys0 and >> vdosys1) that both currently use the -mmsys compatible, which in the driver >> maps to vdosys0. So not only do we have vdosys1 incorrectly probing as >> vdosys0, we also have duplicate clks being registered and duplicate DRM >> pipelines. On my device vdosys1 ends up winning the duplicate clock race. >> >> I suggest just reverting this. The display stuff won't be useful unless >> the drivers are able to distinguish themselves from one another. > > That and try to fix the vdosys0 node ASAP. I'm not sure what you mean? If there are any patches that are in my queue that needs attention, please let me know. Regards, Matthias
On Fri, Dec 16, 2022 at 9:35 PM Matthias Brugger <matthias.bgg@gmail.com> wrote: > > > > On 01/12/2022 12:25, Chen-Yu Tsai wrote: > > On Thu, Dec 1, 2022 at 7:20 PM Chen-Yu Tsai <wenst@chromium.org> wrote: > >> > >> On Mon, Nov 14, 2022 at 7:59 PM AngeloGioacchino Del Regno > >> <angelogioacchino.delregno@collabora.com> wrote: > >>> > >>> Il 11/11/22 09:29, matthias.bgg@kernel.org ha scritto: > >>>> From: Matthias Brugger <matthias.bgg@gmail.com> > >>>> > >>>> For backward compatibility we add the deprecated compatible. > >>>> > >>>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com> > >>> > >>> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > >>> > >>> ...And tested on MT8195 Cherry Chromebook. > >> > >> This now seems like a bad idea. In the dtsi we have two nodes (vdosys0 and > >> vdosys1) that both currently use the -mmsys compatible, which in the driver > >> maps to vdosys0. So not only do we have vdosys1 incorrectly probing as > >> vdosys0, we also have duplicate clks being registered and duplicate DRM > >> pipelines. On my device vdosys1 ends up winning the duplicate clock race. > >> > >> I suggest just reverting this. The display stuff won't be useful unless > >> the drivers are able to distinguish themselves from one another. > > > > That and try to fix the vdosys0 node ASAP. > > I'm not sure what you mean? If there are any patches that are in my queue that > needs attention, please let me know. It was more of a P.S. note.
On Fri, Dec 16, 2022 at 9:33 PM Matthias Brugger <matthias.bgg@gmail.com> wrote: > > > > On 01/12/2022 12:20, Chen-Yu Tsai wrote: > > On Mon, Nov 14, 2022 at 7:59 PM AngeloGioacchino Del Regno > > <angelogioacchino.delregno@collabora.com> wrote: > >> > >> Il 11/11/22 09:29, matthias.bgg@kernel.org ha scritto: > >>> From: Matthias Brugger <matthias.bgg@gmail.com> > >>> > >>> For backward compatibility we add the deprecated compatible. > >>> > >>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com> > >> > >> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > >> > >> ...And tested on MT8195 Cherry Chromebook. > > > > This now seems like a bad idea. In the dtsi we have two nodes (vdosys0 and > > vdosys1) that both currently use the -mmsys compatible, which in the driver > > maps to vdosys0. So not only do we have vdosys1 incorrectly probing as > > vdosys0, we also have duplicate clks being registered and duplicate DRM > > pipelines. On my device vdosys1 ends up winning the duplicate clock race. > > > > That's true, we should fix the DTS deleting vdosys1 node as it's not > implemented. While at it we should also fix the compatible for vdosys0 as > "mediatek,mt8195-mmsys" is now deprecated. > > Would you mind to send a patch? I'll be going on vacation shortly, and will be back after Christmas. Reading the above, I assume you want two patches? One to drop the deprecated compatible, and another to delete the vdosys1 node? And both should be tag with fixes and backported? I can take care of it after I get back. If someone wants to beat me to it, feel free to do it. ChenYu
diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c index ba2e79b26993b..f3431448e8431 100644 --- a/drivers/soc/mediatek/mtk-mmsys.c +++ b/drivers/soc/mediatek/mtk-mmsys.c @@ -303,6 +303,10 @@ static const struct of_device_id of_match_mtk_mmsys[] = { .compatible = "mediatek,mt8192-mmsys", .data = &mt8192_mmsys_driver_data, }, + { /* deprecated compatible */ + .compatible = "mediatek,mt8195-mmsys", + .data = &mt8195_vdosys0_driver_data, + }, { .compatible = "mediatek,mt8195-vdosys0", .data = &mt8195_vdosys0_driver_data,