Message ID | 20221214125821.12489-2-paul@crapouillou.net |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp202949wrn; Wed, 14 Dec 2022 05:02:27 -0800 (PST) X-Google-Smtp-Source: AA0mqf48MSY6aypga7BscmXxDAzAYs+1o1NYZPDrRArC/gpr6lxrmTbX049/DrmzvbTHs2M4sTvG X-Received: by 2002:a17:906:e104:b0:7c1:22ad:655a with SMTP id gj4-20020a170906e10400b007c122ad655amr18810790ejb.23.1671022947147; Wed, 14 Dec 2022 05:02:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671022947; cv=none; d=google.com; s=arc-20160816; b=TRt+EJVAjV1oP/HJ63uaV7Hehnk79azXMfBdhdGt901FPRGT+NCaiCeRol87YPjSGI bgmmeoc9AK/OOIbAJHQf8D3rMd5wBm38Ijuyy4Scbe6HjNM49DP5PVjpqj5wToG8PDze G4eiChIHWWje7Sz94deRxV4/vNDsqjtdIdcgIxyQO4knCjJmEP6V/D7hQpFcZUDjD9TZ Y4etYymJk50mR6oG8hUkY3obgGr4WkT9YH2u02PxTpB8NeNCBMhSb454JloaHL9Hp1BM lTNcNlNKztHhcqwmUW/JfJhT48c9j3+TIqtbX8j92EknYRjjKVNG7BSgjL3sXX378a1J aO3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=V929Ie0WGrd9/qKW1WSMq4nbVzLzTmKoyeEjONPKBnc=; b=fHkT3UxC30EX8w563Ge+/ztKYCvwoPpsooq4HYVulp0DFj05irzd/djDVSs1pUDgwP b6nA8UU9QvhGPy/GPQw/pEtZ+qivEHYo67fN5tZf+fBNS7EKx41/bc8njdBdhhOVQEQN 10I54fh4Z4TiMraqsuDIkShPu8WRbayUI4TJ2slL9xYXZ3aWHx7MOKKVoXjQq3UQG+Rs lEklgDfE8iTwxAPavJ5U4inqgKwqrC5U/oxlpQEzUfPrZ7gRQEciiy3uxO1gMUorQ6ze KxZyiWyMN4JtudzeJn2ecw6ZS6lx2Vpdae8wGYT9FRMR3WKTVsN25vnF1onIc3fapk+e 1NIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=WJrDdD0K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nd39-20020a17090762a700b007adb388df38si11391832ejc.706.2022.12.14.05.01.40; Wed, 14 Dec 2022 05:02:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=WJrDdD0K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238372AbiLNM6s (ORCPT <rfc822;jeantsuru.cumc.mandola@gmail.com> + 99 others); Wed, 14 Dec 2022 07:58:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238310AbiLNM6p (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 14 Dec 2022 07:58:45 -0500 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 933ACB1F3; Wed, 14 Dec 2022 04:58:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1671022716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V929Ie0WGrd9/qKW1WSMq4nbVzLzTmKoyeEjONPKBnc=; b=WJrDdD0KZkbeWjEVzhorAQsFnjG1x/ACBPKI1qF/hggOPz1woTq/bByJ0rc5U+Ul+ZKhoY 110VJ0A1hd3ZwW0AQYzOP15z/4/CiCMhklQhAkoj78fYrRPQzzETqUFz45j+hx4JlWdcD+ wNxf6JR7hlAyzVJvpWSuOtxp7bE1FyU= From: Paul Cercueil <paul@crapouillou.net> To: Phong LE <ple@baylibre.com>, Neil Armstrong <neil.armstrong@linaro.org>, Andrzej Hajda <andrzej.hajda@intel.com>, Robert Foss <robert.foss@linaro.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: list@opendingux.net, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Cercueil <paul@crapouillou.net> Subject: [PATCH 01/10] dt-bindings: display: bridge: it66121: Add compatible string for IT6610 Date: Wed, 14 Dec 2022 13:58:12 +0100 Message-Id: <20221214125821.12489-2-paul@crapouillou.net> In-Reply-To: <20221214125821.12489-1-paul@crapouillou.net> References: <20221214125821.12489-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752194557948605218?= X-GMAIL-MSGID: =?utf-8?q?1752194557948605218?= |
Series |
drm: bridge: it66121: IT6610 support and cleanups
|
|
Commit Message
Paul Cercueil
Dec. 14, 2022, 12:58 p.m. UTC
Add a new ite,it6610 compatible string to the IT66121 binding
documentation, since the two chips are very similar.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
.../devicetree/bindings/display/bridge/ite,it66121.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Comments
On Wed, 14 Dec 2022 at 13:58, Paul Cercueil <paul@crapouillou.net> wrote: > > Add a new ite,it6610 compatible string to the IT66121 binding > documentation, since the two chips are very similar. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > --- > .../devicetree/bindings/display/bridge/ite,it66121.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml > index 1b2185be92cd..72957be0ba3c 100644 > --- a/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml > @@ -17,7 +17,9 @@ description: | > > properties: > compatible: > - const: ite,it66121 > + enum: > + - ite,it66121 > + - ite,it6610 > > reg: > maxItems: 1 > -- > 2.35.1 > Reviewed-by: Robert Foss <robert.foss@linaro.org>
Le jeudi 15 décembre 2022 à 11:55 +0100, Robert Foss a écrit : > On Wed, 14 Dec 2022 at 13:58, Paul Cercueil <paul@crapouillou.net> > wrote: > > > > Add a new ite,it6610 compatible string to the IT66121 binding > > documentation, since the two chips are very similar. > > > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > > --- > > .../devicetree/bindings/display/bridge/ite,it66121.yaml | 4 > > +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git > > a/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml > > b/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml > > index 1b2185be92cd..72957be0ba3c 100644 > > --- > > a/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml > > +++ > > b/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml > > @@ -17,7 +17,9 @@ description: | > > > > properties: > > compatible: > > - const: ite,it66121 > > + enum: > > + - ite,it66121 > > + - ite,it6610 > > > > reg: > > maxItems: 1 > > -- > > 2.35.1 > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org> Series applied to drm-misc-next. Thanks for the reviews! Cheers, -Paul
On 16/12/2022 11:46, Paul Cercueil wrote: >>> properties: >>> compatible: >>> - const: ite,it66121 >>> + enum: >>> + - ite,it66121 >>> + - ite,it6610 These should be ordered alphabetically. What's with the tendency of adding always to the end? >>> >>> reg: >>> maxItems: 1 >>> -- >>> 2.35.1 >>> >> >> Reviewed-by: Robert Foss <robert.foss@linaro.org> > > Series applied to drm-misc-next. > I wished you give DT maintainers a bit more time than two days. Best regards, Krzysztof
Hi Krzysztof, Le vendredi 16 décembre 2022 à 12:21 +0100, Krzysztof Kozlowski a écrit : > On 16/12/2022 11:46, Paul Cercueil wrote: > > > > > properties: > > > > compatible: > > > > - const: ite,it66121 > > > > + enum: > > > > + - ite,it66121 > > > > + - ite,it6610 > > These should be ordered alphabetically. What's with the tendency of > adding always to the end? I'm too used to the "inverse christmas tree" sort :) I can send a quickfix patch if you really want alphabetical order. > > > > > > > > reg: > > > > maxItems: 1 > > > > -- > > > > 2.35.1 > > > > > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org> > > > > Series applied to drm-misc-next. > > > I wished you give DT maintainers a bit more time than two days. Noted. Sorry about that. Cheers, -Paul
On 16/12/2022 13:21, Paul Cercueil wrote: > Hi Krzysztof, > > Le vendredi 16 décembre 2022 à 12:21 +0100, Krzysztof Kozlowski a > écrit : >> On 16/12/2022 11:46, Paul Cercueil wrote: >> >>>>> properties: >>>>> compatible: >>>>> - const: ite,it66121 >>>>> + enum: >>>>> + - ite,it66121 >>>>> + - ite,it6610 >> >> These should be ordered alphabetically. What's with the tendency of >> adding always to the end? > > I'm too used to the "inverse christmas tree" sort :) Since these are not variables and they will not get shorter, any christmas tree sorting here is the same conflict-prone as adding to the end. > > I can send a quickfix patch if you really want alphabetical order. No, no need. Best regards, Krzysztof
On Fri, Dec 16, 2022 at 01:21:54PM +0100, Paul Cercueil wrote: > Hi Krzysztof, > > Le vendredi 16 décembre 2022 à 12:21 +0100, Krzysztof Kozlowski a > écrit : > > On 16/12/2022 11:46, Paul Cercueil wrote: > > > > > > > properties: > > > > > compatible: > > > > > - const: ite,it66121 > > > > > + enum: > > > > > + - ite,it66121 > > > > > + - ite,it6610 > > > > These should be ordered alphabetically. What's with the tendency of > > adding always to the end? > > I'm too used to the "inverse christmas tree" sort :) Come on, the DT standard is sideways christmas tree. ;) Rob
diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml index 1b2185be92cd..72957be0ba3c 100644 --- a/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml +++ b/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml @@ -17,7 +17,9 @@ description: | properties: compatible: - const: ite,it66121 + enum: + - ite,it66121 + - ite,it6610 reg: maxItems: 1