diff mbox series

[3/5] mmc: sdhci-esdhc-imx: improve imxrt1050 data

Message ID 20221017235602.86250-3-giulio.benetti@benettiengineering.com
State New
Headers
Series [1/5] clk: imx: imxrt1050: fix IMXRT1050_CLK_LCDIF_APB offsets |

Commit Message

Giulio Benetti Oct. 17, 2022, 11:56 p.m. UTC 
  i.MXRT1050 usdhc is not affected by ESDHC_FLAG_ERR004536 so let's remove
it. It supports ESDHC_FLAG_STD_TUNING and ESDHC_FLAG_HAVE_CAP1 so let's add
them.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 drivers/mmc/host/sdhci-esdhc-imx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Bough Chen Oct. 18, 2022, 3:06 a.m. UTC | #1 
> -----Original Message-----
> From: Giulio Benetti <giulio.benetti@benettiengineering.com>
> Sent: 2022年10月18日 7:56
> To: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; linux-clk@vger.kernel.org;
> linux-mmc@vger.kernel.org
> Cc: Stephen Boyd <sboyd@kernel.org>; Bough Chen <haibo.chen@nxp.com>;
> Adrian Hunter <adrian.hunter@intel.com>; Ulf Hansson
> <ulf.hansson@linaro.org>; Giulio Benetti
> <giulio.benetti@benettiengineering.com>
> Subject: [PATCH 3/5] mmc: sdhci-esdhc-imx: improve imxrt1050 data
> 
> i.MXRT1050 usdhc is not affected by ESDHC_FLAG_ERR004536 so let's remove it.
> It supports ESDHC_FLAG_STD_TUNING and ESDHC_FLAG_HAVE_CAP1 so let's
> add them.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Reviewed-by: Haibo Chen <haibo.chen@nxp.com>

> ---
>  drivers/mmc/host/sdhci-esdhc-imx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c
> b/drivers/mmc/host/sdhci-esdhc-imx.c
> index 55981b0f0b10..4bc0a2914a95 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -306,7 +306,8 @@ static struct esdhc_soc_data usdhc_imx7ulp_data = {
>  			| ESDHC_FLAG_STATE_LOST_IN_LPMODE,
>  };
>  static struct esdhc_soc_data usdhc_imxrt1050_data = {
> -	.flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_HS200 |
> ESDHC_FLAG_ERR004536,
> +	.flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING
> +			| ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_HS200,
>  };
> 
>  static struct esdhc_soc_data usdhc_imx8qxp_data = {
> --
> 2.34.1
Ulf Hansson Oct. 26, 2022, 11:25 a.m. UTC | #2 
On Tue, 18 Oct 2022 at 01:56, Giulio Benetti
<giulio.benetti@benettiengineering.com> wrote:
>
> i.MXRT1050 usdhc is not affected by ESDHC_FLAG_ERR004536 so let's remove
> it. It supports ESDHC_FLAG_STD_TUNING and ESDHC_FLAG_HAVE_CAP1 so let's add
> them.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-esdhc-imx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index 55981b0f0b10..4bc0a2914a95 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -306,7 +306,8 @@ static struct esdhc_soc_data usdhc_imx7ulp_data = {
>                         | ESDHC_FLAG_STATE_LOST_IN_LPMODE,
>  };
>  static struct esdhc_soc_data usdhc_imxrt1050_data = {
> -       .flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_HS200 | ESDHC_FLAG_ERR004536,
> +       .flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING
> +                       | ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_HS200,
>  };
>
>  static struct esdhc_soc_data usdhc_imx8qxp_data = {
> --
> 2.34.1
>
diff mbox series

Patch

diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index 55981b0f0b10..4bc0a2914a95 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -306,7 +306,8 @@  static struct esdhc_soc_data usdhc_imx7ulp_data = {
 			| ESDHC_FLAG_STATE_LOST_IN_LPMODE,
 };
 static struct esdhc_soc_data usdhc_imxrt1050_data = {
-	.flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_HS200 | ESDHC_FLAG_ERR004536,
+	.flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING
+			| ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_HS200,
 };
 
 static struct esdhc_soc_data usdhc_imx8qxp_data = {