Message ID | 20221014134139.5151-3-xianting.tian@linux.alibaba.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp193754wrs; Fri, 14 Oct 2022 06:52:54 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5NxGHYkAqDgMRQpuAtzRZzwHZ+RxsJvkSIO/pgb8MxyV9n8ldQopr5iInDQDi6ZUCXfwOK X-Received: by 2002:a17:903:2284:b0:178:349b:d21b with SMTP id b4-20020a170903228400b00178349bd21bmr5545000plh.49.1665755574505; Fri, 14 Oct 2022 06:52:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665755574; cv=none; d=google.com; s=arc-20160816; b=BNmFLd0Xf2ZHhF8FE5qwrR6DEt8hiEWam3wEeOa6Og+tW3cHQFVvfFEAZK6bECPDiI zhUb4lCJaRWPnmAkO9NByQw7lxs48AegXPZtMnZwjVdMyAYyggqwnkM1ujVdaVFgMQ5M V4gKzoiWIw/PDsY8um8r1ZVgu5MN8gc34BA9ZvcfFZG4EwU23QPfCeF6D+2AKjghXd4/ RYWhuWYKER1DGUFRP6eGLMelCmm3IjWc9+gzgRXEGuAGg7Mt4wllyjkDl3ziIb3wjAXZ hE9tDcUS93OmHK5jZvQc+nddfBbDg4W6xYHaJTrOZcq0ivrA9j9dwzzJm+nOOjam03SL IClw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=eBy89UlQsfypSCACJy3YyM3ACXT81gb0GdsIZP331e4=; b=KyKo7rImuChzvgF9jzwl5G7TQYfXs11EFp/tyMc+A4tBdiw0vj57MKHDikA4BrrQdr XVR5DHPeQDklN3Gtl2wJFvrwRszvbEUAk42zxfqzP30UPq7PnXXzlwf4xhCsqvM018xb K/idPMfxldaKUlnXR7jtVK1IUQHvF8SCz4bBCFSREqZOaJ+83WvTySFGg4DF9LLpg7SB 4q35Dd1Od/p7YrROr1Tg7B0UpjbQ6o74AkxN0rc6kH8RLfzaHaH9UjjxkDnUEgMzCJg+ zyNXZZW3vYgC12pKo4du5OtCkeQXVB0JSTgLyATvLXi+yIC8sFF4wIVPze+x9/eU8eKd GMQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t189-20020a625fc6000000b00540cbd3cb18si2528166pfb.234.2022.10.14.06.52.42; Fri, 14 Oct 2022 06:52:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229766AbiJNNmO (ORCPT <rfc822;ouuuleilei@gmail.com> + 99 others); Fri, 14 Oct 2022 09:42:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229754AbiJNNmH (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 14 Oct 2022 09:42:07 -0400 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 470B0286EE; Fri, 14 Oct 2022 06:42:05 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=xianting.tian@linux.alibaba.com;NM=1;PH=DS;RN=24;SR=0;TI=SMTPD_---0VS82WcB_1665754918; Received: from localhost.localdomain(mailfrom:xianting.tian@linux.alibaba.com fp:SMTPD_---0VS82WcB_1665754918) by smtp.aliyun-inc.com; Fri, 14 Oct 2022 21:41:59 +0800 From: Xianting Tian <xianting.tian@linux.alibaba.com> To: paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, anup@brainfault.org, heiko@sntech.de, guoren@kernel.org, mick@ics.forth.gr, alexandre.ghiti@canonical.com, bhe@redhat.com, vgoyal@redhat.com, dyoung@redhat.com, corbet@lwn.net, Conor.Dooley@microchip.com, bagasdotme@gmail.com Cc: kexec@lists.infradead.org, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, crash-utility@redhat.com, heinrich.schuchardt@canonical.com, k-hagio-ab@nec.com, hschauhan@nulltrace.org, yixun.lan@gmail.com, Xianting Tian <xianting.tian@linux.alibaba.com> Subject: [PATCH V2 2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64 Date: Fri, 14 Oct 2022 21:41:39 +0800 Message-Id: <20221014134139.5151-3-xianting.tian@linux.alibaba.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221014134139.5151-1-xianting.tian@linux.alibaba.com> References: <20221014134139.5151-1-xianting.tian@linux.alibaba.com> X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746671317461600590?= X-GMAIL-MSGID: =?utf-8?q?1746671317461600590?= |
Series |
Support VMCOREINFO export for RISCV64
|
|
Commit Message
Xianting Tian
Oct. 14, 2022, 1:41 p.m. UTC
The following interrelated definitions and ranges are needed by the kdump
crash tool, they are exported by "arch/riscv/kernel/crash_core.c":
VA_BITS,
PAGE_OFFSET,
phys_ram_base,
MODULES_VADDR ~ MODULES_END,
VMALLOC_START ~ VMALLOC_END,
VMEMMAP_START ~ VMEMMAP_END,
KASAN_SHADOW_START ~ KASAN_SHADOW_END,
KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END
Document these RISCV64 exports above.
Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
---
.../admin-guide/kdump/vmcoreinfo.rst | 30 +++++++++++++++++++
1 file changed, 30 insertions(+)
Comments
On Fri, Oct 14, 2022 at 09:41:39PM +0800, Xianting Tian wrote: > The following interrelated definitions and ranges are needed by the kdump > crash tool, they are exported by "arch/riscv/kernel/crash_core.c": > VA_BITS, > PAGE_OFFSET, > phys_ram_base, > MODULES_VADDR ~ MODULES_END, > VMALLOC_START ~ VMALLOC_END, > VMEMMAP_START ~ VMEMMAP_END, > KASAN_SHADOW_START ~ KASAN_SHADOW_END, > KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END > > Document these RISCV64 exports above. > > Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com> > --- > .../admin-guide/kdump/vmcoreinfo.rst | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst > index 6726f439958c..8e2e164cf3db 100644 > --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst > +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst > @@ -595,3 +595,33 @@ X2TLB > ----- > > Indicates whether the crashed kernel enabled SH extended mode. > + > +RISCV64 > +======= > + > +VA_BITS > +------- > + > +The maximum number of bits for virtual addresses. Used to compute the > +virtual memory ranges. > + > +PAGE_OFFSET > +----------- > + > +Indicates the virtual kernel start address of direct-mapped RAM region. Apologies for not seeing this sooner, but should there not be a "the" prior to "direct-mapped"? > + > +phys_ram_base > +------------- > + > +Indicates the start physical RAM address. > + > +MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END > +---------------------------------------------------------------------------------------------------------------------------------------------------- > + > +Used to get the correct ranges: > + > + * MODULES_VADDR ~ MODULES_END : Kernel module space. > + * VMALLOC_START ~ VMALLOC_END : vmalloc() / ioremap() space. > + * VMEMMAP_START ~ VMEMMAP_END : vmemmap region, used for struct page array. Since I'm in pedant mode, it does look a little odd that you're using region for vmemmap but space for the others but idc that much. Thanks, Conor. > + * KASAN_SHADOW_START ~ KASAN_SHADOW_END : kasan shadow space. > + * KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END : Kernel link and BPF space. > -- > 2.17.1 > >
在 2022/10/18 上午3:40, Conor Dooley 写道: > On Fri, Oct 14, 2022 at 09:41:39PM +0800, Xianting Tian wrote: >> The following interrelated definitions and ranges are needed by the kdump >> crash tool, they are exported by "arch/riscv/kernel/crash_core.c": >> VA_BITS, >> PAGE_OFFSET, >> phys_ram_base, >> MODULES_VADDR ~ MODULES_END, >> VMALLOC_START ~ VMALLOC_END, >> VMEMMAP_START ~ VMEMMAP_END, >> KASAN_SHADOW_START ~ KASAN_SHADOW_END, >> KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END >> >> Document these RISCV64 exports above. >> >> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com> >> --- >> .../admin-guide/kdump/vmcoreinfo.rst | 30 +++++++++++++++++++ >> 1 file changed, 30 insertions(+) >> >> diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst >> index 6726f439958c..8e2e164cf3db 100644 >> --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst >> +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst >> @@ -595,3 +595,33 @@ X2TLB >> ----- >> >> Indicates whether the crashed kernel enabled SH extended mode. >> + >> +RISCV64 >> +======= >> + >> +VA_BITS >> +------- >> + >> +The maximum number of bits for virtual addresses. Used to compute the >> +virtual memory ranges. >> + >> +PAGE_OFFSET >> +----------- >> + >> +Indicates the virtual kernel start address of direct-mapped RAM region. > Apologies for not seeing this sooner, but should there not be a "the" > prior to "direct-mapped"? will fix in v3 > >> + >> +phys_ram_base >> +------------- >> + >> +Indicates the start physical RAM address. >> + >> +MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END >> +---------------------------------------------------------------------------------------------------------------------------------------------------- >> + >> +Used to get the correct ranges: >> + >> + * MODULES_VADDR ~ MODULES_END : Kernel module space. >> + * VMALLOC_START ~ VMALLOC_END : vmalloc() / ioremap() space. >> + * VMEMMAP_START ~ VMEMMAP_END : vmemmap region, used for struct page array. > Since I'm in pedant mode, it does look a little odd that you're using > region for vmemmap but space for the others but idc that much. Sorry, I didn't get your point :( it contains vmemmap area with reference wth arch/arm64/kernel/crash_core.c. > > Thanks, > Conor. > >> + * KASAN_SHADOW_START ~ KASAN_SHADOW_END : kasan shadow space. >> + * KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END : Kernel link and BPF space. >> -- >> 2.17.1 >> >>
On Fri, Oct 14, 2022 at 09:41:39PM +0800, Xianting Tian wrote: > The following interrelated definitions and ranges are needed by the kdump > crash tool, they are exported by "arch/riscv/kernel/crash_core.c": Better say "..., which are exported by ..." > diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst > index 6726f439958c..8e2e164cf3db 100644 > --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst > +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst > @@ -595,3 +595,33 @@ X2TLB > ----- > > Indicates whether the crashed kernel enabled SH extended mode. > + > +RISCV64 > +======= > + > +VA_BITS > +------- > + > +The maximum number of bits for virtual addresses. Used to compute the > +virtual memory ranges. > + > +PAGE_OFFSET > +----------- > + > +Indicates the virtual kernel start address of direct-mapped RAM region. > + > +phys_ram_base > +------------- > + > +Indicates the start physical RAM address. > + > +MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END > +---------------------------------------------------------------------------------------------------------------------------------------------------- > + > +Used to get the correct ranges: > + > + * MODULES_VADDR ~ MODULES_END : Kernel module space. > + * VMALLOC_START ~ VMALLOC_END : vmalloc() / ioremap() space. > + * VMEMMAP_START ~ VMEMMAP_END : vmemmap region, used for struct page array. > + * KASAN_SHADOW_START ~ KASAN_SHADOW_END : kasan shadow space. > + * KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END : Kernel link and BPF space. The documentation LGTM, thanks. When the patch subject is fixed, Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
在 2022/10/18 上午11:19, Bagas Sanjaya 写道: > On Fri, Oct 14, 2022 at 09:41:39PM +0800, Xianting Tian wrote: >> The following interrelated definitions and ranges are needed by the kdump >> crash tool, they are exported by "arch/riscv/kernel/crash_core.c": > Better say "..., which are exported by ..." will fix it in v3 thanks > >> diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst >> index 6726f439958c..8e2e164cf3db 100644 >> --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst >> +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst >> @@ -595,3 +595,33 @@ X2TLB >> ----- >> >> Indicates whether the crashed kernel enabled SH extended mode. >> + >> +RISCV64 >> +======= >> + >> +VA_BITS >> +------- >> + >> +The maximum number of bits for virtual addresses. Used to compute the >> +virtual memory ranges. >> + >> +PAGE_OFFSET >> +----------- >> + >> +Indicates the virtual kernel start address of direct-mapped RAM region. >> + >> +phys_ram_base >> +------------- >> + >> +Indicates the start physical RAM address. >> + >> +MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END >> +---------------------------------------------------------------------------------------------------------------------------------------------------- >> + >> +Used to get the correct ranges: >> + >> + * MODULES_VADDR ~ MODULES_END : Kernel module space. >> + * VMALLOC_START ~ VMALLOC_END : vmalloc() / ioremap() space. >> + * VMEMMAP_START ~ VMEMMAP_END : vmemmap region, used for struct page array. >> + * KASAN_SHADOW_START ~ KASAN_SHADOW_END : kasan shadow space. >> + * KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END : Kernel link and BPF space. > The documentation LGTM, thanks. > > When the patch subject is fixed, > > Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com> >
在 2022/10/18 上午11:19, Bagas Sanjaya 写道: > On Fri, Oct 14, 2022 at 09:41:39PM +0800, Xianting Tian wrote: >> The following interrelated definitions and ranges are needed by the kdump >> crash tool, they are exported by "arch/riscv/kernel/crash_core.c": > Better say "..., which are exported by ..." > >> diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst >> index 6726f439958c..8e2e164cf3db 100644 >> --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst >> +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst >> @@ -595,3 +595,33 @@ X2TLB >> ----- >> >> Indicates whether the crashed kernel enabled SH extended mode. >> + >> +RISCV64 >> +======= >> + >> +VA_BITS >> +------- >> + >> +The maximum number of bits for virtual addresses. Used to compute the >> +virtual memory ranges. >> + >> +PAGE_OFFSET >> +----------- >> + >> +Indicates the virtual kernel start address of direct-mapped RAM region. >> + >> +phys_ram_base >> +------------- >> + >> +Indicates the start physical RAM address. >> + >> +MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END >> +---------------------------------------------------------------------------------------------------------------------------------------------------- >> + >> +Used to get the correct ranges: >> + >> + * MODULES_VADDR ~ MODULES_END : Kernel module space. >> + * VMALLOC_START ~ VMALLOC_END : vmalloc() / ioremap() space. >> + * VMEMMAP_START ~ VMEMMAP_END : vmemmap region, used for struct page array. >> + * KASAN_SHADOW_START ~ KASAN_SHADOW_END : kasan shadow space. >> + * KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END : Kernel link and BPF space. > The documentation LGTM, thanks. > > When the patch subject is fixed, Could you tell me what patch subject should be changed to ? thanks > > Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com> >
On Tue, Oct 18, 2022 at 10:41:50AM +0800, Xianting Tian wrote: > > 在 2022/10/18 上午3:40, Conor Dooley 写道: > > On Fri, Oct 14, 2022 at 09:41:39PM +0800, Xianting Tian wrote: > > > The following interrelated definitions and ranges are needed by the kdump > > > crash tool, they are exported by "arch/riscv/kernel/crash_core.c": > > > VA_BITS, > > > PAGE_OFFSET, > > > phys_ram_base, > > > MODULES_VADDR ~ MODULES_END, > > > VMALLOC_START ~ VMALLOC_END, > > > VMEMMAP_START ~ VMEMMAP_END, > > > KASAN_SHADOW_START ~ KASAN_SHADOW_END, > > > KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END > > > > > > Document these RISCV64 exports above. > > > > > > Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com> > > > --- > > > .../admin-guide/kdump/vmcoreinfo.rst | 30 +++++++++++++++++++ > > > 1 file changed, 30 insertions(+) > > > > > > diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst > > > index 6726f439958c..8e2e164cf3db 100644 > > > --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst > > > +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst > > > @@ -595,3 +595,33 @@ X2TLB > > > ----- > > > Indicates whether the crashed kernel enabled SH extended mode. > > > + > > > +RISCV64 > > > +======= > > > + > > > +VA_BITS > > > +------- > > > + > > > +The maximum number of bits for virtual addresses. Used to compute the > > > +virtual memory ranges. > > > + > > > +PAGE_OFFSET > > > +----------- > > > + > > > +Indicates the virtual kernel start address of direct-mapped RAM region. > > Apologies for not seeing this sooner, but should there not be a "the" > > prior to "direct-mapped"? > will fix in v3 > > > > > + > > > +phys_ram_base > > > +------------- > > > + > > > +Indicates the start physical RAM address. > > > + > > > +MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END > > > +---------------------------------------------------------------------------------------------------------------------------------------------------- > > > + > > > +Used to get the correct ranges: > > > + > > > + * MODULES_VADDR ~ MODULES_END : Kernel module space. > > > + * VMALLOC_START ~ VMALLOC_END : vmalloc() / ioremap() space. > > > + * VMEMMAP_START ~ VMEMMAP_END : vmemmap region, used for struct page array. > > Since I'm in pedant mode, it does look a little odd that you're using > > region for vmemmap but space for the others but idc that much. > > Sorry, I didn't get your point :( > > it contains vmemmap area with reference wth arch/arm64/kernel/crash_core.c. The wording is different, vmemmap uses space and the others use region. Not a big deal. > > > > > Thanks, > > Conor. > > > > > + * KASAN_SHADOW_START ~ KASAN_SHADOW_END : kasan shadow space. > > > + * KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END : Kernel link and BPF space. > > > -- > > > 2.17.1 > > > > > > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
On 10/18/22 13:06, Xianting Tian wrote: > > 在 2022/10/18 上午11:19, Bagas Sanjaya 写道: >> On Fri, Oct 14, 2022 at 09:41:39PM +0800, Xianting Tian wrote: >>> The following interrelated definitions and ranges are needed by the kdump >>> crash tool, they are exported by "arch/riscv/kernel/crash_core.c": >> Better say "..., which are exported by ..." >> >>> diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst >>> index 6726f439958c..8e2e164cf3db 100644 >>> --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst >>> +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst >>> @@ -595,3 +595,33 @@ X2TLB >>> ----- >>> Indicates whether the crashed kernel enabled SH extended mode. >>> + >>> +RISCV64 >>> +======= >>> + >>> +VA_BITS >>> +------- >>> + >>> +The maximum number of bits for virtual addresses. Used to compute the >>> +virtual memory ranges. >>> + >>> +PAGE_OFFSET >>> +----------- >>> + >>> +Indicates the virtual kernel start address of direct-mapped RAM region. >>> + >>> +phys_ram_base >>> +------------- >>> + >>> +Indicates the start physical RAM address. >>> + >>> +MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END >>> +---------------------------------------------------------------------------------------------------------------------------------------------------- >>> + >>> +Used to get the correct ranges: >>> + >>> + * MODULES_VADDR ~ MODULES_END : Kernel module space. >>> + * VMALLOC_START ~ VMALLOC_END : vmalloc() / ioremap() space. >>> + * VMEMMAP_START ~ VMEMMAP_END : vmemmap region, used for struct page array. >>> + * KASAN_SHADOW_START ~ KASAN_SHADOW_END : kasan shadow space. >>> + * KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END : Kernel link and BPF space. >> The documentation LGTM, thanks. >> >> When the patch subject is fixed, > Could you tell me what patch subject should be changed to ? thanks I mean the description, not subject (as in email). That is, fix the description (see above). The subject shouldn't be changed. Sorry for inconvenience. Thanks.
diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst index 6726f439958c..8e2e164cf3db 100644 --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst @@ -595,3 +595,33 @@ X2TLB ----- Indicates whether the crashed kernel enabled SH extended mode. + +RISCV64 +======= + +VA_BITS +------- + +The maximum number of bits for virtual addresses. Used to compute the +virtual memory ranges. + +PAGE_OFFSET +----------- + +Indicates the virtual kernel start address of direct-mapped RAM region. + +phys_ram_base +------------- + +Indicates the start physical RAM address. + +MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END +---------------------------------------------------------------------------------------------------------------------------------------------------- + +Used to get the correct ranges: + + * MODULES_VADDR ~ MODULES_END : Kernel module space. + * VMALLOC_START ~ VMALLOC_END : vmalloc() / ioremap() space. + * VMEMMAP_START ~ VMEMMAP_END : vmemmap region, used for struct page array. + * KASAN_SHADOW_START ~ KASAN_SHADOW_END : kasan shadow space. + * KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END : Kernel link and BPF space.