Message ID | 20221215073212.1966823-1-guoren@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp208273wrn; Thu, 15 Dec 2022 00:00:02 -0800 (PST) X-Google-Smtp-Source: AA0mqf74zvS7cUty6xtRXnkZFZCpIspavPa4KJLfv5WNQMMCR0n87fh5eZKdHfGDcM76QdRuhe1t X-Received: by 2002:a17:90a:649:b0:221:6b58:d092 with SMTP id q9-20020a17090a064900b002216b58d092mr12873503pje.44.1671091202004; Thu, 15 Dec 2022 00:00:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671091201; cv=none; d=google.com; s=arc-20160816; b=mHrfMCa0sXxrXy0rEoz3DGAzejzAz8EAY9i1SShhrWQUb7sWvGNVmrKa7y4A1SmfDz F3iY+GTAhUF/hfiv8+zK5tO5Z8t+T6A4YNN2NizmRr6yu9YKxqSxQVRQSO9mZ6+bXYTa GnvYSJ1l1wuk36x23d3dCpUAufrFSZA48NUHVUWv2JX+u+a3KRpi3KyFkvJhN/BhTQQs Q/f9izoiYGjGuR51D+coxRscmpP4aOYlIahdNLGdtV9fCkvt+DbVR1ItETEnz/y1SF4o wE57rX+tW8qLHJiPSp5Xi1qRo/KHVmVkXEkFe/f1poQAw1siS06hC9syAgL/lDYvT5+C Ae0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=MtIgC6uSSIM0g8JBwOXbm5n7HiU5Zy2VOx6L4H0TXPY=; b=xXNt8CLSTapFpTaqCgdv9xrZgzy8MMMtxMcMD7mFSO3kTHDueWbMQd7mSIUd/hkMRF mXyly1THpRVlLfjiIb9/8xnpNtzSPnteNo0PRU4cnNOw2q1YHzms4Wr/M5J4fy0ZY+4f v3aZzROqpuOo7SsNa7vW7fA+Szio/ZZZ75XcEAvhMkQ3nT/nfvIGUMI1BfTFTMhKipPu QLHw7RD1OBuhDKH2c9fv9XwpSJu4m+wljSCb9Q3HUwcF3FD3lE1c4kIOylLm0IgGZodg RUWToTxgDsFRAdB7X5o29mP/lAn8BsUI1Hdji554LKvsvnyym6D2hoPYqp1yM5MMqtfM N/Dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=up1c8ix9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oo18-20020a17090b1c9200b0021ec5bd32c9si4522142pjb.56.2022.12.14.23.59.47; Thu, 15 Dec 2022 00:00:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=up1c8ix9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229927AbiLOHce (ORCPT <rfc822;jeantsuru.cumc.mandola@gmail.com> + 99 others); Thu, 15 Dec 2022 02:32:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229683AbiLOHc0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 15 Dec 2022 02:32:26 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 478B02A435 for <linux-kernel@vger.kernel.org>; Wed, 14 Dec 2022 23:32:25 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 1EE78CE1B44 for <linux-kernel@vger.kernel.org>; Thu, 15 Dec 2022 07:32:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AD64C43396; Thu, 15 Dec 2022 07:32:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671089541; bh=IuVFclXBC2xjRNMPRTtq1KAZ9dbUziFQCUjGxBXpNv0=; h=From:To:Cc:Subject:Date:From; b=up1c8ix9evWyaIMVotw+FBoA3JiiMPOQLHfXEwVt3x77Nriis+Zm6svfODeRCKBN9 7c2P5ndXAZ1jbzSJIo/s3/e6KywByC4vonLI08eGglyWEY3umhcUUsBBLXqZnyoGk5 wGd+B+au8iNgkco3LADOjNSIkEqFGs5z0QF9M6NfQ4mokYfA4KvrSqfJz/ZipEx2WU ku7C83aDCGn0GmT/OQPVVNFUYC9wem9jHynrYBGH9JQ94ULEoLvWxC+svkB8+kY/Nj KqSkQahr89gkKfeLUq/L2qFN2LA/Kijh+jlGJ4ErSLDlgzVGYsHUMTrESTNpmsM+Dt t0qQZAzNpYGtQ== From: guoren@kernel.org To: palmer@dabbelt.com, prabhakar.mahadev-lad.rj@bp.renesas.com Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, iommu@lists.linux.dev, Guo Ren <guoren@linux.alibaba.com>, kernel test robot <lkp@intel.com>, Guo Ren <guoren@kernel.org> Subject: [PATCH] iommu/renesas: Support riscv compile Date: Thu, 15 Dec 2022 02:32:12 -0500 Message-Id: <20221215073212.1966823-1-guoren@kernel.org> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752266128018692703?= X-GMAIL-MSGID: =?utf-8?q?1752266128018692703?= |
Series |
iommu/renesas: Support riscv compile
|
|
Commit Message
Guo Ren
Dec. 15, 2022, 7:32 a.m. UTC
From: Guo Ren <guoren@linux.alibaba.com> After riscv selects ARCH_RENESAS, we need to add ARM64 || ARM dependency here. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Guo Ren <guoren@linux.alibaba.com> Signed-off-by: Guo Ren <guoren@kernel.org> --- drivers/iommu/Kconfig | 1 + 1 file changed, 1 insertion(+)
Comments
On 2022-12-15 07:32, guoren@kernel.org wrote: > From: Guo Ren <guoren@linux.alibaba.com> > > After riscv selects ARCH_RENESAS, we need to add ARM64 || ARM > dependency here. This effectively removes all the extra COMPILE_TEST coverage we've been enjoying. FWIW I prefer Geert's suggestion to separate the real functional dependency from implicit assumptions about ARCH_RENESAS, with something like: depends on ARCH_RENESAS || COMPILE_TEST depends on !GENERIC_ATOMIC64 #for IOMMU_IO_PGTABLE_LPAE Thanks, Robin. > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > Signed-off-by: Guo Ren <guoren@kernel.org> > --- > drivers/iommu/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > index dc5f7a156ff5..746b95b9f345 100644 > --- a/drivers/iommu/Kconfig > +++ b/drivers/iommu/Kconfig > @@ -283,6 +283,7 @@ config EXYNOS_IOMMU_DEBUG > > config IPMMU_VMSA > bool "Renesas VMSA-compatible IPMMU" > + depends on ARM64 || ARM > depends on ARCH_RENESAS || (COMPILE_TEST && !GENERIC_ATOMIC64) > select IOMMU_API > select IOMMU_IO_PGTABLE_LPAE
On Fri, Dec 16, 2022 at 1:16 AM Robin Murphy <robin.murphy@arm.com> wrote: > > On 2022-12-15 07:32, guoren@kernel.org wrote: > > From: Guo Ren <guoren@linux.alibaba.com> > > > > After riscv selects ARCH_RENESAS, we need to add ARM64 || ARM > > dependency here. > > This effectively removes all the extra COMPILE_TEST coverage we've been > enjoying. FWIW I prefer Geert's suggestion to separate the real > functional dependency from implicit assumptions about ARCH_RENESAS, with > something like: > > depends on ARCH_RENESAS || COMPILE_TEST > depends on !GENERIC_ATOMIC64 #for IOMMU_IO_PGTABLE_LPAE The problem is from clang version 16.0.0, and gcc version 12.2.0 () is okay. I didn't recognize COMPILE_TEST could utilize the x86(another arch) to test the arm driver. How About: diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig index dc5f7a156ff5..a2e259da5a6a 100644 --- a/drivers/iommu/Kconfig +++ b/drivers/iommu/Kconfig @@ -283,6 +283,7 @@ config EXYNOS_IOMMU_DEBUG config IPMMU_VMSA bool "Renesas VMSA-compatible IPMMU" + depends on !RISCV depends on ARCH_RENESAS || (COMPILE_TEST && !GENERIC_ATOMIC64) select IOMMU_API select IOMMU_IO_PGTABLE_LPAE > > Thanks, > Robin. > > > Reported-by: kernel test robot <lkp@intel.com> > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > > Signed-off-by: Guo Ren <guoren@kernel.org> > > --- > > drivers/iommu/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > > index dc5f7a156ff5..746b95b9f345 100644 > > --- a/drivers/iommu/Kconfig > > +++ b/drivers/iommu/Kconfig > > @@ -283,6 +283,7 @@ config EXYNOS_IOMMU_DEBUG > > > > config IPMMU_VMSA > > bool "Renesas VMSA-compatible IPMMU" > > + depends on ARM64 || ARM > > depends on ARCH_RENESAS || (COMPILE_TEST && !GENERIC_ATOMIC64) > > select IOMMU_API > > select IOMMU_IO_PGTABLE_LPAE -- Best Regards Guo Ren
diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig index dc5f7a156ff5..746b95b9f345 100644 --- a/drivers/iommu/Kconfig +++ b/drivers/iommu/Kconfig @@ -283,6 +283,7 @@ config EXYNOS_IOMMU_DEBUG config IPMMU_VMSA bool "Renesas VMSA-compatible IPMMU" + depends on ARM64 || ARM depends on ARCH_RENESAS || (COMPILE_TEST && !GENERIC_ATOMIC64) select IOMMU_API select IOMMU_IO_PGTABLE_LPAE