diff mbox series

ARM: dts: stm32mp13: fix compatible for BSEC

Message ID 20221017134437.1.I167a5efc1f8777cce14518c6fa38400ac684de3e@changeid
State New
Headers
Series ARM: dts: stm32mp13: fix compatible for BSEC |

Commit Message

Patrick Delaunay Oct. 17, 2022, 11:44 a.m. UTC 
  Use the new compatible for stm32mp13 support.

Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
---
This device tree modification depends on the binding modification
introduced by the patch:

dt-bindings: nvmem: add new stm32mp13 compatible for stm32-romem
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20221014172324.1.Ifc1812116ff63f5501f3edd155d3cf5c0ecc846c@changeid/

 arch/arm/boot/dts/stm32mp131.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Oct. 18, 2022, 1:55 a.m. UTC | #1 
On 17/10/2022 07:44, Patrick Delaunay wrote:
> Use the new compatible for stm32mp13 support.
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
> This device tree modification depends on the binding modification
> introduced by the patch:
> 
> dt-bindings: nvmem: add new stm32mp13 compatible for stm32-romem
> https://patchwork.kernel.org/project/linux-arm-kernel/patch/20221014172324.1.Ifc1812116ff63f5501f3edd155d3cf5c0ecc846c@changeid/

This breaks users of DTS. The patch above did not describe devices as
compatible and that's the problem sending patches separately, without
context.

You need to keep compatible.

Best regards,
Krzysztof
Patrick Delaunay Oct. 27, 2022, 3:02 p.m. UTC | #2 
Hi,

On 10/18/22 03:55, Krzysztof Kozlowski wrote:
> On 17/10/2022 07:44, Patrick Delaunay wrote:
>> Use the new compatible for stm32mp13 support.
>>
>> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
>> ---
>> This device tree modification depends on the binding modification
>> introduced by the patch:
>>
>> dt-bindings: nvmem: add new stm32mp13 compatible for stm32-romem
>> https://patchwork.kernel.org/project/linux-arm-kernel/patch/20221014172324.1.Ifc1812116ff63f5501f3edd155d3cf5c0ecc846c@changeid/
> This breaks users of DTS. The patch above did not describe devices as
> compatible and that's the problem sending patches separately, without
> context.
>
> You need to keep compatible.
>
> Best regards,
> Krzysztof

I will sent a V2 patch in a serie with binding change, driver updates 
and explanations.

Regards

Patrick
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/stm32mp131.dtsi b/arch/arm/boot/dts/stm32mp131.dtsi
index dd35a607073d..89a027f894f9 100644
--- a/arch/arm/boot/dts/stm32mp131.dtsi
+++ b/arch/arm/boot/dts/stm32mp131.dtsi
@@ -398,7 +398,7 @@  rtc: rtc@5c004000 {
 		};
 
 		bsec: efuse@5c005000 {
-			compatible = "st,stm32mp15-bsec";
+			compatible = "st,stm32mp13-bsec";
 			reg = <0x5c005000 0x400>;
 			#address-cells = <1>;
 			#size-cells = <1>;